629 Commits

• Fix TestSceneMultiSpectatorLeaderboard not waiting for user population
  Dean Herbert · 2021-12-31 00:48:31 +09:00
  f53a675ca3
• Merge pull request #16205 from smoogipoo/fix-multiplayer-tests

  Fix multiplayer test failures when checking for parted room

  Dean Herbert · 2021-12-22 13:42:05 +09:00
  cfdfe81afb
• Fix multiplayer test failures when checking for parted room
  Dan Balasescu · 2021-12-22 12:55:37 +09:00
  24c6f8fafa
• Fix delete button test failures

  Can be tested by adding a Thread.Sleep() in
  DrawableRoomPlaylistItem.load().

  Dan Balasescu · 2021-12-22 09:55:19 +09:00
  ee64ab6383
• Fix test
  Dan Balasescu · 2021-12-21 18:38:31 +09:00
  e2f8c71081
• Add note about local button clicking usage
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  bb3f375958
• Remove unused method in TestSceneMultiplayerQueueList
  Dean Herbert · 2021-12-21 13:49:51 +09:00
  aad55ef89e
• Centralise all multiplayer button clicking test logic

  This adds the "wait for enabled" check in a way that can be easily
  reused, as it keeps getting missed in test implementations.
  
  This particular commit hopefully fixes
  https://github.com/ppy/osu/runs/4583845033?check_suite_focus=true.

  Dean Herbert · 2021-12-21 13:49:51 +09:00
  9aff646ff4
• Merge branch 'master' into fix-ready-button-test
  Bartłomiej Dach · 2021-12-20 11:02:43 +01:00
  d8be455a43
• Rename TestMultiplayerScreenStack to TestMultiplayerComponents
  Dean Herbert · 2021-12-20 18:24:59 +09:00
  ec0a6735eb
• Add better defined steps to TestLoseHostWhileReady ready button test

  Not 100% sure this will solve the issue but it's worth a try. The button
  state checks are using `Until` everywhere else so this brings the test
  in line with the standards.
  
  As seen
  https://github.com/ppy/osu/runs/4579641456?check_suite_focus=true.

  Dean Herbert · 2021-12-20 17:47:06 +09:00
  87051d5d61
• Better fix for intermittent multiplayer tests
  Dan Balasescu · 2021-12-20 13:10:13 +09:00
  9316abc278
• Merge branch 'master' into forego-resetting-spectate-state
  Dean Herbert · 2021-12-15 18:05:06 +09:00
  9e82a3e79a
• Don't reset spectating state if gameplay is finished
  Dan Balasescu · 2021-12-15 17:40:30 +09:00
  18d7b79207
• Add test coverage of same scenario without deletion
  Dean Herbert · 2021-12-15 17:30:09 +09:00
  39a0a21132
• Add another until step to guard against async test issues
  Dan Balasescu · 2021-12-15 17:00:06 +09:00
  d22e1b9001
• Fix exception when updating the room's visual playlist
  Dan Balasescu · 2021-12-15 16:53:25 +09:00
  740a6f16c7
• Merge pull request #16045 from smoogipoo/multiplayer-local-beatmap-query

  Rework multiplayer's current item tracking

  Dean Herbert · 2021-12-14 18:33:30 +09:00
  cebfeb5220
• Use new method in more places that can benefit from it
  Dean Herbert · 2021-12-13 16:56:43 +09:00
  309290a3c9
• Merge branch 'master' into multiplayer-local-beatmap-query
  Dan Balasescu · 2021-12-12 16:37:41 +09:00
  bf3abb2455
• Fix test failures from async item loading
  Dan Balasescu · 2021-12-12 16:11:48 +09:00
  9f792fec49
• Resolve some test failures due to async population
  Dan Balasescu · 2021-12-11 22:52:08 +09:00
  99cd36d2f6
• Fix starting gameplay too early after import
  Dan Balasescu · 2021-12-11 22:47:50 +09:00
  25b274c323
• Merge branch 'master' into pre-realm-score-tidy
  Dan Balasescu · 2021-12-11 19:25:39 +09:00
  cdb8237a4b
• Move playlist item beatmap population to MatchSubScreen
  Dan Balasescu · 2021-12-10 20:08:59 +09:00
  6057037e35
• Use OnlineID for set operations
  Dean Herbert · 2021-12-10 16:11:48 +09:00
  dbb08f7d46
• Merge branch 'master' into host-enqueue-2
  Dean Herbert · 2021-12-10 14:09:19 +09:00
  50bf2f368d
• Merge pull request #16019 from smoogipoo/cleanup-playlist-item-buttons

  Cleanup duplicated classes in DrawableRoomPlaylistItem

  Dean Herbert · 2021-12-10 12:01:26 +09:00
  1952819db2
• Fix incorrect test namespace
  Dan Balasescu · 2021-12-10 02:09:31 +09:00
  a445dcd2c6
• Allow host to enqeue items and items to be edited
  Dan Balasescu · 2021-12-10 01:15:19 +09:00
  671582a925
• Add edit button to DrawableRoomPlaylistItem
  Dan Balasescu · 2021-12-10 01:08:54 +09:00
  048a495115
• Privatise button again
  Dan Balasescu · 2021-12-10 00:38:18 +09:00
  05aa9635a8
• Cleanup duplicated classes in DrawableRoomPlaylistItem
  Dan Balasescu · 2021-12-09 23:56:49 +09:00
  f9af239ed9
• Minor code reformatting
  Dean Herbert · 2021-12-09 17:53:40 +09:00
  dfe19f3509
• Fix test failures
  Dan Balasescu · 2021-12-09 04:22:34 +09:00
  aec36adf6c
• A bit of cleanup + xmldocs on classes/members
  Dan Balasescu · 2021-12-09 01:40:16 +09:00
  3b4833ca8e
• Remove ctor params from PlaylistsRoomPlaylist
  Dan Balasescu · 2021-12-09 01:16:37 +09:00
  26f6c5e5a5
• Remove ctor params from DrawableRoomPlaylist/DrawablePlaylistItem
  Dan Balasescu · 2021-12-09 01:04:56 +09:00
  3be4d8b68d
• Separate playlist item deletion to Playlists-specific class
  Dan Balasescu · 2021-12-08 20:50:25 +09:00
  beb5d61a42
• Wait for match type changes in team versus test
  Bartłomiej Dach · 2021-12-07 20:40:10 +01:00
  e9694dc74e
• Add match type and queue mode to multiplayer room panels
  Dan Balasescu · 2021-12-07 18:57:13 +09:00
  5ffe702dd6
• Wait for beatmap sets to finish loading to avoid test failures

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2021-12-06 15:03:17 +09:00
  0fa1a96e9d
• Add test coverage of incorrect beatmap being used in multiplayer when match started from song select
  Dean Herbert · 2021-12-06 14:03:33 +09:00
  a76cfbea21
• Merge branch 'master' into new-multiplayer-playlist
  Dean Herbert · 2021-12-04 13:16:09 +09:00
  517a344bcc
• Give playlist items a PlayedAt date
  Dan Balasescu · 2021-12-03 20:25:51 +09:00
  d5803e541b
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Remove now unnecessary test
  Dan Balasescu · 2021-12-02 22:58:25 +09:00
  10932dd282
• Merge branch 'master' into new-multiplayer-playlist
  Dan Balasescu · 2021-12-01 21:35:23 +09:00
  89c47708a1
• Add test considering expired items
  Dan Balasescu · 2021-12-01 21:35:23 +09:00
  f9b4e6f004
• Fix queue mode not being bound to in all cases
  Dan Balasescu · 2021-12-01 21:35:23 +09:00
  e87b0003fb