1079 Commits

• Don't rely on single-use properties
  Dan Balasescu · 2024-07-18 19:07:02 +09:00
  a7e110f669
• Fix editor performance regression with hitmarkers active
  Bartłomiej Dach · 2024-06-26 16:26:32 +02:00
  b339d6a00c
• Fix editor performance dropping over time when hit markers are enabled

  There's probably a better solution but let's hotfix this for now.

  Dean Herbert · 2024-06-26 01:06:37 +09:00
  dc817b62cc
• Fix incorrect slider judgement positions when classic mod is active

  Regressed in https://github.com/ppy/osu/pull/27977.
  
  Bit ad-hoc but don't see how to fix without just reverting the change.

  Bartłomiej Dach · 2024-06-25 10:07:58 +02:00
  2cb18820ea
• Add note about every-frame-transforms
  Dean Herbert · 2024-06-23 03:31:40 +08:00
  df43a1c6cc
• Adjust behaviour of hit animations toggle to match user expectations
  Bartłomiej Dach · 2024-06-20 13:42:32 +02:00
  ad2cd0ba8f
• Only take initial judgement position from object instead of following

  Looks less bad with mods like depth active.
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-05-30 09:03:02 +02:00
  8916f08f86
• Use hopefully safer implementation of anchoring judgements to objects
  Bartłomiej Dach · 2024-05-29 11:11:43 +02:00
  a6c776dac8
• Revert unrelated changes
  Bartłomiej Dach · 2024-05-29 10:57:30 +02:00
  22a2adb5e6
• Merge branch 'master' into magnetised-judgements
  Bartłomiej Dach · 2024-05-29 10:56:53 +02:00
  9fb7cc5900
• SliderBall's rotation updates based on CurvePositionAt
  Aurelian · 2024-05-28 19:38:33 +02:00
  b74f66e335
• Fix formatting
  DavidBeh · 2024-04-24 12:40:23 +02:00
  8c2a4eb78a
• Made judgements follow DrawableOsuHitObjects. Enabled judgements for depth mod
  DavidBeh · 2024-04-24 00:23:45 +02:00
  16190a4ed7
• Fixed judgements with MG mod without causing side effects
  DavidBeh · 2024-04-23 23:24:51 +02:00
  3a914b9337
• Attempt to position DrawableOsuJudgement based on its DrawableOsuHitObject instead of DrawableOsuHitObject.HitObject
  DavidBeh · 2024-04-23 19:19:11 +02:00
  331f1f31b0
• Merge branch 'master' into heatmap-misses
  Bartłomiej Dach · 2024-03-18 14:43:24 +01:00
  c9bbeeb49a
• Fix cross-talk between pooled DrawableSliderRepeat usage causing incorrect rotation
  Dean Herbert · 2024-03-08 11:37:13 +08:00
  fcc35a6acc
• Merge pull request #27429 from bdach/rewind-slider-tracking

  Fix slider tracking state not restoring correctly in all cases on rewind

  Dean Herbert · 2024-03-07 22:41:12 +08:00
  646edb239a
• Update usage of MathUtils
  Dean Herbert · 2024-03-06 12:13:12 +08:00
  b53b752e54
• Store tracking history to slider judgement result instead
  Bartłomiej Dach · 2024-02-29 12:11:50 +01:00
  876b806423
• Reset slider input manager state completely on new object application

  Kind of scary this wasn't happening already.
  
  Mirrors `SpinnerRotationTracker`.

  Bartłomiej Dach · 2024-02-29 11:59:19 +01:00
  1d1db951f0
• Fix slider tracking state not restoring correctly in all cases on rewind
  Bartłomiej Dach · 2024-02-29 11:59:15 +01:00
  d05b31933f
• Fix subscribing to ApplyCustomUpdateState too much
  Bartłomiej Dach · 2024-02-28 13:20:41 +01:00
  b5ce2642aa
• Fix slider tails sometimes not dimming correctly

  Originally noticed during review of another change:
  https://github.com/ppy/osu/pull/27369#issuecomment-1966140198.
  
  `DrawableOsuHitObject` tries to solve the initial dimming of objects
  by applying transform to a list of dimmable parts. For plain drawables
  this is safe, but if one of the parts is a DHO, it is not safe,
  because drawable transforms can be cleared at will.
  
  In particular, on first use of a drawable slider,
  `UpdateInitialTransforms()` would fire via `LoadComplete()` on the
  `DrawableSlider`, but *then*, also via `LoadComplete()`,
  the `DrawableSliderTail` would update its own state and by doing so
  inadvertently clear the dim transform just added by the slider.
  
  To fix, ensure dim transforms are applied to DHOs
  via `ApplyCustomUpdateState`.

  Bartłomiej Dach · 2024-02-27 11:45:03 +01:00
  bbdd85020c
• Merge pull request #27369 from Detze/incorrect-slider-head-dim

  Fix slider head being incorrectly dimmed twice

  Bartłomiej Dach · 2024-02-27 11:17:34 +01:00
  087a2a741a
• Don't dim slider head in DrawableSlider
  Detze · 2024-02-24 21:56:44 +01:00
  91d7bd1026
• Reduce allocations in DrawableSpinner
  Andrei Zavatski · 2024-02-24 20:18:30 +03:00
  1fb19e7129
• Always process position as long as it's hittable

  For example... If a hitobject is pressed but the result is a shake, this
  will stop processing hits.

  Dan Balasescu · 2024-02-07 03:52:56 +09:00
  1f13124b38
• Add xmldocs
  Dan Balasescu · 2024-02-07 03:52:14 +09:00
  e2867986c5
• Fix inverted condition
  Dan Balasescu · 2024-02-07 03:50:56 +09:00
  38f7913b31
• Enable NRT for DrawableHitCircle to clean up
  Dan Balasescu · 2024-02-07 03:38:07 +09:00
  9b8f206486
• Show near-misses on the results-screen heatmap
  Dan Balasescu · 2024-02-06 22:30:22 +09:00
  5850d6a578
• Apply further changes to remove remaining weirdness
  Bartłomiej Dach · 2024-02-05 13:37:38 +01:00
  fb80d76b4a
• Merge branch 'master' into hit-object-result-allocations
  Bartłomiej Dach · 2024-02-05 13:24:10 +01:00
  39fe078984
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• Merge pull request #26703 from peppy/smaller-slider-misses

  Adjust slider tick / end defaults again

  Bartłomiej Dach · 2024-01-29 13:51:07 +01:00
  2667cb8b36
• Merge pull request #26698 from EVAST9919/slider-sample-alloc

  Reduce sliding sample allocations in `DrawableSlider`

  Dean Herbert · 2024-01-29 20:37:32 +09:00
  a3199333bb
• Also fix spinner case
  Dean Herbert · 2024-01-29 20:36:59 +09:00
  034f8c0388
• Reduce allocation overheads in SliderInputManager
  Dean Herbert · 2024-01-26 17:49:20 +09:00
  b6fa50c312
• update DrawableHitCircle.ApplyResult to pass this to its callback
  Chandler Stowell · 2024-01-25 11:25:41 -05:00
  93bd3ce5ae
• Remove weird red fade that didn't work
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  fd9527d523
• Update triangles skin judgment display
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  107b37494e
• Fix slider sliding samples allocation
  Andrei Zavatski · 2024-01-25 04:06:15 +03:00
  21b11092d6
• use stack to pass action state when applying hit results

  this removes closure allocations

  Chandler Stowell · 2024-01-24 13:13:45 -05:00
  d2775680e6
• Fix slider sometimes not updating relative anchor position
  Salman Ahmed · 2024-01-22 02:07:32 +03:00
  57b2d018a9
• change wording
  OliBomby · 2024-01-15 12:51:08 +01:00
  96ffe8e737
• Clarify comment
  OliBomby · 2024-01-15 12:49:40 +01:00
  86382f4408
• Fix so it reacts to PathVersion with Scheduler
  OliBomby · 2024-01-13 12:50:39 +01:00
  fca9b1f536
• Use invalidation based logic for child anchor position updpates in DrawableSlider
  Dean Herbert · 2024-01-09 14:17:33 +09:00
  5970a68e2d
• Reset child anchor position cache on hitobject position change
  Dean Herbert · 2024-01-07 20:55:28 +09:00
  962c8ba4ac