49871 Commits

This Branch

This Branch

All Branches

• Remove unnecessary local
  Bartłomiej Dach · 2022-03-22 19:13:22 +01:00
  c8d48f89e8
• Fix test not actually testing desired scenario anymore

  The test was checking the test scene's own `SelectedMods` bindable
  rather than the multiplayer screen's, and the former was never actually
  being mutated by anything. Therefore the case would pass even on
  `master` with the fix reverted.

  Bartłomiej Dach · 2022-03-22 19:04:32 +01:00
  94c5207f36
• Move and refactor test in line with functionality changes
  Dean Herbert · 2022-03-22 17:38:43 +09:00
  804e856160
• Merge branch 'master' into screen-mod-retention
  Dean Herbert · 2022-03-22 17:27:26 +09:00
  ff8352b749
• Merge pull request #17401 from peppy/update-date-added-on-use-existing

  Fix beatmap date added not being updated on reimporting a soft deleted beatmap

  Dan Balasescu · 2022-03-22 14:41:07 +09:00
  056e568ffb
• Fix beatmap date added not being updated on reimporting a soft deleted beatmap

  Addresses concerns raised in https://github.com/ppy/osu/discussions/17399.

  Dean Herbert · 2022-03-22 14:10:36 +09:00
  0fcb3bdba9
• Fill in assert details, remove whitespace
  NAGILSON · 2022-03-21 22:58:53 -04:00
  33d97f53cb
• remove code from old incorrect test
  NAGILSON · 2022-03-21 22:48:08 -04:00
  aaf2edace9
• [WIP] Multiplayer Mods Regression Test
  NAGILSON · 2022-03-21 22:46:20 -04:00
  74ce009ed8
• Implement suggested change to wipe mods on multiplayer screen
  NAGILSON · 2022-03-21 22:42:17 -04:00
  17b639b404
• Merge pull request #17356 from apollo-dw/strict-tracking

  Implement "Strict Tracking" mod in osu!

  Dan Balasescu · 2022-03-22 07:32:36 +09:00
  36772ec652
• Merge pull request #17359 from frenzibyte/fix-score-panel-max-combo

  Improve method of retrieving beatmap maximum combo for results score panels

  Dan Balasescu · 2022-03-22 06:28:30 +09:00
  aea03ca21d
• Merge pull request #17387 from peppy/fix-follow-point-looping
  Salman Ahmed · 2022-03-21 13:55:17 +03:00
  5184a84478
• Fix follow point animations not looping

  Because they do in stable. I don't know why but let's go with it.
  
  Resolves issue reported in https://github.com/ppy/osu/discussions/17072.

  Dean Herbert · 2022-03-21 18:29:13 +09:00
  e4b2242719
• Merge pull request #17252 from jai-x/new-chat-channel-control

  Implement `ChannelListItem` for new chat design

  Dean Herbert · 2022-03-21 15:41:00 +09:00
  31570d3114
• Fix close button animation not being applied correct on mouse down due to conflicting scales
  Dean Herbert · 2022-03-21 14:41:57 +09:00
  3bb01fd595
• Also add fade to ChannelItem selected box
  Dean Herbert · 2022-03-21 14:41:42 +09:00
  7ca3beb7cc
• Remove space between '#' and channel name

  This was in flyte's design (he was following discord) but doesn't feel
  too correct when it's not aligned with anything else. We can revisit
  this if/when we have better glyphs to represent channel types.

  Dean Herbert · 2022-03-21 14:36:56 +09:00
  428e439f40
• Add slight animation when highlighting an unread channel
  Dean Herbert · 2022-03-21 14:34:54 +09:00
  16caf2d30b
• Add step to TestSceneChannelListItem to actually select an item
  Dean Herbert · 2022-03-21 14:33:50 +09:00
  5104e4db21
• Merge pull request #17379 from peppy/fix-skin-editor-player-overlays
  Salman Ahmed · 2022-03-21 08:32:08 +03:00
  72c8ce7885
• Add animation when mention pill appears (or a new message arrives)
  Dean Herbert · 2022-03-21 14:31:51 +09:00
  692362131e
• Add slight fade when hovering ChannelListItems
  Dean Herbert · 2022-03-21 14:28:14 +09:00
  11b050b66b
• Remove box surrounding close button
  Dean Herbert · 2022-03-21 14:25:29 +09:00
  9eda2f2df1
• Rename renaming button/pill classes
  Dean Herbert · 2022-03-21 14:15:22 +09:00
  f922a6b556
• Merge branch 'master' into new-chat-channel-control
  Dean Herbert · 2022-03-21 14:14:02 +09:00
  812343b410
• Fix loading player via skin editor still allowing changing current audio track

  `PlayerLoader` is required in the sequence to get the game into the
  correct state for gameplay right now. Applying ths simplest fix here.
  
  Closes https://github.com/ppy/osu/issues/17351.

  Dean Herbert · 2022-03-21 13:49:56 +09:00
  355b0fa314
• Merge pull request #17315 from hwabis/queue-list-counter
  Salman Ahmed · 2022-03-21 05:28:33 +03:00
  6fbeea78dd
• Merge branch 'master' into queue-list-counter
  Salman Ahmed · 2022-03-21 05:01:09 +03:00
  5c1e11c153
• Revert OsuTabItem Text to protected, update tab count test
  hwabis · 2022-03-20 21:37:02 -04:00
  06136b2247
• make test name clearer
  hwabis · 2022-03-20 16:28:05 -04:00
  63b6686384
• add queue tab count test
  hwabis · 2022-03-20 16:24:41 -04:00
  8fbdd06895
• Nest specific object classes within the mod
  apollo-dw · 2022-03-20 15:56:41 +00:00
  d3742a91a8
• Remove slider tick judgement flag
  apollo-dw · 2022-03-20 15:41:46 +00:00
  35e2e6a4e7
• Obsolete BeatmapInfo.MaxCombo and suppress in usages
  Salman Ahmed · 2022-03-20 16:30:29 +03:00
  b9859f9f21
• Remove no longer necessary MaxCombo assignment in tests
  Salman Ahmed · 2022-03-20 16:29:56 +03:00
  6f47f7ffc8
• Remove unnecessary MaxCombo migration between unmapped database fields
  Salman Ahmed · 2022-03-20 16:27:54 +03:00
  c2063f415d
• Add note about null return value
  Salman Ahmed · 2022-03-20 16:24:30 +03:00
  aef40da8d4
• GetBeatmapMaximumComboAsync -> GetMaximumAchievableComboAsync
  Salman Ahmed · 2022-03-20 16:18:53 +03:00
  2a78042038
• Simplify queue count text logic
  Salman Ahmed · 2022-03-20 06:25:14 +03:00
  e1d22e58bf
• Bind queue items during playlist initialization

  Along with where the other bindables are bound together (only bind, not
  listening).

  Salman Ahmed · 2022-03-20 06:23:44 +03:00
  7529d6fc00
• Compute the beatmap maximum achievable combo instead of Beatmap.MaxCombo
  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  eca7975864
• Introduce method for computing maximum achievable combo properly
  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  d36f32a9c9
• Add explicit todo about removing BeatmapInfo.MaxCombo

  Using that property is a trap basically.

  Salman Ahmed · 2022-03-20 05:38:14 +03:00
  c5cc7eec79
• Only miss slider tail on untrack
  apollo-dw · 2022-03-19 23:42:12 +00:00
  52d6f083dc
• Pass correct params to UpdateableAvatar ctor in ChannelListItem
  Jai Sharma · 2022-03-19 22:20:17 +00:00
  f3702fbefb
• Rename ControlItem -> ChannelListItem and associated classes
  Jai Sharma · 2022-03-19 21:49:14 +00:00
  ba5a43b526
• Use UpdateableAvatar and remove redundant ControlItemAvatar class
  Jai Sharma · 2022-03-19 21:36:11 +00:00
  653bb47dd5
• Use OsuAnimatedButton as base for ControlItemClose
  Jai Sharma · 2022-03-19 21:23:32 +00:00
  5373c3066f
• Use new mod-related object types for Strict Tracking
  apollo-dw · 2022-03-19 18:29:44 +00:00
  149cfd338d