35 Commits

• Turn tests green, for a short while, maybe (#37218)

  ## [Rewrite `BackgroundMusicManager` to not run into framework
  breakage](https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7)
  
  The attempted proper fix to this was
  https://github.com/ppy/osu-framework/pull/6727. Unfortunately when
  presented with [the framework
  bump](https://github.com/ppy/osu/pull/37217) with that change, CI says
  "you're stupid" and fails on some disposal idiocy that of course is
  undebuggable and irreproducible:
  
  The active test run was aborted. Reason: Test host process crashed :
  Unhandled exception. System.AggregateException: One or more errors
  occurred. (Object reference not set to an instance of an object.)
  ---> System.NullReferenceException: Object reference not set to an
  instance of an object.
  at osu.Framework.Audio.Sample.SampleChannelBass.Dispose(Boolean
  disposing)
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task&
  currentTaskSlot, Thread threadPoolThread)
  	   --- End of inner exception stack trace ---
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Audio.AudioCollectionManager`1.UpdateChildren()
  	   at osu.Framework.Threading.AudioThread.OnExit()
  at osu.Framework.Threading.GameThread.setExitState(GameThreadState
  exitState)
  	   at osu.Framework.Threading.GameThread.RunSingleFrame()
  at osu.Framework.Threading.GameThread.<createThread>g__runWork|70_0()
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  	--- End of stack trace from previous location ---
  at System.Threading.ExecutionContext.RunInternal(ExecutionContext
  executionContext, ContextCallback callback, Object state)
  
  
  (https://github.com/ppy/osu/actions/runs/24019928154/job/70046733058?pr=37217#step:5:119)
  
  I no longer have the energy for any of this shit.
  
  @nekodex would appreciate if you could check that I actually haven't
  broken anything with the bgm here. Seems okay to me in test scenes at
  least.
  
  ## [Apply lowest-effort maybe-fixing changes to a bunch of flaking
  tests](https://github.com/ppy/osu/commit/7bd3ca4adfcce5b90add11565a13f3fe9177ad5e)
  
  None of the failures are reproducible locally, of course. I'm tired of
  this. If anyone else wants to subject themselves to actually
  investigating any of these, by all means, godspeed and good luck.

  Bartłomiej Dach · 2026-04-06 17:59:39 +09:00
  809298ddeb
• Move v2 files to final location

  This contains only renames and namespace updates.

  Dean Herbert · 2026-03-03 16:45:15 +09:00
  c28c64940a
• Fix failing tests after disallowing object placements before first timing point
  Bartłomiej Dach · 2025-12-05 09:52:32 +01:00
  66ebce8c12
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Add the most basic (yet failing) test possible
  Bartłomiej Dach · 2025-03-17 14:52:09 +01:00
  613c46d375
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Add test coverage for correct beat divisor save
  Bartłomiej Dach · 2024-06-27 12:38:29 +02:00
  772a68cb3e
• Move TimelineZoom out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  7f2a6f6f5a
• remove all test usages of SampleControlPoint
  OliBomby · 2023-04-26 14:21:52 +02:00
  c6fc180659
• Fix unrelated tests
  ansel · 2023-01-12 03:39:27 +03:00
  e8029e6390
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix dialog overlay not loading in time for headless test
  Joseph Madamba · 2022-07-11 02:29:56 -07:00
  6220650ea3
• Add failing sample playback disabled check
  Joseph Madamba · 2022-07-09 12:10:18 -07:00
  5fcc4bf713
• Fix editor saving not updating BeatmapSetInfo's hash
  Dean Herbert · 2022-07-08 02:33:14 +09:00
  c53dd4a703
• Add test coverage of star rating and difficulty updating on editor save
  Dean Herbert · 2022-06-24 21:02:38 +09:00
  2c5e5fed6f
• Convert == usages to ReferenceEquals
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  e0c82d11ab
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Disallow exiting the editor without saving (unless explicitly confirming)
  Dean Herbert · 2022-03-22 15:42:56 +09:00
  61ddf1e6cf
• Fix TestSceneEditorSaving not waiting for timeline load

  As seen at
  https://github.com/ppy/osu/runs/5276431764?check_suite_focus=true.

  Dean Herbert · 2022-02-22 15:41:08 +09:00
  347a2346b9
• Add test coverage for editor changes not resetting after exit without save
  Bartłomiej Dach · 2022-01-26 21:15:49 +01:00
  4382adad82
• Refactor editor saving test scene for scalability
  Salman Ahmed · 2022-01-26 07:57:46 +03:00
  064468faad
• Add failing test asserts
  Salman Ahmed · 2022-01-25 11:56:38 +03:00
  b2b6672095
• Add failing test coverage for correct beatmap filename generation on save
  Bartłomiej Dach · 2022-01-23 20:28:19 +01:00
  e236f5d604
• Fix SongSelect-related test failures
  Dan Balasescu · 2021-11-25 21:11:13 +09:00
  09dd054283
• Rename BeatmapInfo.Version to DifficultyName to match underlying interface
  Dean Herbert · 2021-11-11 17:20:53 +09:00
  51a353e12d
• Add failing test coverage showing hitobject local control points are defaults
  Dean Herbert · 2021-10-26 16:06:03 +09:00
  b259192a8a
• Switch away from metadata screen before making any changes in test logic
  Dean Herbert · 2021-10-15 11:14:03 +09:00
  02d29097a2
• Just wait for metadata section to be loaded
  Dean Herbert · 2021-10-14 22:12:38 +09:00
  ad0732484f
• Check mutations at each point in the process (and also check artist/title)
  Dean Herbert · 2021-10-14 14:40:20 +09:00
  2e0a2a28ab
• Use actual BeatmapInfo rather than PlayableBeatmap.BeatmapInfo for editor writes
  Dean Herbert · 2021-10-13 14:50:12 +09:00
  02689a1b60
• Merge pull request #15055 from peppy/fix-taiko-convert-woes

  Fix `BeatmapConverter` not cloning deeply enough

  Dan Balasescu · 2021-10-12 21:07:39 +09:00
  f76b58e843
• Split out editor save steps to try and catch test failure
  Dean Herbert · 2021-10-12 19:40:35 +09:00
  79ac64a088
• Add failing coverage for saving difficulty params from editor
  Bartłomiej Dach · 2021-10-12 16:43:56 +09:00
  55bd7d2512
• Add test coverage of creating, saving and loading a new beatmap
  Dean Herbert · 2021-10-06 12:55:04 +09:00
  6e797ddcac