14030 Commits

Author	SHA1	Message	Date
Bartłomiej Dach	ef39759813	More code quality inspections	2023-12-28 00:18:20 +01:00
Bartłomiej Dach	a3f720bc62	Retrieve system title from online source	2023-12-27 23:37:39 +01:00
Bartłomiej Dach	d9299a8a55	Implement visual appearance of "system title" message in main menu	2023-12-27 23:07:17 +01:00
Bartłomiej Dach	1b7af989ec	Migrate BeatmapOffsetControl to use session static directly	2023-12-27 19:19:27 +01:00
Bartłomiej Dach	d4423d4933	Store last set score to a SessionStatic	2023-12-27 19:13:42 +01:00
Bartłomiej Dach	53766285ce	Remove remaining hexacons usages	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	288ac930e4	Use new icons in editor ... Some that exist on figma are purposefully not used due to an editorial request from @peppy.	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	c45477bd1f	Use new icons in main menu wherever feasible	2023-12-27 17:42:18 +01:00
Bartłomiej Dach	668ce937a8	Merge pull request #26138 from peppy/fix-audio-rate-playback-not-fail ... Bail from score submission if audio playback rate is too far from reality	2023-12-26 19:13:46 +01:00
Dean Herbert	d70fddb6fd	Fix elapsed time being counted twice on first frame	2023-12-27 00:11:22 +09:00
Dean Herbert	03e2463b06	Add test coverage and refactor to better handle equality edge case	2023-12-26 21:21:08 +09:00
Dean Herbert	1f2f749db6	Fix selection not being retained in control point list when undoing / redoing	2023-12-26 21:04:42 +09:00
Dean Herbert	f2c0e7cf2e	Fix editor's control point list refreshing multiple times for a single change	2023-12-26 21:04:42 +09:00
Bartłomiej Dach	b1a26acdd0	Merge pull request #26136 from peppy/add-waveform-visual-offset ... Add visual offset to better align editor waveforms with expectations	2023-12-26 12:57:13 +01:00
Dean Herbert	225528d519	Bail from score submission if audio playback rate is too far from reality ... Closes https://github.com/ppy/osu/issues/23149.	2023-12-26 19:20:58 +09:00
Dean Herbert	f9e47242db	Add visual offset to better align editor waveforms with expectations	2023-12-26 17:44:49 +09:00
Nathan Tran	060bf8beff	Fix rewind backtracking	2023-12-25 15:27:32 -08:00
Dean Herbert	686b2a4394	Disable positional interaction for now	2023-12-24 03:00:51 +09:00
Dean Herbert	72bec527fd	Add conditions to match stable offset adjust limitations	2023-12-24 02:36:27 +09:00
Dean Herbert	92b490f2e7	Don't bother with alt support for now	2023-12-24 01:59:48 +09:00
Dean Herbert	6f11885d4b	Add control to allow changing offset from gameplay	2023-12-23 20:51:30 +09:00
Dean Herbert	7e9522a722	Allow external use of offset text explanation	2023-12-23 20:46:12 +09:00
Dean Herbert	27a9dcc5a1	Add basic hotkey offset adjust support (via existing offset control)	2023-12-23 19:55:05 +09:00
Simon G	b31b9e96d0	adjust beatmap length and drain based on rate changing mods	2023-12-22 03:04:48 +01:00
Bartłomiej Dach	81bbdccee7	Rename ScoreInfo.{ -> Client}Version	2023-12-21 12:56:43 +01:00
Dean Herbert	a4baa0a716	Add versioning of local scores ... For any potential future usage	2023-12-21 18:37:15 +09:00
rushiiMachine	ebbc8333e8	Prevent ExportReplay being spammed on fail by being held down ... This was already handled in ReplayDownloadButton (98efff0bd6/osu.Game/Screens/Ranking/ReplayDownloadButton.cs (L114-L115)) but seemingly missed for SaveFailedScoreButton	2023-12-20 08:41:16 -08:00
Dean Herbert	7fa4dcf0fb	Fix selection retention logic copy paste failure	2023-12-20 19:27:57 +09:00
Dean Herbert	e003462f7d	Fix beatmap updates causing one extra carousel selection	2023-12-20 19:15:02 +09:00
Dean Herbert	64f62e7d90	Fix song select running updates when screen is not active ... Who would have guessed that `Schedule` calls were there for a reason! I've tidied things up. Most of the changes I've made here are not required – the schedule is the main thing here. The reason the sound was playing is because one-too-many schedules was removed causing beatmap updates to update carousel specifics while still at the player loader screen. Note that the selection sound still plays on returning to song select, but this is not a regression. I'm looking at fixing this in a separate PR because I'm in a good place as far as understanding the logic right now and it would be a waste to leave it broken. Closes https://github.com/ppy/osu/issues/25875.	2023-12-20 17:31:09 +09:00
Bartłomiej Dach	9a5027e556	Merge pull request #25900 from peppy/editor-from-any-carousel ... Allow choosing "Edit" from any beatmap carousel item	2023-12-20 08:35:42 +01:00
Dan Balasescu	3818977a36	Merge pull request #25898 from peppy/song-select-stats ... Update song select to always show difficulty stats	2023-12-20 14:39:35 +09:00
Dean Herbert	85e5d74a16	Apply proposed changes	2023-12-20 12:42:06 +09:00
OliBomby	c167f10ad5	fix crash from dragging near zero-length repeating object in timeline	2023-12-19 21:20:45 +01:00
Bartłomiej Dach	e306cc35ba	Merge branch 'master' into fix-song-select-realm-refresh-performance	2023-12-19 14:14:46 +01:00
Dean Herbert	bbfdd6892d	Allow choosing "Edit" from any beatmap carousel item	2023-12-19 19:58:49 +09:00
Dean Herbert	502e3edac3	Add missing invalidation call	2023-12-19 19:39:48 +09:00
Dean Herbert	3b848e8503	Tidy up visual look	2023-12-19 19:28:02 +09:00
Dean Herbert	07bb0805e9	Move advanced stats to a more permanent location on song select	2023-12-19 19:10:43 +09:00
Dean Herbert	0a64d631e2	Add support for dual-column advanced stats	2023-12-19 19:09:47 +09:00
Dean Herbert	8f5d21dc70	Actually fix realm selection retention regression	2023-12-19 18:10:55 +09:00
Dean Herbert	7e9c1b2acb	Use sender's realm (because we can)	2023-12-19 17:27:52 +09:00
Bartłomiej Dach	7c05d66bd7	Add more detail to exception	2023-12-19 08:57:18 +01:00
Dean Herbert	44efa2c540	Fix incorrect ordering of items at song select when certain sort modes are used	2023-12-19 15:09:03 +09:00
Dean Herbert	d81cabc063	Revert "Improve performance of attemptSelection using new cached count and LastSelected" ... This reverts commit 25df42630e.	2023-12-18 22:46:02 +09:00
Dean Herbert	25e3a8e82e	Fix a few of silly issues	2023-12-18 22:45:58 +09:00
Dean Herbert	25df42630e	Improve performance of attemptSelection using new cached count and LastSelected	2023-12-18 20:47:08 +09:00
Dean Herbert	5755fa214a	Cache non-filtered beatmap counts to massively improve count performance	2023-12-18 20:44:08 +09:00
Dean Herbert	034c5cd654	Debounce count updates for good measure	2023-12-18 20:43:23 +09:00
Dean Herbert	6fa1f5ef9b	Simplify invalidation logic ... The only case where this was checking is guaranteed by realm to only be called once.	2023-12-18 20:31:02 +09:00
Dean Herbert	87b7699fcc	Avoid calling invalidation logic per beatmap set updated ... Realm will batch the updates. We don't want to do expensive operations per set when we don't need to.	2023-12-18 20:31:02 +09:00
Dean Herbert	32cc3f9ef7	Combine multiple similar invalidation logic into single event	2023-12-18 20:31:02 +09:00
Dan Balasescu	d7aca2f641	Add IApplicableHealthProcessor	2023-12-17 19:27:03 +09:00
Bartłomiej Dach	b3c6e80f5c	Merge pull request #25770 from peppy/show-back-button-spectator ... Show back button when spectating	2023-12-15 09:08:24 +01:00
Dean Herbert	48e89b903c	Merge pull request #25760 from bdach/if-i-speak-i-am-in-big-trouble-pt-1 ... Fix `AdjustedAttributesTooltip` being broken by design	2023-12-15 12:26:10 +09:00
Dean Herbert	27296c59de	Show back button when spectating ... Avoids getting stuck at some screens. It's a bit ugly having the back button visible like this, but is the best approach we have for now.	2023-12-15 11:26:17 +09:00
Dan Balasescu	fbef40bb1f	Reduce some allocations in SongSelect in the mania ruleset	2023-12-15 11:01:15 +09:00
Bartłomiej Dach	9e5b6b97ff	Fix AdjustedAttributesTooltip being broken by design ... Fixes issue described in the following comment: https://github.com/ppy/osu/pull/25759#issuecomment-1855954637 That is just not how the tooltip system is supposed to be used. To name the individual sins: - Caching and returning a tooltip instance like the classes that used tooltips is incorrect. The lifetime of tooltip instances is managed by the tooltip container. `GetCustomTooltip()` is called by it exclusively. It should return a fresh instance every time. - Not putting actual data in `IHasCustomTooltip.TooltipContent` is wrong. - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly* wrong. I'm not even sure which particular combination of the above transgressions caused the issue as it presented itself, but at this time I frankly do not care.	2023-12-14 16:15:56 +01:00
Givikap120	b22a7cf520	Update AdvancedStats.cs	2023-12-14 14:31:58 +02:00
Givikap120	c2373bb37b	change the order of attributes ... + simplifying the bug fix	2023-12-14 14:31:19 +02:00
Givikap120	8698835db2	fixed bug ... fixed the bug where it's not updates tooltip when there are no mods	2023-12-14 14:00:35 +02:00
Dean Herbert	e296730b37	Merge pull request #24642 from Givikap120/arod_rate_adjust ... Show adjusted AR/OD when using DT/HT	2023-12-13 22:17:10 +09:00
Dean Herbert	76c4931f3a	Merge pull request #25673 from frenzibyte/fix-argon-initial-display ... Fix `ArgonHealthDisplay` not displaying miss correctly during initial transition	2023-12-13 22:16:34 +09:00
Dean Herbert	9235f3d935	Merge pull request #25747 from peppy/fix-hit-error-clear ... Fix hit error displays not clearing on seek	2023-12-13 17:36:24 +09:00
Dean Herbert	5062c53e36	Refactor everything for sanity	2023-12-13 17:33:39 +09:00
Dean Herbert	3131d37621	Clear transformations with more fire	2023-12-13 17:00:21 +09:00
Dean Herbert	fb44fb18e0	Update in line with upstream changes	2023-12-13 16:42:20 +09:00
Dean Herbert	0259ab761b	Merge branch 'master' into arod_rate_adjust	2023-12-13 16:35:18 +09:00
Dean Herbert	fdcf87569c	Merge pull request #25711 from smoogipoo/mania-convert-song-select-keycount ... Display osu!mania keycount in song select carousel panels and details	2023-12-13 16:31:25 +09:00
Dean Herbert	ec6200b4ad	Merge pull request #25743 from peppy/merge-everything-at-once ... Merge everything at once	2023-12-13 16:17:06 +09:00
Dean Herbert	f2c6c348be	Fix HitError Clear methods not correctly returning pooled drawables	2023-12-13 16:13:23 +09:00
Dean Herbert	110749205d	Cache GameplayClockContainer to allow usage of OnSeek	2023-12-13 16:13:08 +09:00
Dean Herbert	5e10f9f899	Fix failing tests due to more textboxes being present with searchable dropdowns	2023-12-13 15:11:47 +09:00
Dean Herbert	eb30a603d9	Fix typo in argument name	2023-12-13 15:01:36 +09:00
Dean Herbert	0be6743e87	Apply Bindable.Parse refactorings	2023-12-13 14:07:38 +09:00
Dean Herbert	5b00cf283d	Merge branch 'master' into drawnode-subtree-draw-cleanup	2023-12-13 14:01:01 +09:00
Dan Balasescu	c31ff84417	Fix possible nullref	2023-12-13 13:32:27 +09:00
Givikap120	2d94841929	fixed one test	2023-12-10 02:00:32 +02:00
Givikap120	faf54bca43	Merge branch 'master' into arod_rate_adjust	2023-12-10 01:49:18 +02:00
Givikap120	1d0c37e138	fixed test errors	2023-12-10 00:40:05 +02:00
Dan Balasescu	b36db3518c	Add keycount to song select details panel and carousel panels	2023-12-09 22:31:51 +09:00
Dean Herbert	a500f55ec6	Merge pull request #25688 from peppy/match-default-sv ... Change default slider velocity for new beatmaps to match osu!stable	2023-12-07 11:52:16 +09:00
Bartłomiej Dach	f69a5b44cc	Merge branch 'master' into fix-argon-initial-display	2023-12-06 09:30:28 +01:00
Bartłomiej Dach	4585a169b1	Merge pull request #25686 from peppy/fix-song-select-match ... Fix searching at song select matching incorrect ruleset	2023-12-06 09:25:47 +01:00
Dean Herbert	0af16732b8	Change default slider velocity to 1.4 ... This is the default in osu!stable and plays better than 1.0.	2023-12-06 13:38:46 +09:00
Dean Herbert	4da6d53c72	Merge pull request #25672 from frenzibyte/fix-argon-health-display-2 ... Fix `ArgonHealthDisplay` sometimes behaving weirdly on miss judgements (alternative)	2023-12-06 12:24:39 +09:00
Dean Herbert	8286d3896f	Fix searching at song select matching incorrect ruleset ... Regressed with https://github.com/ppy/osu/pull/25679.	2023-12-06 11:32:26 +09:00
Salman Ahmed	20fd458fac	Perserve miss animation when followed by a hit at same frame	2023-12-05 21:59:28 +03:00
Salman Ahmed	9496cdf42b	Add explanatory note for scheduling	2023-12-05 21:59:28 +03:00
Salman Ahmed	927cfe4257	Fix health processor event leaks	2023-12-05 21:59:28 +03:00
Bartłomiej Dach	88095aaefa	Merge pull request #25637 from smoogipoo/multiplayer-abort ... Add ability for the host to abort an in-progress match	2023-12-05 13:51:00 +01:00
Bartłomiej Dach	4644c4e7a2	Remove unused class	2023-12-05 12:43:32 +01:00
Bartłomiej Dach	566d336470	Merge pull request #25679 from peppy/song-select-search-performance ... Improve song select search performance	2023-12-05 11:06:31 +01:00
Dean Herbert	5a2240838b	Merge branch 'master' into multiplayer-abort	2023-12-05 17:01:54 +09:00
Dean Herbert	02178d8e61	Remove usage of case-when	2023-12-05 16:58:16 +09:00
Dean Herbert	f317e06da1	Use DangerousActionDialog	2023-12-05 16:54:44 +09:00
Dean Herbert	45e499778f	Search terms before performing other criteria checks ... Very minor, but putting the more common case towards the start of the method allows early return.	2023-12-05 15:28:56 +09:00
Dean Herbert	42010574b5	Avoid list construction when doing filtering	2023-12-05 15:26:14 +09:00
Dean Herbert	27e778ae09	Avoid sorting items when already in the correct sort order	2023-12-05 14:47:32 +09:00
Dean Herbert	7fda38d0b0	Use ordinal comparison when searching at song select ... Bypasses various overheads. In theory should be fine? (until it's not on some language)	2023-12-05 14:14:13 +09:00