70487 Commits

This Branch

This Branch

All Branches

• Remove leftover [Solo] attribute
  Bartłomiej Dach · 2024-11-26 12:40:49 +01:00
  c69d36dc96
• Don't reset state when changing from one selection to another in the editor

  This was causing state pollution in the new selection. I can't see why
  this needs to happen when a selection changes to another.
  
  This fixes https://github.com/ppy/osu/issues/30839 and also the same
  issue happening for the new combo toggle.
  
  Tests all seem to pass, and I can't immediately find anything broken,
  but YMMV.

  Dean Herbert · 2024-11-26 17:33:41 +09:00
  3ecb3b674d
• Add failing test case showing changing selection in editor affects samples
  Dean Herbert · 2024-11-26 17:33:41 +09:00
  e0199386a3
• Merge pull request #30859 from frenzibyte/fix-grid-settings-missing-precision

  Fix editor grid settings not displaying decimal portion in slider tooltips

  Bartłomiej Dach · 2024-11-25 14:54:15 +01:00
  285959943f
• Merge pull request #30748 from stanriders/scale-profile-beatmaps

  Scale down beatmap cards

  Dean Herbert · 2024-11-25 22:53:51 +09:00
  9ca17f9b6b
• Merge pull request #30826 from peppy/beatmap-defaults-match-stable

  Change some beatmap default settings to match stable

  Bartłomiej Dach · 2024-11-25 13:40:19 +01:00
  b5f8773c0b
• Merge branch 'master' into beatmap-defaults-match-stable
  Bartłomiej Dach · 2024-11-25 12:55:08 +01:00
  78c01c1b5a
• Fix incorrect unit test
  Bartłomiej Dach · 2024-11-25 12:53:40 +01:00
  c8847e8da8
• Merge pull request #30861 from frenzibyte/fix-multiplayer-missing-hold-delay

  Fix pause shortcut on multiplayer no longer requiring hold

  Dean Herbert · 2024-11-25 16:22:56 +09:00
  82bdd8fbfc
• Merge pull request #30858 from frenzibyte/fix-match-settings-overlay-typo
  Dean Herbert · 2024-11-25 15:58:17 +09:00
  876c2e468a
• Merge pull request #30862 from frenzibyte/dont-scare-the-player

  Don't play fail animation if restarting on fail

  Dean Herbert · 2024-11-24 23:11:19 +09:00
  c34827a4ed
• Merge pull request #30855 from SupDos/tips-remove-fps

  Remove FPS shortcut tip

  Dean Herbert · 2024-11-24 19:57:08 +09:00
  888f02e3a6
• Don't play fail animation if restarting on failure
  Salman Alshamrani · 2024-11-24 04:45:48 -05:00
  6d0d7f3e75
• Fix pause shortcut on multiplayer not delayed
  Salman Alshamrani · 2024-11-24 04:24:31 -05:00
  f3155bfc7d
• Merge pull request #30830 from smoogipoo/multiplayer-remove-expired-item-removal

  No longer remove expired playlist items from `Room` model

  Salman Alshamrani · 2024-11-23 23:58:17 -05:00
  354bc424a3
• Fix editor grid settings not displaying decimal portion in slider tooltips
  Salman Alshamrani · 2024-11-23 22:27:56 -05:00
  cab26c70c1
• Merge branch 'master' into multiplayer-remove-expired-item-removal
  Salman Alshamrani · 2024-11-23 22:19:21 -05:00
  956da0383f
• Fix room auto start duration setting applied to the wrong component
  Salman Alshamrani · 2024-11-23 22:16:29 -05:00
  8f5d513d46
• Merge branch 'master' into tips-remove-fps
  Salman Alshamrani · 2024-11-23 20:57:14 -05:00
  6b78553559
• Merge pull request #30834 from peppy/fix-song-ticker-contrast

  Fix song ticker having very bad contrast against bright backgrounds

  Salman Alshamrani · 2024-11-23 20:55:26 -05:00
  7a973b0243
• Remove FPS shortcut tip
  SupDos · 2024-11-24 02:34:30 +01:00
  2f096f71d3
• Merge branch 'master' into fix-song-ticker-contrast
  Salman Alshamrani · 2024-11-23 20:14:33 -05:00
  608bda135a
• Remove using directive
  Salman Alshamrani · 2024-11-23 20:13:57 -05:00
  2f45ebeec8
• Merge pull request #30636 from peppy/remove-macos-recommendation

  Remove macOS "borderless" recommendation

  Salman Alshamrani · 2024-11-22 23:54:57 -05:00
  63c2ddb99e
• Merge branch 'master' into remove-macos-recommendation
  Salman Alshamrani · 2024-11-22 23:14:09 -05:00
  c9dc6628fc
• Merge pull request #30812 from smoogipoo/playlist-populate-on-enter

  Fix joining playlists room sometimes not selecting the first item

  Dean Herbert · 2024-11-22 23:57:45 +09:00
  ce41c000a1
• Remove legacy default setter for SamplesMatchPlaybackRate now that it's the default
  Dean Herbert · 2024-11-22 19:05:29 +09:00
  c590bef4c3
• Merge branch 'master' into scale-profile-beatmaps
  Dean Herbert · 2024-11-22 18:33:37 +09:00
  e33e0e16e8
• Fix song ticker having very bad contrast against bright backgrounds

  Closes #30814.

  Dean Herbert · 2024-11-22 18:17:55 +09:00
  04ed954387
• Cleanup CopyFrom() method

  Though the code appears slightly different, it should be semantically
  equivalent. APIUser equality is implemented on `Id` and `Host` should
  never transition from non-null to null.

  Dan Balasescu · 2024-11-22 17:22:30 +09:00
  39504c348d
• No longer remove expired playlist items from Room model
  Dan Balasescu · 2024-11-22 17:19:26 +09:00
  e59ac9e7c8
• Merge pull request #30799 from peppy/fix-player-loader-focus-fux

  Fix beatmap load not continuing when when settings slider is focused

  Bartłomiej Dach · 2024-11-22 08:57:10 +01:00
  479ff7eb41
• Change some beatmap default settings to match stable

  - Countdown should [be off by
  default](https://github.com/peppy/osu-stable-reference/blob/9a0748563812b5085a0ef5f8600b997408330eab/osu!/GameplayElements/Beatmaps/Beatmap.cs#L372)
  - Samples match playback rate
  [also](https://github.com/peppy/osu-stable-reference/blob/9a0748563812b5085a0ef5f8600b997408330eab/osu!/GameplayElements/Beatmaps/Beatmap.cs#L210)

  Dean Herbert · 2024-11-22 16:55:37 +09:00
  a76b4418b9
• Merge pull request #30807 from smoogipoo/multiplayer-nrt

  Enable NRT for multiplayer and playlists

  Bartłomiej Dach · 2024-11-22 08:50:11 +01:00
  ce3d4e8648
• Merge branch 'master' into multiplayer-nrt
  Bartłomiej Dach · 2024-11-22 08:09:42 +01:00
  512d2c6e3b
• Merge pull request #30766 from Darius-Wattimena/catch-improve-info-on-selected

  Add snapping info to the catch selected objects inspector

  Bartłomiej Dach · 2024-11-22 08:08:33 +01:00
  4a129ac0bf
• Merge pull request #29640 from smoogipoo/mania-imperfect-ss

  Make mania award SS even if there are GREAT judgements

  Dean Herbert · 2024-11-22 14:42:32 +09:00
  2024.1122.0 6a0ac4c29e
• Merge pull request #30819 from frenzibyte/recreate-beatmap-per-mod-test

  Recreate beatmap every test run in `ModTestScene`

  Dean Herbert · 2024-11-22 14:11:08 +09:00
  66be38b227
• Rename variable to imply it is now a function
  Dean Herbert · 2024-11-22 13:11:32 +09:00
  41addaae9a
• Recreate beatmap every test run in ModTestScene
  Salman Alshamrani · 2024-11-21 17:48:33 -05:00
  5dffc322af
• Fix tests
  Dan Balasescu · 2024-11-22 01:26:35 +09:00
  2a7266cb23
• Populate rooms as soon as they're joined
  Dan Balasescu · 2024-11-21 23:48:04 +09:00
  f738fb2a89
• Populate parameter description

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2024-11-21 22:47:46 +09:00
  84ac3097c2
• Merge pull request #30802 from cloudrac3r/patch-1

  Use consistent decimal places in BeatmapAttributeText

  Bartłomiej Dach · 2024-11-21 14:32:25 +01:00
  23ef8fd909
• Merge branch 'master' into patch-1
  Bartłomiej Dach · 2024-11-21 13:06:19 +01:00
  74170ea28e
• Fix tests
  Bartłomiej Dach · 2024-11-21 13:06:01 +01:00
  42f2ad2423
• Enable NRT in TestMultiplayerRoomManager
  Dan Balasescu · 2024-11-21 21:03:12 +09:00
  209380cbac
• Fix crash due to being too forgiving of nulls

  This one is super duper annoying to test, because we already have e.g.
  `TestScenePlaylistsScreen`. The only way to test it would be to use an
  `OsuGameTestScene`.
  
  Maybe this is okay?

  Dan Balasescu · 2024-11-21 20:52:34 +09:00
  cc59434ea4
• Merge pull request #30805 from smoogipoo/fix-playlists-enter-status

  Fix playlist room status resetting on enter

  Bartłomiej Dach · 2024-11-21 12:50:39 +01:00
  2eef920e70
• Fix inspection
  Dan Balasescu · 2024-11-21 20:41:14 +09:00
  dc45816566