tsrk
c637fddf73
refactor: decouple Trigger logic from KeyCounterDisplay
...
This allows to keep a coeherent state regardless of the progress of the play
2023-06-14 21:13:35 +02:00
tsrk
e9ef270e46
refactor: move count logic in InputTrigger
...
This will allow us to keep track of the real count regardless of whether
the key counter has been placed mid-replay or not.
2023-06-14 19:39:28 +02:00
tsrk
758831b983
test: remove hard usages of KeyCounterDisplay
2023-06-14 13:25:24 +02:00
tsrk
6fc6729677
feat: integrate attachment flow in SkinComponentsContainer
2023-06-06 00:27:43 +02:00
tsrk
4c397085c5
refactor: improve attachement flow
...
This removes the hard reliance on individual classes and makes its usage easiser to ingreate anywhere
else.
2023-06-06 00:12:53 +02:00
tsrk
41b7eacc72
Merge branch 'master' into hud/argon-kc-animations-poc
2023-06-05 15:22:20 +02:00
Bartłomiej Dach
25d0f0f3da
Merge pull request #23741 from peppy/fix-manage-collection-commit-on-focus-loss
...
Fix collection name changes not being reflected if enter is not pressed
2023-06-04 17:19:13 +02:00
Bartłomiej Dach
d0167cb324
Merge pull request #23718 from peppy/tidy-results-grid-usage
...
Tidy up results screen statistic item flow
2023-06-04 16:57:51 +02:00
Dean Herbert
eb7586b517
Ensure collection edit textbox commits on focus loss
...
As discussed in https://github.com/ppy/osu/discussions/23739
2023-06-04 12:51:03 +09:00
Dean Herbert
3e308e4c27
Add test coverage showing commit failure in manage collections dialog
2023-06-04 12:50:30 +09:00
Bartłomiej Dach
331e90f720
Merge branch 'master' into tidy-results-grid-usage
2023-06-03 19:45:23 +02:00
Bartłomiej Dach
51149343fb
Merge pull request #23551 from timiimit/update-multiplayer-room-diff-range
...
Fix multiplayer room difficulty range not being updated
2023-06-03 19:41:50 +02:00
Bartłomiej Dach
602d5db3bb
Simplify column dimensions code
...
`dimensions` would always receive exactly one item, so might as well
inline it.
And yes, at this point the grid container is mostly a glorified
`FillFlowContainer { Direction = FlowDirection.Vertical }`, but I am not
touching that in this pull pending further decisions with respect to
direction.
2023-06-03 19:40:01 +02:00
Bartłomiej Dach
474f7c2bc0
Fix code quality inspection
2023-06-03 16:50:58 +02:00
Bartłomiej Dach
a9d4556647
Merge branch 'master' into update-multiplayer-room-diff-range
2023-06-03 16:50:09 +02:00
Bartłomiej Dach
0b841eda71
Merge pull request #23719 from peppy/disable-tablet-support-on-error
...
Automatically disable tablet support on error
2023-06-03 12:25:06 +02:00
Bartłomiej Dach
24f0b8df1f
Merge pull request #23733 from peppy/bubble-mod-pool-fix
...
Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)
2023-06-03 08:56:26 +02:00
Dean Herbert
a5fd833214
Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)
2023-06-02 23:01:03 +09:00
Dean Herbert
8063d50369
Merge pull request #23730 from smoogipoo/reduce-legacy-diffcalc-mod-init
...
Fix legacy mod difficulty calculation creating all mods unnecessarily
2023-06-02 22:22:19 +09:00
Dan Balasescu
bfe80fe143
Fix legacy diffcalc creating all mods unnecessarily
2023-06-02 17:37:43 +09:00
Dean Herbert
c33ddedca0
Disable all tablet handlers to guard against a grim future
2023-06-02 08:48:47 +09:00
Bartłomiej Dach
f8289927d2
Merge pull request #23720 from peppy/fix-mouse-disappear-screenshot-fail
...
Fix mouse cursor potentially disappearing for good if screenshot capture fails
2023-06-01 23:09:23 +02:00
Bartłomiej Dach
4daf1fcb7d
Merge pull request #23721 from peppy/fix-mania-hold-not-early-hit
...
Fix osu!mania hold notes snapping to judgement area too early on early hits
2023-06-01 21:57:36 +02:00
Bartłomiej Dach
b4ab3c8921
Merge pull request #23701 from EVAST9919/editor-timeline-fix
...
Fix editor timeline hitobjects popping in and out of existence
2023-06-01 21:57:14 +02:00
Bartłomiej Dach
8433813677
Merge branch 'master' into editor-timeline-fix
2023-06-01 21:18:08 +02:00
Bartłomiej Dach
c2d89a32a9
Adjust inline comment
2023-06-01 21:18:00 +02:00
Andrei Zavatski
03eb7c7830
Fix nullability
2023-06-01 21:21:01 +03:00
Andrei Zavatski
949fe32740
Use combined area of children as a mask instead
2023-06-01 15:32:17 +03:00
Dean Herbert
00bf79d51f
Merge pull request #23691 from smoogipoo/mania-scroll-speed
...
Replace mania scroll "time" with scroll "speed"
2023-06-01 17:23:27 +09:00
Dean Herbert
98f35f7481
Fix osu!mania hold notes snapping to judgement area too early on early hits
...
Closes https://github.com/ppy/osu/issues/23515 .
2023-06-01 16:06:35 +09:00
Dean Herbert
289f0e9862
Use FireAndForget to avoid unobserved exception
2023-06-01 15:50:37 +09:00
Dean Herbert
0a7d5a51d4
Fix mouse cursor potentially disappearing for good if screenshot capture fails
2023-06-01 15:50:13 +09:00
Dean Herbert
9f8a13480b
Automatically disable tablet support on error
...
Closes #23710 .
2023-06-01 15:16:48 +09:00
Dean Herbert
bbc5b86077
Merge pull request #23717 from peppy/fix-accuracy-heatmap
...
Fix accuracy heatmap not working since scoring changes
2023-06-01 14:41:58 +09:00
Dean Herbert
985604fab5
Return StatisticItems rather than StatisticRows from ruleset
...
There were no usages of more than one column being provided per row, so
it seemed like unnecessarily complexity. I'm currently trying to reduce
complexity so we can improve the layout of the results screen, which
currently has up to three levels of nested `GridContainer`s.
Of note, I can't add backwards compatibility because the method
signature has not changed in `Ruleset` (only the return type). If we do
want to keep compatibility with other rulesets, we could designate a new
name for the updated method.
2023-06-01 14:35:15 +09:00
Dean Herbert
dc595b83f1
Remove unused Dimension specification from StatisticItem
2023-06-01 14:25:18 +09:00
Dean Herbert
e830b96e61
Add back required override to make AccuracyHeatmap work
2023-06-01 13:26:47 +09:00
Dean Herbert
310c54fe28
Add test coverage ensuring positional data is present in hit events
2023-06-01 13:26:47 +09:00
Dean Herbert
55a3847036
Merge pull request #23708 from peppy/labelled-slider-visibility
...
Adjust background colour used in `LabelledDrawable`s to allow visibility of some elements
2023-06-01 13:08:17 +09:00
Bartłomiej Dach
d78df0b084
Merge pull request #23695 from peppy/realm-startup-error-handling
...
Adjust realm startup for added reliability
2023-05-31 22:46:58 +02:00
Dean Herbert
7bc3b2072c
Update framework
2023-06-01 00:44:13 +09:00
Dean Herbert
20439e80f6
Adjust background colour used in LabelledDrawables to allow visibility of sliders
2023-05-31 23:24:21 +09:00
Dean Herbert
812def124f
Merge pull request #23661 from peppy/fix-multiplayer-present-crash
...
Fix `OnResume` / `OnSuspending` potentially getting called before `OnEntering` on a sub screen
2023-05-31 19:43:30 +09:00
Dean Herbert
18eb15bfa5
Gracefully handle failures in cleaning up pending file deletions
2023-05-31 19:39:43 +09:00
Bartłomiej Dach
aaf50c47a7
Merge pull request #23696 from peppy/fix-autopilot-ripples
...
Fix cursor ripples appearing in a weird place when "autopilot" mod is enabled
2023-05-30 23:29:30 +02:00
Bartłomiej Dach
2e81cae201
Move comment to more correct place
2023-05-30 23:18:34 +02:00
Bartłomiej Dach
62d1774407
Apply same comment & reworded condition to suspend too
2023-05-30 21:54:56 +02:00
Dan Balasescu
b6e407f348
Merge pull request #23697 from peppy/update-readme
...
Update readme with `UseLocalxxx` scripts mentioned
2023-05-30 23:01:01 +09:00
Andrei Zavatski
d119447a10
Fix editor timeline hitobjects popping in
2023-05-30 16:41:42 +03:00
Dean Herbert
741ee84ed6
Add comment and use full conditional similar to extension method
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-05-30 18:38:28 +09:00
