926 Commits

• Adjust inline comment
  Bartłomiej Dach · 2023-06-01 21:18:00 +02:00
  c2d89a32a9
• Fix nullability
  Andrei Zavatski · 2023-06-01 21:21:01 +03:00
  03eb7c7830
• Use combined area of children as a mask instead
  Andrei Zavatski · 2023-06-01 15:32:17 +03:00
  949fe32740
• Fix editor timeline hitobjects popping in
  Andrei Zavatski · 2023-05-30 16:41:42 +03:00
  d119447a10
• Merge pull request #23649 from peppy/keep-selection-buttons-on-screen

  Ensure editor selection buttons remain on screen when selection is near edge

  Dean Herbert · 2023-05-26 20:51:45 +09:00
  725734bc03
• Merge branch 'master' into sample-set-controls
  Bartłomiej Dach · 2023-05-25 21:58:16 +02:00
  96fe7cbe54
• Fix ComposeBlueprintContainer briefly assigning auto bank

  Seems to have had no consequence due to the way
  `AutomaticBankAssignment` works (that flag is checked in
  `PlacementBlueprint.UpdateTimeAndPosition()`, which runs essentially
  every frame), but let's avoid putting it there at all ever.

  Bartłomiej Dach · 2023-05-25 21:49:29 +02:00
  7d8f08c0ea
• Polish a few extreme edge cases
  Bartłomiej Dach · 2023-05-25 16:39:54 +02:00
  3ad5f8b9c9
• Ensure selection is reset after immediately deleting objects

  Closes https://github.com/ppy/osu/issues/23518.

  Dean Herbert · 2023-05-25 23:20:32 +09:00
  949de35664
• Use alternative layouting implementation
  Bartłomiej Dach · 2023-05-25 16:17:44 +02:00
  beeca5a8dd
• Simplify SelectionHandler's DeselectAll implementation

  We are already doing other operations in this class directly on `SelectedItems`, so might as well change this one to match

  Dean Herbert · 2023-05-25 18:46:31 +09:00
  1049257b56
• Fix bindable feedback loop
  Dean Herbert · 2023-05-25 17:58:38 +09:00
  1e14b02493
• Merge branch 'master' into beat-divisor-visual-improvements
  Bartłomiej Dach · 2023-05-24 22:28:26 +02:00
  578a0e7494
• Allow deselecting any selection in the editor using the Back binding (escape key)
  Dean Herbert · 2023-05-24 19:24:14 +09:00
  b14b1072c2
• Ensure editor selection buttons remain on screen when selection is near edge

  Addresses https://github.com/ppy/osu/discussions/23599.

  Dean Herbert · 2023-05-24 19:16:53 +09:00
  3b9e1e8a94
• Add "auto" bank selection during placement
  Dean Herbert · 2023-05-24 17:11:12 +09:00
  3a05dffa50
• Don't use switch for single case statement
  Dean Herbert · 2023-05-24 16:14:05 +09:00
  fc22c75464
• Update to support non-control-point sample changes
  Dean Herbert · 2023-05-24 14:20:38 +09:00
  a9ba16a2be
• Merge branch 'master' into sample-set-controls
  Dean Herbert · 2023-05-24 14:03:04 +09:00
  298989ffd2
• Tidy up implementation and ensure non-solid ticks start at zero alpha
  Dean Herbert · 2023-05-24 13:49:29 +09:00
  561b759bf9
• Merge pull request #66 from Gyoshi/beat-divisor-visual-improvements

  Add ghost ticks to exhibit current divisor on `BeatDivisorControl`

  Dean Herbert · 2023-05-24 13:41:48 +09:00
  8f1f1955df
• Last instead of Max divisor to match code elsewhere
  Gyoshi · 2023-05-23 18:45:49 +02:00
  7fe19d1992
• Code styling
  Gyoshi · 2023-05-23 18:44:20 +02:00
  c5ef3ae181
• Use RangePadding to align mouse with slider
  Gyoshi · 2023-05-23 18:16:14 +02:00
  b5f8093941
• Small format
  Gyoshi · 2023-05-23 15:11:27 +02:00
  7b1e8ede54
• Remove duplicate code by making GetDivisorForBeatIndex method more general
  Gyoshi · 2023-05-23 15:05:38 +02:00
  1b32370c6a
• Small format & comment
  Gyoshi · 2023-05-23 14:30:35 +02:00
  37a796306d
• Add ghost ticks to exhibit current divisor on BeatDivisorControl
  Johannes vd Berg · 2023-05-23 12:57:25 +02:00
  ebda35c3c9
• Merge pull request #23582 from peppy/placement-blueprint-timeline-combo-fixes

  Fix timeline blueprint display not showing correct combo number / colour during placement

  Bartłomiej Dach · 2023-05-20 15:02:55 +02:00
  afdddb0195
• Add TODO regarding failing stack display code
  Dean Herbert · 2023-05-17 17:52:17 +09:00
  214d7e07fa
• Fix weird purple tint on placement object in timeline
  Dean Herbert · 2023-05-17 17:26:19 +09:00
  9563d4f730
• Update beat divisor control to show ticks in more visually correct locations

  As proposed in https://github.com/ppy/osu/discussions/23527.

  Dean Herbert · 2023-05-17 16:34:12 +09:00
  87ff28b022
• Rename GetSampleInfo to better describe what method does

  Also add full xmldoc

  Dean Herbert · 2023-05-17 14:07:48 +09:00
  dc51d5ecf3
• Fix bank not correctly being assigned when adding sample additions in editor
  Dean Herbert · 2023-05-16 18:52:52 +09:00
  d9ae822966
• Force placement of in-progress object when changing tools in the editor
  Dean Herbert · 2023-05-12 16:06:01 +09:00
  70e248b927
• Fix missing delegate unsubscribe
  Dean Herbert · 2023-05-09 17:08:03 +09:00
  2085833a84
• Rename slider multiplier variable back for now
  Dean Herbert · 2023-05-09 16:58:19 +09:00
  944da06c10
• Change difficulty popover inspector display (yet again)

  I think this makes the most sense of the iterations I've tested so far, albeit maybe being a touch too verbose.

  Dean Herbert · 2023-05-08 13:43:23 +09:00
  a6cb1f90e4
• Show post-multiplied velocity in main hit object inspector
  Dean Herbert · 2023-05-08 13:42:25 +09:00
  a91edd68d9
• Show base velocity in slider adjustment popover
  Dean Herbert · 2023-05-08 13:13:09 +09:00
  d9dd35c020
• Remove median/mode slider velocity display

  The intention was to give an idea of what the most common velocity of
  the beatmap is, but in hindsight, because the "base" velocity is being
  set elsewhere this doesn't make sense. It will/should be 1.0x.
  
  Showing this range is still valuable, though.

  Dean Herbert · 2023-05-08 13:13:09 +09:00
  31de4de720
• Fix delegate leak
  Bartłomiej Dach · 2023-05-05 20:33:27 +02:00
  e808a47811
• Use shorter copy
  Bartłomiej Dach · 2023-05-05 20:30:50 +02:00
  f536238554
• Add display of beatmap slider velocity when adjusting
  Dean Herbert · 2023-05-05 15:57:38 +09:00
  b7a287869a
• Move editor inspector classes out of ruleset namespace
  Dean Herbert · 2023-05-05 15:57:38 +09:00
  cc70d89bf9
• Merge pull request #23308 from OliBomby/sample-control-points

  Remove SampleControlPoint and DifficultyControlPoint from HitObject

  Dean Herbert · 2023-05-03 14:21:51 +09:00
  6b017ac05f
• Fix non-block namespace usage
  Dean Herbert · 2023-05-02 15:09:24 +09:00
  8a536c1cdb
• fix infinite repeat count when adjusting length of 0 length slider
  OliBomby · 2023-05-01 15:48:54 +02:00
  1dc34ee25d
• Merge remote-tracking branch 'upstream/master' into sample-control-points
  OliBomby · 2023-04-30 19:47:03 +02:00
  608fa3cc73
• remove all regular usage of DifficultyControlPoint
  OliBomby · 2023-04-26 17:55:38 +02:00
  c44f71a737