204 Commits

• Fix OverlappingScrollAlgorithm returning incorrect results for TimeAt before first control point
  Dean Herbert · 2023-05-26 19:59:19 +09:00
  cb468fa4ec
• Apply nullability in related classes and remove unused variable
  Dean Herbert · 2023-05-08 17:09:08 +09:00
  1b7dd32eb1
• Use MaximumJudgementOffset for lifetime
  ekrctb · 2023-01-19 21:25:21 +09:00
  d8f9b7d02f
• Fix two implementation oversights
  Dean Herbert · 2022-12-02 16:05:14 +09:00
  809d02cda0
• Fix test failures when no hitobjects are present in a scrolling ruleset
  Dean Herbert · 2022-12-01 21:42:03 +09:00
  d8dd7e7e0f
• Fix multiple instances of last hitobject time being calculated incorrectly
  Dean Herbert · 2022-12-01 18:04:06 +09:00
  896f2d8f74
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove unnecessary #nullable disable
  Bartłomiej Dach · 2022-11-20 15:31:51 +01:00
  0f382590e6
• Introduce IDrawableScrollingRuleset for editor consumption
  Salman Ahmed · 2022-11-20 04:11:10 +03:00
  58296bd4f0
• Fix incorrect fallback logic

  Regressed when attempting to share implementation of binary search.

  Dean Herbert · 2022-10-20 23:08:44 +09:00
  5c13c443ff
• Refactor implementation to support hitobjects nested multiple levels deep
  Dean Herbert · 2022-10-20 22:30:30 +09:00
  26860a903e
• Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time
  Dean Herbert · 2022-10-18 16:15:21 +09:00
  d237c818f6
• Standardise control point search logic in OverlappingScrollAlgorithm

  Was using a very local algorithm which I cannot guarantee is correct.
  I'd rather it just use the one used everywhere else.

  Dean Herbert · 2022-10-18 16:01:05 +09:00
  ec3761ced9
• Fix scrolling nested hit object lifetime not set
  ekrctb · 2022-10-04 15:17:14 +09:00
  1cccd03480
• Add test for scrolling hit object lifetime
  ekrctb · 2022-10-04 15:17:11 +09:00
  781f5420b0
• Compute lifetime from entry in scrolling container
  ekrctb · 2022-10-04 15:12:28 +09:00
  5d80950eaf
• Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements

  Clamp `LifetimeStart` of `HitObject`s to their judgement windows

  Dan Balasescu · 2022-09-28 17:49:35 +09:00
  cbed268ac9
• Clamp LifetimeStart of HitObject's to their judgement windows
  sw1tchbl4d3 · 2022-09-27 16:54:24 +02:00
  0cffbb7562
• Cleanup all other leftover binding instantiation
  o-dasher · 2022-09-25 16:02:40 -04:00
  feadac1f79
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Move mania note height offset application to a much more suitable location
  Dean Herbert · 2022-05-12 16:19:07 +09:00
  f7e055dbfe
• Fix calculation of most common beat length for mania scroll speed
  Dan Balasescu · 2022-01-11 11:00:30 +09:00
  a09563a7d9
• Remove usage of key repeat helper method
  Dean Herbert · 2021-11-18 13:13:36 +09:00
  66c307e0ee
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-08 18:41:17 +09:00
  bc37cb6f43
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Merge branch 'master' into no-more-difficulty-control-points-info
  Dean Herbert · 2021-09-28 13:53:56 +09:00
  46bafb6252
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Move mania-specific conversion to converter
  Dean Herbert · 2021-09-06 21:06:13 +09:00
  3c7a34bdbd
• Populate new approach rate where required
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  d587dc6203
• Update IPositionalSnapProvider to take a HitObject as reference, rather than raw time

  This allows fetching the correct `DifficultyControlPoint` from the
  hitobject. Nothing more.

  Dean Herbert · 2021-09-03 17:11:12 +09:00
  d4e5a612ea
• Increase TimeRange max value
  smoogipoo · 2021-08-02 19:37:45 +09:00
  2af827f913
• Use natural anchor for TimeAtPosition and PositionAtTime

  The natural anchor is the end of the scrolling direction (e.g. Bottom for Down scrolling).

  ekrctb · 2021-06-15 13:15:20 +09:00
  bbf0022689
• Improve xmldoc
  Bartłomiej Dach · 2021-06-14 21:54:55 +02:00
  cb1e2e3d97
• Clarify multiple coordinate systems

  - Fix wrong position is set for DHOs for down/right scrolling direction.

  ekrctb · 2021-06-14 13:13:27 +09:00
  660bf50dc7
• Fix TimeAtPosition doc comment
  ekrctb · 2021-06-14 13:13:27 +09:00
  09f1cbde7e
• Simplify flipPositionIfRequired using scrollLength
  ekrctb · 2021-06-14 13:13:27 +09:00
  fdb09ef4d7
• Use Direction enum instead of int

  The property is named `scrollingAxis` to distinguish from `direction`, which is of `ScrollingDirection` type (unfortunate name crash).

  ekrctb · 2021-06-14 13:13:27 +09:00
  8cf4454780
• Refactor ScrollingHitObjectContainer and expose more useful methods
  ekrctb · 2021-06-11 18:28:48 +09:00
  af3f253b21
• Remove OnAdd/OnRemove of HitObjectContainer

  Instead, override `AddDrawable`/`RemoveDrawable`.

  ekrctb · 2021-06-03 15:00:16 +09:00
  b321b20e9d
• Make HitObjectContainer.Clear non-virtual

  It just call `Remove` for all entries.

  ekrctb · 2021-06-03 15:00:16 +09:00
  0ce7baa3f3
• Merge branch 'simplify-shoc' into fix-scrolling-lifetime

  # Conflicts:
  #	osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs

  ekrctb · 2021-05-31 16:50:47 +09:00
  948a14a627
• Reset lifetime to initial lifetime when layout is invalidated
  ekrctb · 2021-05-31 16:47:10 +09:00
  86d1225aad
• Remove scrollLength caching field

  It was not clear when the field is updated.

  ekrctb · 2021-05-31 16:28:02 +09:00
  6d96846776
• Remove delay of lifetime update

  The scheduling is no longer necessary because `OnAdd` is changed to not invoked immediately for non-pooled DHOs.

  ekrctb · 2021-05-31 16:24:13 +09:00
  742c5b442b
• Don't add nested hit objects to the sets

  Only top-level hit objects are checked for layout computation caching.
  Also, lifetime of nested hit objects are not managed by the HitObjectContainer.

  ekrctb · 2021-05-31 16:20:35 +09:00
  3cedc0824d
• Revert "Use entry to calculate lifetime in ScrollingHOC"

  This reverts commit 632bb70e

  ekrctb · 2021-05-18 19:55:31 +09:00
  84a1a86c63
• Revert "Fix uninitialized scrollLength value is used"

  This reverts commit 73dfb04d

  ekrctb · 2021-05-18 19:55:25 +09:00
  2c65b8fa93
• Fix uninitialized scrollLength value is used
  ekrctb · 2021-04-29 15:17:30 +09:00
  73dfb04df8
• Use entry to calculate lifetime in ScrollingHOC

  DHOs cannot be used to calculate lifetime, it is not created before the entry became alive.

  ekrctb · 2021-04-29 15:04:32 +09:00
  632bb70e0f