1372 Commits

• Mark Live methods as InstantHandleAttribute
  Dean Herbert · 2022-07-28 15:03:08 +09:00
  2209afd0e8
• Add migration of existing collections database
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  1669208a54
• Replace BeatmapCollection with RealmBeatmapCollection
  Dean Herbert · 2022-07-27 19:35:09 +09:00
  41393616d8
• Remove CollectionManager
  Dean Herbert · 2022-07-27 18:45:33 +09:00
  9c543fef48
• Split out legacy import path from realm manager
  Dean Herbert · 2022-07-27 15:04:09 +09:00
  6b73f7c7ec
• Fix new update pathway not actually being used
  Dean Herbert · 2022-07-26 17:58:09 +09:00
  9173271900
• Add ImportAsUpdate method to IModelImporter to avoid otehr changes
  Dean Herbert · 2022-07-26 15:49:04 +09:00
  8370ca9765
• Fix some realm pieces not being cleaned up
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  8a0c8f5fd8
• Move implementation of updating a beatmap to BeatmapImporter
  Dean Herbert · 2022-07-25 19:51:19 +09:00
  2e14d8730c
• Fix old version of beatmap potentially not being deleted during update flow

  This can happen if the online IDs are not present in the `.osu` files.
  Previously this was only working due to the early logic in the import
  process (that relies on matching all online IDs perfectly).

  Dean Herbert · 2022-07-25 19:51:19 +09:00
  b7f6413bce
• Change migration to trigger reprocessing on every local beatmap

  Was originally relying on the fact that this would be triggered due to a
  null `LastOnlineUpdate`, but wouldn't cover the case of beatmaps with no
  `OnlineID`.

  Dean Herbert · 2022-07-21 18:31:12 +09:00
  94cd641fb4
• Change default value of StarRating to -1
  Dean Herbert · 2022-07-21 18:20:46 +09:00
  d5e0dba9da
• Add last applied version to RulesetInfo
  Dean Herbert · 2022-07-21 18:15:25 +09:00
  68f28ff660
• Merge branch 'master' into date-submitted-ranked
  Dan Balasescu · 2022-07-20 18:36:57 +09:00
  2b399ec7ad
• Fix incorrect DI fetch and apply nullability to ModelDownloader
  Dean Herbert · 2022-07-19 20:06:34 +09:00
  6357223341
• Add ranked and submitted date storage and filtering
  Dean Herbert · 2022-07-19 19:55:56 +09:00
  30daa0fd44
• Add basic handling of download failures
  Dean Herbert · 2022-07-19 19:01:23 +09:00
  17046b0553
• Add new properties to BeatmapInfo to track online hash and updates
  Dean Herbert · 2022-07-19 17:57:01 +09:00
  6ea380d649
• Update naming
  Dean Herbert · 2022-07-18 16:17:20 +09:00
  51f91fe62e
• Store user country on databased scores
  Salman Ahmed · 2022-07-16 06:39:05 +03:00
  4e7156cee8
• Standardise HasReplay implementation (and remove from persisting to realm)
  Dean Herbert · 2022-07-15 16:14:21 +09:00
  c8c79d2185
• Add last played date to BeatmapInfo
  Dean Herbert · 2022-07-13 16:36:43 +09:00
  8820ea4006
• Ensure initial beatmap processing is done inside the import transaction
  Dean Herbert · 2022-07-11 02:51:54 +09:00
  8b6665cb5b
• Merge pull request #19029 from peppy/fix-skin-import-duplicate

  Fix skins potentially being duplicated on batch import

  Dan Balasescu · 2022-07-08 14:18:14 +09:00
  0bc332e90b
• Fix editor saving not updating BeatmapSetInfo's hash
  Dean Herbert · 2022-07-08 02:33:14 +09:00
  c53dd4a703
• Fix skins potentially being duplicated on batch import

  Resolves https://github.com/ppy/osu/discussions/19024#discussioncomment-3099200

  Dean Herbert · 2022-07-07 22:39:07 +09:00
  cf1da1dd18
• Fix transaction not being disposed
  Dean Herbert · 2022-07-07 18:15:38 +09:00
  ac216d94a8
• Add automatic transaction handling to realm helper methods
  Dean Herbert · 2022-07-07 17:36:25 +09:00
  5197d0fa9e
• Add statistics display for MemoryCachingComponents

  Never sure if these are working as they should (or how well they are
  working). This helps quite a bit.

  Dean Herbert · 2022-07-06 18:38:40 +09:00
  a1b6ec60c8
• Add note regarding why the realmRetrievalLock return is done on the async thread
  Dean Herbert · 2022-07-05 16:23:10 +09:00
  33db508301
• Ensure blocking restoration only completes after update callback work is completed
  Dean Herbert · 2022-07-05 14:39:14 +09:00
  5adec2c738
• Rename realm ThreadLocal to better convey what it's doing

  Every time I looked at this code I have to re-learn what it's doing.
  Changing these variable names should help quite a bit.

  Dean Herbert · 2022-07-05 13:38:25 +09:00
  1b98936328
• Fix realm backup creation failing when run from RealmAccess constructor

  At the point of construction, we are not on the update thread, but it
  doesn't really matter at this point because there's no other usages.

  Dean Herbert · 2022-07-04 16:45:23 +09:00
  506409a9c4
• Count time spent upwards to display attempts correctly
  Salman Ahmed · 2022-07-02 10:46:52 +03:00
  e28ee8bc7a
• Fix clashing error messaging during realm block operations
  Dean Herbert · 2022-07-02 16:30:04 +09:00
  93809a92d4
• Add more verbose logging to realm blocking process
  Dean Herbert · 2022-07-02 12:36:56 +09:00
  4fd47b5fa0
• Merge pull request #18835 from peppy/beatmap-update-flow

  Split out beatmap update tasks to `BeatmapUpdater` and invoke from editor save flow

  Dan Balasescu · 2022-07-01 20:28:04 +09:00
  3b1842a2c2
• Merge branch 'master' into realm-fix-async-write-after-disposal
  Dean Herbert · 2022-06-30 19:07:15 +09:00
  447b496eff
• Add xmldoc and update parameter naming for MemoryCachingComponent.Invalidate flow
  Dean Herbert · 2022-06-30 17:17:06 +09:00
  2a73210865
• Merge branch 'master' into beatmap-update-flow
  Dean Herbert · 2022-06-30 16:44:17 +09:00
  98938821e5
• Fix PerformWrite not rolling back transaction on exception
  Dean Herbert · 2022-06-30 15:15:09 +09:00
  78d86fd3ff
• Add one more lock to appease CI
  Dean Herbert · 2022-06-29 22:45:19 +09:00
  7cb4e32c17
• Merge branch 'master' into realm-fix-async-write-after-disposal
  Dean Herbert · 2022-06-29 22:39:05 +09:00
  a3b4a515fc
• Add back thread safety and locking as required
  Dean Herbert · 2022-06-29 20:56:01 +09:00
  32af4e41ea
• Fix one more case of collection modification during enumeration

  https://sentry.ppy.sh/share/issue/a61c27b2a63a4a6aa80e75873f9d87ca/

  Dean Herbert · 2022-06-29 02:28:23 +09:00
  ecdb30d215
• Remove probably redundant realmLock

  As far as I can tell all accesses are safe due to update thread
  guarantees. The only weird one may be async writes during a
  `BlockAllOperations`, but the `Compact` loop should handle this quite
  amicably.

  Dean Herbert · 2022-06-28 16:55:54 +09:00
  e10ac45fd7
• Merge pull request #18862 from peppy/empty-beatmap-file-fix-2

  Fix second case of empty beatmaps being reported to sentry as errors

  Dan Balasescu · 2022-06-27 20:37:57 +09:00
  396e7fc166
• Merge pull request #18864 from peppy/fix-realm-audio-track-test-fail

  Centralise and harden editor-ready-for-use check

  Dean Herbert · 2022-06-27 19:42:49 +09:00
  f355c3a3c9
• Throw immediately if attempting to WriteAsync after disposed
  Dean Herbert · 2022-06-27 19:34:28 +09:00
  83982d258d
• Ensure all async writes are completed before realm is disposed
  Dean Herbert · 2022-06-27 19:21:05 +09:00
  c39c99bd43