Dean Herbert
55b80f70f6
Change "playfield" skin layer to respect shifting playfield border in osu! ruleset
2024-06-28 18:12:20 +09:00
Dean Herbert
4bb8a45d75
Merge pull request #28636 from bdach/daily-challenge/watch-room
...
Add client/server models for allowing clients to receive realtime playlist updates
2024-06-28 17:51:40 +09:00
Salman Ahmed
f462aa59df
Add test coverage for the issues that were pointed out recently
2024-06-28 11:23:52 +03:00
Bartłomiej Dach
007bd3973a
Merge pull request #28653 from peppy/featured-artist-even-more-visible
...
Update beatmap listing filter overlay to better imply selected filters
2024-06-28 09:50:21 +02:00
Bartłomiej Dach
a3ea36d2b2
Fix formatting
2024-06-28 09:45:45 +02:00
Bartłomiej Dach
7ac5bd4d37
Ensure past drawable objects also get their results populated in editor test play
2024-06-28 09:37:10 +02:00
Bartłomiej Dach
ace6427d40
Expand test coverage
...
- Covers fail case that wasn't covered before
- Removes arbitrary wait step that was inevitably going to cause
intermittent test failures
2024-06-28 09:30:28 +02:00
Bartłomiej Dach
b36e0f0875
Merge branch 'master' into fix/editor-test-exit
2024-06-28 09:17:40 +02:00
Bartłomiej Dach
030bbf2641
Fix vertical overlaps on multiselection filters when they wrap
2024-06-28 09:07:29 +02:00
Dean Herbert
04c09b5027
Merge pull request #28652 from smoogipoo/fix-dangerous-button-lowpass
...
Fix low pass filter sometimes not applied in dialog overlays
2024-06-28 16:05:35 +09:00
Dean Herbert
fa1527f446
Update design for selected filters to better imply that they are selected
2024-06-28 15:45:09 +09:00
Dan Balasescu
77b00dac7e
Fix low pass filter sometimes not applied in dialog overlays
2024-06-28 15:20:55 +09:00
Dean Herbert
c1bec7a7c3
Simplify colour logic for beatmap overlay filter rows
2024-06-28 14:55:55 +09:00
Salman Ahmed
86b8357b8b
Improve UX & input handling when customisation panel is open
2024-06-28 08:53:31 +03:00
Dan Balasescu
1668048fb7
Merge pull request #28650 from peppy/mod-preset-tooltip-improvements
...
Show mod preset description text in tooltip popup
2024-06-28 14:07:06 +09:00
Dean Herbert
d370f50cc1
Syncrhronise colours across mod and preset tooltips
2024-06-28 13:16:54 +09:00
Dean Herbert
28d5278935
Show preset description text in tooltip popup
...
As proposed in https://github.com/ppy/osu/discussions/28610 .
2024-06-28 13:16:53 +09:00
Dan Balasescu
17151e81ee
Merge pull request #28500 from Givikap120/pp_counter_fix
...
Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject"
2024-06-28 13:12:45 +09:00
Dan Balasescu
3b3f914cd2
Merge branch 'master' into pp_counter_fix
2024-06-28 12:40:56 +09:00
Salman Ahmed
167ffac218
Reorder container layout for popovers to recognize clicks on customisation panel
...
Basically moves `PopoverContainer` to cover both the columns and the customisation panel, so that if the customisation panel is clicked on, the popover container will notice that and hide popovers like the mod preset popover.
2024-06-28 06:35:21 +03:00
Dean Herbert
8598e8bf34
Merge pull request #28640 from bdach/osu-inspector-distance
...
Show distance in pixels to previous/next object in osu! hitobject inspector
2024-06-28 00:44:31 +09:00
Dean Herbert
fd6b77ea92
Fix distance snap control being removed
2024-06-27 23:59:38 +09:00
Dean Herbert
b293eb7930
Remove redundant array spec
2024-06-27 22:19:06 +09:00
Bartłomiej Dach
1b741dada3
Show distance in pixels to previous/next object in osu! hitobject inspector
2024-06-27 14:46:57 +02:00
Bartłomiej Dach
e35744118c
Merge pull request #28638 from OliBomby/beat-divisor
...
Fix editor not loading arbitrary beat divisors
2024-06-27 13:31:44 +02:00
Bartłomiej Dach
772a68cb3e
Add test coverage for correct beat divisor save
2024-06-27 12:38:29 +02:00
OliBomby
29412bb29b
Fix editor setting arbitrary beat divisor
2024-06-27 12:22:00 +02:00
Bartłomiej Dach
d6e7781be1
Add client/server models for allowing clients to receive realtime playlist updates
2024-06-27 11:32:18 +02:00
Dean Herbert
76a1f19233
Merge pull request #28613 from bdach/control-point-table-is-bad
...
Improve performance of editor tables
2024-06-27 18:22:56 +09:00
Bartłomiej Dach
9e07c8fff7
Update framework again
2024-06-27 10:31:26 +02:00
Dean Herbert
00d66ad561
Merge pull request #28634 from smoogipoo/traceable-increased-visibility
...
Support increased visibility for first object with traceable mod
2024-06-27 16:50:00 +09:00
Bartłomiej Dach
9384cbcdd8
Fix scroll-into-view on control point table not working as it is supposed to
2024-06-27 09:46:35 +02:00
Bartłomiej Dach
a5aedded16
Remove commented code
2024-06-27 09:44:55 +02:00
Dan Balasescu
779d2e8172
Support increased visibility for first object with traceable mod
2024-06-27 16:00:22 +09:00
Dean Herbert
f07a635447
Merge pull request #28630 from peppy/fix-long-note-break-woes
2024-06-27 15:50:25 +09:00
Bartłomiej Dach
b1baa49459
Add note about implicit reliance on sort by start time
2024-06-27 07:56:57 +02:00
Bartłomiej Dach
ef952bcd65
Use GetLastObjectTime() for safety
...
Due to other circumstances this has no real effect, but may as well.
2024-06-27 07:48:06 +02:00
Bartłomiej Dach
981340debe
Add safety test coverage for removal of breaks at end of beatmap
2024-06-27 07:45:59 +02:00
Dan Balasescu
e6a5131b67
Merge pull request #28632 from frenzibyte/fix-dropdown-enter-key
...
Fix osu! dropdown no longer handling `Enter` key to select items
2024-06-27 14:36:24 +09:00
Dean Herbert
8f9b2106d6
Merge pull request #28620 from normalid-awa/ui/mod-select-color-improvement
...
Optimize Text Color For Mod Multiplier Text
2024-06-27 13:56:12 +09:00
Salman Ahmed
811621325f
Fix osu! dropdown search text box having commits disabled
...
I've also removed inheritance from `SearchTextBox` because it contains
logic that might interfere with the internal implementation of dropdown
search bars (focus logic and stuff).
2024-06-27 07:09:46 +03:00
Salman Ahmed
e4335a543e
Add failing test case
...
Includes a refactor of `ThemeComparisonTestScene` to allow accessing a manual input manager.
2024-06-27 06:41:44 +03:00
Dean Herbert
7ef7e5f163
Fix break generation not accounting for concurrent hitobjects correctly
2024-06-27 12:10:26 +09:00
Dean Herbert
bbacfc8d23
Add failing test coverage of osu!mania automated break creation scenarios
2024-06-27 12:10:10 +09:00
Dean Herbert
ec86cc1333
Merge pull request #28608 from bdach/daily-challenge/carousel
...
Implement carousel container for daily challenge screen
2024-06-27 10:45:23 +09:00
Dean Herbert
1a606ae7e5
Merge pull request #28621 from bdach/fix-hitmarker-performance-again
...
Fix editor performance regression with hitmarkers active
2024-06-27 01:16:17 +09:00
Bartłomiej Dach
847946937e
Fix test failures
2024-06-26 16:56:43 +02:00
Bartłomiej Dach
b339d6a00c
Fix editor performance regression with hitmarkers active
2024-06-26 16:26:32 +02:00
Dean Herbert
1998742e42
Update framework
2024-06-26 22:56:43 +09:00
Bartłomiej Dach
fff27e619d
Fix slider tail volume not saving
...
Closes https://github.com/ppy/osu/issues/28587 .
As outlined in the issue thread, the tail volume wasn't saving because
it wasn't actually attached to a hitobject properly, and as such the
`LegacyBeatmapEncoder` logic, which is based on hitobjects, did not
pick them up on save.
To fix that, switch to using `NodeSamples` for objects that are
`IHasRepeats`. That has one added complication in that having it work
properly requires changes to the decode side too. That is because the
intent is to allow the user to change the sample settings for each node
(which are specified via `NodeSamples`), as well as "the rest of the
object", which generally means ticks or auxiliary samples like
`sliderslide` (which are specified by `Samples`).
However, up until now, `Samples` always queried the control point
which was _active at the end time of the slider_. This obviously can't
work anymore when converting `NodeSamples` to legacy control points,
because the last node's sample is _also_ at the end time of the slider.
To bypass that, add extra sample points after each node (just out of
reach of the 5ms leniency), which are supposed to control volume of
ticks and/or slides.
Upon testing, this *sort of* has the intended effect in stable, with
the exception of `sliderslide`, which seems to either respect or _not_
respect the relevant volume spec dependent on... not sure what, and not
sure I want to be debugging that. It might be frame alignment, or it
might be the phase of the moon.
2024-06-26 15:52:16 +02:00
