osu-lazer

Remove Task from the inner-most Import method in RealmArchiveModelImporter

One of my pending work items for post-realm merge.

The lowest-level import task is no longer asynchronous, as we don't want
it to span multiple threads to allow easier interaction with realm.
Removing the `Task` spec simplifies a heap of usages.

Individual usages should decide whether they want to run the import
asynchronously, by either using an alternative override or spooling up a
thread themselves.

Dean Herbert · 2022-01-25 15:30:29 +09:00

778d2a71b4

Merge pull request #16591 from peppy/fix-editor-slider-velocity-saving

Don't include nested hit objects' `DifficultyControlPoints` in legacy encoder logic

Dan Balasescu · 2022-01-25 14:50:09 +09:00

05a2d7fbfe

Update remaining cases of clashing variable name in realm.Run(realm..

Dean Herbert · 2022-01-25 13:04:05 +09:00

e23b10e6a5

Fix cases of Access instead of Realm

Dean Herbert · 2022-01-25 12:58:15 +09:00

3e5c9e8436

Rename RealmContextFactory to RealmAccess

Dean Herbert · 2022-01-24 20:38:07 +09:00

6eb2c28e41

Don't include nested hit objects' DifficultyControLPoints in legacy encoder logic

The editor doesn't currently propagate velocity to nested objects. We're
not yet sure whether it should or not. For now, let's just ignore nested
objects' `DifficultyControlPoints` for simplicity.

Note that this only affects osu! ruleset due to the pre-check on
`isOsuRuleset`.

Dean Herbert · 2022-01-24 19:54:08 +09:00

c3758047fd

Merge branch 'master' into custom-meter

Dean Herbert · 2022-01-24 15:46:44 +09:00

d7db6fa918

Fix saved beatmap filename depending on ToString() implementation

Bartłomiej Dach · 2022-01-23 20:28:30 +01:00

838a9f69ed

Initialise Simple{Triple,Quadruple} only once ever rather than create every time

Bartłomiej Dach · 2022-01-23 15:21:25 +01:00

4e5a1f27a8

Replace TimeSignatures enum with struct for storage of arbitrary meter

Bartłomiej Dach · 2022-01-22 20:50:31 +01:00

735414bc49

Add forced refresh on GetAllUsableBeatmapSets()

This is commonly used in tests in a way where it's not feasible to
guarantee correct results unless a refresh is called. This method
shouldn't really be used outside of tests anyway, but that's for a
folow-up effort.

Dean Herbert · 2022-01-21 17:33:29 +09:00

495636538f

Update all usages of CreateContext to use either Run or Write

Dean Herbert · 2022-01-21 17:27:08 +09:00

114c9e8c1f

Fix various cases of creating realm contexts from update thread when not necessary

Dean Herbert · 2022-01-21 01:44:56 +09:00

a5d2047f05

Avoid constructor overhead for realm BeatmapMetadata parameterless constructor

Dean Herbert · 2022-01-20 17:14:51 +09:00

6c10531df2

Fix some regressions in json output (we need to make all these explicit instead)

Dean Herbert · 2022-01-20 17:09:31 +09:00

deb108816c

Avoid constructor overhead for realm BeatmapSetInfo parameterless constructor

Dean Herbert · 2022-01-20 17:03:44 +09:00

ccddf9b47d

Avoid constructor overhead for realm BeatmapInfo parameterless constructor

Dean Herbert · 2022-01-20 16:47:27 +09:00

3faf980fed

Fix expanded content scrollbar inadvertently hiding expanded content

Bartłomiej Dach · 2022-01-19 22:30:49 +01:00

247c557eaf

Show scrollbar on expanded card content where applicable

Bartłomiej Dach · 2022-01-19 22:21:08 +01:00

77748a5f93

Merge pull request #16505 from peppy/remove-base-difficulty-usage

Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)

Dan Balasescu · 2022-01-19 13:53:55 +09:00

3e5d29ed00

Merge branch 'master' into optimise-set-detach-part-2

Dan Balasescu · 2022-01-19 13:20:38 +09:00

2556f1cb87

Add back BaseDifficulty with obsoletion counter to account for custom rulesets

Dean Herbert · 2022-01-19 12:33:56 +09:00

2363130f8b

Avoid file retrieval overhead when detaching BeatmapSetInfo

It seems that no usages of `BeatmapSetInfo` detaches require files - a
`WorkingBeatmap` is always obtained before doing further lookups.

Therefore we can omit this include unless the detaching object is a
`BeatmapInfo`. A refetch is performed when retrieving a
`WorkingBeatmap` to complete the equation.

Dean Herbert · 2022-01-19 00:49:18 +09:00

60b80c88b6

Remove all usage of AuthorString

Dean Herbert · 2022-01-18 23:30:40 +09:00

67bf95bc91

Add some missing IgnoredAttributes to reduce automapper overhead

Dean Herbert · 2022-01-18 23:25:30 +09:00

3596c6ed5d

Remove all usage of BaseDifficulty (and access Difficulty instead)

Dean Herbert · 2022-01-18 22:57:39 +09:00

7f65f3a47f

Update automapper spec in line with v11

See https://docs.automapper.org/en/latest/11.0-Upgrade-Guide.html for
 more details.

Dean Herbert · 2022-01-18 15:23:28 +09:00

9a43ed742b

Give the placeholder ruleset better defaults to allow tests to work again

Dean Herbert · 2022-01-17 14:40:00 +09:00

381174e482

Initialise all parameters is paramaterless constructor for now for added safety

Dean Herbert · 2022-01-17 13:51:30 +09:00

744084b418

Fix GetDisplayTitleRomanisable() relying on ToString() implementation

Bartłomiej Dach · 2022-01-15 15:26:41 +01:00

e75d21507c

Return immediately on failed web request in synchronous BeatmapOnlineLookupQueue flow

Dean Herbert · 2022-01-14 13:20:51 +09:00

dea2e1fac0

Remove unused cancellationToken parameter in synchronous BeatmapOnlineLookupQueue flow

Dean Herbert · 2022-01-14 13:19:00 +09:00

8424d86e9a

Ensure detached when performing model Clone operations on BeatmapInfo/ScoreInfo

Dean Herbert · 2022-01-14 13:08:20 +09:00

9b33fbbee5

Add EF to realm beatmap migration

Dean Herbert · 2022-01-13 18:23:18 +09:00

b610d2db12

Remove pointless compatibility parameter BeatmapSetInfoID

Dean Herbert · 2022-01-13 18:02:10 +09:00

069d6d2954

Add synchronous fetch flow to BeatmapOnlineLookupQueue

The async flow doesn't work great with the realm import process. We
might be able to improve on this going forward, but for the time being
adding a synchronous path seems safest.

After all, we are already an an asynchronous (dedicated) thread pool at
this point.

Dean Herbert · 2022-01-13 16:36:54 +09:00

93c78253d6

Use ctor rather than MemberwiseClone to guarantee a safer clone of BeatmapDifficulty

Dean Herbert · 2022-01-13 13:23:41 +09:00

b77cb344d5

Remove unnecessary Ruleset null check in BeatmapDifficultyCache

Dean Herbert · 2022-01-13 13:19:49 +09:00

86b2ac3217

Replace compatibility properties with direct references

Dean Herbert · 2022-01-12 18:13:14 +09:00

eb70a1eeb7

Sanitise and remove some usages of Detach which are no longer required