67628 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Dean Herbert	bca4d51e5a	Merge pull request #28590 from peppy/update-framework ... Update framework	2024-06-25 23:34:30 +09:00
Dean Herbert	0a44022697	Update framework	2024-06-25 23:03:37 +09:00
Dean Herbert	6cd1367329	Merge pull request #28580 from bdach/fix-breaks ... Fix crash when attempting to adjust duration of break that has no preceding/succeeding objects	2024-06-25 20:24:27 +09:00
Dean Herbert	a12f32519d	Merge pull request #28572 from bdach/fix-playlist-duration-death ... Fix crash on calculating playlist duration when rate-changing mods are present	2024-06-25 20:15:26 +09:00
Dean Herbert	2c4809cc01	Merge pull request #28576 from PercyDan54/rank-update ... Fix silver S rank display animating on every hit	2024-06-25 20:02:51 +09:00
Bartłomiej Dach	fae6dcfffa	Remove manual breaks at the start/end of beatmap ... This is the secondary cause of https://github.com/ppy/osu/issues/28577, because you could do the following: - Have a break autogenerate itself - Adjust either end of it to make it mark itself as manually-adjusted - Remove all objects before or after said break to end up in a state wherein there are no objects before or after a break. The direct fix is still correct because it is still technically possible to end up in a state wherein a break is before or after all objects (obvious one is manual `.osu` editing), but this behaviour is also undesirable for the autogeneration logic.	2024-06-25 12:49:17 +02:00
Bartłomiej Dach	18e2a925a8	Add failing test coverage for manual breaks at start/end of map not being culled	2024-06-25 12:34:37 +02:00
Bartłomiej Dach	03cdfd0660	Fix timeline break piece crashing on drag if there are no objects before start or after end ... This fixes the direct cause of https://github.com/ppy/osu/issues/28577.	2024-06-25 12:25:37 +02:00
Dean Herbert	c5c30949d2	Merge pull request #28570 from bdach/fix-upscroll ... Fix legacy skin hold note bodies not appearing when scrolling upwards	2024-06-25 19:08:23 +09:00
PercyDan54	2de0852551	Fix transient rank value applied to bindable	2024-06-25 18:06:50 +08:00
Dean Herbert	a042b6e141	Merge pull request #28568 from bdach/fix-classic-slider-drawable-judgement-position ... Fix incorrect slider judgement positions when classic mod is active	2024-06-25 19:04:05 +09:00
Bartłomiej Dach	0d2a47167c	Fix crash on calculating playlist duration when rate-changing mods are present ... Regressed in https://github.com/ppy/osu/pull/28399. To reproduce, enter a playlist that has an item with a rate-changing mod (rather than create it yourself). This is happening because `APIRuleset` has `CreateInstance()` unimplemented: b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159) and only triggers when the playlist items in question originate from web. This is why it is bad to have interface implementations throw outside of maybe mock implementations for tests. `CreateInstance()` is a scourge elsewhere in general, we need way less of it in the codebase (because while convenient, it's also problematic to implement in online contexts, and also expensive because reflection).	2024-06-25 11:28:10 +02:00
Bartłomiej Dach	1eac0c622a	Fix legacy skin hold note bodies not appearing when scrolling upwards ... - Closes https://github.com/ppy/osu/issues/28567. - Regressed in https://github.com/ppy/osu/pull/28466. Bit of a facepalm moment innit...	2024-06-25 10:35:36 +02:00
Bartłomiej Dach	2cb18820ea	Fix incorrect slider judgement positions when classic mod is active ... Regressed in https://github.com/ppy/osu/pull/27977. Bit ad-hoc but don't see how to fix without just reverting the change.	2024-06-25 10:07:58 +02:00
Dean Herbert	b4cefe0cc2	Update rider vcsConfiguration ... Updated in recent rider versions	2024-06-25 15:50:11 +09:00
Dan Balasescu	442705bc0c	Merge pull request #28559 from peppy/fix-key-binding-corruption ... Fix scale control key binding breaking previous defaults	2024-06-24 11:46:43 +09:00
Salman Ahmed	7cbd04db9c	Merge branch 'master' into fix-key-binding-corruption	2024-06-24 05:30:21 +03:00
Dean Herbert	1dc9f10235	Fix scale control key binding breaking previous defaults ... Oops from ppy/osu#28309.	2024-06-24 09:46:23 +08:00
Dean Herbert	3bf742bda2	Merge pull request #28537 from bdach/hit-animations ... Adjust behaviour of hit animations toggle to match user expectations	2024-06-23 11:58:04 +09:00
Dean Herbert	c58bb62408	Merge branch 'master' into hit-animations	2024-06-23 04:32:47 +09:00
Dean Herbert	df43a1c6cc	Add note about every-frame-transforms	2024-06-23 03:31:40 +08:00
Dean Herbert	80907acaa6	Update resources	2024-06-22 22:01:05 +08:00
Bartłomiej Dach	8bbbedaec3	Merge pull request #28540 from ssz7-ch2/fix-typo ... Fix typo in ScoreProcessor	2024-06-21 08:32:01 +02:00
sometimes	89d3f67eb3	fix accuracyProcess typo	2024-06-20 22:06:00 -04:00
Bartłomiej Dach	ad2cd0ba8f	Adjust behaviour of hit animations toggle to match user expectations	2024-06-20 13:42:32 +02:00
Dean Herbert	cd4dce2c7e	Merge pull request #28478 from bdach/timeline-drag-selection-crash ... Fix crash on drag selection via timeline while placement is active	2024-06-20 19:00:45 +09:00
Dean Herbert	14104e57d4	Merge branch 'master' into timeline-drag-selection-crash	2024-06-20 15:16:10 +09:00
Dean Herbert	0eb533f2fd	Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads ... Reload scrolling hitobject composer on control point changes	2024-06-20 15:15:26 +09:00
Dean Herbert	9eb6752033	Merge pull request #28528 from bdach/break-autogeneration	2024-06-19 23:46:05 +09:00
Dean Herbert	a718af8af5	Adjust break colours to match closer to stable	2024-06-19 22:02:10 +08:00
Bartłomiej Dach	617c1341d7	Make (Manual)BreakPeriod a class again ... CodeFileSanity doesn't like records and it being a record wasn't doing much anymore anyway.	2024-06-19 14:53:09 +02:00
Dean Herbert	00443403b6	Merge branch 'master' into break-autogeneration	2024-06-19 21:49:17 +09:00
Dean Herbert	32a7885f10	Merge pull request #28523 from bdach/break-display-and-adjustment ... Display breaks on editor timeline & allow manually adjusting their duration	2024-06-19 21:48:54 +09:00
Dean Herbert	00a866b699	Change colour to match bottom timeline (and adjust tween sligthly)	2024-06-19 20:30:43 +08:00
Bartłomiej Dach	8757e08c2c	Fix test failures due to automatic break generation kicking in	2024-06-19 11:32:08 +02:00
Bartłomiej Dach	2d9c3fbed2	Remove no-longer-necessary null propagation	2024-06-19 11:21:57 +02:00
Bartłomiej Dach	4390798761	Add test coverage for automatic break generation	2024-06-19 11:14:38 +02:00
Bartłomiej Dach	7311a7ffd7	Purge manual breaks if they intersect with an actual hitobject	2024-06-19 10:51:37 +02:00
Bartłomiej Dach	7ed587b783	Fix summary timeline not reloading properly on break addition/removal	2024-06-19 10:26:01 +02:00
Bartłomiej Dach	58701b17f8	Add patcher support for breaks	2024-06-19 10:22:14 +02:00
Bartłomiej Dach	4022a8b06c	Implement automatic break period generation	2024-06-19 10:22:06 +02:00
Bartłomiej Dach	1f692f5fc7	Make BreakPeriod a struct	2024-06-19 09:01:33 +02:00
Bartłomiej Dach	6a6ccbc09f	Make list of breaks bindable	2024-06-19 07:44:03 +02:00
Dan Balasescu	1933c14bee	Merge pull request #28518 from bdach/update-framework ... Update framework	2024-06-18 23:44:42 +09:00
Bartłomiej Dach	f88f05717a	Fix bottom timeline break visualisations not updating	2024-06-18 15:54:34 +02:00
Bartłomiej Dach	814f1e552f	Implement ability to manually adjust breaks	2024-06-18 15:51:29 +02:00
Bartłomiej Dach	a9e662a2b6	Add break display to editor timeline	2024-06-18 14:55:59 +02:00
Dean Herbert	e6187ebec0	Fix nullability insepction	2024-06-18 15:13:52 +08:00
Bartłomiej Dach	366ba26cb6	Adjust calls to DrawableExtensions.With<T>()	2024-06-18 07:41:20 +02:00
Bartłomiej Dach	659505f711	Adjust calls to GetContainingInputManager()	2024-06-18 07:41:19 +02:00