68221 Commits

This Branch

This Branch

All Branches

• Make event feed test show more realistic content automatically
  Dean Herbert · 2024-07-25 14:31:21 +09:00
  bba151a776
• Merge pull request #29054 from peppy/fix-leaderboard-refreshing

  Fix excessive leaderboard refreshes in daily challenge screen

  Bartłomiej Dach · 2024-07-25 07:15:17 +02:00
  ccef98d24e
• Debounce leaderboard refetches to stop excessive operations after returning from gameplay
  Dean Herbert · 2024-07-25 12:58:35 +09:00
  aac98ab6b2
• Avoid reloading the daily challenge leaderboard when already requested
  Dean Herbert · 2024-07-25 12:55:45 +09:00
  9ec687caab
• Merge pull request #29047 from RealCyGuy/good-first-issues

  Fix link to good first issues in CONTRIBUTING.md

  Dan Balasescu · 2024-07-25 10:38:23 +09:00
  c5814e0869
• fix link to good first issues
  Cyrus Yip · 2024-07-24 18:24:52 -07:00
  d63335082e
• Merge pull request #29046 from peppy/disable-macos-runs

  Disable macOS test runs for now

  Dan Balasescu · 2024-07-25 09:49:00 +09:00
  3dd7db5499
• Disable macOS test runs for now

  We are seeing update frames run as little as [once per
  second](https://github.com/ppy/osu/blob/aa4d16bdb873d7296b899cee7b7491ffdf5cd6ab/osu.Game/Overlays/BeatmapListingOverlay.cs#L141).
  Until we can ascertain why this is happening, let's reduce developer
  stress by not running macOS tests for now.

  Dean Herbert · 2024-07-25 09:05:58 +09:00
  4cc07badbd
• Merge pull request #29044 from frenzibyte/fix-drag-overwritten-by-focus

  Fix dragging number boxes no longer working correctly

  Dan Balasescu · 2024-07-25 08:36:39 +09:00
  d057bee4fb
• Add lenience to avoid floating point errors
  Salman Ahmed · 2024-07-24 23:26:23 +03:00
  b3e3bf7cec
• Fix dragging number boxes overwritten by select-all-on-focus feature
  Salman Ahmed · 2024-07-24 23:19:04 +03:00
  6645dac71d
• Merge pull request #29039 from bdach/multiple-selection-sample-popover

  Make sample popover change properties of all samples in multiple selection

  Dean Herbert · 2024-07-24 22:49:20 +09:00
  2024.725.0 4983e5f33e
• Make sample popover change properties of all samples in multiple selection

  Closes https://github.com/ppy/osu/issues/28916.
  
  The previous behaviour *may* have been intended, but it was honestly
  quite baffling. This seems like a saner variant.

  Bartłomiej Dach · 2024-07-24 12:15:12 +02:00
  1ed7e4b075
• Add test coverage for expected sample popover behaviour
  Bartłomiej Dach · 2024-07-24 12:08:13 +02:00
  55382a4ba6
• Merge pull request #29036 from bdach/hardcode-positions-for-leaderboard

  Fill daily challenge top 50 position numbers client-side

  Dean Herbert · 2024-07-24 17:49:51 +09:00
  6e4625609d
• Merge pull request #29037 from bdach/daily-challenge-exit-when-offline

  Exit daily challenge screen when going offline

  Dean Herbert · 2024-07-24 17:48:07 +09:00
  65fcef1929
• Exit daily challenge screen when going offline

  This sort of thing is bound to happen when rewriting screens from
  scratch without invoking abstract eldritch entities sometimes. Damned if
  you do, damned if you don't...

  Bartłomiej Dach · 2024-07-24 09:15:32 +02:00
  788b70469d
• Fill daily challenge top 50 position numbers client-side

  Only doing this client-side, because doing this server-side is
  expensive:
  
  	https://github.com/ppy/osu-web/pull/11354#discussion_r1689224285

  Bartłomiej Dach · 2024-07-24 08:57:11 +02:00
  bf4bf4d39e
• Merge pull request #29021 from bdach/editor-breaks-respect-time-preempt

  Respect pre-empt time when auto-generating breaks

  Dean Herbert · 2024-07-24 15:21:12 +09:00
  aded31bd07
• Merge pull request #29020 from bdach/drag-selection-tolerance

  Add tolerance when drag-scrolling editor timeline

  Dean Herbert · 2024-07-23 22:28:29 +09:00
  a9ccb50b98
• Change order of application to avoid bias to side with more room to drag

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2024-07-23 20:56:21 +09:00
  aed7ba9508
• Fix autogenerated breaks not invalidating on change to pre-empt time
  Bartłomiej Dach · 2024-07-23 13:38:50 +02:00
  c3062f96ee
• Add test coverage for break generation respecting pre-empt time
  Bartłomiej Dach · 2024-07-23 13:38:25 +02:00
  c2fa30bf81
• Respect pre-empt time when auto-generating breaks

  Closes https://github.com/ppy/osu/issues/28703.

  Bartłomiej Dach · 2024-07-23 13:30:13 +02:00
  088e8ad0a2
• Move editor beatmap processor test cases off of OsuHitObjects

  Most of them are about to become obsolete once consideration for
  `TimePreempt` is re-added.

  Bartłomiej Dach · 2024-07-23 13:28:49 +02:00
  25d63ac6a5
• Merge pull request #29019 from bdach/catch-juice-stream-editing-weirdness-continued

  Fix duration fluctuations and one-frame jitters when editing juice streams

  Dean Herbert · 2024-07-23 19:02:30 +09:00
  40b171f544
• Use non-screen-space coordinates and add time-based drag ramping for better control
  Dean Herbert · 2024-07-23 18:59:22 +09:00
  cc4ed0ff3f
• Add tolerance when drag-scrolling editor timeline

  Closes https://github.com/ppy/osu/issues/28983.
  
  While the direct cause of this is most likely mouse confine in
  full-screen, it shouldn't/can't really be disabled just for this,
  and I also get this on linux in *windowed* mode.
  
  In checking other apps, adding some tolerance to this sort of
  drag-scroll behaviour seems like a sane UX improvement anyways.

  Bartłomiej Dach · 2024-07-23 11:10:18 +02:00
  38fc6f70f6
• Merge branch 'master' into catch-juice-stream-editing-weirdness-continued
  Dean Herbert · 2024-07-23 17:05:40 +09:00
  aba05a21aa
• Merge pull request #28999 from bdach/catch-juice-stream-editing-weirdness

  Fix various shortcomings in juice stream selection blueprint

  Dean Herbert · 2024-07-23 16:43:39 +09:00
  5911c42116
• Fix tests
  Bartłomiej Dach · 2024-07-23 09:13:43 +02:00
  6100f5269d
• Fix editing juice stream path sometimes changing its duration

  I'm not *super* sure why this works, but it appears to, and my educated
  guess as to why is that it counteracts the effects of a change in the SV
  of the juice stream by artificially increasing or decreasing the
  velocity when running the appropriate path conversions and expected
  distance calculations. The actual SV change takes effect on the next
  default application, which is triggered by the `Update()` call at the
  end of the method.

  Bartłomiej Dach · 2024-07-22 15:14:45 +02:00
  f3617eadad
• Fix EditablePath.UpdateHitObjectFromPath() not automatically updating object

  This is important because the editable path conversions heavily depend
  on the value of `JuiceStream.Velocity` being correct. The value is only
  guaranteed to be correct after an `ApplyDefaults()` call, which is
  triggered by updating the object via `EditorBeatmap`.

  Bartłomiej Dach · 2024-07-22 14:50:25 +02:00
  56af009e77
• Fix tests
  Bartłomiej Dach · 2024-07-22 13:37:24 +02:00
  1d91201c43
• Unify juice stream piece UX with osu! control point pieces

  - Use same hover state
  - Use shift-right click for quick delete rather than shift-left click

  Bartłomiej Dach · 2024-07-22 13:30:15 +02:00
  6b3c1f4e47
• Fix catch juice stream vertex remove operation not undoing
  Bartłomiej Dach · 2024-07-22 13:21:49 +02:00
  47964f33d7
• Fix catch juice stream vertex add operation not undoing
  Bartłomiej Dach · 2024-07-22 12:18:53 +02:00
  64381d4087
• Merge pull request #28996 from bdach/fix-dim-again

  Fix editor UI dimming when hovering over expanded part of toolboxes

  Dean Herbert · 2024-07-22 19:11:31 +09:00
  7e5fda4539
• Fix editor UI dimming when hovering over expanded part of toolboxes

  Closes https://github.com/ppy/osu/issues/28969.

  Bartłomiej Dach · 2024-07-22 11:57:46 +02:00
  57fa502786
• Merge pull request #28849 from frenzibyte/custom-profile-colour

  Add custom hue support to user profile overlay

  Bartłomiej Dach · 2024-07-22 09:41:32 +02:00
  dd8be62d07
• Merge pull request #28881 from smoogipoo/fix-judgement-cut

  Fix judgement animation getting cut early

  Bartłomiej Dach · 2024-07-22 09:24:57 +02:00
  088b8aff11
• Merge pull request #28954 from frenzibyte/fix-pause-input-handling

  Fix held gameplay keys stuck after pausing and resuming

  Dean Herbert · 2024-07-20 15:45:19 +09:00
  2024.718.1 15220f3bf4
• Merge branch 'master' into fix-pause-input-handling
  Dean Herbert · 2024-07-20 15:23:34 +09:00
  401c0fe2bf
• Merge pull request #28963 from peppy/update-framework

  Update framework

  Dean Herbert · 2024-07-20 15:23:21 +09:00
  88929a5636
• Update framework
  Dean Herbert · 2024-07-20 14:08:00 +09:00
  d914b990f3
• Add explanatory note
  Salman Ahmed · 2024-07-19 19:19:36 +03:00
  e539670df1
• Fix pause overlay hiding input from ruleset input manager

  If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.

  Salman Ahmed · 2024-07-19 18:48:35 +03:00
  818b60a3d8
• Schedule resume operation by one frame to ensure the triggered key down event does not cause a gameplay press
  Salman Ahmed · 2024-07-19 18:48:35 +03:00
  4f6c7fe7c3
• Add extensive test cases for correct input handling while paused in osu! & non-osu!
  Salman Ahmed · 2024-07-19 18:48:35 +03:00
  d7651ef387
• Merge pull request #28949 from peppy/hold-off-incompatibility

  Make "Hold Off" and "No Release" mod incompatible

  Bartłomiej Dach · 2024-07-19 14:36:45 +02:00
  2bd4a5e16b