1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-30 06:32:54 +08:00
Commit Graph

68732 Commits

Author SHA1 Message Date
normalid
dce894108a Remove unused blending mode 2024-07-23 20:50:08 +08:00
normalid
f7dc0b65da Clean up the code 2024-07-23 20:47:49 +08:00
normalid
5dcc8b7a8f Make the text are always horizontal 2024-07-23 19:56:43 +08:00
Dean Herbert
aed7ba9508
Change order of application to avoid bias to side with more room to drag
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-07-23 20:56:21 +09:00
normalid
777a0deb0f Update the offset formula 2024-07-23 19:45:53 +08:00
Bartłomiej Dach
c3062f96ee
Fix autogenerated breaks not invalidating on change to pre-empt time 2024-07-23 13:38:50 +02:00
Bartłomiej Dach
c2fa30bf81
Add test coverage for break generation respecting pre-empt time 2024-07-23 13:38:25 +02:00
Bartłomiej Dach
088e8ad0a2
Respect pre-empt time when auto-generating breaks
Closes https://github.com/ppy/osu/issues/28703.
2024-07-23 13:30:13 +02:00
Bartłomiej Dach
25d63ac6a5
Move editor beatmap processor test cases off of OsuHitObjects
Most of them are about to become obsolete once consideration for
`TimePreempt` is re-added.
2024-07-23 13:28:49 +02:00
normalid
ad1a86ebdc Implement the overlay 2024-07-23 19:05:14 +08:00
Dean Herbert
40b171f544
Merge pull request #29019 from bdach/catch-juice-stream-editing-weirdness-continued
Fix duration fluctuations and one-frame jitters when editing juice streams
2024-07-23 19:02:30 +09:00
Dean Herbert
cc4ed0ff3f
Use non-screen-space coordinates and add time-based drag ramping for better control 2024-07-23 18:59:22 +09:00
Bartłomiej Dach
38fc6f70f6
Add tolerance when drag-scrolling editor timeline
Closes https://github.com/ppy/osu/issues/28983.

While the direct cause of this is most likely mouse confine in
full-screen, it shouldn't/can't really be disabled just for this,
and I also get this on linux in *windowed* mode.

In checking other apps, adding some tolerance to this sort of
drag-scroll behaviour seems like a sane UX improvement anyways.
2024-07-23 11:10:18 +02:00
Dean Herbert
aba05a21aa
Merge branch 'master' into catch-juice-stream-editing-weirdness-continued 2024-07-23 17:05:40 +09:00
Dean Herbert
5911c42116
Merge pull request #28999 from bdach/catch-juice-stream-editing-weirdness
Fix various shortcomings in juice stream selection blueprint
2024-07-23 16:43:39 +09:00
Bartłomiej Dach
6100f5269d
Fix tests 2024-07-23 09:13:43 +02:00
Bartłomiej Dach
f3617eadad
Fix editing juice stream path sometimes changing its duration
I'm not *super* sure why this works, but it appears to, and my educated
guess as to why is that it counteracts the effects of a change in the SV
of the juice stream by artificially increasing or decreasing the
velocity when running the appropriate path conversions and expected
distance calculations. The actual SV change takes effect on the next
default application, which is triggered by the `Update()` call at the
end of the method.
2024-07-22 15:14:45 +02:00
Bartłomiej Dach
56af009e77
Fix EditablePath.UpdateHitObjectFromPath() not automatically updating object
This is important because the editable path conversions heavily depend
on the value of `JuiceStream.Velocity` being correct. The value is only
guaranteed to be correct after an `ApplyDefaults()` call, which is
triggered by updating the object via `EditorBeatmap`.
2024-07-22 14:50:25 +02:00
Bartłomiej Dach
f86ab1a64e
Fix filename 2024-07-22 13:49:52 +02:00
Bartłomiej Dach
1d91201c43
Fix tests 2024-07-22 13:37:24 +02:00
Bartłomiej Dach
6b3c1f4e47
Unify juice stream piece UX with osu! control point pieces
- Use same hover state
- Use shift-right click for quick delete rather than shift-left click
2024-07-22 13:30:15 +02:00
Bartłomiej Dach
47964f33d7
Fix catch juice stream vertex remove operation not undoing 2024-07-22 13:21:49 +02:00
Bartłomiej Dach
64381d4087
Fix catch juice stream vertex add operation not undoing 2024-07-22 12:18:53 +02:00
Dean Herbert
7e5fda4539
Merge pull request #28996 from bdach/fix-dim-again
Fix editor UI dimming when hovering over expanded part of toolboxes
2024-07-22 19:11:31 +09:00
Bartłomiej Dach
57fa502786
Fix editor UI dimming when hovering over expanded part of toolboxes
Closes https://github.com/ppy/osu/issues/28969.
2024-07-22 11:57:46 +02:00
Bartłomiej Dach
636e965868
Remove no-longer-valid test remark & adjust test 2024-07-22 11:29:39 +02:00
Bartłomiej Dach
157cc884f4
Fix swells not being correctly treated in editor gameplay test
Closes https://github.com/ppy/osu/issues/28989.

Because swell ticks are judged manually by their parenting objects,
swell ticks were not given a start time (with the thinking that there
isn't really one *to* give). This tripped up the "judge past objects"
logic in `EditorPlayer`, since it would enumerate all objects
(regardless of nesting) that are prior to current time and mark them as
judged. With all swell ticks having the default start time of 0 they
would get judged more often than not, leading to behaviour weirdness.

To resolve, give swell ticks a *relatively* sane start time equal to
the start time of the swell itself.
2024-07-22 11:27:56 +02:00
Bartłomiej Dach
e2fe1935a9
Add failing test case 2024-07-22 11:22:36 +02:00
Bartłomiej Dach
dd8be62d07
Merge pull request #28849 from frenzibyte/custom-profile-colour
Add custom hue support to user profile overlay
2024-07-22 09:41:32 +02:00
Bartłomiej Dach
088b8aff11
Merge pull request #28881 from smoogipoo/fix-judgement-cut
Fix judgement animation getting cut early
2024-07-22 09:24:57 +02:00
Dean Herbert
15220f3bf4
Merge pull request #28954 from frenzibyte/fix-pause-input-handling
Fix held gameplay keys stuck after pausing and resuming
2024-07-20 15:45:19 +09:00
Dean Herbert
401c0fe2bf
Merge branch 'master' into fix-pause-input-handling 2024-07-20 15:23:34 +09:00
Dean Herbert
88929a5636
Merge pull request #28963 from peppy/update-framework
Update framework
2024-07-20 15:23:21 +09:00
Dean Herbert
d914b990f3
Update framework 2024-07-20 14:08:00 +09:00
Salman Ahmed
e539670df1 Add explanatory note 2024-07-19 19:19:36 +03:00
Salman Ahmed
818b60a3d8 Fix pause overlay hiding input from ruleset input manager
If a key is pressed while the pause overlay is visible, the ruleset input manager will not see it, therefore if the user resumes while the key is held then releases the key, the ruleset input manager will not receive the key up event.
2024-07-19 18:48:35 +03:00
Salman Ahmed
4f6c7fe7c3 Schedule resume operation by one frame to ensure the triggered key down event does not cause a gameplay press 2024-07-19 18:48:35 +03:00
Salman Ahmed
d7651ef387 Add extensive test cases for correct input handling while paused in osu! & non-osu! 2024-07-19 18:48:35 +03:00
Bartłomiej Dach
2bd4a5e16b
Merge pull request #28949 from peppy/hold-off-incompatibility
Make "Hold Off" and "No Release" mod incompatible
2024-07-19 14:36:45 +02:00
Bartłomiej Dach
41bad54313
Merge pull request #28948 from peppy/editor-blah
Minor editor design tweaks
2024-07-19 13:49:42 +02:00
Bartłomiej Dach
27000aa8ed
Merge branch 'master' into editor-blah 2024-07-19 13:42:40 +02:00
Salman Ahmed
ce0397aaef
Merge branch 'master' into hold-off-incompatibility 2024-07-19 14:38:10 +03:00
Dan Balasescu
ad564f31cb
Merge pull request #28947 from peppy/fix-playlist-item-panel
Fix various visuals of playlist beatmap panels
2024-07-19 20:12:40 +09:00
Dean Herbert
f500abd4f7 Make "Hold Off" and "No Release" mod incompatible 2024-07-19 14:08:39 +03:00
Dean Herbert
c2cc85e6f0
Use purple again for kiai time specifically 2024-07-19 19:59:38 +09:00
Dean Herbert
c4de2bbb60
Ignore "too many ticks" in timeline (triggers in normal cases) 2024-07-19 19:57:47 +09:00
Dean Herbert
5ee645ac8f
Increase opacity of control points slightly 2024-07-19 19:50:21 +09:00
Dean Herbert
d9297438ba
Merge pull request #28900 from smoogipoo/fix-more-tests
Fix more test failures
2024-07-19 19:38:52 +09:00
Dean Herbert
f11f01f9b7
Fix various visuals of playlist beatmap panels
Supersedes https://github.com/ppy/osu/pull/28907.

- Fix border being fat
- Fix thumbnail not masking correctly
- Fix background layer not being correctly fit to the panel
- Dim the main background on hover
- Minor tweaks to dimming
2024-07-19 19:26:04 +09:00
Dan Balasescu
6553122361
Merge pull request #28946 from peppy/fix-carousel-pause
Fix beatmap carousel performance regression with large databases
2024-07-19 19:17:40 +09:00