130 Commits

• Add note about why bodyPiece sizing is done as it is

  I think we're going to have to change this as it's quite limiting in
  what you can do with osu!mania skin implementation, but for now I want
  to leave a note as to why this is done, because each time I have to
  trial and error check what breaks when adjusting it.

  Dean Herbert · 2023-03-09 20:26:49 +09:00
  ed3ff62e4f
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b
• Refactor SkinnableSound.Samples to be non-nullable
  Dean Herbert · 2023-01-27 19:32:30 +09:00
  74ab036f3e
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix osu!mania hold notes occasionally getting in a visually incorrect hit state

  To correctly end a mania hold note, `endHold()` needs to be called. This
  was not happening in a very specific scenario:
  
  - The hold note's head is not hit
  - The user pressed the column's key within the hold note's tail's window,
    but does so to hit the next object (a note in proximity to the hold note's tail).
  - The hit policy forces a miss on the hold note, but `endHold()` is not called
  - `CheckForResult` is not called after this point due to `Judged` being `true`.
  
  Closes #21311.

  Dean Herbert · 2022-11-22 16:15:34 +09:00
  57723107dd
• Add "Component" prefix to lookup naming
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  1aa0e40f2f
• Rename ISkinComponent to ISkinLookup
  Dean Herbert · 2022-11-09 17:46:43 +09:00
  c908969d9b
• Fix hold note disappear instantly
  ekrctb · 2022-10-25 19:16:23 +09:00
  92ab39f5c2
• Implement hold "sliding" samples in osu!mania
  Dean Herbert · 2022-10-11 16:31:37 +09:00
  f060e6a780
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update with keybinding changes
  smoogipoo · 2021-09-16 18:26:12 +09:00
  f9d5abff8a
• Fix hold notes handling all input ever
  Dean Herbert · 2021-08-24 19:08:04 +09:00
  6252b8aa42
• Fix DrawableHoldNote retaining hit states through applications
  smoogipoo · 2021-05-12 17:07:42 +09:00
  f992b59b4f
• Initial implementation of DHO pooling
  smoogipoo · 2021-05-12 16:35:05 +09:00
  5692cecaa4
• Fix hold note crashing with 0 length
  smoogipoo · 2021-04-22 19:51:33 +09:00
  4148d473e3
• Miss all ticks when hold note is hit
  smoogipoo · 2021-03-31 12:21:14 +09:00
  43e48406ca
• Adjust namespace
  ekrctb · 2020-12-07 12:32:52 +09:00
  e3c035fe9c
• Store time of hold note break
  Bartłomiej Dach · 2020-11-13 21:14:34 +01:00
  b62bf5798d
• Disable pressed/released action logic when rewinding
  Bartłomiej Dach · 2020-11-13 20:49:06 +01:00
  7a89e58483
• Update existing implementations
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  a3dc1d5730
• Replace comparison references to HitResult.Miss with IsHit
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  2b1ef16f89
• Use new hit results in mania
  smoogipoo · 2020-09-29 16:33:38 +09:00
  b1877b649b
• Merge branch 'master' into mania-notelock
  smoogipoo · 2020-08-31 13:31:41 +09:00
  aa151e4cd7
• Implement basic mania hit order policy
  smoogipoo · 2020-08-27 20:24:21 +09:00
  deb172bb6c
• Merge branch 'master' into hold-note-lighting
  smoogipoo · 2020-08-26 20:22:07 +09:00
  1db836e9e0
• Implement hold note lighting
  smoogipoo · 2020-08-26 20:21:56 +09:00
  9372c6eef6
• Fix hold notes bouncing with SV changes
  smoogipoo · 2020-08-21 23:11:15 +09:00
  8632c3adf0
• Apply suggestions from code review

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dan Balasescu · 2020-08-21 19:38:59 +09:00
  42ee9b75df
• Rework freezing to use masking
  smoogipoo · 2020-08-21 17:52:42 +09:00
  aead13628b
• Merge branch 'master' into hold-note-freeze
  smoogipoo · 2020-08-21 14:39:25 +09:00
  37cf7999b1
• Mask the tail as the body gets shorter
  smoogipoo · 2020-08-19 01:40:26 +09:00
  1d9d885d27
• Add rewinding support
  smoogipoo · 2020-08-19 01:37:31 +09:00
  4d4d9b7356
• Fix incorrect anchors for up-scroll
  smoogipoo · 2020-08-19 00:05:36 +09:00
  99315a4aa7
• Fix body size + freeze head piece
  smoogipoo · 2020-08-19 00:05:05 +09:00
  988ad378a7
• Implement mania hold note body recycling
  smoogipoo · 2020-08-18 17:56:48 +09:00
  385f7cf85d
• Initial implementation of hold note freezing
  smoogipoo · 2020-08-18 00:29:00 +09:00
  548ccc1a50
• Fix hold notes accepting presses during release lenience
  smoogipoo · 2020-07-20 22:26:58 +09:00
  f044c06d08
• Merge pull request #8823 from smoogipoo/all-ruleset-encoders

  Implement legacy beatmap encoding for all rulesets

  Dean Herbert · 2020-04-24 17:49:34 +09:00
  59bd2b3035
• Fix hold note placement body sized incorrectly
  smoogipoo · 2020-04-23 12:53:23 +09:00
  4f0b5a34d3
• Reword comment
  smoogipoo · 2020-04-22 09:06:04 +09:00
  1f962f5c56
• Cleanup handling of mania samples
  smoogipoo · 2020-04-22 09:06:04 +09:00
  d957614fc9
• Rework lookups to not require total playfield columns
  smoogipoo · 2020-04-03 12:31:05 +09:00
  1f797207f7
• Implement mania hold note skinning
  smoogipoo · 2020-03-31 16:42:35 +09:00
  1952fcc0ce
• Apply OnRelease method signature refactorings
  smoogipoo · 2020-01-22 13:22:34 +09:00
  7b2f58eb30
• internal -> public
  smoogipoo · 2019-12-23 18:48:14 +09:00
  d6fd1007c4
• Rewrite hold note input handling
  smoogipoo · 2019-12-23 17:48:57 +09:00
  7ac6f68de8
• Separate head/tail notes from hold note class
  smoogipoo · 2019-12-23 17:48:57 +09:00
  42853b5af6
• Clean up head/tail setting in various DHOs
  smoogipoo · 2019-10-17 14:02:23 +09:00
  bc41eb176e
• Add back/obsolete old AddNested() method
  smoogipoo · 2019-10-17 14:02:08 +09:00
  f429a8f7c2