Dean Herbert
b8a10d9b0e
Mark recommendation test as flaky
...
Will revisit during song select refactoring no doubt.
2025-01-07 17:58:12 +09:00
Dean Herbert
4f1a6b4688
Always show dialog when clicking supporter icon before opening browser
...
I managed to do this by accident three times today while testing using
the dashboard display, so it's time to action on it.
Touched on in
https://github.com/ppy/osu/discussions/30740#discussioncomment-11345996 .
Was also mentioned recently in discord or another discussion explicitly
but I can't find that.
2025-01-06 17:51:04 +09:00
Dan Balasescu
448790a76f
Merge pull request #31386 from peppy/fix-applying-offset
...
Fix not being able to apply last play offset after returning to song select
2025-01-06 11:40:12 +09:00
Dean Herbert
d6e73d75d2
Merge pull request #31414 from frenzibyte/fix-display
...
Fix mobile release dialog obstructed by the software keyboard
2025-01-05 00:37:29 +09:00
Dean Herbert
37da72d764
Reduce nesting slightly
2025-01-05 00:32:06 +09:00
Salman Alshamrani
3fc86f60ee
Fix mobile release dialog obstructed by the software keyboard
2025-01-03 22:01:06 -05:00
Dean Herbert
b4698851a3
Merge pull request #31403 from frenzibyte/mobile-disclaimer
2025-01-04 02:35:36 +09:00
Dean Herbert
2cd86cbf91
Localise text
2025-01-04 01:28:33 +09:00
Dean Herbert
da85517036
Adjust popup icon animation slightly
2025-01-04 01:28:09 +09:00
Dean Herbert
60fd0be481
Make popup body text left aligned when multiple lines of text are provided
2025-01-04 01:19:56 +09:00
Dean Herbert
1d81dade25
Update copy and require actually clicking button to confirm
2025-01-04 01:13:03 +09:00
Dean Herbert
97d065d887
Only flip value if popup was definitely shown
2025-01-04 00:58:19 +09:00
Dean Herbert
1161b7b3c0
Flip navigation test expectations in line with new behaviour
2025-01-04 00:55:12 +09:00
Salman Alshamrani
c40371c052
Move dialog class location
2025-01-03 00:27:26 -05:00
Salman Alshamrani
039800550c
Display popup disclaimer about game state and performance on mobile platforms
2025-01-03 00:20:50 -05:00
Dean Herbert
2d4a3aa4f9
Merge pull request #31354 from bdach/show-hit-markers-for-repeats
...
Fix slider repeats not properly respecting "show hit markers" setting
2025-01-02 18:45:55 +09:00
Dean Herbert
2a28c5f4de
Add static memory of last applied offset score
...
I don't really like adding this new session static, but we don't have a
better place to put this.
2025-01-02 16:20:25 +09:00
Dean Herbert
2d3595f768
Add test covering required behaviour
...
See https://github.com/ppy/osu/issues/30885 .
2025-01-02 16:20:09 +09:00
Dean Herbert
58dcb25bd5
Revert "Clear previous LastLocalUserScore when returning to song select"
...
This reverts commit ced8dda1a2
2025-01-02 15:59:00 +09:00
Dan Balasescu
1cb2c86104
Merge pull request #31383 from peppy/editor-toolbar-scrolling-weird
...
Always block scroll input above editor toolbox areas
2025-01-02 15:11:11 +09:00
Dan Balasescu
6546dc0969
Merge pull request #31381 from peppy/auto-start-10-seconds
...
Add auto-start setting for 10 seconds
2025-01-02 15:09:23 +09:00
Dean Herbert
cca63b599e
Always block scroll input above editor toolbox areas
...
Originally this was an intentional choice (see
https://github.com/ppy/osu/pull/18088 ) when these controls were more
transparent and didn't for a solid toolbox area.
But this is no longer the case, so for now let's always block scroll to
match user expectations.
Closes #31262 .
2025-01-02 14:31:27 +09:00
Dean Herbert
1211f6cf4c
Add auto-start setting for 10 seconds
...
As touched on in
https://github.com/ppy/osu/discussions/31205#discussioncomment-11671185 .
Doesn't require server-side changes as the server just uses a
`TimeSpan`.
2025-01-02 13:06:34 +09:00
Dan Balasescu
9da27b5fe5
Merge pull request #31305 from bdach/round-coordinates-on-legacy-export
...
Round object coordinates to nearest integers on legacy export rather than truncating
2025-01-01 21:05:18 +09:00
Dean Herbert
8196325815
Merge pull request #31363 from hrfarmer/game-mode
2025-01-01 11:11:30 +09:00
Salman Alshamrani
3ac2d90f19
Add explanatory note
2024-12-31 20:44:50 -05:00
Bartłomiej Dach
929173c971
Merge pull request #31342 from minetoblend/feature/speedy-metronome
...
Speed up metronome in timing screen when pressing control key
2024-12-31 14:49:48 +01:00
Dean Herbert
b09a34cfa8
Merge pull request #31362 from CuNO3/master
...
Ignore whitespace while 2FA authentication
2024-12-31 21:14:42 +09:00
Dean Herbert
6ff3110433
Consolidate variable
2024-12-31 21:14:15 +09:00
aychar
333ae75a82
Add game mode key to plist
2024-12-31 00:29:36 -06:00
Unili
acd51c8e9d
Merge branch 'ppy:master' into master
2024-12-31 11:35:55 +08:00
CuNO3
22c8229993
Ignore whitespace while 2FA authentication
2024-12-31 10:43:48 +08:00
Marvin Schürz
0641d2b510
Remove turboweird function and update displayed bpm text
2024-12-30 19:12:21 +01:00
Dean Herbert
73083e1337
Merge pull request #31350 from bdach/fix-slider-drag-marker-blocking-context-menu
...
Fix slider end drag marker blocking open of control point piece context menus
2024-12-30 22:27:30 +09:00
Bartłomiej Dach
06879eee39
Fix slider repeats not properly respecting "show hit markers" setting
...
Closes https://github.com/ppy/osu/issues/31286 .
Curious on thoughts about how the instant arrow fade looks on
non-classic skins. On argon it's probably fine, but it does look a
little off on triangles...
2024-12-30 13:52:50 +01:00
Dan Balasescu
11a4e3beb4
Merge pull request #31287 from stanriders/change-relax-leniency
...
Change `OsuModRelax` hit leniency to be the same as in stable
2024-12-30 21:42:48 +09:00
Dan Balasescu
643e849029
Merge branch 'master' into fix-slider-drag-marker-blocking-context-menu
2024-12-30 21:34:11 +09:00
Dan Balasescu
c56a6ed595
Merge pull request #31348 from bdach/fix-slider-quick-delete
...
Fix quick-deleting unselected slider path control point also deleting all selected control points
2024-12-30 21:33:57 +09:00
Dan Balasescu
ab111178d0
Merge pull request #31352 from bdach/collapse-sample-point-indicators-better
...
Take custom bank name length into account when collapsing sample point indicators
2024-12-30 21:32:07 +09:00
Bartłomiej Dach
693db097ee
Take custom bank name length into account when collapsing sample point indicators
...
Would close https://github.com/ppy/osu/issues/31312 .
Not super happy with the performance overhead of this, but this is
already a heuristic-based implementation to avoid every-frame
`.ChildrenOfType<>()` calls or similar, so not super sure how to do
better. The `Array.Contains()` check stands out in profiling, but
without it the indicators can collapse *too* eagerly sometimes.
2024-12-30 12:04:41 +01:00
Bartłomiej Dach
4d326ec31f
Fix slider end drag marker blocking open of control point piece context menus
...
Closes https://github.com/ppy/osu/issues/31323 .
2024-12-30 11:07:25 +01:00
Bartłomiej Dach
a4c6f221c2
Add extra test coverage to prevent regressions
...
Covers scenario described in https://github.com/ppy/osu/issues/31176 and
fixed in https://github.com/ppy/osu/pull/31184 .
2024-12-30 11:07:21 +01:00
Bartłomiej Dach
2a758bc3df
Add failing test case
2024-12-30 10:47:55 +01:00
Bartłomiej Dach
182f998f9b
Fix quick-deleting unselected slider path control point also deleting all selected control points
...
Closes https://github.com/ppy/osu/issues/31308 .
Logic matches corresponding quick-delete logic in
130802e480/osu.Game/Screens/Edit/Compose/Components/SelectionHandler.cs (L307-L316)
2024-12-30 09:44:04 +01:00
Bartłomiej Dach
aa67f87fe9
Add failing test coverage
2024-12-30 09:42:24 +01:00
Bartłomiej Dach
f18114d2fb
Merge pull request #31282 from peppy/fix-volume-key-repeat
...
Fix volume adjust key repeat not working as expected
2024-12-30 08:49:35 +01:00
Marvin Schürz
9ea7afb38e
Use return value instead of field to force weight position update
2024-12-30 03:59:54 +01:00
Marvin Schürz
aa6763785c
Use 3x speed instead when beat snap divisor is divisible by 3
2024-12-30 03:21:52 +01:00
Marvin Schürz
8be500535d
Speed up metronome when holding control
2024-12-30 03:13:22 +01:00
Dean Herbert
10ee2e28c2
Merge pull request #31303 from bdach/pause-on-gameplay-test
...
Pause playback when entering gameplay test from editor
2024-12-28 04:41:28 +09:00
