372 Commits

• Bump difficulty calculator versions

  To trigger client-side recalculations of star ratings.
  
  Should have been done in https://github.com/ppy/osu/pull/35029.
  
  Probably closes https://github.com/ppy/osu/issues/35357.

  Bartłomiej Dach · 2025-10-20 08:46:30 +02:00
  03a5aedf99
• Replace nested ternaries with ifs
  Dan Balasescu · 2025-09-23 13:45:10 +09:00
  82ac42cae3
• Remove databasing of MechanicalDifficulty and ReadingDifficulty attributes (#35028)

  * Remove databasing of `MechanicalDifficulty` and `ReadingDifficulty` attributes
  
  * Update attribute IDs

  James Wilson · 2025-09-15 13:46:00 +03:00
  2749184c38
• osu!taiko final balancing before deploy (#34962)

  * Change maximum UR estimation + buff rhythm
  
  * Penalty for classic ezhd
  
  * Buff mono bonus to counterbalance logic fix
  
  * New miss penalty + slightly nerf length bonus
  
  * Adjust rhythm values
  
  * Adjust penalty and buff high SR acc
  
  * Exclude HDFL from hidden reading penalties
  
  * Make comment a lil nicer
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Eloise · 2025-09-15 09:43:26 +01:00
  c7f50f35b7
• Prevent Taiko difficulty crash if a map only contains 0-strains (#34829)

  * Prevent Taiko difficulty crash if a map only contains 0-strains
  
  * Add second check for safety
  
  This is accessing a different array of strains. I'd rather be safe than sorry.
  
  * Add guard in PP too
  
  * Make `MarginOfError` a const

  James Wilson · 2025-08-31 12:04:56 +00:00
  6a35b7237b
• Implement deltatimenormaliser into rhythm grouping logic (#33403)

  * additions
  
  * review fixes
  
  * Formatting
  
  * comments + review
  
  * fix
  
  * fix renaming and namespace
  
  * balancing + round
  
  ---------
  
  Co-authored-by: tsunyoku <tsunyoku@gmail.com>
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2025-08-28 13:19:13 +00:00
  087f0565e6
• osu!taiko reduce multiplier for hidden on lazer (#34089)

  * Reduce multiplier for hidden on lazer
  
  * Refactor
  
  * Quality
  
  * The space

  Eloise · 2025-07-30 21:48:45 +02:00
  dbb16fc834
• osu!taiko new acc pp formula + rhythm difficulty penalty (#34188)

  * New acc curve
  
  * Penalise rhythm difficulty based on unstable rate
  
  * Rename mono acc stuff for more clarity
  
  * Fix nullable
  
  * Rename stuff
  
  * Get actual estimation for SS unstable rate
  
  * Double space my bad
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Eloise · 2025-07-29 18:03:13 +00:00
  eaaca60b1d
• osu!taiko consistency factor changes using object strains (#34327)

  * Calculate consistency factor from object strains
  
  * Use `totalDifficultHits` in performance calc
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Eloise · 2025-07-28 13:58:54 +00:00
  803e30f50f
• Fix colour penalties being bypassed via repeated ratio variance (#33641)

  * fix a lil bit of colour
  
  * review comments
  
  * fix empty initialiser

  Jay Lawton · 2025-07-27 14:31:46 +00:00
  e54779ceee
• ensure monolengthbonus applies to new strain contribution only (#33635)

  * stamina fix
  
  * review changes
  
  * fix naming
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Jay Lawton · 2025-07-22 09:37:51 +00:00
  ddf9d6b8c8
• osu!taiko changes to length bonus using consistency factor (#33582)

  * Implement new formulas for length bonus
  
  * Add comment(s)
  
  * Fix up HDFL thing

  Eloise · 2025-06-10 11:31:11 +01:00
  7066f3def7
• osu!taiko new miss penalty using consistency factor (#33409)

  * New formulas for effective miss count and penalty
  
  * More elaborate comments
  
  * More comment stuff

  Eloise · 2025-06-08 22:47:26 +00:00
  5df41c08f4
• osu!taiko simplify pp summing and make performance attributes accurate (#33500)

  * Change pp summing and adjust multipliers
  
  * Add back convert consideration for hidden
  
  * And the other one whoops
  
  ---------
  
  Co-authored-by: StanR <hi@stanr.info>

  Eloise · 2025-06-08 08:48:28 +00:00
  6ae8a68389
• Remove multipliers nerfing ez (#33415)
  Eloise · 2025-06-06 16:46:33 +03:00
  6a9aeda5d4
• Remove stamina skill buff from strain length bonus (#33380)

  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Eloise · 2025-06-03 14:47:42 +01:00
  b982c3cd20
• Add a consistency factor to osu!taiko diffcalc (#33233)

  * add consistency attribute
  
  * write attributes to json for serialisation
  
  * comment change
  
  * fix json, add mechanical difficulty
  
  * write new attributes to database
  
  ---------
  
  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Jay Lawton · 2025-05-23 11:57:37 +00:00
  ace74824b8
• Remove track usage in difficulty and performance calculations (#33132)
  James Wilson · 2025-05-14 12:37:08 +00:00
  d22b3fb200
• osu!taiko skills refactor (#32426)

  Co-authored-by: James Wilson <tsunyoku@gmail.com>

  Jay Lawton · 2025-03-24 10:07:23 +00:00
  8b11be5ac0
• Remove JSON property attributes from non-databased taiko difficulty attributes
  tsunyoku · 2025-03-12 19:10:41 +00:00
  db0676d615
• Bump difficulty calculator versions in preparation for release
  Dean Herbert · 2025-03-06 16:05:51 +09:00
  bdd2808fb5
• Add note about weird taiko iteration
  Dean Herbert · 2025-02-10 17:57:01 +09:00
  d4ce712672
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7
• Fix inspections
  Dean Herbert · 2025-02-07 13:54:35 +09:00
  4f6fd68a91
• Add better documentation for interval change code
  Dean Herbert · 2025-02-05 18:48:48 +09:00
  40ea7ff238
• Initial tidy-up pass on IntervalGroupingUtils
  Dean Herbert · 2025-02-05 15:47:18 +09:00
  8447679db9
• Tidy up xmldoc and remove another unused field
  Dean Herbert · 2025-02-05 15:33:06 +09:00
  325483192a
• Remove unused HitObjectInterval
  Dean Herbert · 2025-02-05 15:10:15 +09:00
  fc93390284
• Simplify TaikoRhythmData's ratio computation
  Dean Herbert · 2025-02-05 15:09:51 +09:00
  709ad02a51
• Rename Colour / Rhythm related fields and classes
  Dean Herbert · 2025-02-05 15:08:15 +09:00
  fa844b0ebc
• Use correct English
  tsunyoku · 2025-01-27 12:56:33 +00:00
  f3c17f1c2b
• Rename class, rename children to hit objects and groups, make fields un-settable
  tsunyoku · 2025-01-27 12:54:22 +00:00
  71b89c390f
• Account for floating point errors
  tsunyoku · 2025-01-26 20:15:13 +00:00
  13c956c248
• Fix incorrect startTime calculation
  tsunyoku · 2025-01-26 16:21:07 +00:00
  a7aa553445
• Remove unused default value
  tsunyoku · 2025-01-23 10:29:04 +00:00
  8f17a44976
• Keep old behaviour of double.PositiveInfinity being the default for Interval
  tsunyoku · 2025-01-22 13:26:12 +00:00
  753e9ef7c7
• Fix incorrect namespace
  tsunyoku · 2025-01-22 13:24:30 +00:00
  2c0d6b14c8
• Replace weird IntervalGroupedHitObjects inheritance layer
  tsunyoku · 2025-01-21 15:58:33 +00:00
  14c68bcc58
• Revert Precision.DefinitelyBigger usage
  tsunyoku · 2025-01-21 15:01:32 +00:00
  1c4bc6dffd
• Fix typo in ColourEvaluator
  tsunyoku · 2025-01-21 14:56:51 +00:00
  764b0001ef
• Make rescale a static method
  tsunyoku · 2025-01-21 14:33:40 +00:00
  e0882d2a53
• Rename rhythm preprocessing objects to be clearer with intent
  tsunyoku · 2025-01-21 14:29:07 +00:00
  20a76d832d
• Add xmldoc to explain IHasInterval.Interval
  tsunyoku · 2025-01-21 14:28:15 +00:00
  ef8867704a
• Refactor StaminaEvaluator
  tsunyoku · 2025-01-21 14:25:28 +00:00
  b8c79d58a7
• Format ReadingEvaluator
  tsunyoku · 2025-01-21 14:24:46 +00:00
  9919179b0b
• Refactor ColourEvaluator
  tsunyoku · 2025-01-21 14:24:27 +00:00
  dbe36887f6
• Remove EffectiveBPMPreprocessor
  tsunyoku · 2025-01-21 14:24:04 +00:00
  fa20bc6631
• Tidy up code quality of RhythmEvaluator
  Dean Herbert · 2025-01-21 13:40:55 +09:00
  c8b05ce114
• Use correct HitWindows class for osu!taiko hit windows in difficulty calculator (#31579)

  * Use correct `HitWindows` class for osu!taiko hit windows in difficulty calculator
  
  * Remove redundant (and incorrect) hit window creation
  
  * Balance rhythm against hit window changes

  James Wilson · 2025-01-20 17:04:31 +05:00
  a77dfb1068
• Replace indexed skill access with skills.OfType<...>().Single() (#30034)

  * Replace indexed skill access with `skills.First(s is ...)`
  
  * Fix comment
  
  * Further refactoring to remove casts
  
  ---------
  
  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  StanR · 2025-01-20 09:39:35 +00:00
  22e839d62b