46 Commits

• Various tournament-minded improvements for multiplayer (#37000)

  https://github.com/user-attachments/assets/042311f1-b8c3-479b-a173-13b93fe2c5cc
  
  - `/roll` command is now supported in multiplayer chat for all players
  (don't need to be a referee).
  - Referees are shown in the room with a special status.
  - Tournament mode rooms can be locked, which prevents users from
  changing team (and slot, whenever those get brought back). When the room
  is locked, the user team indicator shows a padlock icon on top to
  indicate the lock state.
  
  ---
  
  - Related: https://github.com/ppy/osu-server-spectator/issues/406
  
  Grab-bag because I really don't think splitting this into 3 PRs is very
  helpful.
  
  I was going to add an animation for rolling but I had a go on Friday and
  my attempt got more or less the same reception as a wet fart so I'm not
  trying again. Someone else can if so inclined. I have completely lost
  trust in my design senses.
  
  Contrary to stable the roll results are completely ephemeral and go away
  when the room is re-entered. This could be both considered good and bad.
  Not for me to say.

  Bartłomiej Dach · 2026-03-20 18:56:45 +09:00
  43c53b5a8d
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Make Room.Playlist non-bindable
  Dan Balasescu · 2024-11-15 15:51:01 +09:00
  34c0f72dd6
• Make Room.Type non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  81e4cb348f
• Make Room.Name non-bindable
  Dan Balasescu · 2024-11-15 14:29:15 +09:00
  6160df1586
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove unused RulesetStore from BeatmapManager constructor
  Dean Herbert · 2022-07-28 16:19:05 +09:00
  2b9d46d803
• Isolate client's Room from TestMultiplayerClient
  Dan Balasescu · 2022-07-01 19:23:25 +09:00
  b64c0d011c
• Rename APIRoom -> ClientAPIRoom, remove unused asserts
  Dan Balasescu · 2022-07-01 19:21:59 +09:00
  0be858b5bf
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Merge branch 'master' into beatmap-decoder-ruleset-store
  Dean Herbert · 2022-02-18 16:52:33 +09:00
  631c23ea3a
• Update existing usages to point to RealmRulesetStore
  Dean Herbert · 2022-02-16 17:13:54 +09:00
  0138f22c8d
• Merge branch 'master' into remove-playlistitem-beatmap
  Dean Herbert · 2022-02-16 14:24:57 +09:00
  7e24b36f26
• Rename "client" fields in tests to specify whether spectator or multiplayer
  Dean Herbert · 2022-02-16 09:52:18 +09:00
  6a08fd57ef
• Merge branch 'master' into fix-multi-cache-dependencies
  Dean Herbert · 2022-02-16 09:44:37 +09:00
  187870b794
• Merge branch 'master' into net6
  Dan Balasescu · 2022-02-16 00:40:04 +09:00
  ea5bb46fb8
• Remove beatmap bindable from PlaylistItem
  Dan Balasescu · 2022-02-15 23:50:08 +09:00
  bdc3b76df0
• Fix incorrect usages of user lookup cache in tests
  Dan Balasescu · 2022-02-15 21:23:24 +09:00
  539cbe62c6
• Remove ruleset and mod bindables from PlaylistItem
  Dan Balasescu · 2022-02-15 16:28:15 +09:00
  efeba30b9f
• Use WaitSafely() in tests where it was not already being used
  Dean Herbert · 2022-02-15 02:35:08 +09:00
  02f58a82fc
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Fix cases of Access instead of Realm
  Dean Herbert · 2022-01-25 12:58:15 +09:00
  3e5c9e8436
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Add local ContextFactory caching to all remaining test scenes that create local managers
  Dean Herbert · 2022-01-14 19:59:21 +09:00
  a59dcccab7
• Make tests compile again
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  31a3161189
• Update model manager and many related classes to get things compiling again
  Dean Herbert · 2022-01-12 17:00:00 +09:00
  00e3af3366
• Replace usages of Wait with WaitSafely
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  031a40af6a
• Rename TestMultiplayerScreenStack to TestMultiplayerComponents
  Dean Herbert · 2021-12-20 18:24:59 +09:00
  ec0a6735eb
• Better fix for intermittent multiplayer tests
  Dan Balasescu · 2021-12-20 13:10:13 +09:00
  9316abc278
• Wait for match type changes in team versus test
  Bartłomiej Dach · 2021-12-07 20:40:10 +01:00
  e9694dc74e
• Fix test failures due to wrong asserts & uninitialised playlist

  * The "create room" button was disabled headless due to not specifying
    the imported beatmap. In visual tests it seems to work due to
    selecting from the local database randomly.
  
  * The test asserts are brought in line with expectations.

  Bartłomiej Dach · 2021-11-30 20:57:08 +01:00
  de034b4d9c
• Add extra until step to make cause of potential failures more obvious
  Bartłomiej Dach · 2021-11-30 20:56:11 +01:00
  b74b09eb3a
• Fix incorrect test step text

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2021-11-30 17:16:30 +09:00
  8de06803a8
• Add test coverage of match type propagating to other users' settings
  Dean Herbert · 2021-11-30 17:09:32 +09:00
  049d9ce5ef
• Fix a few more multiplayer test timeouts

  These can be tested by adding a `Task.Delay(3000);` at the end of the
  `MultiplayerClient.JoinRoom` task. The reason is typically that
  `Client.Room` becomes not-null but the join task still hasn't completed
  yet, so e.g. the ready button is still disabled.

  Dan Balasescu · 2021-11-23 16:07:03 +09:00
  69a9fc9732
• Add failing test steps
  Bartłomiej Dach · 2021-11-11 09:01:50 +01:00
  f38d6ef8db
• Add failing test showing team display display failure
  Dean Herbert · 2021-11-10 13:44:31 +09:00
  52c740b377
• Clean up multiplayer-screen tests by removing intermediate screen
  smoogipoo · 2021-10-28 14:29:49 +09:00
  0e293471c2
• Fix dependency missing in a few TestScenes

  Hopefully these are rather temporary cases until a better solution is
  found for these dependency-loading screens.

  smoogipoo · 2021-10-27 20:47:40 +09:00
  a87d8d0359
• Rename room managers
  smoogipoo · 2021-10-27 19:36:32 +09:00
  f3dba49aae
• Fix incorrect load state check

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-10-06 05:31:07 +09:00
  1a784b788d
• Add various logging output in an atttempt to figure multiplayer test failure
  Dean Herbert · 2021-10-05 18:53:20 +09:00
  e6efdae7c9
• Fix compilation failure
  smoogipoo · 2021-08-05 20:52:40 +09:00
  c56b6a5379
• Add test coverage of changing teams via clicking
  Dean Herbert · 2021-08-03 23:42:37 +09:00
  69e6c08cc2
• Fire initial match user states in TestMultiplayerClient
  Dean Herbert · 2021-08-03 23:42:37 +09:00
  75426f84f1
• Add basic test coverage
  Dean Herbert · 2021-08-03 23:42:37 +09:00
  a0119f8cd6