967 Commits

Author	SHA1	Message	Date
Dean Herbert	affa9507a1	Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play	2023-02-16 18:21:33 +09:00
Dean Herbert	da8ab7143b	Merge branch 'master' into maximum-judgement-offset-in-hit-object	2023-02-15 14:48:15 +09:00
Bartłomiej Dach	c5e1f54185	Fix sample store creation mutating shared resource store	2023-01-30 20:48:52 +01:00
ekrctb	d8f9b7d02f	Use MaximumJudgementOffset for lifetime	2023-01-19 21:25:21 +09:00
Berkan Diler	08d2fbeb8e	Use new ArgumentNullException.ThrowIfNull throw-helper API	2022-12-22 21:27:59 +01:00
Dean Herbert	4a7d7c6ed9	Use MaxBy in all locations that can and update inspection level to match dotnet-build	2022-12-19 16:47:10 +09:00
Dan Balasescu	850931120d	Merge pull request #21479 from peppy/fix-wrong-last-hit-object-time ... Fix some components not accounting for final hold notes in osu!mania beatmaps	2022-12-02 18:12:00 +09:00
Dan Balasescu	a39bd634c4	Merge pull request #21405 from LumpBloom7/Editor-DrawableRuleset-Dependencies ... Provide DrawableRulesetDependencies from HitObjectComposer	2022-12-02 17:31:31 +09:00
Dean Herbert	809d02cda0	Fix two implementation oversights	2022-12-02 16:05:14 +09:00
Dean Herbert	d8dd7e7e0f	Fix test failures when no hitobjects are present in a scrolling ruleset	2022-12-01 21:42:03 +09:00
Dean Herbert	896f2d8f74	Fix multiple instances of last hitobject time being calculated incorrectly	2022-12-01 18:04:06 +09:00
Bartłomiej Dach	6ebde9a747	Annotate Playfield.Mods as maybe-null	2022-11-30 20:00:25 +01:00
Dean Herbert	5ce2d6f54a	Hide the game mouse cursor when playing osu!catch with relax mod	2022-11-30 18:13:53 +09:00
Dean Herbert	bb0237d4a9	Fix nullability inspection on disposal path	2022-11-30 17:49:08 +09:00
Dean Herbert	4215f4f5d7	Merge branch 'master' into Editor-DrawableRuleset-Dependencies	2022-11-30 17:42:46 +09:00
Derrick Timmermans	93ba84e5ff	Fix code style	2022-11-27 21:48:44 +01:00
Derrick Timmermans	70c320b2e8	Provide ruleset dependencies only to Compose Placement Blueprints	2022-11-27 21:43:33 +01:00
Dan Balasescu	7bc8908ca9	Partial everything	2022-11-27 00:00:27 +09:00
Bartłomiej Dach	0f382590e6	Remove unnecessary #nullable disable	2022-11-20 15:31:51 +01:00
Salman Ahmed	58296bd4f0	Introduce IDrawableScrollingRuleset for editor consumption	2022-11-20 04:11:10 +03:00
Susko3	56fd1f95b1	Fix FallbackSampleStore.GetAsync fallback logic	2022-11-13 18:47:28 +01:00
Dean Herbert	5c13c443ff	Fix incorrect fallback logic ... Regressed when attempting to share implementation of binary search.	2022-10-20 23:08:44 +09:00
Dean Herbert	26860a903e	Refactor implementation to support hitobjects nested multiple levels deep	2022-10-20 22:30:30 +09:00
Dean Herbert	d237c818f6	Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time	2022-10-18 16:15:21 +09:00
Dean Herbert	ec3761ced9	Standardise control point search logic in OverlappingScrollAlgorithm ... Was using a very local algorithm which I cannot guarantee is correct. I'd rather it just use the one used everywhere else.	2022-10-18 16:01:05 +09:00
Salman Ahmed	4fb156ef4e	Update xmlodc and add nullability attributes	2022-10-13 00:16:42 +03:00
Salman Ahmed	7a6ecaff0d	Remove default invisible cursor container from rulesets	2022-10-12 17:50:47 +03:00
Salman Ahmed	9b45a9cf76	Rename various cursor symbols ... - `IProvideCursor.MenuCursor` -> `IProvideCursor.Cursor` - `MenuCursor` -> `MenuCursorContainer	2022-10-11 16:21:01 +03:00
Salman Ahmed	2d4f390372	Remove non-smoke key bindings on "Relax" mod instead	2022-10-09 17:14:16 +03:00
ekrctb	1cccd03480	Fix scrolling nested hit object lifetime not set	2022-10-04 15:17:14 +09:00
ekrctb	781f5420b0	Add test for scrolling hit object lifetime	2022-10-04 15:17:11 +09:00
ekrctb	5d80950eaf	Compute lifetime from entry in scrolling container	2022-10-04 15:12:28 +09:00
Dan Balasescu	cbed268ac9	Merge pull request #20510 from sw1tchbl4d3r/high_bpm_judgements ... Clamp `LifetimeStart` of `HitObject`s to their judgement windows	2022-09-28 17:49:35 +09:00
sw1tchbl4d3	0cffbb7562	Clamp LifetimeStart of HitObject's to their judgement windows	2022-09-27 16:54:24 +02:00
o-dasher	feadac1f79	Cleanup all other leftover binding instantiation	2022-09-25 16:02:40 -04:00
ekrctb	c59aa57450	Remove createLifetimeEntry from HitObjectEntryManager	2022-09-14 15:19:33 +09:00
ekrctb	a9eba27129	Factor out pooling logic from Playfield	2022-09-14 15:19:05 +09:00
Dean Herbert	6bf6b7e125	Fix null considerations in DrawableRulesetDependencies	2022-09-13 13:13:38 +09:00
Salman Ahmed	0ca4be5e5b	Fix one more inspection	2022-09-13 03:45:31 +03:00
Dean Herbert	d4afc3629c	Merge branch 'master' into kps	2022-09-08 23:00:36 +09:00
Dean Herbert	6729bb3e1a	Change FrameStableClock to inherit IGameplayClock	2022-09-08 18:24:18 +09:00
Dan Balasescu	b559d4ecdf	Rename GameplayAdjustments -> AdjustmentsFromMods	2022-09-08 17:14:06 +09:00
Dean Herbert	75d0deef72	Apply proposed changes to remove inheritance from MasterGameplayClockContainer	2022-09-07 17:49:05 +09:00
Dean Herbert	bc1212f4e6	Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method	2022-09-06 22:26:46 +09:00
Dean Herbert	44b456e216	Use gameplay clock's TrueGameplayRate in FrameStabilityContainer?	2022-09-05 23:38:22 +09:00
Dean Herbert	7337d4c1aa	Merge branch 'master' into kps	2022-08-31 15:41:42 +09:00
Dean Herbert	105aa01e7d	Update usages of RemoveInternal	2022-08-29 15:57:40 +09:00
Dean Herbert	a215d009fe	Update Remove/RemoveRange/RemoveAll calls in line with framework changes	2022-08-29 15:57:40 +09:00
Ryuki	5cddc7ed1f	Code cleanup (CPS)	2022-08-24 17:13:23 +02:00
Dean Herbert	f3847b90fd	Tidy up attach logic	2022-08-24 19:36:01 +09:00