55 Commits

• Move BeatmapVersion from BeatmapInfo to IBeatmap

  Closes https://github.com/ppy/osu/issues/32420.
  
  The failure cause here is that in editor the beatmap version for the
  beatmap affected (or... any beatmap, really), is 0 (ZERO). That is
  probably a regression from https://github.com/ppy/osu/pull/32315, but
  like... can we universally agree that calling that change "a regression"
  in any capacity is dumb? Like what was that code *doing* playing dumb
  reference games and copying stuff into an arbitrary instance that could
  get or not get used later on? And now you have a 50/50 chance of
  accessing the *correct* model's field, depending on whether you go via
  `BeatmapInfo` or `Beatmap.BeatmapInfo`?
  
  Moving the field to `IBeatmap`, i.e. what is by now - by consensus,
  since https://github.com/ppy/osu/pull/28473 - supposed to be the "decoded
  and materialised" beatmap, fixes this issue.
  
  I probably should have done this as part of
  https://github.com/ppy/osu/pull/28473 but it slipped my mind. Probably
  for the better too because this change has rather large chances of
  breaking stuff so maybe better to examine it in isolation (via diffcalc
  runs or whatever).
  
  For added humour points, you'd say that the field on `BeatmapInfo` was
  not `[Ignore]`d, so this is a realm schema change, right? No. As far as
  I can tell, it's not. I opened realm studio and `BeatmapVersion` *is not
  a listed column` on `Beatmap` models.
  
  I'm also not gonna get into the fact that I think `EditorBeatmap` doing
  dumb games with juggling two `BeatmapInfo` references since
  https://github.com/ppy/osu/pull/15075 is bad, because I don't think I
  have the mental capacity to hotfix this by going down that train of
  thought.

  Bartłomiej Dach · 2025-03-17 15:04:48 +01:00
  91f3be5fea
• Move bookmarks out of BeatmapInfo

  Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...

  Bartłomiej Dach · 2024-12-03 14:17:14 +01:00
  808934581f
• Fix Beatmap.Countdown not being copied on conversion
  Bartłomiej Dach · 2024-11-26 11:39:03 +01:00
  46d1f00590
• Merge branch 'master' into beatmap-info-purge
  Dean Herbert · 2024-07-23 12:09:32 +09:00
  d707e29ff7
• Enforce IBeatmap.Breaks to be sorted chronologically
  Salman Ahmed · 2024-07-08 16:06:38 +03:00
  b33e54d064
• Revert "Change breaks list to IReadOnlyList"

  This reverts commit 2c3b411bb5.

  Dan Balasescu · 2024-07-02 12:16:11 +09:00
  04da1209f7
• Revert "Move break cloning back to non-virtual method"

  This reverts commit f69bc40a4b.

  Dan Balasescu · 2024-07-02 12:16:10 +09:00
  db84711214
• Move break cloning back to non-virtual method
  Dean Herbert · 2024-07-02 12:07:13 +09:00
  f69bc40a4b
• Change breaks list to IReadOnlyList
  Dean Herbert · 2024-07-02 11:59:24 +09:00
  2c3b411bb5
• Isolate bindable breaks list to EditorBeatmap
  Dean Herbert · 2024-07-02 11:31:55 +09:00
  005af280f2
• Fix ManiaModInvert permanently messing up the beatmap
  Dan Balasescu · 2024-07-01 15:02:00 +09:00
  f942595829
• Move CountdownOffset out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  dd50d6fa6e
• Move TimelineZoom out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  7f2a6f6f5a
• Move GridSize out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:15:00 +02:00
  6685c5ab74
• Move DistanceSpacing out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 14:14:58 +02:00
  3634307d7c
• Move SamplesMatchPlaybackRate out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:32:23 +02:00
  c216283bf4
• Move EpilepsyWarning out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:28:41 +02:00
  f64a0624a5
• Move WidescreenStoryboard out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:23:53 +02:00
  1ab86ebd24
• Move LetterboxInBreaks out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:18:44 +02:00
  a6b7600bf2
• Move SpecialStyle out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:12:30 +02:00
  011c2e3651
• Move StackLeniency out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:33 +02:00
  0a4560a03e
• Move AudioLeadIn out of BeatmapInfo
  Bartłomiej Dach · 2024-06-12 13:04:28 +02:00
  4339e2dc4a
• Preserve storyboard events when saving a beatmap in the editor

  Until we have full encoding support for storyboards, this stop-gap
  measure ensures that storyboards don't just disappear from existence.

  Dean Herbert · 2024-04-30 00:01:56 +08:00
  fd3f4a9e7b
• Fix control points not being cloned when running beatmap conversion

  Closes #20994.
  
  I haven't considered how this affects performance of difficulty
  calculation or otherwise. Seems like a sane initial fix which we can
  iterate on going forward.
  
  I've tested using the scenario in the linked issue.
  
  I'm not going to add test coverage because
  [BeatmapConversionTest](https://github.com/ppy/osu/blob/master/osu.Game/Tests/Beatmaps/BeatmapConversionTest.cs)
  should correctly cover this scenario once we are serialising control
  points as well.

  Dean Herbert · 2022-11-01 17:42:09 +09:00
  978d15955c
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Shallow clone BeatmapInfo during conversion process to avoid overwriting fields
  Dean Herbert · 2021-10-12 16:43:56 +09:00
  1373cc02d7
• Remove obsolete code
  smoogipoo · 2021-04-09 13:56:58 +09:00
  8293b06c0a
• Fix a couple of new inspections introduced in Rider EAPs
  Dean Herbert · 2021-03-15 13:35:08 +09:00
  6d4c1ba2ae
• Rework to support obsoletion
  smoogipoo · 2020-09-17 21:37:32 +09:00
  de5ef8a471
• Make beatmap conversion support cancellation tokens
  smoogipoo · 2020-09-17 17:40:05 +09:00
  c7d24203ce
• Fix potential out-of-order objects after conversion
  smoogipoo · 2020-07-13 16:52:05 +09:00
  1116703e92
• Merge branch 'master' into remove-legacy-id
  Dan Balasescu · 2019-12-25 21:01:12 +09:00
  9702cc9809
• Provide the ruleset to converter classes
  Dean Herbert · 2019-12-24 16:02:16 +09:00
  0677f746aa
• Simplify/improve beatmap conversion precheck
  smoogipoo · 2019-12-23 17:44:18 +09:00
  6e7426a098
• Turn on warnings, resolve issues
  smoogipoo · 2019-04-25 17:36:17 +09:00
  0bd35ab7bb
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Cleanups
  smoogipoo · 2018-10-17 10:53:21 +09:00
  d431dd59a8
• Fix beatmap conversion tests failing
  smoogipoo · 2018-10-16 12:01:58 +09:00
  41391a6627
• Simplify linq from beatmap conversion
  smoogipoo · 2018-10-11 20:29:37 +09:00
  fb1760f580
• Don't deep-clone beatmapinfo/control points
  smoogipoo · 2018-05-17 13:17:33 +09:00
  397d93660a
• Fix not being able to convert beatmaps with 0 hitobjects
  smoogipoo · 2018-05-07 15:27:45 +09:00
  30a3f4f29f
• Initial rework of beatmap conversion process
  smoogipoo · 2018-04-19 22:04:12 +09:00
  03a5df84c6
• Use IBeatmap wherever possible
  smoogipoo · 2018-04-19 20:44:38 +09:00
  66b3b295e7
• Make an interface for beatmaps
  smoogipoo · 2018-04-19 18:58:40 +09:00
  b5a55a0dce
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Move combo colours completely out of beatmap
  Dean Herbert · 2018-03-20 16:24:06 +09:00
  9a0fc9e29a
• Fix combo colours not working until now
  Dean Herbert · 2018-03-13 19:19:08 +09:00
  16eab2eebf
• Rename to IBeatmapConverter, move to separate file
  smoogipoo · 2018-03-02 20:19:47 +09:00
  a2c239d5e3
• Implement basic structure for beatmap conversion testing
  smoogipoo · 2018-03-02 13:13:00 +09:00
  797d03a65f