65490 Commits

This Branch

This Branch

All Branches

• Add test coverage of incorrect version on missing skin.ini
  Dean Herbert · 2023-09-27 16:50:01 +09:00
  84682b4227
• Merge pull request #24932 from smoogipoo/spinner-od-based-max-rpm

  Cap maximum spinner RPM based on OD

  Dean Herbert · 2023-09-27 15:56:27 +09:00
  0a208a5a47
• Merge pull request #24930 from peppy/adjust-mania-barlines

  Adjust osu!mania "major" barlines to be less visually distracting

  Bartłomiej Dach · 2023-09-26 19:39:22 +02:00
  e1d52134ae
• Merge pull request #24935 from bdach/fix-flaky-editor-beatmap-creation-test

  Fix flaky editor beatmap creation test

  Dean Herbert · 2023-09-27 01:09:01 +09:00
  b9c9cba6d5
• Fix flaky editor beatmap creation test

  Came up as a failure when locally running tests for
  ppy/osu-framework#6001 - but the test is actually a previously-known
  flaky that I couldn't reproduce the failure of until the aforementioned
  PR.
  
  This appears to be a simple race; the test scene queries the track
  length from update thread, but the length is actually set on the audio
  thread. So it's not unreasonable that given unlucky timing, the length
  will not be set by `TrackBass` before it is queried.
  
  To fix, switch assert to until step. I'm generally not really willing
  to give this more time of day until this change is proven insufficient.

  Bartłomiej Dach · 2023-09-26 16:42:59 +02:00
  12585c9f27
• Merge pull request #24779 from smoogipoo/split-legacy-scoring-attribs

  Split legacy scoring attribs into its own table

  Dean Herbert · 2023-09-26 22:35:38 +09:00
  9d8c3f0f5c
• Fix bonus requirement not considering number of normal ticks
  Dan Balasescu · 2023-09-26 18:11:27 +09:00
  05c9f0f9cc
• Fix incorrect change in taiko score simulator
  Dan Balasescu · 2023-09-26 17:46:03 +09:00
  19a442a32a
• Adjust new test scene to not be super broken
  Dean Herbert · 2023-09-26 17:30:49 +09:00
  40a548d372
• Cap maximum spinner RPM based on OD
  Dan Balasescu · 2023-09-26 17:20:20 +09:00
  859155dda1
• Merge pull request #24706 from frenzibyte/limit-gameplay-sprite-dimensions

  Add maximum dimensions limit to skinnable gameplay elements

  Dean Herbert · 2023-09-26 17:15:55 +09:00
  3b85a636b2
• Add minor edge smoothing to fix flickering of barlines

  In most cases.
  
  Closes https://github.com/ppy/osu/issues/15184.

  Dean Herbert · 2023-09-26 17:06:52 +09:00
  9949480ccd
• Adjust osu!mania "major" barlines to be less visually distracting

  Applies to both "triangles" and "argon" skins.

  Dean Herbert · 2023-09-26 17:06:27 +09:00
  5150c5a643
• Merge branch 'master' into limit-gameplay-sprite-dimensions
  Dean Herbert · 2023-09-26 16:40:32 +09:00
  990c54519b
• Rename test scene, add xmldoc and increase scale factor to something absurdly high
  Dean Herbert · 2023-09-26 16:39:36 +09:00
  b1561b650f
• Reduce delay before loading beatmap after selection change at song select

  This was originally set high because of performance concerns. We have
  since improved things quite drastically. Even with a very low debounce
  my song select is amazingly smooth.
  
  This is about as low as we can got unless we want chaos when key
  repeating left/right arrows (it's not as bad as you think, maybe worth
  testing during review and see if it feels more expected?).
  
  Of note, stable has key repeat disabled on left/right arrows and zero
  debounce.
  
  Addresses concerns in https://github.com/ppy/osu/discussions/24916.

  Dean Herbert · 2023-09-26 16:21:09 +09:00
  ae31a8fadf
• Merge branch 'master' into split-legacy-scoring-attribs
  Dean Herbert · 2023-09-26 15:52:27 +09:00
  0dcf7a2fa9
• Improve notification display when score import fails
  Dean Herbert · 2023-09-26 15:00:56 +09:00
  d1d82d2b49
• Ensure DrawableStoryboardSprite's texture size propagates corectly on skin change
  Dean Herbert · 2023-09-26 14:13:51 +09:00
  567bc8fcd3
• Merge branch 'master' into fix-storyboard-skin-textures-lookup
  Dean Herbert · 2023-09-26 14:05:27 +09:00
  2ca1c684bb
• Update osu! scoring tests to match updated formulae
  Bartłomiej Dach · 2023-09-25 19:16:31 +02:00
  72c61c3a6a
• Update classic scoring algorithm to closer match stable score V1
  Bartłomiej Dach · 2023-09-25 19:16:18 +02:00
  57c00e728b
• Improve Code Quality
  Fabian van Oeffelt · 2023-09-25 17:51:39 +02:00
  2040dcabe0
• Remove unused namepace
  Fabian van Oeffelt · 2023-09-25 16:56:34 +02:00
  2a3391d83b
• Fix SR/BPM Display in Playlist rooms
  Fabian van Oeffelt · 2023-09-25 16:53:40 +02:00
  59d3143645
• Fix multiple difficulty search queries not working in some cases.
  Pasi4K5 · 2023-09-25 13:38:47 +02:00
  74896fd6b2
• Add TestSceneDifficultySearch
  Pasi4K5 · 2023-09-25 12:53:17 +02:00
  ab57cbf6f5
• Add ability to search for difficulty names
  Pasi4K5 · 2023-09-25 12:52:49 +02:00
  793d1bf970
• Merge pull request #24897 from peppy/fix-oauth-refresh-no-connection

  Fix OAuth refresh attempt when no network available causing full logout

  Dan Balasescu · 2023-09-24 14:06:04 +09:00
  81130eacd1
• Fix OAuth refresh attempt when no network available causing full logout
  Dean Herbert · 2023-09-24 10:50:07 +09:00
  3c62521e69
• Merge pull request #24889 from Fabiano1337/master

  Fix game crash when using "Bubbles" mod on a beatmap with no hit circles

  Salman Ahmed · 2023-09-24 03:02:10 +03:00
  7d7fc09dbc
• Simplify code
  Salman Ahmed · 2023-09-24 02:22:50 +03:00
  734ee0e68b
• Get first Spinner,Slider or HitCircle instead of only HitCircle

  Fixes bug

  Fabian van Oeffelt · 2023-09-23 13:18:49 +02:00
  7c40072c47
• Add test scene
  Andrei Zavatski · 2023-09-23 06:31:26 +03:00
  292273edbe
• Update in line with framed clock changes
  Dean Herbert · 2023-09-22 22:02:18 +09:00
  d019cb5167
• Fix StopUsingBeatmapClock not transferring time and running state
  Dean Herbert · 2023-09-22 16:22:36 +09:00
  251a85db43
• Fix editor operating directly on track rather than decoupled clock
  Dean Herbert · 2023-09-22 16:22:36 +09:00
  faa0481fc6
• Update usages of GameplayClockContainer not using an adjustable source
  Dean Herbert · 2023-09-22 16:22:36 +09:00
  c40bd74138
• Update tests which were not using an IAdjustableClock as GameplayClockContainer source
  Dean Herbert · 2023-09-22 16:22:36 +09:00
  a3e4d19933
• Don't apply decoupling to SpectatorPlayerClocks

  See inline comment for reasoning. It's a bit complicated.

  Dean Herbert · 2023-09-22 16:22:35 +09:00
  8367bb6bee
• Fix FramedBeatmapClock's source not being processed
  Dean Herbert · 2023-09-22 16:22:35 +09:00
  6629a47ed3
• Add note about test not calling ProcessFrame
  Dean Herbert · 2023-09-22 16:22:35 +09:00
  3cb928fe6f
• Set source directly in FramedBeatmapClock ctor

  This isn't required, but avoids creating a temporary `StopwatchClock`
  and generally just makes debug easier with less state changes.

  Dean Herbert · 2023-09-22 16:22:35 +09:00
  bf08fbe196
• Fix souce clock not always being transferred to FramedBeatmapClock in time
  Dean Herbert · 2023-09-22 16:22:35 +09:00
  586311d508
• Add missing TestManualClock.Reset implementation for safe measure
  Dean Herbert · 2023-09-22 16:22:35 +09:00
  59d6e67512
• Add note about beatmap offset not being reapplied correctly on ChangeSource
  Dean Herbert · 2023-09-22 14:41:07 +09:00
  0200b63fd3
• Remove second hopefully-unnecessary workaround
  Dean Herbert · 2023-09-22 14:41:07 +09:00
  a1e298930c
• Remove hopefully-unnecessary workaround

  It was causing issues with the new implementation.

  Dean Herbert · 2023-09-22 14:41:05 +09:00
  a451ab75dd
• Disable decoupling for OsuGameBase's beatmap implementation

  This avoids it ever mutating the underlying track (aka attempting to start
  it). Resolves the one caveat mentioned in
  aeef92fa710648d4a00edc523e13c17ac6104125.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  df08c4e1ad
• Remove unnecessary encapsulation workaround

  The new implementation of `DecouplingClock` will not mutate the
  underlying clock in any way (unless attempting to start it when
  approaching from a negative time value).
  
  This should be quite safe as a result.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  5f634f2812