65490 Commits

This Branch

This Branch

All Branches

• Remove no longer used scoring difficulty attributes
  Bartłomiej Dach · 2023-10-16 12:36:58 +02:00
  f2436a5ecb
• Fix incorrect initial rotation transfer value

  Should have been removed as part of https://github.com/ppy/osu/pull/24360.

  Dean Herbert · 2023-10-16 19:34:55 +09:00
  0bb95cfa88
• Tidy up lastAngle usage and add assertion of maximum delta
  Dean Herbert · 2023-10-16 19:34:22 +09:00
  10bab61441
• Use ID rather than SoloScoreID

  The latter is apparently not going to be a thing anymore.

  Bartłomiej Dach · 2023-10-16 12:02:55 +02:00
  e2192806e4
• Change SpinFramesGenerator to take degrees as input
  Dean Herbert · 2023-10-16 18:34:56 +09:00
  04af46b8c7
• Add prospective test coverage of spinner input handling
  Dean Herbert · 2023-10-16 18:31:01 +09:00
  28ee99f132
• Add SpinFramesGenerator class to simplify creating spinner tests
  Dean Herbert · 2023-10-16 18:25:40 +09:00
  cfa4adb24d
• Rename RateAdjustedRotation to TotalRotation
  Dean Herbert · 2023-10-16 18:25:03 +09:00
  159b24acf7
• Allow watching replay from multi/playlist results screens
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  fb2293821a
• Preserve OnlineID when importing scores

  Previously, for lazer scores, the ID returned from `osu-web` was
  discarded and replaced with -1, due to the fact that the appropriate
  structures for unification with stable, as well as unification across
  solo and multiplayer, were not in place yet.
  
  Now we're at the point where scores from all the aforementioned sources
  receive a `solo_scores` DB row, and as such, we can start treating
  `solo_scores`-scheme IDs as canonical "online IDs" for a score.

  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  c4af8591a5
• Use solo score ID as OnlineID when converting from MultiplayerScore
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  d5a733d244
• Add LegacyOnlineID handling to places that definitely need it

  Mostly places that can interact with imported replays.
  
  There are other places that use the online ID as a sort tiebreaker, or
  to check presence of a score on results screens, but they should
  probably still continue to only use `OnlineID`, since all scores with a
  legacy online ID should have an online ID, but the converse is not
  generally true.

  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  b144cfd55c
• Encode/decode new OnlineID into/from LegacyReplaySoloScoreInfo
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  c53f4c144c
• Move legacy online ID encode/decode to legacy property
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  fa519984df
• Add failing test for legacy online ID decoding
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  bfcb4f4f2d
• Add LegacyOnlineID with backwards migration
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  c1a817fec6
• Fix large instantaneous delta on first frame

  Happens when the first update frame comes in before any mouse input.

  Dan Balasescu · 2023-10-16 18:17:11 +09:00
  84be714d6b
• Merge pull request #25139 from peppy/collection-ordering-fix

  Fix collections not being sorted alphabetically in context menus

  Bartłomiej Dach · 2023-10-16 10:53:43 +02:00
  9cd33d9bb2
• Merge pull request #25140 from peppy/manage-collections-drag-handles-bye-bye

  Remove drag handles from manage collections dialog for now

  Bartłomiej Dach · 2023-10-16 10:47:38 +02:00
  ee3ddacf46
• Merge pull request #25136 from peppy/fix-taiko-hp-bar-animation

  Fix health bar animating when it shouldn't be

  Bartłomiej Dach · 2023-10-16 10:30:17 +02:00
  38d92187af
• Reformat long lines
  Bartłomiej Dach · 2023-10-16 09:06:34 +02:00
  c48142816c
• Rename test step
  Bartłomiej Dach · 2023-10-16 09:04:53 +02:00
  624c05e0ff
• Fix collections not being sorted correctly in context menus
  Dean Herbert · 2023-10-16 16:03:12 +09:00
  7139592e43
• Remove mention of "any tick"

  They're very dead now.

  Bartłomiej Dach · 2023-10-16 08:57:35 +02:00
  b9a84127ac
• Fix test failure due to missing zero (and FP shenanigans)
  Bartłomiej Dach · 2023-10-16 08:53:56 +02:00
  db00b794a2
• Remove drag handles from manage collections dialog for now

  The realm implementation doesn't support this.

  Dean Herbert · 2023-10-16 15:51:18 +09:00
  36112302d6
• Fix code quality inspection (weird one)
  Dean Herbert · 2023-10-16 15:16:10 +09:00
  d9d0629157
• Rename PerfectBonusNote to NotePerfectBonus
  Dean Herbert · 2023-10-16 15:14:28 +09:00
  4f1546c474
• Fix legacy skin body piece dimming when it shouldn't
  Dean Herbert · 2023-10-16 15:11:33 +09:00
  3f09ed396f
• Add empty hit windows on PefectBonusNote
  Dean Herbert · 2023-10-16 14:58:49 +09:00
  1a957364ae
• Add DisplayResult flag and remove unnecessary AlwaysPresent
  Dean Herbert · 2023-10-16 14:57:58 +09:00
  43f619f92a
• Fix MissForcefully not considering the bonus object
  Dean Herbert · 2023-10-16 14:53:36 +09:00
  14fedffcc1
• Fix various tests
  Dean Herbert · 2023-10-16 14:21:33 +09:00
  7c49843411
• Adjust method flow to hopefully be more legible
  Dean Herbert · 2023-10-16 13:31:14 +09:00
  e85c039722
• Remove nullability of bonusNote
  Dean Herbert · 2023-10-16 13:14:58 +09:00
  ddbda69751
• Fix health bar animating when it shouldn't be

  It wasn't correctly checking the current underlying health, which could
  be zero in usages of `AccumulatingHealthProcessor`, for instance.
  
  Closes #25046.

  Dean Herbert · 2023-10-16 13:12:04 +09:00
  48832c64ac
• Merge pull request #25113 from nekodex/generic-error-sfx

  Use new `generic-error` sample in appropriate places

  Dean Herbert · 2023-10-14 04:35:12 +09:00
  54722bf251
• Merge branch 'master' into generic-error-sfx
  Dean Herbert · 2023-10-14 03:56:41 +09:00
  67a8a51ec7
• Merge pull request #25101 from peppy/fix-hr-cs-mania-adjustment

  Fix "Hard Rock" mod affecting CS/AR in osu!mania and osu!taiko

  Dean Herbert · 2023-10-14 03:56:24 +09:00
  3cb9945545
• Update resources
  Dean Herbert · 2023-10-14 03:48:59 +09:00
  d4627a2402
• Merge branch 'master' into fix-hr-cs-mania-adjustment
  Bartłomiej Dach · 2023-10-13 16:08:54 +02:00
  8a4c2624bd
• Merge pull request #25115 from bdach/fix-keybinding-test-failures

  Fix key binding panel test failures from introducing placeholder text

  Dean Herbert · 2023-10-13 22:50:58 +09:00
  c372f11013
• Fix key binding panel test failures from introducing placeholder text

  Whoops.

  Bartłomiej Dach · 2023-10-13 15:03:41 +02:00
  9b474b656d
• Merge pull request #25110 from peppy/limit-extra-elements

  Apply a few more object sizing limits

  Bartłomiej Dach · 2023-10-13 14:57:36 +02:00
  4e1d564d70
• Merge branch 'master' into fix-hr-cs-mania-adjustment
  Bartłomiej Dach · 2023-10-13 14:08:05 +02:00
  c762241268
• Use new generic-error sample in appropriate places
  Jamie Taylor · 2023-10-13 21:06:50 +09:00
  d97b618d02
• Remove approach rate adjustment from TaikoModHardRock

  Approach rate does nothing in taiko.

  Bartłomiej Dach · 2023-10-13 14:05:43 +02:00
  d656306692
• Merge pull request #25112 from bdach/dangerous-button-shades

  Fix dangerous buttons using different shades of pink

  Dean Herbert · 2023-10-13 20:43:24 +09:00
  3d5736188e
• Merge pull request #25106 from bdach/dimmed-placeholder-empty-binding

  Use dimmed placeholder text instead of empty box on cleared bindings

  Dean Herbert · 2023-10-13 20:43:02 +09:00
  7ac2a1721c
• Fix dangerous buttons using different shades of pink
  Bartłomiej Dach · 2023-10-13 13:16:24 +02:00
  af89d69fc4