780 Commits

• Annotate mods that give pp
  Bartłomiej Dach · 2024-01-31 14:59:35 +01:00
  f89923aeae
• Reintroduce IMod.Ranked

  What goes around, comes around.

  Bartłomiej Dach · 2024-01-31 14:48:35 +01:00
  e71c95f1fe
• Fix Cinema mod being compatible with mods that can force failure

  Addresses
  https://github.com/ppy/osu/pull/26080#issuecomment-1868833214.

  Bartłomiej Dach · 2024-01-08 22:34:41 +01:00
  aa83b84bb2
• Make ScoreProcessor.Rank read-only
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  705f25e4b9
• Expose Mod.UsesDefaultConfiguration
  Dan Balasescu · 2023-12-29 17:16:16 +09:00
  a6313c4ee8
• Make cinema mod incompatible with no fail
  Bartłomiej Dach · 2023-12-23 15:10:31 +01:00
  0cbf594a8c
• Change "cinema" mod to never fail

  Addresses https://github.com/ppy/osu/discussions/26032.

  Dean Herbert · 2023-12-23 21:12:47 +09:00
  15a9740eb6
• Revert change to ModSuddenDeath
  Dan Balasescu · 2023-12-22 16:43:17 +09:00
  5703546d71
• Fix perfect/sudden death not working on slider tails
  Dan Balasescu · 2023-12-22 14:02:25 +09:00
  ea778c6e0a
• Merge pull request #25934 from peppy/adjust-classic-mod-multiplier

  Adjust "classic" mod multiplier to 0.96x

  Dan Balasescu · 2023-12-20 17:11:09 +09:00
  188c463c9c
• Remove ModBlockFail

  Was only being used by `NoFail` now.

  Dean Herbert · 2023-12-20 14:50:45 +09:00
  14d2d0d215
• Adjust "classic" mod multiplier to 0.96x

  Following discussions on discord, this seems like the most agreed upon
  value. Increasing this is important so that imported legacy scores don't
  lose too much value.

  Dean Herbert · 2023-12-20 14:33:14 +09:00
  d7603e8021
• Allow Relax to fail and remove failable mod exclusions

  Allows the Relax mod to fail, and remove NF/PF/SD mod exclusion
  
  ref: https://github.com/ppy/osu/discussions/13229

  rushiiMachine · 2023-12-19 12:33:00 -08:00
  1b004dbebc
• Fix keyboard precision of nightcore/daycore adjustments being incorrect

  Closes https://github.com/ppy/osu/issues/25854.

  Dean Herbert · 2023-12-19 01:07:33 +09:00
  374425ea75
• Change osu ruleset to use new HP algorithm by default
  Dan Balasescu · 2023-12-17 19:33:04 +09:00
  4b9aefa6f2
• Add IApplicableHealthProcessor
  Dan Balasescu · 2023-12-17 19:27:03 +09:00
  d7aca2f641
• Merge pull request #25744 from peppy/adjust-mod-multipliers

  Adjust some mod multipliers for initial leaderboard sanity

  Dan Balasescu · 2023-12-13 17:56:13 +09:00
  8c7570525a
• Update HT mod multiplier to match stable better
  Dean Herbert · 2023-12-13 15:53:39 +09:00
  4983845041
• Adjust some mod multipliers for initial leaderboard sanity
  Dean Herbert · 2023-12-13 14:31:19 +09:00
  996bc659e4
• Apply Bindable.Parse refactorings
  Dean Herbert · 2023-12-13 14:07:38 +09:00
  0be6743e87
• Adjust with framework changes
  Dan Balasescu · 2023-12-04 08:51:21 +09:00
  b56a78c6ec
• Fix touch device mod declared valid for multiplayer

  Mostly matters for web, so that it doesn't permit creation of playlist
  items with touch device inside.

  Bartłomiej Dach · 2023-11-14 16:30:10 +09:00
  69c2c0e427
• Use placeholder mod icon for touch device
  Bartłomiej Dach · 2023-11-06 10:14:56 +01:00
  204cd541e2
• Declare Touch Device incompatible with Autopilot

  With Autopilot active, Touch Device no longer matters.

  Bartłomiej Dach · 2023-11-02 22:57:05 +01:00
  8e9006b5d5
• Do not attempt to turn on Touch Device in song select with autoplay active
  Bartłomiej Dach · 2023-11-02 22:56:43 +01:00
  8784dd42c0
• Automatically activate and deactivate touch device mod in song select
  Bartłomiej Dach · 2023-11-02 19:45:48 +01:00
  2f6ff893b5
• Mark ModTouchDevice as always valid for submission
  Bartłomiej Dach · 2023-11-02 19:25:57 +01:00
  68efb3c110
• Generalise notion of 'touch device' mod
  Bartłomiej Dach · 2023-11-02 19:14:05 +01:00
  9f11a04cc7
• Seal a few more multiplayer playability flags of rate-changing mods

  Not really changing anything, just tightening things down to curb
  possible funny business.

  Bartłomiej Dach · 2023-10-31 16:20:33 +01:00
  a90f8dd4f6
• Seal UnknownMod

  Not a class for extension.

  Bartłomiej Dach · 2023-10-31 16:18:09 +01:00
  955e2ed051
• Mark ModScoreV2 as invalid for multiplayer

  Doesn't do much for the client; mostly a safety for osu-web's sake,
  as without the change it could theoretically fail to validate the mod
  properly in multiplayer contexts.

  Bartłomiej Dach · 2023-10-31 16:16:59 +01:00
  a644c75957
• Seal ModScoreV2

  Nobody should ever need to extend it.

  Bartłomiej Dach · 2023-10-31 16:16:14 +01:00
  456f4ebba2
• Seal ModAutoplay playability flags

  Can't do much more than that due to the unfortunate fact of Cinema
  inheriting from Autoplay.

  Bartłomiej Dach · 2023-10-31 16:15:10 +01:00
  3a2645efb1
• Add xmldoc to Mod playability flags
  Bartłomiej Dach · 2023-10-31 16:13:44 +01:00
  7ea298a1b6
• Add inline commentary in Mod{Day,Night}core about different speed adjustments
  Bartłomiej Dach · 2023-10-18 12:27:16 +02:00
  cff69d63a6
• Take in IBindables and tidy up multiplier handling
  Dean Herbert · 2023-10-18 17:39:13 +09:00
  9907adc337
• Move audio adjustment hookup to own method for clarity
  Dean Herbert · 2023-10-18 17:38:11 +09:00
  161890292f
• Also share ScoreMultiplier implementation
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  e56ff33271
• Split common functionality from rate adjust mods into helper class
  Dean Herbert · 2023-10-18 17:23:50 +09:00
  43238b0cee
• Merge branch 'master' into pitch_change
  Dean Herbert · 2023-10-18 16:33:03 +09:00
  eabfcfbf2a
• Fix "Hard Rock" mod affecting CS/AR in osu!mania

  Closes https://github.com/ppy/osu/issues/25090.
  
  Not sure if there are other exceptions we should account for here.

  Dean Herbert · 2023-10-12 19:48:47 +09:00
  3849b11644
• Merge branch 'master' into mods-stable-ordering
  Bartłomiej Dach · 2023-09-28 18:30:56 +02:00
  8215c4cb0e
• Include mention of what to do when not using field in xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2023-09-28 22:10:30 +09:00
  e0e222c1fa
• Display mod icons using stable ordering

  In discussion with nanaya, we likely want this now that we're adding the
  ability for some icons to be extended. Historically mod icons have been
  displayed in a stable but arbitrary order (based on their position in
  the `Mods` enum).
  
  This change aims to make them stable across lazer scores (where they are
  stored based on .. the order the user selected them).

  Dean Herbert · 2023-09-28 16:48:09 +09:00
  7d74d84e6c
• Add basic structure and test coverage for extended info on mod icon
  Dean Herbert · 2023-09-27 19:29:03 +09:00
  16e752e07d
• Fix rate adjust mods not showing "x" prefix on customisation slider's tooltip
  Dean Herbert · 2023-09-13 16:43:48 +09:00
  d146da9546
• Fix too many things being exposed
  Bartłomiej Dach · 2023-09-07 08:11:04 +02:00
  9c6f77b26e
• Inline local control
  Dean Herbert · 2023-09-07 14:22:06 +09:00
  e05d7d5f8d
• Fix code quality issues
  Dean Herbert · 2023-09-07 14:19:19 +09:00
  d2a6235135
• adds new diffsetting control that shows millisecond values for approach rate override
  isakvik · 2023-09-07 01:41:22 +02:00
  2ab11ab568