484 Commits

• Update R# + fix inspections
  Dan Balasescu · 2024-02-02 21:00:28 +09:00
  b44f77cee1
• Prevent custom divisor ranges from halting preset cycling

  A custom divisor like 24 or 32 will result in a range containing
  many divisors that are already in the `Common` and `Triplets` presets.
  When this happens, it can become impossible to cycle between presets,
  because the preset can only be changed if the new divisor isn't already
  contained within the current preset's range.

  Mike Will · 2024-01-24 18:31:39 -05:00
  9e1c242713
• Rename test method slightly
  Dean Herbert · 2024-01-17 19:53:23 +09:00
  1af5d1434c
• Fix android build CI failing

  No idea why this is only in android, but okay.

  Salman Ahmed · 2024-01-17 08:53:28 +03:00
  05729706eb
• Add failing test case
  Salman Ahmed · 2024-01-17 08:15:01 +03:00
  f11682d44f
• Few new rider inspection
  Dean Herbert · 2024-01-04 16:39:50 +09:00
  b1813b17a2
• Add test coverage of failure case
  Bartłomiej Dach · 2023-12-29 10:36:53 +01:00
  9bb0663b3b
• Add test coverage and refactor to better handle equality edge case
  Dean Herbert · 2023-12-26 21:21:08 +09:00
  03e2463b06
• Fix editor test not waiting for editor to load
  Dan Balasescu · 2023-12-13 13:15:49 +09:00
  8977e74171
• Apply NRT to ButtonSystem
  Dean Herbert · 2023-11-24 13:18:17 +09:00
  7e59a1d0be
• Attempt to fix intermittent failures on new tests

  See https://github.com/ppy/osu/pull/25418/checks?check_run_id=18886372597.

  Dean Herbert · 2023-11-22 21:46:35 +09:00
  aa8dc6bd80
• Merge pull request #25520 from peppy/context-menu-spacers

  Allow context menus to have visible spacers

  Dean Herbert · 2023-11-21 16:56:36 +09:00
  21bf288277
• Merge pull request #25409 from Tom94/bspline-sliders

  Add free-hand drawing of sliders to the editor

  Bartłomiej Dach · 2023-11-21 16:28:14 +09:00
  bf972a04ee
• Merge pull request #25371 from RatinFX/open-editor-timestamp

  Implement opening editor timestamp links

  Bartłomiej Dach · 2023-11-21 15:48:36 +09:00
  d83b2e24e7
• Adjust localisablel strings and keys
  Dean Herbert · 2023-11-21 15:08:15 +09:00
  917a68eac3
• Reorder and simplify private helper methods
  Dean Herbert · 2023-11-21 15:05:51 +09:00
  3afaafb1d9
• Allow context menus to have visible spacers
  Dean Herbert · 2023-11-21 14:24:10 +09:00
  405ab499e9
• Fix tests
  Bartłomiej Dach · 2023-11-20 21:57:14 +09:00
  c16afeb347
• Merge branch 'master' into bspline-sliders
  Bartłomiej Dach · 2023-11-20 12:03:29 +09:00
  b6e3e42445
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Rename diagonal scale variable and update xmldoc
  Dean Herbert · 2023-11-10 17:55:02 +09:00
  35e11c7c63
• Fix compose select box test failures
  Bartłomiej Dach · 2023-11-10 16:08:45 +09:00
  8690b08769
• Separate Test cases by relevant rulesets
  ratinfx · 2023-11-07 13:02:46 +01:00
  81caa854e6
• HitObject Selection logic and separation for gamemodes

  + moved time_regex into EditorTimestampParser

  ratinfx · 2023-11-07 01:36:58 +01:00
  aa87e0a44d
• Removed nullable line from Test
  ratinfx · 2023-11-07 00:54:15 +01:00
  8e8a88cfaf
• Moved error checks into Editor

  - Invoke Action on error to Notify user
  - added some comments

  ratinfx · 2023-11-04 21:17:58 +01:00
  7492d953ae
• Fixed up tests
  ratinfx · 2023-11-04 12:04:58 +01:00
  19cdf99df8
• Added OpenEditorTimestamp Tests
  ratinfx · 2023-11-04 03:42:08 +01:00
  f867cff8c7
• Fix failing tests
  Dean Herbert · 2023-10-30 18:06:11 +09:00
  63e6eaf538
• Add test coverage of failing context menu display
  Dean Herbert · 2023-10-30 18:06:11 +09:00
  6be02966b9
• Fix editor not prompting before saving beatmap for export
  Dean Herbert · 2023-10-25 14:39:46 +09:00
  6934e045df
• Remove DistancedHitObjectComposer inheritance from osu! composer
  Bartłomiej Dach · 2023-10-19 11:46:30 +02:00
  dcfd6a0a8a
• Fix various other inspections
  Dean Herbert · 2023-10-17 17:48:51 +09:00
  e081fa48a2
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Fix incorrect test assumption in TestSceneEditorClock

  I don't know what this test was trying to do, but it was wrong. Any
  offset which is applied should be invisible to the clock's final
  `CurrentTime` (and to the user).

  Dean Herbert · 2023-10-06 16:43:28 +09:00
  1005b7ac85
• Fix flaky editor beatmap creation test

  Came up as a failure when locally running tests for
  ppy/osu-framework#6001 - but the test is actually a previously-known
  flaky that I couldn't reproduce the failure of until the aforementioned
  PR.
  
  This appears to be a simple race; the test scene queries the track
  length from update thread, but the length is actually set on the audio
  thread. So it's not unreasonable that given unlucky timing, the length
  will not be set by `TrackBass` before it is queried.
  
  To fix, switch assert to until step. I'm generally not really willing
  to give this more time of day until this change is proven insufficient.

  Bartłomiej Dach · 2023-09-26 16:42:59 +02:00
  12585c9f27
• Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity
  Dean Herbert · 2023-09-06 19:01:08 +09:00
  1a37543d28
• Fix test failures via test-local popover containers
  Bartłomiej Dach · 2023-08-19 15:08:30 +02:00
  3d52a1267e
• Remove flaky test documentation for fixed test
  Dean Herbert · 2023-08-16 14:30:10 +09:00
  a8824c8c8a
• Add test case covering exit block

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Bartłomiej Dach · 2023-08-08 22:06:49 +02:00
  d91798271d
• Interface with SelectionRotationHandler via DI rather than explicit passing
  Bartłomiej Dach · 2023-07-30 20:21:41 +02:00
  ebe5dd2ac9
• Make SelectionRotationHandler a Component
  Bartłomiej Dach · 2023-07-30 20:18:33 +02:00
  262f25dce8
• Merge branch 'master' into selection-operations-refactor
  Bartłomiej Dach · 2023-07-30 19:29:06 +02:00
  821cd08f34
• Adjust cyclic selection test to hitcircle lifetime adjustments

  As it turns out, the tightening of hitcircle lifetimes in editor caused
  the test to fail, since the objects were too far apart and at the
  starting time of the test, the first object was fully faded out and as
  such not alive, therefore leading cyclic selection to fail to select it.
  
  To fix, bring all three objects closer together time-wise so that this
  does not happen and the test can continue to exercise its original
  behaviour.

  Bartłomiej Dach · 2023-07-25 18:54:13 +02:00
  d75e6f78d6
• Migrate test to SelectionRotationHandler
  Bartłomiej Dach · 2023-07-23 20:56:22 +02:00
  21df0e2d60
• Adjust failing test after metrics changes
  Bartłomiej Dach · 2023-07-21 19:08:40 +02:00
  2ef843261b
• Merge branch 'master' into editor-metrics
  Dean Herbert · 2023-07-21 14:26:32 +09:00
  ca3d1538ae
• Add test coverage of double click behaviour
  Bartłomiej Dach · 2023-07-20 20:51:17 +02:00
  48024cd17f
• Fix test step descriptions
  Bartłomiej Dach · 2023-07-20 20:47:33 +02:00
  f60a6e9893
• Apply NRT to TestSceneComposerSelection
  Dean Herbert · 2023-07-19 17:22:25 +09:00
  94c5b8ed32