65988 Commits

This Branch

This Branch

All Branches

• Merge pull request #27390 from peppy/cutoff-fix

  Fix low pass filter getting stuck in multiple locations

  Bartłomiej Dach · 2024-02-26 16:19:16 +01:00
  ab90b756e7
• Apply safeties for AudioFilter usage around drawables which go non-present
  Dean Herbert · 2024-02-26 21:22:25 +08:00
  c686dfd361
• Expose AudioFilter.IsAttached publicly
  Dean Herbert · 2024-02-26 21:15:44 +08:00
  7a96cf1289
• Merge pull request #27234 from brandondong/delete_none_message

  Add feedback to delete button even when no-op

  Bartłomiej Dach · 2024-02-26 13:13:53 +01:00
  09b420a083
• Merge pull request #27389 from peppy/menu-hotkeys

  Allow better menu navigation using same hotkey to progress to destination

  Bartłomiej Dach · 2024-02-26 12:31:22 +01:00
  119a373285
• Merge pull request #27386 from peppy/fix-use-current-distance-snap

  Fix "Use current" snap not working

  Bartłomiej Dach · 2024-02-26 12:30:35 +01:00
  46ec477191
• Merge pull request #26181 from rushiiMachine/flashlight-playfield-based-size-

  Make flashlight scale with playfield

  Dean Herbert · 2024-02-26 19:18:40 +08:00
  588e510363
• Add test coverage
  Bartłomiej Dach · 2024-02-26 11:59:57 +01:00
  8966ea2fa3
• Merge branch 'master' into flashlight-playfield-based-size-
  Bartłomiej Dach · 2024-02-26 10:55:06 +01:00
  353485a707
• Assert proportional scaling rather than assume average

  Because if scaling is ever actually non-proportional then this should be
  somewhat loud.
  
  Also use the absolute value to prevent funny things happening if/when
  someone does negative scale.

  Bartłomiej Dach · 2024-02-26 10:53:04 +01:00
  115d82664b
• Allow better menu navigation using same hotkey to progress to destination

  As touched on in https://github.com/ppy/osu/discussions/27102.
  
  You can now use:
  
  - `L L L` to get to playlists
  - `M M M` to get to multiplayer
  - `S` to get to settings

  Dean Herbert · 2024-02-26 17:24:04 +08:00
  8962be2ed5
• Fix inspections
  Dean Herbert · 2024-02-26 15:45:29 +08:00
  9a46e738bd
• Fix "Use current" snap not working

  Regressed with https://github.com/ppy/osu/pull/27249.
  
  I was suspicious of this specific operation at the time but didn't test properly.

  Dean Herbert · 2024-02-26 14:11:54 +08:00
  4c744ccb69
• Merge pull request #27379 from EVAST9919/gameplay-alloc

  Further reduce allocations during gameplay

  Dean Herbert · 2024-02-26 09:55:28 +08:00
  b0c45c87c6
• Add local function to perform iteration to better explain the "why"
  Dean Herbert · 2024-02-26 09:04:39 +08:00
  4421ff975b
• Remove unused using
  Andrei Zavatski · 2024-02-25 19:05:40 +03:00
  9e3defebda
• Reduce allocations in HitObjectLifetimeEntry
  Andrei Zavatski · 2024-02-25 18:02:42 +03:00
  c3fa97d062
• Fix HUDOverlay allocations
  Andrei Zavatski · 2024-02-25 17:59:20 +03:00
  f948f8ee5c
• Merge pull request #27364 from EVAST9919/spinner-alloc

  Reduce osu spinner allocations

  Dean Herbert · 2024-02-25 09:36:02 +08:00
  e8d2abc4f7
• Reset lastRecord on resetState for good measure
  Dean Herbert · 2024-02-25 08:18:19 +08:00
  e12f8c03ee
• Store last enqueued RotationRecord in SpinnerSpmCalculator
  Andrei Zavatski · 2024-02-24 20:36:06 +03:00
  9e90f7fb0d
• Reduce allocations in DrawableSpinner
  Andrei Zavatski · 2024-02-24 20:18:30 +03:00
  1fb19e7129
• Merge pull request #27359 from EVAST9919/spinner-stutter

  Fix `Argon` and `Triangles` spinner freeze at low replay speed

  Dean Herbert · 2024-02-25 00:42:09 +08:00
  5e7f0bd94f
• Merge branch 'master' into spinner-stutter
  Dean Herbert · 2024-02-25 00:13:48 +08:00
  a3429986bc
• Simplify implementation
  Dean Herbert · 2024-02-25 00:12:20 +08:00
  824d671cce
• Merge pull request #27144 from cdwcgt/allow-muted-ranked

  Allow pp for muted mod for any combination of settings

  Dan Balasescu · 2024-02-25 00:31:37 +09:00
  006416057b
• Completely remove transform flow for spm counter
  Andrei Zavatski · 2024-02-24 17:09:49 +03:00
  2696620d12
• Remove repeated TimeStarted check
  Andrei Zavatski · 2024-02-24 16:42:44 +03:00
  4bba0eaf4b
• Fix incorrect operator
  Andrei Zavatski · 2024-02-24 16:41:53 +03:00
  9b526912e9
• Merge pull request #27357 from EVAST9919/smoke-alloc

  Reduce allocations in `SmokeSegment`

  Dean Herbert · 2024-02-24 19:23:50 +08:00
  28917446ab
• Fix Argon and Trianles spinner stutter
  Andrei Zavatski · 2024-02-24 14:22:34 +03:00
  e7d8ca3292
• Merge pull request #27344 from bdach/editor-combo-colours-rotate

  Fix editor displaying combo colours in effectively incorrect order

  Dean Herbert · 2024-02-24 10:44:02 +08:00
  05f0b4796c
• Merge pull request #27336 from peppy/realm-collection-filter-optimise

  Improve search performance at song select when a collection is selected

  Salman Ahmed · 2024-02-24 03:18:52 +03:00
  c93965ab7e
• Merge branch 'master' into realm-collection-filter-optimise
  Salman Ahmed · 2024-02-24 01:19:30 +03:00
  247eac806a
• Reduce smoke allocations
  Andrei Zavatski · 2024-02-23 18:21:11 +03:00
  31dabaefaa
• Use hashset for faster lookup
  Bartłomiej Dach · 2024-02-23 15:38:52 +01:00
  869f0a82de
• Enable NRT in EditorBeatmapSkin
  Bartłomiej Dach · 2024-02-23 14:52:44 +01:00
  f86b7f0702
• Fix editor displaying combo colours in effectively incorrect order

  Addresses https://github.com/ppy/osu/discussions/27316.
  
  Stable lies about the first combo colour being first; in the `.osu`
  file it is actually second. It does a thing in editor itself to correct
  for this.
  
      https://github.com/peppy/osu-stable-reference/blob/master/osu!/GameModes/Edit/Forms/SongSetup.cs#L233-L234

  Bartłomiej Dach · 2024-02-23 14:49:46 +01:00
  d1d32fc16c
• Merge pull request #27320 from frenzibyte/adjust-old-style-spinner

  Fix old-style legacy spinner fade-in not matching stable

  Dean Herbert · 2024-02-23 12:20:40 +08:00
  d544b4dbf1
• Materialise realm collection hashes during song select search process

  Without this, there's a large overhead to do a realm-live `Contains`
  search when a collection is selected.
  
  This may also help considerably alleviate
  https://github.com/ppy/osu/discussions/27298#discussioncomment-8552508
  as we will be performing the native realm search much less.

  Dean Herbert · 2024-02-23 11:41:27 +08:00
  157819c199
• Update delete collections message when none
  Brandon · 2024-02-22 19:40:02 -08:00
  6c8204f9a3
• Update delete/restore mod presets message when none
  Brandon · 2024-02-22 19:10:15 -08:00
  d6beae2ce1
• Merge branch 'master' into delete_none_message
  Brandon · 2024-02-22 17:37:26 -08:00
  01d0ad506d
• Merge pull request #27329 from SupDos/add-missing-extension-ios

  Add missing .olz association to iOS

  Dean Herbert · 2024-02-23 02:36:18 +08:00
  7cbfd4400e
• Add missing .olz association to iOS
  SupDos · 2024-02-22 18:54:28 +01:00
  e1ceb8a5fa
• Merge pull request #27324 from bdach/github-actions-bump

  Update github actions to resolve most node deprecation warnings

  Dan Balasescu · 2024-02-23 02:26:16 +09:00
  083892e753
• Update github actions to resolve most node deprecation warnings

  As is github tradition, workflows started yelling about running on a
  node version that was getting sunset, so here we go again.
  
  Relevant bumps:
  
  - https://github.com/actions/checkout/releases/tag/v4.0.0
  - https://github.com/actions/setup-dotnet/releases/tag/v4.0.0
  - https://github.com/actions/cache/releases/tag/v4.0.0
  - https://github.com/actions/setup-java/releases/tag/v4.0.0
  - https://github.com/peter-evans/create-pull-request/releases/tag/v6.0.0
  - https://github.com/dorny/test-reporter/releases/tag/v1.8.0
  
  Notably, `actions/upload-artifact` is _not_ bumped to v4, although it
  should be to resolve the node deprecation warnings, because it has more
  breaking changes and bumping would break `dorny/test-reporter`
  (see https://github.com/dorny/test-reporter/issues/363).

  Bartłomiej Dach · 2024-02-22 17:18:10 +01:00
  99bbbf810b
• Merge branch 'master' into adjust-old-style-spinner
  Salman Ahmed · 2024-02-22 16:43:44 +03:00
  af6ed85880
• Merge pull request #26149 from rushiiMachine/fix-skin-editor-init-fail

  Fix `SkinEditorOverlay` freezing when `ReplayPlayer` screen exits early

  Bartłomiej Dach · 2024-02-22 14:36:35 +01:00
  9018579ecd
• Fix old-style legacy spinner fade in not matching stable
  Salman Ahmed · 2024-02-22 16:31:13 +03:00
  bbf3f6b56c