42033 Commits

This Branch

This Branch

All Branches

• Add playlist count pill
  smoogipoo · 2021-07-12 15:11:53 +09:00
  a8cbffa57e
• Split pill display into abstract class
  smoogipoo · 2021-07-12 15:11:10 +09:00
  185e36bf97
• Adjust some layout
  smoogipoo · 2021-07-12 14:07:21 +09:00
  b4b0b862ef
• Merge branch 'master' into lounge-redesign
  smoogipoo · 2021-07-12 13:54:42 +09:00
  ac26374a93
• Merge pull request #13824 from peppy/da-mod-refactor

  Refactor `ModDifficultyAdjust` to more elegantly track user override status

  Dan Balasescu · 2021-07-12 12:03:45 +09:00
  0c52b26d23
• Merge pull request #13839 from peppy/fix-migration-test-failure

  Fix migration target having left over files potentially causing test failures

  Dan Balasescu · 2021-07-12 11:47:18 +09:00
  ffa60479c9
• Make CurrentNumber internal
  Dean Herbert · 2021-07-12 11:26:30 +09:00
  a6258d705e
• Do not store direct references to original bindable

  `DifficultyAdjustSettingsControl` and its inner `SliderControl` were
  holding different references to `DifficultyBindable`s from the
  difficulty adjust mod, therefore leading to bindings being lost to the
  framework-side automatic unbind logic if the mod was toggled off and
  back on in rapid succession.
  
  Resolve by adding a shadowed implementation of `GetBoundCopy()` and
  using it to isolate the controls from the mod bindable.

  Bartłomiej Dach · 2021-07-11 15:28:13 +02:00
  32b4f5fbd6
• Merge pull request #13853 from frenzibyte/disallow-custom-ruleset-score-submission

  Disallow custom rulesets from attempting to submit scores

  Dean Herbert · 2021-07-11 15:21:38 +09:00
  e0b2356bb0
• Add missing osu!catch difficulty adjust attributes
  Dean Herbert · 2021-07-11 10:14:42 +09:00
  79d546afa2
• Update player test scene Ruleset bindable from creation method
  Salman Ahmed · 2021-07-11 03:46:19 +03:00
  f21ea3b790
• Add test coverage for excluded cases in score submission
  Salman Ahmed · 2021-07-11 03:35:35 +03:00
  6b8de2a10b
• Disallow custom rulesets from score submission
  Salman Ahmed · 2021-07-11 03:34:57 +03:00
  07ede7a147
• Merge pull request #13840 from peppy/fix-run-from-screen-test-failures

  Ensure run-from-screen song select reaches correct point in execution

  Bartłomiej Dach · 2021-07-10 14:13:21 +02:00
  236e8019cc
• Merge branch 'master' into fix-run-from-screen-test-failures
  Bartłomiej Dach · 2021-07-10 13:37:20 +02:00
  08cd17435c
• Merge pull request #13838 from peppy/fix-access-denied-test-failures

  Fix test failures due to logger pollution

  Bartłomiej Dach · 2021-07-10 13:36:33 +02:00
  94406d77de
• Merge branch 'master' into fix-access-denied-test-failures
  Bartłomiej Dach · 2021-07-10 13:00:27 +02:00
  1bd5b1a8b9
• Merge pull request #13828 from ekrctb/catch-editor-selection-confine

  Don't move selected objects outside the playfield in catch editor

  Dean Herbert · 2021-07-10 19:30:32 +09:00
  c64fe06bf6
• Update test to match expectations after refactor
  Bartłomiej Dach · 2021-07-10 11:44:32 +02:00
  b705213ea9
• Merge branch 'master' into da-mod-refactor
  Bartłomiej Dach · 2021-07-10 11:41:54 +02:00
  6f89f8e572
• Invert strangely negated condition
  Bartłomiej Dach · 2021-07-10 11:23:38 +02:00
  c5011865fc
• Fix up English in comment
  Bartłomiej Dach · 2021-07-10 11:22:54 +02:00
  494089e402
• Merge pull request #13841 from peppy/update-song-progress-keyboard-handling

  Move handling of replay seek operations out of progress bar

  Bartłomiej Dach · 2021-07-10 11:17:40 +02:00
  e8005e3bfb
• Remove previous seek testing logic from common test scene
  Dean Herbert · 2021-07-09 16:52:03 +09:00
  6ae631b03a
• Modify comment
  ekrctb · 2021-07-09 15:13:54 +09:00
  995ef953c6
• Add test coverage of seeking and pausing
  Dean Herbert · 2021-07-09 14:47:11 +09:00
  9083b28114
• Move handling of replay seek operations out of progress bar

  This is in order to avoid using the now obsoleted property
  `SliderBar.AllowKeyboardInputWhenNotHovered`
  (see https://github.com/ppy/osu-framework/pull/4579).

  Dean Herbert · 2021-07-09 14:28:59 +09:00
  6a5f0e8237
• Simplify bindable update methods
  Dean Herbert · 2021-07-09 13:58:44 +09:00
  741062a6da
• Refactor DifficultyAdjustSettingsControl to help with readability
  Dean Herbert · 2021-07-09 13:50:07 +09:00
  e0277763d0
• Update override matching test to match expectations
  Dean Herbert · 2021-07-09 13:30:14 +09:00
  51bd83b3f4
• Allow null values for ReadCurrentFromDifficulty

  As long as this isn't a constructor parameter it feels best to
  gracefully handle omission. Realistically having it in the ctor is the
  best move, but it doesn't feel great in line with the other parameters
  passed in via object initalisers.

  Dean Herbert · 2021-07-09 13:26:01 +09:00
  f9cd7f10d8
• Standardise variables
  Dean Herbert · 2021-07-09 13:24:26 +09:00
  90326f8864
• Fix storage wrapping logic setting logger too early in startup sequence
  Dean Herbert · 2021-07-09 13:18:49 +09:00
  df4bd86cfc
• Fix storage wrapping logic setting logger too early in startup sequence
  Dean Herbert · 2021-07-09 13:17:25 +09:00
  f3b68a4fbf
• Expand the selection movement limiting code with detailed comments
  ekrctb · 2021-07-09 12:58:08 +09:00
  7e14679606
• Ensure run-from-screen song select reaches correct point in execution

  Fixes issues as seen at
  https://github.com/ppy/osu/runs/3023581865?check_suite_focus=true. Song
  select may take a few frames to perform initial selection as there is a
  bit of internal async logic. This ensures that the beatmap has been
  updated before continuing with test execution.

  Dean Herbert · 2021-07-09 12:36:56 +09:00
  9786e1a932
• Fix migration target having left over files potentially causing test failures

  As seen at
  https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050324.

  Dean Herbert · 2021-07-09 12:21:25 +09:00
  887035c12e
• Fix test failures due to logger pollution

  As seen at
  https://github.com/ppy/osu/pull/13831/checks?check_run_id=3025050307. I
  can't confirm that this will fix the issue but it looks like the only
  plausible reason. I have confirmed that the logging is not coming from
  the local (first logging is guaranteed to be after `SetupForRun`).

  Dean Herbert · 2021-07-09 12:15:30 +09:00
  9f7c6adb58
• Merge pull request #13831 from nekodex/add-dropdown-sound-to-profile

  Change profile section expansion button to use dropdown sounds

  Dean Herbert · 2021-07-09 11:58:48 +09:00
  dbfeea9880
• Rename function to be more accurate
  Jamie Taylor · 2021-07-09 11:16:47 +09:00
  2eb12a59b7
• Merge pull request #13827 from peppy/fix-mod-select-cross-talk

  Fix cross talk between `ModSelectOverlay`s

  Bartłomiej Dach · 2021-07-08 20:31:55 +02:00
  bd3f8b78cc
• Merge branch 'master' into fix-mod-select-cross-talk
  Bartłomiej Dach · 2021-07-08 19:53:50 +02:00
  3e21eeb7c2
• Merge pull request #13830 from nekodex/volume-control-switching-sound

  Add sound for switching between volume controls

  Dean Herbert · 2021-07-09 01:03:36 +09:00
  1c7854b846
• Rename control class to be more descriptive
  Dean Herbert · 2021-07-08 20:37:38 +09:00
  b7803b889e
• Avoid double playback of sample
  Jamie Taylor · 2021-07-08 20:36:25 +09:00
  8746ef0ba9
• Change profile section expansion to use dropdown sounds
  Jamie Taylor · 2021-07-08 20:23:11 +09:00
  546f55d341
• Add sound for switching between volume controls
  Jamie Taylor · 2021-07-08 20:01:39 +09:00
  93eb385dd4
• Don't move selected objects outside the playfield in catch editor
  ekrctb · 2021-07-08 18:49:32 +09:00
  c937c45360
• Add test coverage
  Dean Herbert · 2021-07-08 18:29:54 +09:00
  7153983dd4
• Fix cross talk between ModSelectOverlays
  Dean Herbert · 2021-07-08 17:59:04 +09:00
  af270cccc4