1
0
mirror of https://github.com/ppy/osu.git synced 2024-09-23 12:07:25 +08:00
Commit Graph

42033 Commits

Author SHA1 Message Date
Dean Herbert
35d4b12a4f Remove single local usage of AllSources 2021-07-07 13:52:52 +09:00
Dean Herbert
eb8b14a931 Reorder methods to make more sense 2021-07-07 13:51:51 +09:00
Dean Herbert
ddb1da5a66 Tidy up class (although it's not in a good state logically) 2021-07-07 13:48:35 +09:00
Bartłomiej Dach
e94e283ee4 Move shared inner classes to separate files 2021-07-06 22:11:54 +02:00
Bartłomiej Dach
f45418dde7 Replace game-side directory/file selector with framework extensions 2021-07-06 22:11:54 +02:00
Dean Herbert
523546d8b6 Use List to guarantee lookup order 2021-07-06 22:51:56 +09:00
Salman Ahmed
255f7b7b53 Add failing test scene 2021-07-06 22:44:23 +09:00
Dean Herbert
2e0155ce04
Merge pull request #13798 from smoogipoo/fix-spectate-button-tests
Fix intermittent spectate button test failures
2021-07-06 22:29:57 +09:00
Dean Herbert
12afdbdf57
Merge pull request #13791 from peppy/remove-resx-files
Remove all `.resx` files from osu project
2021-07-06 22:29:28 +09:00
Derrick Timmermans
4451598bcf
Fix remaining quality complaints 2021-07-06 15:17:19 +02:00
Derrick Timmermans
4b1b5a88fe
Add null check to supress quality errors 2021-07-06 14:39:53 +02:00
Derrick Timmermans
ffe18ebe51
Resolve build errors 2021-07-06 14:11:46 +02:00
smoogipoo
6bc0020825 Fix intermittent spectate button test failures 2021-07-06 20:28:55 +09:00
Derrick Timmermans
07d54d261a
Let selection container handle manual selection changes 2021-07-06 13:24:18 +02:00
Dean Herbert
06d2c6f0a1 Update resources 2021-07-06 19:51:57 +09:00
ekrctb
7b21d1ecf9 Fix juice stream outline disappears away when start position is outside the screen. 2021-07-06 19:50:32 +09:00
Derrick Timmermans
c5a0672277
Use IStateful<SelectionState> instead of ISelected 2021-07-06 12:07:25 +02:00
Dean Herbert
e4b436198b
Merge pull request #13797 from smoogipoo/fix-ready-button-tests
Fix intermittent ready button test failures
2021-07-06 18:36:35 +09:00
Derrick Timmermans
32ef2405c4
Use null instead of -1 2021-07-06 11:30:56 +02:00
smoogipoo
b209868d96 Fix another potential failure 2021-07-06 17:57:24 +09:00
smoogipoo
8b12ec9586 Fix intermittent ready button test failures 2021-07-06 17:52:27 +09:00
Dean Herbert
d75d67577a Fix regressed tests 2021-07-06 17:37:34 +09:00
Dean Herbert
cd4885e450 Add xmldoc and remove any question of how the intitial flow is being run 2021-07-06 17:18:45 +09:00
ekrctb
2ba3003934 Add nested fruit outlines to juice stream selection blueprint 2021-07-06 17:15:51 +09:00
ekrctb
7833a1b09a Allow FruitOutline to be used for nested hit objects 2021-07-06 17:15:27 +09:00
Dean Herbert
032c285ede Move private downwards 2021-07-06 17:07:29 +09:00
Dean Herbert
1232925f93 Make source manipulation methods protected 2021-07-06 17:06:00 +09:00
Dean Herbert
b4240d3ca4 Simplify lookups to avoid a second dictionary fetch 2021-07-06 17:04:59 +09:00
Dean Herbert
ec1224218c Localise source changed flow for better clarity 2021-07-06 16:57:19 +09:00
Dean Herbert
935fbe7cc6 Remove double fetch/binding of parent source 2021-07-06 16:51:29 +09:00
ekrctb
0fa7716ced Show path of juice stream in selection blueprint 2021-07-06 16:46:12 +09:00
ekrctb
7ef7c5148f Add ScrollingPath for visualization of the real path of a JuiceStream 2021-07-06 16:41:53 +09:00
Dean Herbert
93ef783339 Remove BindableList usage 2021-07-06 16:40:23 +09:00
Dan Balasescu
fe70b52086
Merge pull request #13793 from ekrctb/catch-hit-object-serialization
Fix copy-and-paste not working in osu!catch editor
2021-07-06 16:38:05 +09:00
Dan Balasescu
32e6c9c5d3
Merge pull request #13786 from peppy/multiplayer-test-fixes
Fix multiplayer test failures due to leaderboard load process
2021-07-06 16:33:41 +09:00
Dean Herbert
4366be5c1f
Merge pull request #13792 from peppy/fix-migration-cleanup-failure
Fix potential failure during cleanup of files in migration tests
2021-07-06 15:39:04 +09:00
ekrctb
175d666906 Use getters of OriginalX and XOffset 2021-07-06 15:32:32 +09:00
ekrctb
ae1b1cbec9 Allow serialization of catch hit objects 2021-07-06 15:32:32 +09:00
Dean Herbert
7f7cf0b927 Fix potential failure during cleanup of files in migration tests 2021-07-06 15:08:00 +09:00
Dean Herbert
d07c469a89
Merge pull request #13783 from smoogipoo/smooth-auto-gen
Make osu! auto generator interpolate during key-up frames
2021-07-06 15:04:40 +09:00
smoogipoo
1beb85a26f Bump localisation analyser packages 2021-07-06 14:56:52 +09:00
Dean Herbert
0658cfb986 Throw exceptions rather than silently failing if attempting to add a clock for a non-tracked user 2021-07-06 14:56:00 +09:00
smoogipoo
402b527903 Add .editorconfig for localisation analyser 2021-07-06 14:54:56 +09:00
Dean Herbert
1a6b8b2c73 Populate UserScores as early as possible to avoid weird ordering requirements 2021-07-06 14:53:31 +09:00
Dean Herbert
0ecda98b39 Update prefixes to match new resx locations 2021-07-06 14:28:52 +09:00
Dean Herbert
7f2baef998 Remove all .resx files from osu project 2021-07-06 14:24:17 +09:00
Dean Herbert
2cd1bde2bf
Merge pull request #13790 from PercyDan54/remove-redundant-arg
Remove redundant arguments
2021-07-06 14:00:59 +09:00
Bartłomiej Dach
af02a1efcb Bump redundant argument default value inspection severity to warning 2021-07-05 21:02:40 +02:00
Bartłomiej Dach
686dd2b5ce Remove unused constant 2021-07-05 20:35:14 +02:00
Bartłomiej Dach
8e102280b7 Revert & disable case with two contradicting inspections
Leaving the `false` default value without the suppression triggers
`RedundantArgumentDefaultValue`, while removing it triggers
`BaseMethodCallWithDefaultParameter`.

Disable the former, because a single redundant parameter is less bad
than silent breakage if the default value of `propagateChildren` in the
base method ever changes.
2021-07-05 20:21:44 +02:00