39398 Commits

This Branch

This Branch

All Branches

• Remove left-over debug logging
  Dean Herbert · 2021-05-13 16:42:13 +09:00
  19223ba013
• Remove unused DI resolution
  Dean Herbert · 2021-05-13 16:41:36 +09:00
  5818ed4c8c
• Enable autoplay in skin editor tests
  Dean Herbert · 2021-05-13 14:55:11 +09:00
  e0e9106921
• Merge pull request #12758 from Naxesss/verify-settings-ui

  Add setting UI components to the verify screen

  Dean Herbert · 2021-05-13 14:35:35 +09:00
  5b71d8ca37
• Move DI resolution to inside BDL parameters
  Dean Herbert · 2021-05-13 13:54:06 +09:00
  b81f86bd4d
• Simplify binding flow in InterpretationSection
  Dean Herbert · 2021-05-13 13:51:41 +09:00
  c6648112e5
• Tidy up specification of SettingsSection
  Dean Herbert · 2021-05-13 13:45:10 +09:00
  cdcbaf4291
• Change default skin editor shortcut to Ctrl+Shift+S

  Avoids a conflict with song select's random rewind functionality. As
  mentioned in #12776.

  Dean Herbert · 2021-05-13 13:34:04 +09:00
  23e284b8b3
• Add JsonConstructor attribute to SkinnableTargetWrapper
  Dean Herbert · 2021-05-13 13:16:20 +09:00
  db19617b8b
• Standardise naming of methods related to SkinnableInfo
  Dean Herbert · 2021-05-13 13:14:49 +09:00
  3b862798e9
• Add xmldoc to SkinnableElementTargetContainer
  Dean Herbert · 2021-05-13 13:13:22 +09:00
  581e7940c7
• Add xmldoc and tidy up logic in Skin
  Dean Herbert · 2021-05-13 13:09:33 +09:00
  c93ed541f3
• Set default for bindable in object initializer

  Fixes the CI failure.

  Naxess · 2021-05-13 06:08:48 +02:00
  47948d7b34
• Remove stray comment
  Dean Herbert · 2021-05-13 13:07:06 +09:00
  992a052426
• Reorder fields in SkinEditor
  Dean Herbert · 2021-05-13 13:04:17 +09:00
  469a7f5d2a
• Move field upwards in class
  Dean Herbert · 2021-05-13 13:03:23 +09:00
  2bf8635ffd
• Remove duplicated call to base.GetDrawableComponent
  Dean Herbert · 2021-05-13 13:02:55 +09:00
  a38cb61b08
• Also refresh when interpreted difficulty changes
  Naxess · 2021-05-13 06:00:21 +02:00
  fb305130de
• Use local bound copy in InterpretationSection as well

  Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.

  Naxess · 2021-05-13 05:59:49 +02:00
  ee0a6ba93e
• Add xmldoc to SkinnableInfo
  Dean Herbert · 2021-05-13 12:57:28 +09:00
  6caf4e3879
• Keep track of local bound copy
  Naxess · 2021-05-13 05:46:47 +02:00
  e80d8f6922
• Use more consistent lambda discards
  Naxess · 2021-05-13 05:38:45 +02:00
  04c1585eb2
• Merge branch 'master' into skin-serialisation
  Dean Herbert · 2021-05-13 12:35:06 +09:00
  8b9ac86d4b
• Merge pull request #12754 from peppy/skin-instantiation-info

  Add `SkinInfo.InstantiationInfo` to allow creating different skin types

  Dean Herbert · 2021-05-13 12:34:14 +09:00
  8bf05e142b
• Merge pull request #12777 from smoogipoo/fix-test-failure

  Fix possible multiplayer test failure

  Dean Herbert · 2021-05-13 12:33:59 +09:00
  fb13ed52f7
• Use local bound copy for HiddenIssueTypes
  Naxess · 2021-05-13 05:25:20 +02:00
  e86834b740
• Isolate refreshing to IssueList
  Naxess · 2021-05-13 05:25:02 +02:00
  c8d21f2c3f
• Fix possible test failure
  smoogipoo · 2021-05-13 11:53:50 +09:00
  5b03092968
• Split ShowIssueTypes dict into hidden and configurable lists

  This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
  
  Bindings are a bit less neat, though.

  Naxess · 2021-05-13 04:50:32 +02:00
  fbb76ba598
• Set interpreted difficulty to correct default
  Naxess · 2021-05-13 04:36:20 +02:00
  dd8423c4c4
• Remove unnecessary local variable

  This now exists in `VerifyScreen`, which we can access from here.

  Naxess · 2021-05-13 04:30:40 +02:00
  6806e40ad9
• Move ShowIssueTypes to VerifyScreen
  Naxess · 2021-05-13 04:29:27 +02:00
  56bd897666
• Actually annotate the correct ctor
  Bartłomiej Dach · 2021-05-12 23:53:39 +02:00
  27ca7d0f4f
• Fix missed InstantiationInfo setter usages
  Bartłomiej Dach · 2021-05-12 23:34:25 +02:00
  a6aec6e007
• Merge branch 'master' into skin-instantiation-info
  Bartłomiej Dach · 2021-05-12 23:23:57 +02:00
  d31fa20e92
• Extract invariant instantiation info extension method
  Bartłomiej Dach · 2021-05-12 23:23:51 +02:00
  1b579dd838
• Mark all skin ctors used via reflection in SkinInfo.CreateInstance()
  Bartłomiej Dach · 2021-05-12 23:23:42 +02:00
  4464204e33
• Fix incorrect inline comments

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Dean Herbert · 2021-05-12 19:37:00 +09:00
  7bac81f394
• Merge pull request #12753 from peppy/health-bar-hud-overlay-dependency

  Remove downwards dependency from `HUDOverlay` to `HealthDisplay`

  Dan Balasescu · 2021-05-12 19:27:02 +09:00
  4e7c079560
• Remove unused using statement
  Dean Herbert · 2021-05-12 19:06:40 +09:00
  55e1f97f59
• Change default skin to use component lookup for conformity
  Dean Herbert · 2021-05-12 18:55:48 +09:00
  75227e5a70
• Remove remaining test usage of SkinnableXXX HUD components
  Dean Herbert · 2021-05-12 18:53:25 +09:00
  0a895fff15
• Revert "Also save on skin switch"

  This reverts commit 2f55d1e5ab.

  Dean Herbert · 2021-05-12 17:45:51 +09:00
  088335a035
• Fix rotation handle visibility logic not handling two handles hovered at once
  Salman Ahmed · 2021-05-12 11:42:55 +03:00
  96d3586294
• Add failing test case
  Salman Ahmed · 2021-05-12 11:42:55 +03:00
  80e231d90a
• Also save on skin switch
  Dean Herbert · 2021-05-12 17:42:12 +09:00
  2f55d1e5ab
• Avoid hard crash if Save() is called before preparing for mutation
  Dean Herbert · 2021-05-12 17:42:04 +09:00
  be187e8ebd
• Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen

  Implement the multiplayer spectator screen

  Dean Herbert · 2021-05-12 17:24:35 +09:00
  c6f0a6aed3
• Reverse direction of binding to allow for better abstract class definitions
  Dean Herbert · 2021-05-12 16:53:58 +09:00
  d2e0e8ad94
• Rename Settings to have a more localised name
  Dean Herbert · 2021-05-12 16:38:04 +09:00
  17e3764576