8698 Commits

• Remove not required null conditional
  Salman Ahmed · 2021-05-14 09:32:56 +03:00
  8338f702c3
• Add very basic test logic to ensure PlayerLoader is present for playlists
  Dean Herbert · 2021-05-14 15:02:36 +09:00
  48672f8afd
• Fix online play subscreens not pushing player loaders when starting gameplay
  Salman Ahmed · 2021-05-14 04:25:29 +03:00
  9e8c0a7e70
• Merge branch 'master' into remove-skinnable-hud-classes
  Dan Balasescu · 2021-05-13 21:06:48 +09:00
  d5b14b6b99
• Merge pull request #12750 from peppy/skin-serialisation

  Add skin editor saving / loading support

  Dan Balasescu · 2021-05-13 20:58:03 +09:00
  746862dcb1
• Merge branch 'master' into skin-serialisation
  Dan Balasescu · 2021-05-13 19:49:55 +09:00
  3c471837f8
• Merge branch 'master' into fix-two-hovered-handles
  Dan Balasescu · 2021-05-13 19:24:42 +09:00
  a3869c02f4
• Merge branch 'skin-serialisation' into remove-skinnable-hud-classes
  Dean Herbert · 2021-05-13 19:05:08 +09:00
  c8b7cfc753
• Rename SkinnableElementTargetContainer to SkinnableTargetContainer
  Dean Herbert · 2021-05-13 17:07:38 +09:00
  106fa97a11
• Rename ISkinnableComponent to ISkinnableDrawable
  Dean Herbert · 2021-05-13 17:06:00 +09:00
  7921dc7ece
• Replace ISkinSerialisable with IsEditable property
  Dean Herbert · 2021-05-13 17:03:17 +09:00
  cdcd31b546
• Merge pull request #12758 from Naxesss/verify-settings-ui

  Add setting UI components to the verify screen

  Dean Herbert · 2021-05-13 14:35:35 +09:00
  5b71d8ca37
• Move DI resolution to inside BDL parameters
  Dean Herbert · 2021-05-13 13:54:06 +09:00
  b81f86bd4d
• Simplify binding flow in InterpretationSection
  Dean Herbert · 2021-05-13 13:51:41 +09:00
  c6648112e5
• Tidy up specification of SettingsSection
  Dean Herbert · 2021-05-13 13:45:10 +09:00
  cdcbaf4291
• Standardise naming of methods related to SkinnableInfo
  Dean Herbert · 2021-05-13 13:14:49 +09:00
  3b862798e9
• Set default for bindable in object initializer

  Fixes the CI failure.

  Naxess · 2021-05-13 06:08:48 +02:00
  47948d7b34
• Also refresh when interpreted difficulty changes
  Naxess · 2021-05-13 06:00:21 +02:00
  fb305130de
• Use local bound copy in InterpretationSection as well

  Else we're relying on the `VerifyScreen`'s bindable instance, and by extension the `VerifyScreen` instance itself.

  Naxess · 2021-05-13 05:59:49 +02:00
  ee0a6ba93e
• Add xmldoc to SkinnableInfo
  Dean Herbert · 2021-05-13 12:57:28 +09:00
  6caf4e3879
• Keep track of local bound copy
  Naxess · 2021-05-13 05:46:47 +02:00
  e80d8f6922
• Use more consistent lambda discards
  Naxess · 2021-05-13 05:38:45 +02:00
  04c1585eb2
• Merge branch 'master' into skin-serialisation
  Dean Herbert · 2021-05-13 12:35:06 +09:00
  8b9ac86d4b
• Use local bound copy for HiddenIssueTypes
  Naxess · 2021-05-13 05:25:20 +02:00
  e86834b740
• Isolate refreshing to IssueList
  Naxess · 2021-05-13 05:25:02 +02:00
  c8d21f2c3f
• Split ShowIssueTypes dict into hidden and configurable lists

  This way `VerifyScreen` is decoupled from which options `VisibilitySection` provides.
  
  Bindings are a bit less neat, though.

  Naxess · 2021-05-13 04:50:32 +02:00
  fbb76ba598
• Set interpreted difficulty to correct default
  Naxess · 2021-05-13 04:36:20 +02:00
  dd8423c4c4
• Remove unnecessary local variable

  This now exists in `VerifyScreen`, which we can access from here.

  Naxess · 2021-05-13 04:30:40 +02:00
  6806e40ad9
• Move ShowIssueTypes to VerifyScreen
  Naxess · 2021-05-13 04:29:27 +02:00
  56bd897666
• Merge pull request #12753 from peppy/health-bar-hud-overlay-dependency

  Remove downwards dependency from `HUDOverlay` to `HealthDisplay`

  Dan Balasescu · 2021-05-12 19:27:02 +09:00
  4e7c079560
• Remove remaining test usage of SkinnableXXX HUD components
  Dean Herbert · 2021-05-12 18:53:25 +09:00
  0a895fff15
• Fix rotation handle visibility logic not handling two handles hovered at once
  Salman Ahmed · 2021-05-12 11:42:55 +03:00
  96d3586294
• Merge pull request #12538 from smoogipoo/multiplayer-spectator-screen

  Implement the multiplayer spectator screen

  Dean Herbert · 2021-05-12 17:24:35 +09:00
  c6f0a6aed3
• Reverse direction of binding to allow for better abstract class definitions
  Dean Herbert · 2021-05-12 16:53:58 +09:00
  d2e0e8ad94
• Rename Settings to have a more localised name
  Dean Herbert · 2021-05-12 16:38:04 +09:00
  17e3764576
• Move SkinnableElementTargetContainer out of HUD namespace
  Dean Herbert · 2021-05-12 15:59:33 +09:00
  494a1b01a5
• Merge branch 'health-bar-hud-overlay-dependency' into skin-serialisation
  Dean Herbert · 2021-05-12 12:54:37 +09:00
  4aad7b96ea
• Improve safety of bindings in HealthDisplay
  Dean Herbert · 2021-05-12 12:53:30 +09:00
  184dbaf202
• Add InterpretationSection and its bindable in IssueList

  We'll eventually connect that bindable so that checks can access it.

  Naxess · 2021-05-12 01:32:18 +02:00
  4aeaec6ecc
• Refresh IssueList on changes in VisibilitySection
  Naxess · 2021-05-12 01:30:45 +02:00
  ad78aec1ef
• Add IssueList filtering based on those bindables
  Naxess · 2021-05-12 01:29:46 +02:00
  1bb7d412da
• Add VisibilitySection and its bindables in IssueList
  Naxess · 2021-05-12 01:27:21 +02:00
  2e4399f0c1
• Add abstract Section class

  Similar to `Section` in the timing screen, but does not make use of checkboxes, nor specific to control points.
  
  So there's a lot of things that differ, hence new class instead of factoring that out.

  Naxess · 2021-05-12 01:26:12 +02:00
  01b8794757
• Separate IssueList into own class
  Naxess · 2021-05-12 01:23:31 +02:00
  1de35f880b
• Take IssueList in IssueSettings constructor

  We'll be using this for bindables later.

  Naxess · 2021-05-12 01:22:32 +02:00
  d3c1ec55ee
• Factor out load from settings into new Settings class
  Naxess · 2021-05-12 01:21:38 +02:00
  97bd482d4d
• Remove downwards dependency from HUDOverlay to HealthDisplay
  Dean Herbert · 2021-05-11 23:18:23 +09:00
  8e226319e2
• Change HealthDisplay to be a CompositeDrawable
  Dean Herbert · 2021-05-11 23:10:30 +09:00
  048677846b
• Fix spectate being entered while not having the beatmap
  smoogipoo · 2021-05-11 19:22:09 +09:00
  9ad1e5067e
• Show a message when attempting to customisse a screen which doesn't support it
  Dean Herbert · 2021-05-11 18:39:15 +09:00
  f55407f871