961 Commits

Author	SHA1	Message	Date
Dean Herbert	9c1f4b552e	Rename and invert flags for slider classic behaviours	2023-11-02 17:43:21 +09:00
Dean Herbert	48bdeaeff1	Fix another potential crash in bubbles mod ... Storing `DrawableHitObject` for later use is not safe – especially when accessing `HitObject` – as it's a pooled class. In the case here, it's important to note that `PrepareForUse` can be called a frame or more later in execution, which made this unsafe. Closes https://github.com/ppy/osu/issues/24444.	2023-11-02 02:43:51 +09:00
Dean Herbert	24b1d1e955	Fix code quality fail	2023-10-27 18:18:07 +09:00
Termincc	8b9b085ef5	Address mod incompatibilities ... Makes FreezeFrame and Transform mods incompatible.	2023-10-26 22:15:10 +10:00
Dean Herbert	686c45e21b	Merge branch 'master' into legacy-tick-test-coverage	2023-10-20 16:41:32 +09:00
Dean Herbert	54da6f1048	Merge pull request #25160 from bdach/repeat-arrow-hidden-fade ... Adjust slider repeat transforms to closer match stable	2023-10-18 18:03:48 +09:00
Dan Balasescu	939b55020c	Merge branch 'master' into legacy-tick-test-coverage	2023-10-18 15:21:31 +09:00
Bartłomiej Dach	30e5f47007	Instantly fade out slider repeats when hidden is active	2023-10-17 14:15:21 +02:00
Dean Herbert	5341a335a6	Bypass Parent nullability checks for now	2023-10-17 17:48:45 +09:00
Dean Herbert	3849b11644	Fix "Hard Rock" mod affecting CS/AR in osu!mania ... Closes https://github.com/ppy/osu/issues/25090. Not sure if there are other exceptions we should account for here.	2023-10-12 19:48:47 +09:00
Dean Herbert	dd6d09189e	Remove usage of LastTick in osu! ruleset	2023-09-29 16:58:17 +09:00
Dean Herbert	d7119674e8	Update comments to better explain what LastTick is doing	2023-09-29 14:40:44 +09:00
Dean Herbert	81485c548c	Move LegacyLastTickOffset specification to generation code and stop passing everywhere	2023-09-29 14:32:29 +09:00
Salman Ahmed	734ee0e68b	Simplify code	2023-09-24 02:22:50 +03:00
Fabian van Oeffelt	7c40072c47	Get first Spinner,Slider or HitCircle instead of only HitCircle ... Fixes bug	2023-09-23 13:18:49 +02:00
Dean Herbert	e3e7a81ad9	Remove slider head circle movement (and remove setting from "classic" mod)	2023-09-14 17:49:41 +09:00
Bartłomiej Dach	e9b08219e9	Block input to objects lying under already-hit slider heads before slider is fully judged when classic note lock is active	2023-09-08 13:42:18 +02:00
Bartłomiej Dach	168a828f23	Revert "Block input to objects lying under already-hit hitcircles when classic note lock is active" ... This reverts commit 03c61a573e. The goal here was to handle an edge case discovered during work on note lock, wherein it was determined that on stable hit circles would block input from reaching objects underneath them. However, the change mentioned above did that _too_ hard and caused overlaps to also be blocked even long past a hit circle has been faded out. Revert the change pending further (and more careful) investigation.	2023-09-08 10:11:21 +02:00
Bartłomiej Dach	323a4f4522	Only show preempt time when limits are extended	2023-09-07 08:30:02 +02:00
Bartłomiej Dach	bd633889e7	Remove local preempt time calculation ... And just use a hitcircle, and read the actual value. Comes with 100% less chance of forgetting to update either place in the future.	2023-09-07 08:23:50 +02:00
Bartłomiej Dach	9c6f77b26e	Fix too many things being exposed	2023-09-07 08:11:04 +02:00
Dean Herbert	e05d7d5f8d	Inline local control	2023-09-07 14:22:06 +09:00
isakvik	2ab11ab568	adds new diffsetting control that shows millisecond values for approach rate override	2023-09-07 01:41:22 +02:00
isakvik	3db0d0d341	extendable minimum AR value for osu!std diff adjust mod, set to -10	2023-09-06 23:26:34 +02:00
Dean Herbert	1a37543d28	Rename SliderVelocity to SliderVelocityMultiplier to distinguish from Velocity	2023-09-06 19:01:08 +09:00
Bartłomiej Dach	03c61a573e	Block input to objects lying under already-hit hitcircles when classic note lock is active	2023-09-05 22:50:27 +02:00
Dean Herbert	0da37e4e99	Merge pull request #24701 from frenzibyte/remove-flashlight-slider-dim-transform ... Apply flashlight slider dim immediately to match osu!(stable)	2023-09-04 16:35:30 +09:00
Salman Ahmed	920c6fa48f	Update comment	2023-09-01 23:29:51 +03:00
Salman Ahmed	f74dfa9c6c	Apply flashlight slider dim immediately to match osu!(stable)	2023-09-01 22:55:33 +03:00
Dean Herbert	90121814f9	Merge branch 'master' into stable-notelock	2023-09-01 17:15:48 +09:00
Salman Ahmed	993cebe785	Fix mod "Classic" interfering with DrawableHitCircle animation while in hit state	2023-08-30 21:42:47 +03:00
Bartłomiej Dach	7f215f163f	Use reduced hittable range with autopilot active	2023-08-24 08:52:49 +02:00
Liam DeVoe	6a81230298	rename ObjectOrderedHitPolicy to LegacyHitPolicy	2023-07-19 14:44:28 -04:00
Bartłomiej Dach	6d32206a08	Fix slider tails receiving wrong colours ... Only visually apparent on legacy skins.	2023-06-19 17:47:01 +02:00
Dean Herbert	0900cebc0d	Avoid doing expensive colour fetch operation every update	2023-06-19 20:12:17 +09:00
Dean Herbert	aa96fefae2	Merge branch 'master' into snap-colour-mod	2023-06-19 20:01:36 +09:00
John Biddle	d07437f810	Added recommendations from bdach: ... Fixed null checking in ApplyToDrawableHitObject Renamed mod to "Synesthesia" Moved to the "Fun" mod category	2023-06-08 00:52:28 -07:00
Dean Herbert	247fa088db	Add IHasNoTimedInputs interface to scope change further	2023-06-06 22:22:42 +09:00
Dean Herbert	a5fd833214	Fix "bubbles" mod not adding pool to hierarchy (and constructing too early)	2023-06-02 23:01:03 +09:00
John	ed850196d9	Reverted to applying the color change in OnUpdate, removed EnableComboColour flag from DrawableHitObject.cs	2023-05-30 01:43:08 -07:00
Dean Herbert	3e94d4bb5a	Fix cursor ripples appearing in a weird place when "autopilot" mod is enabled	2023-05-30 15:18:23 +09:00
John	b7dc8d49ba	Removed import for Allocation and other unnecessary [Resolved] tag missed in last commit	2023-05-16 21:14:55 -07:00
John	e2633ae993	Removed unnecessary [Resolved] attribute (thanks bdach) ... Moved accent color assignment from OnUpdate to ApplyCustomUpdateState. In order to get this to work, a flag needed to be added to DrawableHitObject.cs to disable combo color updates also being applied.	2023-05-16 21:08:56 -07:00
Bartłomiej Dach	a6ddb107cd	Merge branch 'master' into master	2023-05-14 19:45:31 +02:00
alix	d503312788	updates and add changes	2023-05-14 13:37:44 -04:00
John	7a907f7207	Code quality improvements (thanks to ItsShamed): Removed #nullable disable, fixed incorrect LocalisableString, removed incorrect dependency injection for OsuColour, fixed nullable dependency for IBeatmap ... Removed unnecessary usage of "this." caught by the CI code quality check	2023-05-12 22:13:39 -07:00
John	24f07633f3	Formatting fixes	2023-05-12 19:43:28 -07:00
John	e5884016ab	Initial commit for the snap colour mod. Implements basic functionality.	2023-05-12 19:07:25 -07:00
alix	b3a5e4d305	nest class outside of OsuModRandom	2023-05-12 00:29:00 -04:00
alix	53ab780796	fix indents	2023-05-11 23:50:45 -04:00