56 Commits

• Add legacy storyboard encoder (#37790)

  - Closes https://github.com/ppy/osu/issues/37757
  
  Commit-by-commit reading is recommended. Commits will be split to PRs on
  request but I consider this to be the minimal viable functional
  increment.
  
  ## Done
  
  - This adds a first version of a full storyboard encoder
  (a66dc406f498e35d4e0c8f2a462e946a9a1aeccc). I expect there to be hiccups
  due to weird corners of the `.osb` format; this is only intended to be
  somewhat correct as a start to build upon. Storyboarders are asked to
  file issues as necessary.
  - Due to the fact that storyboard definitions can reside both in the
  `.osu` and the `.osb`, b60698a95c4de1bfeb36fbb159fd5a6028920832 adds the
  required storage to be able to tell which storyboard element lives
  where, so that it can be decoded properly later.
  - In c9d3e04a4135886b5b0943c85f3cc6f4fe99c84c, the storyboard decoder is
  weaved into the beatmap decoder to handle the `.osu` part of the
  storyboard, via the
  `LegacyStoryboardEncoder.Encode{General,Events}ToBeatmap()` methods. For
  `.osb`s, `LegacyStoryboardEncoder.EncodeStandaloneStoryboard()` is
  intended, but for now is not used outside tests.
  - Because of the above, dd1c4e43dc51154cd67860f096712f8b4f229661 removes
  `Beatmap.UnhandledEventLines` as no longer required.
  - 26ac417ed98a8937c42e5f52c4e15ef065a48902 adds tests. They are mostly
  handwritten to ensure basic encode-decode roundtripping. Using existing
  storyboards is difficult, see "Known issues" section as to why.
  - 5cc542366db7caac38eb0729260d884905a2c0d5 fixes a bug in the storyboard
  decoder where the trigger group number was not properly negated on
  decode (see inline comment reference to relevant stable code).
  
  ## Known issues
  
  - Any and all variables in the `[Variables]` section are inlined into
  their usages by `LegacyStoryboardDecoder`, and as such
  `LegacyStoryboardEncoder` will end up inlining them and discarding the
  `[Variables]` section. As far as I can tell stable will also do this.
  - `LegacyStoryboardDecoder` splits all `M` (move) commands into
  `MX`/`MY` commands. Therefore, `LegacyStoryboardEncoder` will write out
  things in the same split way. I did not put in effort to attempt to
  reconcile this, for reasons of part laziness, part not wanting to bloat
  this already-large diff.
  - Ordering of storyboard samples on decode may not match the order on
  decode. I'm crossing fingers this doesn't matter.

  Bartłomiej Dach · 2026-05-20 17:46:51 +09:00
  0e443b1c47
• Adjust method naming and copy
  Bartłomiej Dach · 2023-01-01 18:50:47 +01:00
  a82f1a6abd
• fix typo
  cdwcgt · 2022-12-16 10:48:56 +09:00
  a4d28aff6d
• Add test for set preview point
  cdwcgt · 2022-12-16 01:35:54 +09:00
  984f0b5fa9
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Rename to "clone" instead of "duplicate"
  Dean Herbert · 2022-10-25 11:43:23 +09:00
  4d4f6e25ba
• Add test coverage of clone operations
  Dean Herbert · 2022-10-25 11:38:58 +09:00
  da74690ec9
• Remove unused RulesetStore from BeatmapManager constructor
  Dean Herbert · 2022-07-28 16:19:05 +09:00
  2b9d46d803
• Centralise and harden editor-ready-for-use check

  Not only does this combine the check into one location, but it also adds
  a check on the global `WorkingBeatmap` being updated, which is the only
  way I can see the following failure happening:
  
  ```csharp
  05:19:07     osu.Game.Tests: osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.TestAddAudioTrack
  05:19:07       Failed TestAddAudioTrack [161 ms]
  05:19:07       Error Message:
  05:19:07        TearDown : System.NullReferenceException : Object reference not set to an instance of an object.
  05:19:07       Stack Trace:
  05:19:07       --TearDown
  05:19:07        at osu.Game.Database.ModelManager`1.<>c__DisplayClass7_0.<AddFile>b__0(TModel managed) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36
  05:19:07        at osu.Game.Database.ModelManager`1.<>c__DisplayClass8_0.<performFileOperation>b__0(Realm realm) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 49
  05:19:07        at osu.Game.Database.RealmExtensions.Write(Realm realm, Action`1 function) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\RealmExtensions.cs:line 14
  05:19:07        at osu.Game.Database.ModelManager`1.performFileOperation(TModel item, Action`1 operation) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 46
  05:19:07        at osu.Game.Database.ModelManager`1.AddFile(TModel item, Stream contents, String filename) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Database\ModelManager.cs:line 36
  05:19:07        at osu.Game.Screens.Edit.Setup.ResourcesSection.ChangeAudioTrack(FileInfo source) in C:\BuildAgent\work\ecd860037212ac52\osu.Game\Screens\Edit\Setup\ResourcesSection.cs:line 115
  05:19:07        at osu.Game.Tests.Visual.Editing.TestSceneEditorBeatmapCreation.<TestAddAudioTrack>b__13_0() in C:\BuildAgent\work\ecd860037212ac52\osu.Game.Tests\Visual\Editing\TestSceneEditorBeatmapCreation.cs:line 101
  05:19:07        at osu.Framework.Testing.Drawables.Steps.AssertButton.checkAssert()
  05:19:07        at osu.Framework.Testing.Drawables.Steps.StepButton.PerformStep(Boolean userTriggered)
  05:19:07        at osu.Framework.Testing.TestScene.runNextStep(Action onCompletion, Action`1 onError, Func`2 stopCondition)
  ```

  Dean Herbert · 2022-06-27 16:22:01 +09:00
  5a7d339cc8
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove pointless override in test implementation
  Dean Herbert · 2022-06-16 18:27:16 +09:00
  8a5755ca52
• Combine BeatmapManager and BeatmapModelManager into one class
  Dean Herbert · 2022-06-16 18:07:04 +09:00
  1f3e1b2d97
• Remove custom hash function flow
  Dean Herbert · 2022-06-15 00:42:30 +09:00
  f11fe54385
• Update screen transition events to use new event args
  Dean Herbert · 2022-04-22 00:52:44 +09:00
  832d37b2c2
• Split out IDialogOverlay to allow for easier testing
  Dean Herbert · 2022-04-18 18:36:26 +09:00
  e315313266
• Fix unprotected access to potentially-null DI'd dialog overlay
  Bartłomiej Dach · 2022-03-22 22:10:05 +01:00
  51a1721bc9
• Disallow exiting the editor without saving (unless explicitly confirming)
  Dean Herbert · 2022-03-22 15:42:56 +09:00
  61ddf1e6cf
• Restructure difficulty copy flow to adapt to latest changes
  Bartłomiej Dach · 2022-02-14 22:02:37 +01:00
  e45a2ae0fc
• Apply some renames to convey difference between creation options better
  Bartłomiej Dach · 2022-02-13 14:01:23 +01:00
  6fd663a718
• Add flow for copying existing difficulty content
  Bartłomiej Dach · 2022-02-13 14:01:20 +01:00
  a2c2b2bbb3
• Add editor override to respect IsolateSavingFromDatabase
  Bartłomiej Dach · 2022-02-02 21:57:21 +01:00
  a8ffc4fc2a
• Add failing test coverage for save after safeties addition
  Bartłomiej Dach · 2022-02-02 21:57:10 +01:00
  afc48d86df
• Add basic test coverage for new difficulty creation
  Bartłomiej Dach · 2022-02-02 21:55:34 +01:00
  0d51c015ad
• Remove unused ruleset ctor params from test beatmap model managers

  No longer used since 00e3af3366.

  Bartłomiej Dach · 2022-02-01 21:49:41 +01:00
  75101b1105
• Recreate test beatmap of EditorTestScene on set up
  Salman Ahmed · 2022-01-25 13:03:27 +03:00
  a93873e8ca
• Fix cases of Access instead of Realm
  Dean Herbert · 2022-01-25 12:58:15 +09:00
  3e5c9e8436
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Merge branch 'master' into global-bindable-thread-safety
  Dean Herbert · 2022-01-18 18:12:00 +09:00
  02baad30d7
• Update broken test scenes to match new OsuTestScene logic
  Dean Herbert · 2022-01-18 13:41:50 +09:00
  da9a60a695
• Update model manager and many related classes to get things compiling again
  Dean Herbert · 2022-01-12 17:00:00 +09:00
  00e3af3366
• Various updates to ruleset and primary key usages to move closer to realm support
  Dean Herbert · 2022-01-12 16:57:13 +09:00
  b8cd3cdbbc
• Rewrite PreviewTrackManager to avoid constructing TrackBass locally

  This paves the way for the framework code quality change
  (https://github.com/ppy/osu-framework/pull/4873) which stops exposing
  the constructor.
  
  Most of the restructuring here is required to give `PreviewTrackManager`
  an adjustable target to apply the global mute.

  Dean Herbert · 2021-11-09 17:38:12 +09:00
  3b485b5f37
• Remove unused reader parameter
  Dean Herbert · 2021-10-24 23:48:46 +09:00
  26cf5370c3
• Split out IModelDownloader and also split apart ScoreManager
  Dean Herbert · 2021-09-30 18:25:20 +09:00
  3e3b9bc963
• Hook up all required interfaces to new BeatmapManager
  Dean Herbert · 2021-09-30 17:18:39 +09:00
  90225f2082
• Expose test helper for switching between difficulties
  Bartłomiej Dach · 2021-09-12 13:55:48 +02:00
  22fa9a303e
• Delegate Editor{Beatmap,Clock} to Editor directly
  Bartłomiej Dach · 2021-09-12 13:40:06 +02:00
  f8a681d810
• Make EditorTestScene go through EditorLoader
  Bartłomiej Dach · 2021-09-12 13:26:04 +02:00
  8357efc74f
• Remove redundant arguments
  PercyDan54 · 2021-07-05 23:52:39 +08:00
  e1c646b9b2
• Merge branch 'master' into legacy-skin-resource-improvements
  Dean Herbert · 2021-05-31 19:36:09 +09:00
  17fa2426d4
• Merge branch 'master' into non-nullable-beatmapset-files
  Dean Herbert · 2021-05-31 18:19:57 +09:00
  d4cb70735d
• Fix bindable lease failure in editor beatmap creation tests
  Dean Herbert · 2021-05-31 14:24:46 +09:00
  5925beaf21
• Remove previous consumption logic in GetWorkingBeatmap

  This should not be required since the introduction of `workingCache`,
  which does the same thing in a more global way.

  Dean Herbert · 2021-05-31 14:11:58 +09:00
  06bd696cc2
• Revert "Revert "Fix editor tests failing due to empty files being specified""

  This reverts commit 1af684c4b2.

  Dean Herbert · 2021-05-28 14:33:06 +09:00
  581a86b91a
• Revert "Fix editor tests failing due to empty files being specified"

  This reverts commit fdbd421040.

  Dean Herbert · 2021-05-28 14:15:28 +09:00
  1af684c4b2
• Fix editor tests failing due to empty files being specified
  Dean Herbert · 2021-05-20 17:09:55 +09:00
  fdbd421040
• Add test coverage of audio track changing
  Dean Herbert · 2020-09-24 22:00:13 +09:00
  011b176244
• Move more logic to base EditorTestScene
  Dean Herbert · 2020-09-14 15:27:08 +09:00
  0ef4dfc192
• Move setting up the ruleset bindable to top-base test scene
  Salman Ahmed · 2020-06-10 18:23:31 +03:00
  4fb71eeb20
• Use CreateRuleset() for editor test scenes as well
  Salman Ahmed · 2020-06-04 00:47:10 +03:00
  741fa20149