9562 Commits

• Merge branch 'master' into beatmap-carousel-v2-split-panels
  Bartłomiej Dach · 2025-01-24 15:16:23 +01:00
  092c7b4253
• Fix test failures
  Bartłomiej Dach · 2025-01-24 14:24:16 +01:00
  b0136f98a9
• Merge pull request #31645 from peppy/offset-adjust-more-lenience

  Make offset adjust more lenient

  Bartłomiej Dach · 2025-01-24 14:01:25 +01:00
  7845c5cfb7
• Split out beatmaps and set panels into two separate classes
  Dean Herbert · 2025-01-24 20:10:41 +09:00
  175eb82ccf
• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Add test coverage of various selection examples

  Where possible I've tried to match the test and method names of
  `TestSceneBeatmapCarousel` for easy coverage comparison.

  Dean Herbert · 2025-01-23 18:51:25 +09:00
  eaea053c7d
• Fix sort direction being flipped
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  ffca90779f
• Tidy up tests in preparation for adding more
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  9ab045495d
• Make CarouselItem sealed and remove BeatmapCarouselItem concept

  Less abstraction is better. As far as I can tell, we don't need a custom
  model for this. If there's any tracking to be done, it should be done
  within `BeatmapCarousel`'s implementation (or a filter).

  Dean Herbert · 2025-01-23 18:48:44 +09:00
  980f6cf18e
• Show selection defaults in test scene (and make prettier)
  Dean Herbert · 2025-01-23 15:50:40 +09:00
  8657576210
• Merge pull request #31588 from minetoblend/feature/paste-snapped

  Snap to beat divisor when pasting hitobjects in editor

  Dean Herbert · 2025-01-22 18:38:12 +09:00
  218720bca5
• Apply NRT to new class
  Dean Herbert · 2025-01-22 18:36:13 +09:00
  c94b8bf051
• Merge pull request #31604 from peppy/fix-song-select-right-click-handling

  Fix song select right click handling

  Bartłomiej Dach · 2025-01-22 10:00:03 +01:00
  2623d8dcac
• Switch IsImportant to init property isntead of virtual
  Dean Herbert · 2025-01-22 16:41:26 +09:00
  4cf4b8c73d
• Add transient flag for notifications which shouldn't linger in history
  Dean Herbert · 2025-01-22 16:41:26 +09:00
  fde2b22bbc
• Add test scene for clipboard snapping
  Marvin Schürz · 2025-01-21 11:02:41 +01:00
  cc7c549468
• Merge pull request #31527 from bdach/spectator-list-ready

  Show spectating users during gameplay

  Dan Balasescu · 2025-01-21 18:54:11 +09:00
  8f8246278a
• Add failing test coverage of random rewind button not working
  Dean Herbert · 2025-01-21 17:24:41 +09:00
  c8cc36e9af
• Knock some sense into daily challenge profile test scene
  Dean Herbert · 2025-01-20 15:40:38 +09:00
  b5b407fe7c
• Adjust tests to worked with snapped start time
  Marvin Schürz · 2025-01-20 01:38:18 +01:00
  45e0d9154e
• Merge spectator list classes into one skinnable
  Bartłomiej Dach · 2025-01-17 11:23:14 +01:00
  3c4bfc0a01
• Add completion marker to daily challenge profile counter
  Bartłomiej Dach · 2025-01-17 10:26:59 +01:00
  b215073957
• Merge pull request #31513 from smoogipoo/remove-status-from-apiuser

  Remove `Status` and `Activity` bindables from `APIUser`

  Dean Herbert · 2025-01-17 17:36:47 +09:00
  a8456ce9ac
• Merge pull request #31535 from peppy/beatmap-carousel-v2-right-click-scroll

  Refactor absolute scrolling at song select

  Dan Balasescu · 2025-01-17 17:02:14 +09:00
  88829d5321
• Merge pull request #31533 from peppy/fix-gameplay-offset-adjust-limitations

  Fix gameplay offset adjustment limits not being enforced

  Bartłomiej Dach · 2025-01-17 08:21:24 +01:00
  7d026761fc
• Merge branch 'master' into beatmap-carousel-v2-right-click-scroll
  Dan Balasescu · 2025-01-17 16:12:52 +09:00
  79fff136a9
• Merge branch 'master' into remove-status-from-apiuser
  Dan Balasescu · 2025-01-17 15:42:40 +09:00
  5425d62186
• Fix tests
  Dan Balasescu · 2025-01-17 15:42:19 +09:00
  ae7e4bef86
• Fix test potentially false-negative due to realm write delays
  Dean Herbert · 2025-01-17 14:16:38 +09:00
  224f39825f
• Merge branch 'spectator-list-visuals' into spectator-list-ready
  Bartłomiej Dach · 2025-01-16 15:13:04 +01:00
  0c54853710
• Merge branch 'master' into spectator-list-visuals
  Bartłomiej Dach · 2025-01-16 14:07:53 +01:00
  e3b780d0fb
• Move absolute scroll support local to carousel and allow custom bindings
  Dean Herbert · 2025-01-16 20:47:59 +09:00
  a6057a9f54
• Merge pull request #31471 from peppy/beatmap-carousel-v2

  Add basic framework for carousel displays (aka `BeatmapCarouselV2`)

  Bartłomiej Dach · 2025-01-16 12:21:53 +01:00
  6b921fc4e4
• Move bindables to OsuConfigManager & SessionStatics
  Dan Balasescu · 2025-01-16 19:33:42 +09:00
  8400726887
• Adjust test to work better when running in sequence
  Dean Herbert · 2025-01-16 18:56:21 +09:00
  56dfe4a231
• Add failing test coverage showing offset adjust is not limited correctly
  Dean Herbert · 2025-01-16 18:05:58 +09:00
  a4174a3644
• Expose as IBindable from IAPIProvider, writes via config
  Dan Balasescu · 2025-01-16 17:05:18 +09:00
  b54d959263
• Add client methods allowing users to be notified of who is watching them
  Bartłomiej Dach · 2025-01-15 14:18:01 +01:00
  43fc48a3f3
• Implement spectator list display

  - First step for https://github.com/ppy/osu/issues/22087
  - Supersedes / closes https://github.com/ppy/osu/pull/22795
  
  Roughly uses design shown in
  https://github.com/ppy/osu/pull/22795#issuecomment-1579936284 with some
  modifications to better fit everything else, and some customisation
  options so it can fit better on other skins.

  Bartłomiej Dach · 2025-01-15 14:17:53 +01:00
  582c5180b9
• Move animation handling to Carousel implementation to better handle add/removes

  With the animation logic being external, it was going to make it very
  hard to apply the scroll offset when a new panel is added or removed
  before the current selection.
  
  There's no real reason for the animations to be local to beatmap
  carousel. If there's a usage in the future where the animation is to
  change, we can add more customisation to `Carousel` itself.

  Dean Herbert · 2025-01-15 17:01:07 +09:00
  6027947657
• Merge pull request #31506 from peppy/fix-storyboard-break-overhead

  Fix stutter on intensive storyboards when entering break time with 100% background dim

  Bartłomiej Dach · 2025-01-15 08:23:58 +01:00
  614243fef4
• Remove Status and Activity bindables from APIUser

  As for the tests, I'm (ab)using the `IsOnline` state for the time being
  to restore functionality.

  Dan Balasescu · 2025-01-14 23:45:30 +09:00
  20108e3b74
• Add difficulty, artist and title sort examples

  Also:
  
  - Adds hinting at grouping and header status of items
  - Passes through criteria and prepare for grouping tests.
  - Makes `Filters` list `protected` because naming clash with `Filter()`
    on `BeatmapCarousel`.

  Dean Herbert · 2025-01-14 19:52:48 +09:00
  7e8a80a0e5
• Split out BeatmapCarousel classes and drop V2 suffix
  Dean Herbert · 2025-01-14 19:18:02 +09:00
  d97a3270a5
• Merge branch 'master' into beatmap-carousel-v2
  Dean Herbert · 2025-01-14 19:06:52 +09:00
  8d41eda91a
• Merge pull request #31444 from smoogipoo/friend-presence-2

  Add notifications for when friends go online or offline

  Dean Herbert · 2025-01-14 18:58:19 +09:00
  b4d054fdc0
• Merge pull request #31474 from peppy/scroll-container-double-precision

  Update game `ScrollContainer` usage in line with framework changes

  Bartłomiej Dach · 2025-01-14 10:56:55 +01:00
  459577cc32
• Make test class partial
  Bartłomiej Dach · 2025-01-14 09:22:56 +01:00
  058ff8af77
• Add failing test coverage showing storyboard not being updated when dimmed
  Dean Herbert · 2025-01-14 16:22:10 +09:00
  7761a0c18a
• Adjust test to pass

  What I think was happening here is that the dump of the accuracy
  counter's state was happening too early. The component is loaded
  synchronously into the `ISerialisableDrawableContainer` before its
  default position is set via the "apply defaults" `ArgonSkin` flow
  - so the test needs to wait for that to take place first.

  Bartłomiej Dach · 2025-01-13 13:14:34 +01:00
  39a69d6454