71348 Commits

This Branch

This Branch

All Branches

• Update test case to consider pen as touch
  Salman Alshamrani · 2025-01-25 18:08:57 -05:00
  91e944d4e9
• Add basic test coverage for pen + touch playstyle
  Salman Alshamrani · 2025-01-25 17:15:38 -05:00
  67c36b2c82
• Merge pull request #31664 from ThePooN/ios-non-exempt-encryption

  🔧 Specify we're not using non-exempt encryption

  Salman Alshamrani · 2025-01-24 13:00:08 -05:00
  129ab03ec4
• 🔧 Specify we're not using non-exempt encryption
  ThePooN · 2025-01-24 18:14:55 +01:00
  354126b7f7
• Merge pull request #31652 from peppy/beatmap-carousel-v2-split-panels

  Split out beatmap and set panels in  beatmap carousel v2

  Bartłomiej Dach · 2025-01-24 16:00:04 +01:00
  3c763971ff
• Merge branch 'master' into beatmap-carousel-v2-split-panels
  Bartłomiej Dach · 2025-01-24 15:16:23 +01:00
  092c7b4253
• Remove unused field
  Bartłomiej Dach · 2025-01-24 15:15:50 +01:00
  55ab3c72f6
• Remove selection animation on set panel
  Dean Herbert · 2025-01-24 22:45:08 +09:00
  82c5f37c2c
• Fix test failures
  Bartłomiej Dach · 2025-01-24 14:24:16 +01:00
  b0136f98a9
• Merge pull request #31645 from peppy/offset-adjust-more-lenience

  Make offset adjust more lenient

  Bartłomiej Dach · 2025-01-24 14:01:25 +01:00
  7845c5cfb7
• Merge pull request #31623 from Layendan/room-context-menu

  Add view in browser context menu functionality to multiplayer/playlist rooms

  Dean Herbert · 2025-01-24 20:31:49 +09:00
  a94681158d
• Fix breakage from reordering co-reliant variable sets (and guard against it)
  Dean Herbert · 2025-01-24 20:20:18 +09:00
  da762384f8
• Split out beatmaps and set panels into two separate classes
  Dean Herbert · 2025-01-24 20:10:41 +09:00
  175eb82ccf
• Move pool item preparation / cleanup duties to Carousel
  Dean Herbert · 2025-01-24 20:10:41 +09:00
  0164a2e4dc
• Merge pull request #31634 from peppy/beatmap-carousel-v2-selection

  Add selection support to beatmap carousel v2

  Bartłomiej Dach · 2025-01-24 11:43:17 +01:00
  2d46da1520
• Move activation drawable flow portion to ICarouselPanel
  Dean Herbert · 2025-01-24 18:40:48 +09:00
  9366bfbf0d
• Adjust comments on ICarouselPanel to imply external use
  Dean Herbert · 2025-01-24 18:34:04 +09:00
  92429b2ed9
• Merge pull request #31644 from peppy/fix-beatmap-offset-crash

  Fix potential crash when adjusting offset

  Bartłomiej Dach · 2025-01-24 10:20:29 +01:00
  2f84aec88d
• Fix average button not correctly becoming disabled where it previously would
  Dean Herbert · 2025-01-24 17:17:34 +09:00
  721b2dfbba
• Move line to correct location
  Dean Herbert · 2025-01-24 16:45:14 +09:00
  28a59f4e29
• Adjust layout and code quality slightly
  Dean Herbert · 2025-01-24 15:57:13 +09:00
  05b1002e9d
• Bypass offset disallowed status when handling realm callbacks

  Hopefully don't need to overthink this one.

  Dean Herbert · 2025-01-24 15:49:47 +09:00
  8f8a6455b4
• Add safeties against attempting to apply previous play while offset adjust is not allowed

  This should theoretically not be possible, but while we are sharing this
  control's implementation between gameplay and non-gameplay usages, let's
  ensure nothing weird can occur.

  Dean Herbert · 2025-01-24 15:49:47 +09:00
  ee78e1b223
• Consume GameplayStartTime for more lenient offset adjustments
  Dean Herbert · 2025-01-24 15:30:02 +09:00
  fb10996951
• Expose GameplayStartTime in IGameplayClock
  Dean Herbert · 2025-01-24 15:29:49 +09:00
  5cc8181bad
• Merge pull request #31640 from frenzibyte/discord-rpc-ux

  Hide Discord RPC error messages away from user attention

  Dean Herbert · 2025-01-24 14:36:13 +09:00
  4ae6dfd790
• Hide Discord RPC error messages away from user attention
  Salman Alshamrani · 2025-01-23 21:22:35 -05:00
  61a818e4ed
• Remove unused method
  Layendan · 2025-01-23 15:39:18 -07:00
  d326f23576
• Fix formatting
  Layendan · 2025-01-23 15:37:30 -07:00
  b0a7237fd6
• Inherit menu items from parent class
  Layendan · 2025-01-23 15:36:20 -07:00
  13c64b59af
• Merge pull request #31633 from bdach/thanks-for-nothing-github-actions

  Roll back windows build image to 2019 on android build job

  Dean Herbert · 2025-01-24 00:35:58 +09:00
  c3269013d9
• Simplify selection handling logic
  Dean Herbert · 2025-01-23 23:58:51 +09:00
  f4270ab3b9
• Add regions to BeatmapCarousel
  Dean Herbert · 2025-01-23 23:53:09 +09:00
  d5369d3508
• ActivateSelection -> TryActivateSelection
  Dean Herbert · 2025-01-23 22:44:39 +09:00
  0716b73d2a
• Adjust inline commentary based on review feedback
  Dean Herbert · 2025-01-23 22:41:20 +09:00
  2feab31426
• Add test coverage of various selection examples

  Where possible I've tried to match the test and method names of
  `TestSceneBeatmapCarousel` for easy coverage comparison.

  Dean Herbert · 2025-01-23 18:51:25 +09:00
  eaea053c7d
• Fix sort direction being flipped
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  ffca90779f
• Tidy up tests in preparation for adding more
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  9ab045495d
• Add selection and activation flow
  Dean Herbert · 2025-01-23 18:51:24 +09:00
  2f94456a06
• Add set-difficulty tracking in BeatmapCarouselFilterGrouping

  Rather than tracking inside individual items, let's just maintain a
  single dictionary which is refreshed every time we regenerate filters.

  Dean Herbert · 2025-01-23 18:48:44 +09:00
  ecef5e5d71
• Make CarouselItem sealed and remove BeatmapCarouselItem concept

  Less abstraction is better. As far as I can tell, we don't need a custom
  model for this. If there's any tracking to be done, it should be done
  within `BeatmapCarousel`'s implementation (or a filter).

  Dean Herbert · 2025-01-23 18:48:44 +09:00
  980f6cf18e
• Move Selected status to drawables

  Basically, I don't want bindables in `CarouselItem`. It means there
  needs to be a bind-unbind process on pooling. By moving these to the
  drawable and just updating every frame, we can simplify things a lot.

  Dean Herbert · 2025-01-23 18:48:43 +09:00
  c67c0a7fc0
• Merge pull request #31632 from peppy/beatmap-carousel-v2-cleanups

  Initial carousel additions in preparation for selection logic

  Bartłomiej Dach · 2025-01-23 10:43:12 +01:00
  beaadfa1fa
• Roll back windows build image to 2019 on android build job

  Per workaround suggested in
  https://github.com/actions/runner-images/issues/11402#issuecomment-2596473501.
  
  Applying this now as my hopes for a swift resolution without changes on
  our side are slim to none (read thread linked above in full to learn
  why).

  Bartłomiej Dach · 2025-01-23 10:12:30 +01:00
  b4e8a17f03
• displayedCarouselItems -> carouselItems
  Dean Herbert · 2025-01-23 15:58:35 +09:00
  ded1d9f019
• Only show loading when doing a user triggered filter
  Dean Herbert · 2025-01-23 15:51:54 +09:00
  d526835627
• Reorder carousel methods into logical regions
  Dean Herbert · 2025-01-23 15:50:57 +09:00
  6ac2dbc818
• Show selection defaults in test scene (and make prettier)
  Dean Herbert · 2025-01-23 15:50:40 +09:00
  8657576210
• Fix formatting
  Layendan · 2025-01-22 11:42:11 -07:00
  f673d16a1f
• Merge pull request #31509 from bdach/local-metadata-cache-corruption

  Refetch local metadata cache if corruption is detected

  Dean Herbert · 2025-01-23 02:43:14 +09:00
  bf23c67603