67745 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	901fec65ef	Address code quality issues	2024-07-03 15:49:17 +02:00
Arthur Araujo	21829e7ef4	Fix test method names	2024-07-02 21:12:15 -03:00
Arthur Araujo	7143ff523f	Make MarkerChecks and MarkerCheck class private	2024-07-02 21:09:49 -03:00
Arthur Araujo	7cdad20119	Fix explicit array type specification in MarkerChecks	2024-07-02 20:55:52 -03:00
Arthur Araujo	7cb3d7445c	Add verify checks for title markers	2024-07-02 17:20:00 -03:00
Bartłomiej Dach	3bf3e9133b	Merge pull request #28689 from smoogipoo/fix-break-conversion ... Fix `ManiaModInvert` permanently destroying the beatmap	2024-07-02 07:53:16 +02:00
Dan Balasescu	00462f6d56	Merge pull request #28660 from mcendu/no-release-mod ... Add "No Release" mod	2024-07-02 12:46:27 +09:00
Dan Balasescu	31edca866c	Remove unused code	2024-07-02 12:21:24 +09:00
Dan Balasescu	04da1209f7	Revert "Change breaks list to IReadOnlyList" ... This reverts commit 2c3b411bb5.	2024-07-02 12:16:11 +09:00
Dan Balasescu	db84711214	Revert "Move break cloning back to non-virtual method" ... This reverts commit f69bc40a4b.	2024-07-02 12:16:10 +09:00
Dean Herbert	f69bc40a4b	Move break cloning back to non-virtual method	2024-07-02 12:07:13 +09:00
Dean Herbert	2c3b411bb5	Change breaks list to IReadOnlyList	2024-07-02 11:59:24 +09:00
Dean Herbert	f694ae416e	Fix typo in xmldoc	2024-07-02 11:47:40 +09:00
Dean Herbert	005af280f2	Isolate bindable breaks list to EditorBeatmap	2024-07-02 11:31:55 +09:00
Nathan Du	1eb10e029c	Rewrite no release mod ... Per the request of spaceman_atlas, the No Release mod is rewritten to avoid modifications to DrawableHoldNoteTail. The approach is based on that of the Strict Tracking mod for the osu!(standard) ruleset, injecting the mod behavior by replacing the normal hold note with the mod's variant. The variant inherits most bevaior from the normal hold note, but when creating nested hitobjects, it creates its own hold note tail variant instead, which in turn is used to instantiate the mod's variant of DrawableHoldNoteTail with a new behavior. The time a judgement is awarded is changed from the end of its Perfect window to the time of the tail itself.	2024-07-01 20:29:30 +08:00
Dan Balasescu	f942595829	Fix ManiaModInvert permanently messing up the beatmap	2024-07-01 15:02:00 +09:00
Dan Balasescu	4cb58fbe47	Add failing test	2024-07-01 15:02:00 +09:00
Dean Herbert	56f4f40334	Merge pull request #28657 from peppy/playfield-skin-components-respect-border ... Change "playfield" skin layer to respect shifting playfield border in osu! ruleset	2024-07-01 10:35:15 +09:00
Dan Balasescu	2f9bce5274	Merge pull request #28686 from peppy/fix-summary-timeline-break-display ... Fix summary timeline not correctly updating after changes to breaks	2024-07-01 10:03:16 +09:00
Dean Herbert	8bb51d5a4f	Fix summary timeline not correctly updating after changes to breaks ... Closes https://github.com/ppy/osu/issues/28678. Oops.	2024-06-30 20:32:16 +09:00
Nathan Du	463ab46fee	formatting	2024-06-29 16:46:16 +08:00
Nathan Du	679f4735b3	add tests for No Release mod ... The new test scene is essentially a copy of TestSceneHoldNoteInput, modified to test the judgement changes applied by the new mod. A base class might need to be abstracted out for them.	2024-06-29 16:20:07 +08:00
Nathan Du	960d552dc1	Initial implemention of the No Release mod ... This commit adds a new osu!mania mod No Release that relaxes tail judgements. The current implementation automatically awards Perfect (or Meh if the hold note is broken midway) for a hold note tail at the end of its Perfect window, as long as it is held by then. Tests are pending for the next commit.	2024-06-28 22:21:08 +08:00
Bartłomiej Dach	18f4fac4c1	Merge pull request #25725 from smoogipoo/fix-juicestream-velocity ... Fix JuiceStream velocity calculation	2024-06-28 13:42:44 +02:00
Bartłomiej Dach	81c6da98c2	Merge pull request #26465 from LeNitrous/fix/editor-test-exit ... Fix editor test play not marking hit objects before its start time as judged.	2024-06-28 12:12:17 +02:00
Bartłomiej Dach	deeb2e99a2	Add test for correct juice stream tick counts in editor ... cda9440a29 inadvertently fixes this in the most frequent case by inverting the `TickDistanceMultiplier` from being not-1 to 1 on beatmap versions above v8. This can still potentially go wrong if a beatmap from a version below v8 is edited, because upon save it will be reencoded at the latest version, meaning that the multiplier will change from not-1 to 1 - but this can be handled separately.	2024-06-28 11:58:07 +02:00
Bartłomiej Dach	c70a72ece8	Merge branch 'master' into fix-juicestream-velocity	2024-06-28 11:47:39 +02:00
Dean Herbert	55b80f70f6	Change "playfield" skin layer to respect shifting playfield border in osu! ruleset	2024-06-28 18:12:20 +09:00
Dean Herbert	4bb8a45d75	Merge pull request #28636 from bdach/daily-challenge/watch-room ... Add client/server models for allowing clients to receive realtime playlist updates	2024-06-28 17:51:40 +09:00
Bartłomiej Dach	007bd3973a	Merge pull request #28653 from peppy/featured-artist-even-more-visible ... Update beatmap listing filter overlay to better imply selected filters	2024-06-28 09:50:21 +02:00
Bartłomiej Dach	a3ea36d2b2	Fix formatting	2024-06-28 09:45:45 +02:00
Bartłomiej Dach	7ac5bd4d37	Ensure past drawable objects also get their results populated in editor test play	2024-06-28 09:37:10 +02:00
Bartłomiej Dach	ace6427d40	Expand test coverage ... - Covers fail case that wasn't covered before - Removes arbitrary wait step that was inevitably going to cause intermittent test failures	2024-06-28 09:30:28 +02:00
Bartłomiej Dach	b36e0f0875	Merge branch 'master' into fix/editor-test-exit	2024-06-28 09:17:40 +02:00
Bartłomiej Dach	030bbf2641	Fix vertical overlaps on multiselection filters when they wrap	2024-06-28 09:07:29 +02:00
Dean Herbert	04c09b5027	Merge pull request #28652 from smoogipoo/fix-dangerous-button-lowpass ... Fix low pass filter sometimes not applied in dialog overlays	2024-06-28 16:05:35 +09:00
Dean Herbert	fa1527f446	Update design for selected filters to better imply that they are selected	2024-06-28 15:45:09 +09:00
Dan Balasescu	77b00dac7e	Fix low pass filter sometimes not applied in dialog overlays	2024-06-28 15:20:55 +09:00
Dean Herbert	c1bec7a7c3	Simplify colour logic for beatmap overlay filter rows	2024-06-28 14:55:55 +09:00
Dan Balasescu	1668048fb7	Merge pull request #28650 from peppy/mod-preset-tooltip-improvements ... Show mod preset description text in tooltip popup	2024-06-28 14:07:06 +09:00
Dean Herbert	d370f50cc1	Syncrhronise colours across mod and preset tooltips	2024-06-28 13:16:54 +09:00
Dean Herbert	28d5278935	Show preset description text in tooltip popup ... As proposed in https://github.com/ppy/osu/discussions/28610.	2024-06-28 13:16:53 +09:00
Dan Balasescu	17151e81ee	Merge pull request #28500 from Givikap120/pp_counter_fix ... Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject"	2024-06-28 13:12:45 +09:00
Dan Balasescu	3b3f914cd2	Merge branch 'master' into pp_counter_fix	2024-06-28 12:40:56 +09:00
Dean Herbert	8598e8bf34	Merge pull request #28640 from bdach/osu-inspector-distance ... Show distance in pixels to previous/next object in osu! hitobject inspector	2024-06-28 00:44:31 +09:00
Dean Herbert	fd6b77ea92	Fix distance snap control being removed	2024-06-27 23:59:38 +09:00
Dean Herbert	b293eb7930	Remove redundant array spec	2024-06-27 22:19:06 +09:00
Bartłomiej Dach	1b741dada3	Show distance in pixels to previous/next object in osu! hitobject inspector	2024-06-27 14:46:57 +02:00
Bartłomiej Dach	e35744118c	Merge pull request #28638 from OliBomby/beat-divisor ... Fix editor not loading arbitrary beat divisors	2024-06-27 13:31:44 +02:00
Bartłomiej Dach	772a68cb3e	Add test coverage for correct beat divisor save	2024-06-27 12:38:29 +02:00