1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 16:57:25 +08:00
Commit Graph

58258 Commits

Author SHA1 Message Date
Joseph Madamba
5dfd4180c8 Fix playlist selecting random item when not allowed after deleting 2023-01-03 11:10:02 -08:00
Joseph Madamba
49b0984079 Add failing playlist no selection after deleted test 2023-01-03 11:10:01 -08:00
Bartłomiej Dach
4ead7ea33f
Merge branch 'master' into fix-leaderboard-fetch-wrong 2023-01-03 20:01:30 +01:00
Bartłomiej Dach
cd3ff9534c
Merge pull request #22018 from frenzibyte/fix-combo-colour-export
Fix editor exporting beatmap combo colours in wrong order
2023-01-03 20:01:18 +01:00
Bartłomiej Dach
3d425c93e6
Merge branch 'master' into fix-combo-colour-export 2023-01-03 19:21:24 +01:00
Salman Ahmed
6f67e3ba12
Merge pull request #22016 from peppy/fix-volume-controls-chat-text-box
Fix default volume control keys not working when chat textbox is focused
2023-01-03 20:46:38 +03:00
Dean Herbert
beb3b96aca Harden request equality checks 2023-01-04 01:44:00 +08:00
Dean Herbert
96e81e7f41 Switch on NRT and add IEquatable to GetScoresRequest 2023-01-04 01:41:21 +08:00
Salman Ahmed
a06e25ac83
Merge branch 'master' into fix-volume-controls-chat-text-box 2023-01-03 20:04:47 +03:00
Dean Herbert
4300555efe
Merge pull request #22019 from frenzibyte/fix-catch-mod-no-scope
Fix catcher not moving when fully hidden with "No Scope" mod
2023-01-03 21:25:46 +08:00
Salman Ahmed
71125afcb4 Add test coverage 2023-01-03 15:43:44 +03:00
Salman Ahmed
efbd9ba4b9 Fix catcher not moving when fully hidden in "No Scope" mod 2023-01-03 15:28:05 +03:00
Salman Ahmed
4491a5ba9f Fix editor exporting beatmap combo colours in wrong order 2023-01-03 13:41:08 +03:00
Dean Herbert
ac85433178 Fix default volume control keys not working when chat textbox is focused
Closes #22004.
2023-01-03 09:44:35 +08:00
Dean Herbert
8f7ae0395a Fix song select leaderboard potentially showing wrong scores on quick beatmap changes
Closes #22002.
2023-01-03 00:55:09 +08:00
Bartłomiej Dach
a124c967df
Add proper offline & loading state handling to user profile overlay 2023-01-02 17:23:09 +01:00
Bartłomiej Dach
c759b743dc
Add support for switching rulesets on profile overlay 2023-01-02 17:23:06 +01:00
Bartłomiej Dach
a2e726502f
Add ruleset selector to profile overlay 2023-01-02 17:23:04 +01:00
Bartłomiej Dach
7683ab68b0
Use UserProfile in profile ruleset selector 2023-01-02 17:23:01 +01:00
Bartłomiej Dach
1722f3a125
Add ruleset to UserProfile 2023-01-02 17:22:55 +01:00
Bartłomiej Dach
4dd7727f71
Remove test-specific workaround in overlay 2023-01-02 17:21:14 +01:00
Bartłomiej Dach
ae3a211da7
Rewrite user profile overlay test to not depend on online API 2023-01-02 17:21:12 +01:00
Bartłomiej Dach
d7294ac3e6
Substitute APIUser for UserProfile in overlay 2023-01-02 17:21:09 +01:00
Bartłomiej Dach
608d8ee7d4
Add UserProfile model to be used in user profile overlay
As `APIUser` implements `IEquatable`, attempting to replace an `APIUser`
with another `APIUser` with the same online ID has no effect on the user
profile overlay. This is a significant hurdle in implementing support
for viewing the profile for different rulesets, as in that case the
profile is basically reloaded for the same user, but slightly different
data.

To facilitate this, wrap `APIUser` in a new `UserProfile` class. This
will mean that the equality rules can be changed locally to the user
profile overlay without impacting other components that depend on the
`APIUser` equality rules. The ruleset that the user profile is being
displayed with will eventually be added to `UserProfile`, too.
2023-01-02 17:21:00 +01:00
Dean Herbert
53cc71c2fe
Merge pull request #21991 from bdach/user-profile/nrt
Enable NRT in user profile overlay
2023-01-02 18:17:55 +08:00
Bartłomiej Dach
73f14bd14f
Enable NRT in user profile overlay test scenes 2023-01-01 23:49:15 +01:00
Bartłomiej Dach
88e90d5fa0
Enable NRT in user profile overlay 2023-01-01 23:49:11 +01:00
Bartłomiej Dach
b689ad6d80
Fix changing preview point not prompting for save 2023-01-01 19:54:26 +01:00
Bartłomiej Dach
efdd557f3b
Adjust binding logic 2023-01-01 19:45:23 +01:00
Bartłomiej Dach
452ebddfd2
Adjust visual appearance of preview time part
- Use slightly different hue of green to distinguish from difficulty
  control points. The colour is still not ideal, but picking
  a distinctive enough hue is pretty hard.

- Place the preview time part at the bottom rather at the top.
  Not sure why it was at the top; not only could it overlap with the
  control points, but it also looked quite badly misaligned there
  when bookmarks were displayed at the bottom.
2023-01-01 19:42:55 +01:00
Bartłomiej Dach
656bf12b3d
Add all possible timeline elements to test for demonstrative purposes 2023-01-01 19:42:46 +01:00
Bartłomiej Dach
a82f1a6abd
Adjust method naming and copy 2023-01-01 18:50:47 +01:00
Bartłomiej Dach
0e59b55a12
Merge branch 'master' into previewTime 2023-01-01 18:38:19 +01:00
Bartłomiej Dach
b97d4b571e
Merge pull request #21916 from Joehuu/remember-chat-textbox-per-channel
Save / sync chat text box messages per channel
2023-01-01 18:02:31 +01:00
Bartłomiej Dach
2698d58c46
Merge branch 'master' into remember-chat-textbox-per-channel 2023-01-01 17:29:38 +01:00
Dean Herbert
7e39ee3982
Merge pull request #21945 from cdwcgt/acc-UI
Add new display modes for accuracy counter
2023-01-01 23:20:12 +08:00
Bartłomiej Dach
a454fa4b8b
Merge pull request #21983 from peppy/fix-recent-activity-linking
Fix incorrect domain root being used for recent activity entries on profile overlay
2023-01-01 11:22:26 +01:00
Dean Herbert
9a4f0cad2c Fix incorrect domain root being used for recent activity entries on profile overlay
Closes https://github.com/ppy/osu/issues/21980.
2023-01-01 17:48:05 +08:00
Bartłomiej Dach
f7c8986292
Merge pull request #21979 from peppy/add-beatmaps-override-keywords
Add search keywords for beatmap colours / hitsound overrides
2023-01-01 09:27:19 +01:00
Dean Herbert
87250ad847 Add search keywords for beatmap colours / hitsound overrides 2023-01-01 14:32:28 +08:00
Bartłomiej Dach
6509d3538c
Fix counter initially rolling down from 100% to 0% in minimum achievable mode 2022-12-30 21:13:41 +01:00
Bartłomiej Dach
7580ab78be
Move binding to LoadComplete() 2022-12-30 21:08:48 +01:00
Bartłomiej Dach
6ed474d4fb
Rearrange formula for maximum accuracy
Feels like it's easier to understand this way. The difference of the
maximum scoring values for the entire beatmap and the max values for the
part of the beatmap that has already been played represents the act of
filling the rest of the unjudged objects with maximum results.
2022-12-30 20:56:54 +01:00
Bartłomiej Dach
ae026e2d2d
Add test coverage 2022-12-30 20:55:54 +01:00
Bartłomiej Dach
8ace635249
Adjust minimum values 2022-12-30 20:55:51 +01:00
Bartłomiej Dach
bb2822a175
xmldoc pass 2022-12-30 20:55:48 +01:00
Bartłomiej Dach
6d42cc5a36
Naming pass 2022-12-30 20:30:58 +01:00
Dean Herbert
ceedc3f934
Merge pull request #21937 from bdach/fix-toolbar-gradient
Fix toolbar gradient not showing when mouse is hovered over buttons
2022-12-31 03:07:59 +08:00
cdwcgt
d60349c7c6
add description 2022-12-30 23:24:41 +09:00
cdwcgt
8beb168be9
remove nullable disabled 2022-12-30 23:24:20 +09:00