Dan Balasescu
93c1a27f22
Add failing test
2024-08-13 18:34:28 +09:00
Andrei Zavatski
c500264306
Cache created judgement in HitObject
2024-02-09 23:20:31 +03:00
ekrctb
32acaa44be
Remove now-redundant code
2023-01-19 19:57:25 +09:00
ekrctb
812a4b412a
Move judgement result revert logic to Playfield
...
Previously, some judgement results were not reverted
when the source DHO is not alive (e.g. frames skipped in editor).
Now, all results are reverted in the exact reverse order.
2023-01-19 19:57:13 +09:00
Dan Balasescu
7bc8908ca9
Partial everything
2022-11-27 00:00:27 +09:00
Dan Balasescu
7527d815e8
Remove unused using
2022-09-22 20:58:23 +09:00
Dean Herbert
a2ff31f37d
Fix failing test
2022-09-22 20:43:38 +09:00
Dean Herbert
cb8ed1f144
Adjust variables slightly for readability
2022-09-21 01:29:12 +09:00
Drison64
979f7f88a1
Fixed TestCatcherWidth and added TestFruitClampedToCatchableRegion
2022-09-20 12:41:06 +02:00
Drison64
18fe37bb22
Reverted changes
2022-09-19 17:25:35 +02:00
Drison64
ca9fe9f240
Fixed TestCatcherCatchWidth failing
2022-09-18 22:05:09 +02:00
Dan Balasescu
f8830c6850
Automated #nullable processing
2022-06-17 16:37:17 +09:00
Darius Wattimena
9685892b94
Added an extra unit test when actually catching the last banana to also clear the plate
2021-11-18 20:23:42 +01:00
Darius Wattimena
cfedbb92c1
Added a unit test to cover clearing of the plate when missing the last banana
2021-11-18 20:07:03 +01:00
Dean Herbert
6944151486
Apply batch fixing of built-in types using var
2021-10-27 13:04:41 +09:00
Dean Herbert
a92d499d7a
Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
2021-10-01 16:55:50 +09:00
ekrctb
da69867fd4
Move catcher trail generation logic to CatcherArea
2021-07-27 19:07:37 +09:00
ekrctb
bb046fa3b8
Move catcher trail generation logic to Catcher
...
It resolves mutual dependency of `Catcher` and `CatcherTrailDisplay`.
Trail generation logic is moved to `Catcher`.
The generation logic no longer uses delayed scheduling because the hidden state is hard to manage.
Instead, the last time a trail is generated is calculated and used.
The new logic has a different behavior when the dash key is pressed in succession under 50ms, but it is not noticeable for normal plays.
2021-07-26 17:51:59 +09:00
ekrctb
b88ee3c1a1
Pass DroppedObjectContainer via constructor instead of DI
...
It is now just one level deep, so it is not beneficial to use DI here.
This effectively reverts ae09c23e
2021-07-19 20:11:49 +09:00
ekrctb
623ba15919
Relax caught object stacking test
...
The stacking code currently uses an unseeded RNG and there is a non-zero chance the stack will be very flat (small Y position difference).
Technically, `RNG.NextSingle(0, 5)` can return `0`, but extremely unlikely that the all RNG calls return 0.
2021-07-04 10:23:49 +09:00
ekrctb
170513568b
Move caught object stack vertical offset logic
2021-07-02 20:43:47 +09:00
ekrctb
ae09c23e4e
Resolve DroppedObjectContainer via DI
2021-06-24 16:09:13 +09:00
ekrctb
16d5893535
Add DroppedObjectContainer class
2021-06-24 15:51:54 +09:00
ekrctb
181f1da3d3
Maintain catch hit explosion by lifetime entries
...
- Fix hit explosion not showing when a replay is rewound to a time after a hit object is caught
2021-06-04 19:46:50 +09:00
Dean Herbert
2203552e9e
Add stacking test logic to TestSceneCatcherArea for skinned testing
2021-04-22 17:34:53 +09:00
Dean Herbert
84a7138223
Update tests to better support stack regeneration cases
2021-04-22 17:13:19 +09:00
smoogipoo
7fa5fd5647
Update usages of config with framework changes
2021-03-17 16:10:16 +09:00
ekrctb
ccca7e0b25
more specific type droppedObjectContainer
2020-12-09 10:35:01 +09:00
ekrctb
c301223d8c
Make object on the catcher plate separate CaughtObject class
2020-12-08 21:11:40 +09:00
ekrctb
ed50fd445e
Fix hit lighting colour not applied in TestSceneCatcher
2020-12-08 21:07:12 +09:00
ekrctb
100b365c98
Restore hyper dash state on revert judgement result
2020-12-08 15:21:47 +09:00
ekrctb
cb76a2d7b5
Restore catcher state on revert judgement result
2020-12-08 15:03:03 +09:00
ekrctb
0213f77b4b
Move catcher state changing logic to OnNewResult method
2020-12-08 14:28:30 +09:00
ekrctb
3de46d0a3b
Fix & clarify catcher tests
2020-12-04 10:14:00 +09:00
ekrctb
1d669cf65e
Add more TestSceneCatcher tests
...
Some tests are moved from TestSceneCatcherArea
2020-12-03 16:44:36 +09:00
ekrctb
2eb2c934cc
Refactor fruit dropping code
...
- The repeated `Remove` call was quadratic complexity.
Now it is linear time.
2020-12-03 16:44:36 +09:00
smoogipoo
648999a2de
Remove all RequiredTypes usages
2020-05-16 18:17:12 +09:00
Salman Ahmed
95de2c6f7f
Mark Catcher.additiveTarget to never be null
...
And provide empty containers instead.
2020-04-22 05:04:07 +03:00
Dean Herbert
2c840c52a3
Add skinnable test scene per ruleset to better allow dynamic compilation
2020-04-07 16:20:13 +09:00
Dean Herbert
1733519c3a
Split out CatcherArea nested classes and reorder methods
2020-03-13 12:59:30 +09:00
Dean Herbert
0d18ea1d29
Add animation and fallback catcher support
2020-03-10 12:36:25 +09:00
Dean Herbert
a3e0f84fcc
Update catcher test to use SkinnableTestScene
2020-02-17 17:19:46 +09:00
Dean Herbert
45514ff660
Apply fixes
2019-11-25 11:30:55 +09:00
Dean Herbert
c0bcbfd892
Merge branch 'master'
...
Conflicts:
osu.Game.Tests/Visual/Gameplay/TestSceneSkinnableDrawable.cs
2019-09-05 14:40:30 +09:00
Dean Herbert
40c61894ef
Update some case sensitive resources lookups in-line with resources
2019-09-04 10:44:24 +09:00
Dean Herbert
bebc3309ce
Refactor skin configuration to be infinitely extensible
2019-09-03 17:57:34 +09:00
Dean Herbert
70e417533f
Update naming
2019-08-30 15:13:29 +09:00
Dean Herbert
a15828ab25
Introduce the concept of SkinComponents
...
Removes reliance on string lookups and better defines elements for introduction into database
2019-08-30 14:55:52 +09:00
iiSaLMaN
94b5caf740
Fix build issues
2019-08-23 15:18:56 +03:00
iiSaLMaN
d8535574d1
Pass sample info to Skin.GetSample
2019-08-23 14:32:43 +03:00
