Bartłomiej Dach
8754fa40f4
Source autoplay mod from beatmap about to be presented rather than ambient global
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
063694f544
Do not attempt to load gameplay scene if current beatmap is dummy
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
9d39b70e38
Fix endless player not handling load failure
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
055fb5bd8f
Do not set initial activity in skin editor endless player
...
Seems like an overreach to say that the user is "watching a replay"
there.
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
43312619e3
Add test coverage for crashing on wrong ruleset
2023-12-04 14:42:51 +01:00
Bartłomiej Dach
7c041df0f1
Add test coverage for crashing on dummy beatmap
2023-12-04 14:42:42 +01:00
Bartłomiej Dach
d3e94cd5bf
Add test coverage for crashing on empty beatmap
2023-12-04 14:42:40 +01:00
Bartłomiej Dach
7deff70b4a
Extract beatmap import steps from gameplay scene switch helper
2023-12-04 13:34:36 +01:00
Dean Herbert
36b1369a4e
Merge pull request #25636 from Susko3/fix-older-android-storage
...
Request `READ_EXTERNAL_STORAGE` on older android versions
2023-12-04 12:11:08 +09:00
Dean Herbert
c2a4a6d8cb
Add inline comment matching framework
2023-12-04 12:10:31 +09:00
Dean Herbert
e06d5f5875
Merge pull request #25649 from smoogipoo/remove-mania-drain-again
...
Once again remove Mania passive HP drain
2023-12-04 12:03:32 +09:00
Dan Balasescu
d0acb7f4f9
Improve commenting
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2023-12-04 06:08:31 +09:00
Dan Balasescu
230278f2c9
Once again remove Mania passive HP drain
2023-12-03 01:47:20 +09:00
Bartłomiej Dach
ee2a06be2f
Merge pull request #25627 from Susko3/fix-overlapping-chat-links
...
Fix overlapping chat links crashing the game
2023-12-02 16:36:29 +01:00
Susko3
abb4c943a7
Rename to more readable names
2023-12-01 18:35:57 +01:00
Bartłomiej Dach
30a4e77097
Merge branch 'master' into fix-overlapping-chat-links
2023-12-01 14:30:55 +01:00
Bartłomiej Dach
7ac33bc3eb
Merge pull request #25626 from Susko3/cleanup-chat-link-test
...
Cleanup chat link tests
2023-12-01 14:28:46 +01:00
Bartłomiej Dach
28aa98ab6a
Merge branch 'master' into cleanup-chat-link-test
2023-12-01 13:34:42 +01:00
Bartłomiej Dach
d97ae8df6a
Remove commented out italic code
...
It's a holdover from the Exo days (anyone remember those?) and hasn't
been relevant for years, so why keep it.
2023-12-01 13:31:11 +01:00
Bartłomiej Dach
cdaff30aa6
Update framework
2023-12-01 13:24:51 +01:00
Susko3
e0eea07a3f
Request READ_EXTERNAL_STORAGE on older android versions
2023-12-01 13:01:49 +01:00
Bartłomiej Dach
3d1f10b9eb
Merge pull request #25618 from Joehuu/fix-chat-icon
...
Fix chat overlay top bar icon being incorrect
2023-12-01 13:00:39 +01:00
Susko3
d3517998cf
Use common Overlaps() logic
...
This actually fixes the problem and makes the tests pass
2023-12-01 01:11:10 +01:00
Susko3
30bdd2d4c0
Extract Overlaps() logic to accept generic index and length
2023-12-01 01:07:23 +01:00
Susko3
152c7e513e
Ignore overlapping links instead of crashing
2023-12-01 00:54:13 +01:00
Susko3
c395ae2460
Add failing tests
...
They throws `ArgumentOutOfRangeException` on the first drawable Update()
2023-12-01 00:51:20 +01:00
Susko3
7f9ae55f5e
Add passing tests
2023-12-01 00:48:55 +01:00
Susko3
1a33bfbb3a
Enable NRT
2023-12-01 00:37:16 +01:00
Susko3
fba6349c65
Remove unused properties
2023-12-01 00:36:40 +01:00
Susko3
21fedff54f
Check number of links shown
2023-12-01 00:29:37 +01:00
Susko3
7b1ccb38cb
Remove redundant string interpolation
2023-11-30 23:35:10 +01:00
Susko3
0520ac265f
Move to TestCase-based test
2023-11-30 23:34:43 +01:00
Susko3
52ffbcc6db
Move special cases to TestCase'd test
2023-11-30 23:29:22 +01:00
Susko3
3ca3f25492
Extract local method
2023-11-30 23:26:52 +01:00
Joseph Madamba
d2324cd8f9
Fix chat overlay top bar icon being incorrect
2023-11-30 10:20:01 -08:00
Susko3
9a32c0368e
Remove redundant linkAmount parameter
2023-11-30 14:38:58 +01:00
Susko3
831fe5b9f2
Use collection assert to ease debugging
2023-11-30 14:36:23 +01:00
Dean Herbert
b2e1a63cd7
Merge pull request #25595 from smoogipoo/fix-bad-slider-lengths
...
Fix taiko and mania using the incorrect slider length when converting beatmaps
2023-11-30 16:59:48 +09:00
Dan Balasescu
9c0fefebc9
Merge pull request #25602 from peppy/fix-slider-end-display
...
Fix results screen not including slider end misses in tick count
2023-11-29 22:00:06 +09:00
Dean Herbert
3553717cc6
Fix results screen not including slider end misses in tick count
2023-11-29 21:28:25 +09:00
Dean Herbert
9bee354195
Merge pull request #25601 from smoogipoo/catch-score-ranks
...
Adjust catch score grade cutoffs
2023-11-29 20:57:07 +09:00
Dean Herbert
1cfcaee121
Reorder badges so that SS shows above others
...
This isn't perfect and probably needs much more consideration, but let's
at least give the "better" ranks more visibility by bringing them to the
front.
Of note, this is only important due to the changes to osu!catch
accuracy-grade cutoffs, which brings things closer in proximity than
ever before.
2023-11-29 20:29:52 +09:00
Dan Balasescu
295a1b01d6
Adjust catch score grade cutoffs
2023-11-29 19:05:31 +09:00
Dan Balasescu
1c3bcbd548
Use IHasPath instead of IHasDistance for mania/taiko
2023-11-29 17:30:21 +09:00
Dan Balasescu
301d503b0b
Add another source of FP inaccuracy to match osu!stable
2023-11-29 16:41:19 +09:00
Dean Herbert
448ca6fa27
Merge pull request #25597 from smoogipoo/fix-diffcalc-command
...
Attempt to fix diffcalc script comment-based variable extraction once again
2023-11-29 14:56:58 +09:00
Dan Balasescu
979bbf0d81
Wrap echo in double quotes
2023-11-28 22:12:23 +09:00
Dan Balasescu
16577829e2
Fix mania and taiko slider conversion distance
2023-11-28 21:14:56 +09:00
Dan Balasescu
26855a2c04
Add failing test
2023-11-28 21:14:34 +09:00
Dean Herbert
537c9e031d
Merge pull request #25522 from bdach/no-concurrent-connections
...
Implement flow allowing disconnection from online services when another client instance for same user is detected
2023-11-28 19:09:38 +09:00
