1
0
mirror of https://github.com/ppy/osu.git synced 2025-01-18 14:52:56 +08:00
Commit Graph

12102 Commits

Author SHA1 Message Date
Dean Herbert
0954e0b032
Add seasonal lighting
Replaces kiai fountains for now.
2024-12-20 14:46:20 +09:00
Dean Herbert
024029822a
Add christmas intro 2024-12-20 14:46:20 +09:00
Dean Herbert
55dff1f0ef
Merge branch 'master' into skinnable-mod-display 2024-12-20 14:08:51 +09:00
Dean Herbert
f9939e7f95
Remove invalid test 2024-12-20 00:50:53 +09:00
Bartłomiej Dach
68a5618e81
Add test coverage 2024-12-16 16:03:26 +09:00
Dean Herbert
bdd417c1a1
Move "global" scroll-adjusts-volume to a per-screen component-based implementation 2024-12-16 15:21:07 +09:00
Dean Herbert
64555debc2
Fix adjusting control point offset after undo/redo causing catastrophic failure
Closes https://github.com/ppy/osu/issues/31098.

Low effort fix because it was already half broken. The test was testing
in isolation but in actual editor usage it wasn't working as expected.
2024-12-13 19:33:51 +09:00
Dan Balasescu
f84c67babd
Merge pull request #31101 from Joehuu/recommended-diff-beatmap-listing
Add recommended difficulty numerical value near filter in beatmap listing
2024-12-13 18:57:16 +09:00
Dan Balasescu
e2af8820de
Merge pull request #31107 from bdach/flaky-editor-test
Attempt to fix flaky editor beatmap creation test
2024-12-13 18:53:43 +09:00
Dan Balasescu
edbaaa9468
Fix test 2024-12-13 17:41:55 +09:00
Bartłomiej Dach
fdc41ace7e
Fix flaky editor beatmap creation test
As seen in
https://github.com/ppy/osu/actions/runs/12289146465/job/34294167417#step:5:1588
or
https://github.com/ppy/osu/actions/runs/12310133160/job/34358241666#step:5:53.

Exception messages hint pretty strongly at this being a threading issue
and there does seem to be a rather frivolous lack of waiting for
`CreateNewDifficulty()` to do its thing, so I'm thinking maybe this will
help.
2024-12-13 17:35:41 +09:00
Dean Herbert
b470e30cc0
Add failing test showing player settings appearing in skin editor 2024-12-13 17:18:34 +09:00
Joseph Madamba
f7364de01a
Add test and null protections 2024-12-12 15:23:00 -08:00
Bartłomiej Dach
88241d5b95
Merge pull request #30838 from smoogipoo/better-room-status
Improve multiplayer room status handling
2024-12-12 13:05:59 +09:00
Dean Herbert
862b41c38e
Move BeatmapInfoWedgeV2 to correct namespace 2024-12-12 12:53:05 +09:00
Dean Herbert
a3998fbd52
Merge branch 'master' into better-room-status 2024-12-11 18:06:55 +09:00
Dean Herbert
a868c33380
Remove BeatmapCarousel testing backdoor 2024-12-11 16:28:51 +09:00
Dean Herbert
c94b393e30
Access beatmap store via abstract base class
The intention here is to make things more testable going forward.
Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
where `BeatmapSets` can be set by tests and bypas/block realm retrieval.
2024-12-11 16:28:51 +09:00
Bartłomiej Dach
89e3c551ff
Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files
Allow choosing different background/audio files for individual difficulties
2024-12-11 14:12:58 +09:00
Dean Herbert
48bf2fa001
Merge pull request #30960 from bdach/bookmarks
Implement basic bookmark support in editor
2024-12-09 23:42:04 -08:00
Dean Herbert
7ec2d91e14
Merge branch 'master' into editor-multiple-background-audio-files 2024-12-10 14:19:55 +09:00
Dan Balasescu
1b8d9370aa
Merge pull request #30973 from frenzibyte/copy-effect-points
Preserve effect point specifications when creating blank difficulties
2024-12-09 16:13:52 +09:00
Bartłomiej Dach
459533aba6
Merge branch 'master' into bookmarks 2024-12-07 22:22:04 +09:00
Dean Herbert
2713ae601a
Remove unused using 2024-12-07 14:41:30 +09:00
Bartłomiej Dach
13759f5aa0
Back out test change
It was mostly a demonstrative thing to use in the heat in the moment for
the skinnable mod display and it breaks all other tests. So let's just
not.
2024-12-07 13:47:09 +09:00
Thomas Müller
db18492fbc Update default osk for skinnable mod display 2024-12-07 13:12:09 +09:00
Thomas Müller
0a00f7a7c2 Implement skinnable mod display
Also makes the mod display initialization sequence (start expanded, then
unexpand) controlled by HUDOverlay rather than mod display itself. This
enabled different treatment depending on whether the mod display is
viewed in the skin editor or in the player.

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-12-07 12:06:33 +09:00
Dean Herbert
e22f3b7d05
Merge branch 'master' into named-pipe 2024-12-07 10:42:55 +09:00
Dean Herbert
5849a69a86
Merge pull request #30921 from huoyaoyuan/netcore-analyzer
Set up-to-date .NET code quality analyzers
2024-12-06 17:29:09 -08:00
Dean Herbert
8d0e1f9d18
Merge branch 'master' into improve-menu-sample-playback 2024-12-05 21:07:03 +09:00
Huo Yaoyuan
d92ea910cf Merge branch 'master' into netcore-analyzer 2024-12-05 17:18:56 +08:00
Dean Herbert
791416c8f1
Merge pull request #30937 from frenzibyte/fix-quick-restart-not-saving-score
Fix score no longer being saved when quick-restarting after pass
2024-12-04 23:48:18 -08:00
Salman Alshamrani
8e0f6fc12d Re-encode difficulties on resource change 2024-12-04 04:36:00 -05:00
Salman Alshamrani
60d91bada8 Merge branch 'master' into editor-multiple-background-audio-files 2024-12-04 04:31:15 -05:00
Salman Alshamrani
06824c1658 Add failing test case 2024-12-04 04:20:09 -05:00
Salman Alshamrani
2a6fbb59ff Add failing test case 2024-12-04 02:32:00 -05:00
Bartłomiej Dach
808934581f
Move bookmarks out of BeatmapInfo
Not sure why I didn't do that in https://github.com/ppy/osu/pull/28473...
2024-12-03 14:17:14 +01:00
Dean Herbert
75781e3436
Update usages of IPC in line with framework changes 2024-12-03 16:34:23 +09:00
Dan Balasescu
be05f2a1c2
Merge pull request #30929 from timschumi/rate-change-ready
Account for rate changing mods when disabling the "Ready" button
2024-12-03 16:30:16 +09:00
Dan Balasescu
6ff1dec7b2
Add tests 2024-12-03 15:45:58 +09:00
Dean Herbert
5b2558cec2
Merge pull request #28473 from bdach/beatmap-info-purge
Move unnecessary properties from `BeatmapInfo` / realm to `IBeatmap`
2024-12-02 16:19:12 +09:00
Salman Alshamrani
9140893249 Fix score no longer being saved when quick-restarting after pass 2024-11-30 23:36:02 -05:00
Huo Yaoyuan
68f21709a8 Fix CA1865 2024-11-30 02:32:09 +08:00
Huo Yaoyuan
fa3c95c296 Merge branch 'master' 2024-11-30 01:07:08 +08:00
Dean Herbert
f56b2b9aef
Merge pull request #30793 from bdach/close-playlists
Add ability to close playlists within grace period after creation
2024-11-29 22:37:32 +09:00
Salman Alshamrani
489d7a30ec Perform a single Save call rather than doing it in each difficulty 2024-11-28 18:37:13 -05:00
Salman Alshamrani
078d62fe09 Fix weird default in test scene 2024-11-28 17:54:03 -05:00
Salman Alshamrani
a8db35ac45
Merge branch 'master' into daily-challenge-tier-thresholds 2024-11-28 17:46:55 -05:00
Jamie Taylor
58cf1c11e4
Improve menu/context-menu sample playback 2024-11-29 06:54:48 +09:00
Bartłomiej Dach
2e6f43a75d
Merge branch 'master' into close-playlists 2024-11-28 14:01:36 +01:00
Huo Yaoyuan
f5a7716509 Apply minor performance rules 2024-11-28 20:41:44 +08:00
Hiviexd
6ed21229b7 update test 2024-11-28 12:49:48 +01:00
Bartłomiej Dach
98a156ae2d
Merge pull request #30874 from peppy/chat-order
Sort public chat channels alphabetically, private channels based on recent messages
2024-11-28 12:46:14 +01:00
Huo Yaoyuan
8f6e5c4754 Convert legacy ruleset to globalconfig 2024-11-28 19:34:56 +08:00
Dan Balasescu
077719903b
Merge pull request #30905 from peppy/fix-multiple-offset-applications
Clear previous `LastLocalUserScore` when returning to song select
2024-11-28 18:58:13 +09:00
Dean Herbert
c26c84ba45
Add test coverage governing new behaviour 2024-11-28 18:03:19 +09:00
Bartłomiej Dach
0d491e3159
Merge branch 'master' into fix-daily-challenge-leaderboard 2024-11-28 09:41:24 +01:00
Dan Balasescu
5d7aafaab3
Merge pull request #30894 from HenintsoaSky/star-fountains-toggle-setting
Add a toggle for star fountains during gameplay
2024-11-28 17:35:11 +09:00
Bartłomiej Dach
4314f9c0a9
Remove unused accessors 2024-11-28 09:22:08 +01:00
Salman Alshamrani
238a1ce284 Fix tests reliability and improve code
Shaved off lots of copypasta so the test actually shows what it's testing.
2024-11-27 15:27:21 -05:00
Salman Alshamrani
4b8094d0db Update test coverage 2024-11-27 05:58:06 -05:00
Salman Alshamrani
dfbccc2144 Knock some sense into the playlists results screen implementation
As we're moving towards using the `/playlist/<id>/scores/<id>` endpoint,
the existing playlists results screen classes needed some restructuring.
2024-11-27 01:20:43 -05:00
Dean Herbert
573aaf6637
Merge pull request #27128 from frenzibyte/user-statistics-provider
Introduce `UserStatisticsProvider` component and add support for respecting selected ruleset
2024-11-27 13:13:47 +09:00
HenintsoaSky
80a66085a9 rename and remove again 2024-11-27 00:41:02 +03:00
HenintsoaSky
460471e73f Rename of the setting 2024-11-27 00:27:22 +03:00
HenintsoaSky
df74a177ae Add option to disable star fountain in gameplay 2024-11-27 00:13:32 +03:00
Bartłomiej Dach
33c2eb1af7
Merge pull request #30881 from peppy/fix-editor-state-leaking
Fix hitobjects' samples getting in bad state when changing selection between objects
2024-11-26 13:54:50 +01:00
Bartłomiej Dach
3e373ae85e
Merge pull request #30868 from peppy/ur-perf-fix
Improve performance of UR calculations
2024-11-26 13:54:17 +01:00
Bartłomiej Dach
c69d36dc96
Remove leftover [Solo] attribute 2024-11-26 12:40:49 +01:00
Bartłomiej Dach
cf905d0f5c
Merge branch 'master' into beatmap-info-purge 2024-11-26 10:21:16 +01:00
Dean Herbert
e0199386a3
Add failing test case showing changing selection in editor affects samples 2024-11-26 17:33:41 +09:00
Salman Alshamrani
d150aeef2b Use score-based endpoint everywhere 2024-11-26 01:01:59 -05:00
Dean Herbert
f708466a9b
Add test coverage 2024-11-26 13:25:55 +09:00
Dean Herbert
9ca17f9b6b
Merge pull request #30748 from stanriders/scale-profile-beatmaps
Scale down beatmap cards
2024-11-25 22:53:51 +09:00
Dean Herbert
5668258182
Add incremental processing 2024-11-25 21:13:17 +09:00
Bartłomiej Dach
78c01c1b5a
Merge branch 'master' into beatmap-defaults-match-stable 2024-11-25 12:55:08 +01:00
Bartłomiej Dach
c8847e8da8
Fix incorrect unit test 2024-11-25 12:53:40 +01:00
Dean Herbert
33d725e889
Address unstable rate calculations as a list for marginal gains 2024-11-25 19:44:11 +09:00
Salman Alshamrani
53b390667a Fix failing test 2024-11-24 06:04:36 -05:00
Salman Alshamrani
aa1358b2b4 Enable NRT and fix code 2024-11-24 04:33:03 -05:00
Salman Alshamrani
dc210d59b5 Add test coverage for sync button 2024-11-24 00:45:11 -05:00
Salman Alshamrani
259ad8ae0f Add failing test cases 2024-11-23 23:52:14 -05:00
Dan Balasescu
1b8db7cfd6
Fix test 2024-11-22 21:28:35 +09:00
Dan Balasescu
82a63228de
Improve handling of multiplayer room status 2024-11-22 21:21:04 +09:00
Dean Herbert
086a34f5c0
Merge branch 'master' into beatmap-info-purge 2024-11-22 18:47:32 +09:00
Dean Herbert
e33e0e16e8
Merge branch 'master' into scale-profile-beatmaps 2024-11-22 18:33:37 +09:00
Bartłomiej Dach
cfc38df889
Add close button to playlists footer 2024-11-22 09:57:56 +01:00
Bartłomiej Dach
479ff7eb41
Merge pull request #30799 from peppy/fix-player-loader-focus-fux
Fix beatmap load not continuing when when settings slider is focused
2024-11-22 08:57:10 +01:00
Bartłomiej Dach
512d2c6e3b
Merge branch 'master' into multiplayer-nrt 2024-11-22 08:09:42 +01:00
Dean Herbert
41addaae9a
Rename variable to imply it is now a function 2024-11-22 13:11:32 +09:00
Salman Alshamrani
5dffc322af Recreate beatmap every test run in ModTestScene 2024-11-21 17:48:33 -05:00
Bartłomiej Dach
74170ea28e
Merge branch 'master' into patch-1 2024-11-21 13:06:19 +01:00
Bartłomiej Dach
42f2ad2423
Fix tests 2024-11-21 13:06:01 +01:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists 2024-11-21 20:32:09 +09:00
Dan Balasescu
8dbf750446
Fix inspection 2024-11-21 18:38:56 +09:00
Dan Balasescu
fe8e9d455a
Add failing test 2024-11-21 18:09:39 +09:00
Dean Herbert
945139635f
Add failing test case 2024-11-21 02:27:57 +09:00
Bartłomiej Dach
dfa32302ac
Add test case covering stability of compatibility export operation
This is important as the format will be used more when lazer beatmap
submission comes online, and its stability is a useful property for
that.

Included archive contains an `.osu` with a few fractional-millisecond
timing points and objects, as well as a multi-segment-type slider. That
should cover the range of all possible modifications that the
compatibility exporter currently performs.
2024-11-20 13:26:54 +01:00
Dean Herbert
6fba6de4dc
Merge branch 'master' into multiplayer-remove-cmc-and-composite 2024-11-20 17:24:55 +09:00
Dean Herbert
c6d08daee8
Remove MultiplayerMatchSubScreen flaky test attribute
Didn't really work to fix these tests due to the sticky nature of the
failure. Also I can no longer reproduce locally, so the hope is that
these are fixed by https://github.com/ppy/osu/pull/30634.
2024-11-20 17:11:49 +09:00