276 Commits

Author	SHA1	Message	Date
Dan Balasescu	920648c267	Minor refactorings and xmldoc additions	2025-01-16 14:00:27 +09:00
Andrei Zavatski	7a6355d7cf	Sync cursor trail rotation with the cursor	2025-01-14 23:12:23 +03:00
Andrei Zavatski	208824e9f4	Add ability for cursor trail to spin	2025-01-14 22:16:32 +03:00
Dean Herbert	8d913e8971	Fix multiple animation inconsistencies pointed out in review	2025-01-07 16:54:11 +09:00
Dean Herbert	794765ba85	Remove use of Loop (and transforms) for slider repeat arrow animations ... Less transforms in gameplay is always better. This fixes repeat arrows animating completely incorrectly in the editor (and probably gameplay when rewinding).	2025-01-02 18:36:58 +09:00
Dean Herbert	b8d6bba039	Fix legacy hitcircle fallback logic being broken with recent fix ... I was a bit too eager to replace all calls with the new `provider` in dae380b7fa, while it doesn't actually make sense. To handle the case that was trying to be fixed, using the `provider` to check whether the *prefix* version of the circle sprite is available is enough alone. Closes https://github.com/ppy/osu/issues/31200	2024-12-24 16:05:44 +09:00
Dean Herbert	dae380b7fa	Fix lookups of hit circle slider pieces potentially using wrong source skin ... Addresses https://github.com/ppy/osu/discussions/30927.	2024-12-10 22:03:07 +09:00
Dean Herbert	312336de24	Fix classic skin spinner's middle pieces displaying in the wrong order ... Closes https://github.com/ppy/osu/issues/30873. See [stable reference](3ea48705eb/osu!/GameplayElements/HitObjects/Osu/SpinnerOsu.cs#L148-L158).	2024-11-26 18:12:28 +09:00
Dean Herbert	48cfd77ee8	Component -> Lookup	2024-08-23 14:48:50 +09:00
Dean Herbert	1435fe24ae	Remove requirement of base calls to ensure user skin container layouts are retrieved	2024-08-22 19:14:30 +09:00
Dean Herbert	b57b8168a6	Rename Target lookup to Component	2024-08-22 19:00:28 +09:00
Dean Herbert	9a21174582	Move GlobalSkinnableContainers to global scope	2024-08-22 18:46:07 +09:00
Dean Herbert	f37cab0c6e	Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup	2024-08-22 18:39:36 +09:00
Salman Ahmed	20658ef4ee	Fix legacy key counter position not matching stable	2024-08-21 00:10:16 +09:00
Dean Herbert	5710f0f302	Merge pull request #26254 from frenzibyte/mania-combo-counter ... Add argon/classic osu!mania combo counter	2024-08-15 17:56:28 +09:00
Salman Ahmed	49c71f7863	Fix beatmap skin always overriding ruleset HUD components	2024-08-15 16:47:10 +09:00
Dean Herbert	d2eb6ccb8c	Standardise skin transformer code structure	2024-08-12 14:27:21 +09:00
Dean Herbert	80c814008f	Update in line with new changes	2024-08-09 14:55:01 +09:00
Dean Herbert	60d383448f	Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer ... This didn't make any sense, so let's do it a better way.	2024-08-08 16:29:54 +09:00
Dean Herbert	725dc4de9b	Use transformers for per-skin key counter implementation	2024-08-06 18:17:21 +09:00
Dean Herbert	fb1d20bd39	Comment in some clarification	2024-04-22 15:07:11 +08:00
Dan Balasescu	0170c04baf	Fix cursormiddle not using the same source as cursor	2024-04-22 15:01:28 +09:00
Dan Balasescu	40c48f903b	Add failing test	2024-04-22 15:01:28 +09:00
Salman Ahmed	b3aa9e25d2	Disable legacy slider AA for now	2024-02-27 23:18:29 +03:00
Salman Ahmed	83af9dfb39	Fix aa_width being incorrect	2024-02-27 02:43:02 +03:00
Salman Ahmed	2f54775182	Add stable code references	2024-02-27 02:17:02 +03:00
Salman Ahmed	81e6a6d96a	Rewrite LegacySliderBody rendering to perfectly match stable	2024-02-27 02:11:32 +03:00
Salman Ahmed	e01722a266	Revert "Match stable's slider border thickness more closely" ... This reverts commit 3502ec456d.	2024-02-27 01:30:20 +03:00
Salman Ahmed	8363c39da8	Revert "Match stable's slider border thickness perfectly" ... This reverts commit 8032ce9225.	2024-02-27 01:30:20 +03:00
Detze	8032ce9225	Match stable's slider border thickness perfectly	2024-02-26 18:37:27 +01:00
Detze	3502ec456d	Match stable's slider border thickness more closely	2024-02-26 04:36:09 +01:00
Salman Ahmed	bbf3f6b56c	Fix old-style legacy spinner fade in not matching stable	2024-02-22 16:31:13 +03:00
Bartłomiej Dach	cd1acf1ef9	Merge pull request #27288 from peppy/fix-follow-circle-animation ... Fix classic skin follow circles animating from incorrect starting point	2024-02-21 10:53:56 +01:00
Dean Herbert	a137fa5480	Fix classic skin follow circles animating from incorrect starting point	2024-02-21 15:43:53 +08:00
Dean Herbert	86e3b597b4	Fix LegacyApproachCircle incorrectly applying scaling factor	2024-02-21 13:18:51 +08:00
Dean Herbert	993e733fce	Merge pull request #26598 from frenzibyte/fix-storyboard-sprites-2 ... Remove handling for non-legacy texture lookup paths in `LegacySkin`	2024-01-22 17:50:55 +09:00
Bartłomiej Dach	3853f63b74	Merge pull request #26567 from peppy/cusor-scale-rate ... Fix cursor scale animation not matching stable on classic skins	2024-01-18 13:59:49 +01:00
Salman Ahmed	1527ab89ef	Refactor DefaultApproachCircle/LegacyApproachCircle to make sense	2024-01-18 11:16:26 +03:00
Salman Ahmed	06da7f74de	Merge branch 'master' into fix-storyboard-sprites-2	2024-01-17 18:43:25 +03:00
Salman Ahmed	eaa748f075	Remove unused using directive	2024-01-17 18:35:34 +03:00
Salman Ahmed	ed1e66b8f9	Fix enabling beatmap skin cause hitobjects to use LegacyApproachCircle regardless of selected skin	2024-01-17 16:36:09 +03:00
Salman Ahmed	e54d20ea93	Remove ancient osu-resources lookup path from legacy skin textures	2024-01-17 16:33:14 +03:00
Dean Herbert	c45daa373e	Fix cursor scale animation not matching stable on classic skins	2024-01-16 17:15:25 +09:00
Justin	e3ab7b1e9f	Update disctop to use turnratio like stable	2024-01-16 17:22:22 +11:00
Dean Herbert	c5893f245c	Change legacy version checks to account for users specifying incorrect versions	2023-12-23 14:03:45 +09:00
Dean Herbert	66f7b9fae1	Adjust slider follow circle animation to not abruptly scale on early ticks	2023-11-17 19:09:24 +09:00
Dean Herbert	fbba3787d1	Merge pull request #25190 from frenzibyte/match-skin-element-animation-support ... Match capability of animating legacy skin elements with osu!(stable)	2023-10-30 18:25:06 +09:00
Bartłomiej Dach	99e590c8dd	Fix legacy sprite texts not matching stable with respect to fixed width ... stable's `pSpriteText` has a `TextConstantSpacing` flag, that is selectively enabled for some usages. In particular, these are: - mania combo counter (not yet implemented) - taiko combo counter (not yet implemented) - score counter - accuracy counter - scoreboard entries (not yet implemented) Everything else uses non-fixed-width fonts. Hilariously, `LegacySpinner` _tried_ to account for this by changing `Font` to have `fixedWidth: false` specified, only to fail to notice that `LegacySpriteText` changes `Font` in its BDL, making the property set do precisely nothing. For this reason, attempting to set `Font` on a `LegacySpriteText` will now throw.	2023-10-27 20:14:39 +02:00
Bartłomiej Dach	c9cb0561f7	Move maxSizePerGlyph optional ctor param to init-only property ... I'm doing this as I'm about to add more similar properties to `LegacySpriteText` and I don't want to create a twenty-argument constructor monstrosity.	2023-10-27 19:48:10 +02:00
Dean Herbert	23ea128f30	Merge branch 'master' into velocity-based-ball-animation	2023-10-25 14:01:19 +09:00