Dean Herbert
3ecb3b674d
Don't reset state when changing from one selection to another in the editor
...
This was causing state pollution in the new selection. I can't see why
this needs to happen when a selection changes to another.
This fixes https://github.com/ppy/osu/issues/30839 and also the same
issue happening for the new combo toggle.
Tests all seem to pass, and I can't immediately find anything broken,
but YMMV.
2024-11-26 17:33:41 +09:00
Dean Herbert
e0199386a3
Add failing test case showing changing selection in editor affects samples
2024-11-26 17:33:41 +09:00
Dan Balasescu
d3d111de7d
Merge pull request #30832 from peppy/mania-precise-scroll-speed
...
Allow setting osu!mania scroll speed to single decimal precision
2024-11-26 17:30:56 +09:00
Dan Balasescu
943837e3b5
Merge pull request #30878 from peppy/config-pause-hold-thing-of-course
...
Add setting to allow hold-for-pause to still exist
2024-11-26 16:35:35 +09:00
Dean Herbert
1e6c04e98b
Remove debug logging
2024-11-26 16:11:06 +09:00
Salman Alshamrani
42c68ba43e
Add inline comment
2024-11-26 01:28:58 -05:00
Salman Alshamrani
b76460f100
Schedule the thing
...
Queuing up requests on change to `api.LocalUser` is bad because the API
state is updated after `LocalUser` is updated, therefore we have to
schhhhhedullllllllleeeeeeeeeeeeeeee.
2024-11-26 01:26:44 -05:00
Dean Herbert
e3ea38a366
Add setting to allow hold-for-pause to still exist
...
Users have asked for this multiple times since last release.
Not sure on the best default value, but I'm going with the
stable/classic one, at least for the initial release to avoid needing
migrations.
In the future we may reconsider this for new users.
2024-11-26 15:14:19 +09:00
Salman Alshamrani
7201bac60d
Remove DailyChallengePlayer
2024-11-26 01:10:19 -05:00
Salman Alshamrani
c1416f9920
Bring back user-based endpoint for viewing result screen from playlists lounge
2024-11-26 01:10:12 -05:00
Salman Alshamrani
d150aeef2b
Use score-based endpoint everywhere
2024-11-26 01:01:59 -05:00
Dean Herbert
e8fae85e8d
Fix hidden dissmissing logic
2024-11-26 14:45:40 +09:00
Dean Herbert
672dbe6e03
Better control of show/hide of overlay
2024-11-26 14:42:30 +09:00
Dean Herbert
d057dc9a95
Refactor MedalOverlay to be more readable
...
Shouldn't really have any functionality changes, just fixing some old
code that I can't easily parse these days.
2024-11-26 14:19:39 +09:00
Dean Herbert
8585327858
Ensure DrawableMedal loading doesn't ever block on online resources
2024-11-26 14:08:53 +09:00
Salman Alshamrani
dfa21574fd
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-25 23:52:56 -05:00
Dean Herbert
17347563ee
Fix incorrect null handling
2024-11-26 13:25:57 +09:00
Dean Herbert
f708466a9b
Add test coverage
2024-11-26 13:25:55 +09:00
Dean Herbert
d6cf1db0f5
Add basic xmldoc to results class
2024-11-26 12:16:26 +09:00
Dean Herbert
d903d381d5
Rename NextProcessableIndex to EventCount in line with actual functionality
2024-11-26 12:10:34 +09:00
Bartłomiej Dach
285959943f
Merge pull request #30859 from frenzibyte/fix-grid-settings-missing-precision
...
Fix editor grid settings not displaying decimal portion in slider tooltips
2024-11-25 14:54:15 +01:00
Dean Herbert
9ca17f9b6b
Merge pull request #30748 from stanriders/scale-profile-beatmaps
...
Scale down beatmap cards
2024-11-25 22:53:51 +09:00
Bartłomiej Dach
b5f8773c0b
Merge pull request #30826 from peppy/beatmap-defaults-match-stable
...
Change some beatmap default settings to match stable
2024-11-25 13:40:19 +01:00
Bartłomiej Dach
0a3f3c3210
Add guard against fetching statistics for non-legacy rulesets
2024-11-25 13:14:22 +01:00
Dean Herbert
bbe8f2ec44
Only update unstable rate counter when an applicable hitobject is reached
2024-11-25 21:13:18 +09:00
Dean Herbert
ea68d4b33a
Use class instead of record for lower allocations
2024-11-25 21:13:18 +09:00
Dean Herbert
5668258182
Add incremental processing
2024-11-25 21:13:17 +09:00
Bartłomiej Dach
78c01c1b5a
Merge branch 'master' into beatmap-defaults-match-stable
2024-11-25 12:55:08 +01:00
Bartłomiej Dach
c8847e8da8
Fix incorrect unit test
2024-11-25 12:53:40 +01:00
Dean Herbert
33d725e889
Address unstable rate calculations as a list for marginal gains
2024-11-25 19:44:11 +09:00
Dean Herbert
605fe71f46
Make empty hitwindows readonly static and slightly improve comparison performance
2024-11-25 19:17:32 +09:00
Dean Herbert
a1916d12db
Ensure UR benchmark has hitwindows populated
2024-11-25 18:53:15 +09:00
Dean Herbert
82bdd8fbfc
Merge pull request #30861 from frenzibyte/fix-multiplayer-missing-hold-delay
...
Fix pause shortcut on multiplayer no longer requiring hold
2024-11-25 16:22:56 +09:00
Dean Herbert
876c2e468a
Merge pull request #30858 from frenzibyte/fix-match-settings-overlay-typo
2024-11-25 15:58:17 +09:00
Salman Alshamrani
1468385559
Reset new file states after syncing
2024-11-24 22:38:48 -05:00
tsrk.
cfaf972813
Merge branch 'master' into xxx-add-localisation-support-for-menu-tip
2024-11-24 18:24:43 +01:00
Dean Herbert
c34827a4ed
Merge pull request #30862 from frenzibyte/dont-scare-the-player
...
Don't play fail animation if restarting on fail
2024-11-24 23:11:19 +09:00
tsrk.
8611ed31c2
refactor(MenuTip): add localisation support
...
Signed-off-by: tsrk. <tsrk@tsrk.me>
2024-11-24 14:22:56 +01:00
Salman Alshamrani
53b390667a
Fix failing test
2024-11-24 06:04:36 -05:00
Dean Herbert
888f02e3a6
Merge pull request #30855 from SupDos/tips-remove-fps
...
Remove FPS shortcut tip
2024-11-24 19:57:08 +09:00
Salman Alshamrani
ae9119eef0
Hide back button when quick-restarting unless load time takes long
2024-11-24 05:40:06 -05:00
Salman Alshamrani
2420793466
Allow controlling back button visibility state from screens
2024-11-24 05:39:43 -05:00
Salman Alshamrani
6d0d7f3e75
Don't play fail animation if restarting on failure
2024-11-24 04:45:48 -05:00
Salman Alshamrani
aa1358b2b4
Enable NRT and fix code
2024-11-24 04:33:03 -05:00
Salman Alshamrani
f3155bfc7d
Fix pause shortcut on multiplayer not delayed
2024-11-24 04:24:31 -05:00
Salman Alshamrani
631bfadd68
Replace event subscription with callback in UserStatisticsWatcher
...
Also no longer cancels previous API requests as there's no actual need to do it.
2024-11-24 04:11:13 -05:00
Salman Alshamrani
3480da22d2
Remove no-op SaveState call
2024-11-24 01:13:39 -05:00
Salman Alshamrani
95a6226413
Only enable button if there are different filenames
2024-11-24 01:11:36 -05:00
Salman Alshamrani
a872f74974
Make sync button only affect changed resource type
2024-11-24 01:02:34 -05:00
Salman Alshamrani
c8b13b726d
Add localisation support
2024-11-24 00:45:17 -05:00
