886 Commits

• Fix slider parts not reproxying after first hitobject freed
  Bartłomiej Dach · 2021-09-18 16:27:30 +02:00
  79438c19a4
• Fix repeat arrows being hidden beneath head circles in legacy skins

  Aims to make minimal changes to `DrawableSlider` itself. I'm not super
  happy about the slider ball being moved above the head circle, but it
  *is* what people are used to so no one except for me is going to
  complain.
  
  Supersedes and closes https://github.com/ppy/osu/pull/14561.

  Dean Herbert · 2021-09-01 19:41:49 +09:00
  738ce0f689
• Merge branch 'master' into avoid-default-skin-judgement-transform-overhead
  Dan Balasescu · 2021-08-27 10:02:40 +09:00
  f0296e5d12
• Remove redundant default value
  Salman Ahmed · 2021-08-26 08:18:58 +03:00
  b9ea984c36
• Avoid expensive text spacing transforms for now
  Dean Herbert · 2021-08-26 13:15:27 +09:00
  8cfb3d456b
• Avoid unnecessary unbind operations when constructing FollowPointLifetimeEntry
  Dean Herbert · 2021-08-26 12:35:31 +09:00
  69064c1938
• Implement IHasApproachCircle in DrawableHitCircle as well
  Salman Ahmed · 2021-06-21 07:35:07 +03:00
  68e28f4903
• Replace spinner approach circle proxying logic with hooking up to OnSkinChange in mod
  Salman Ahmed · 2021-06-19 20:06:28 +03:00
  c04b09520d
• Move spinner approach circle to its own SkinnableDrawable
  Salman Ahmed · 2021-06-18 20:33:50 +03:00
  843c8bd7a4
• Merge branch 'master' into legacy-spinner-approach-circle
  Salman Ahmed · 2021-06-18 19:50:52 +03:00
  f7b5341663
• Hide spinner approach circle in "Hidden" mod
  Salman Ahmed · 2021-06-18 06:23:54 +03:00
  c9458fd9ce
• Fix approach circle fade not running early on an early user hit

  Regressed in https://github.com/ppy/osu/pull/12153.
  Closes https://github.com/ppy/osu/issues/13531.

  Dean Herbert · 2021-06-17 15:09:05 +09:00
  a46f730a69
• Merge branch 'master' into fix-skin-sample-lookup
  Dean Herbert · 2021-06-08 17:37:36 +09:00
  6017ef3825
• Fix slider repeat arrow not updating rotation immediately while paused in editor

  A bit of a local solution, but not sure there's a better way to handle
  this.
  
  Closes #13342.

  Dean Herbert · 2021-06-07 15:58:43 +09:00
  277eb9fa6e
• Merge branch 'legacy-skin-default-fallback' into fix-skin-sample-lookup
  Dean Herbert · 2021-06-07 12:01:19 +09:00
  d26c9a66c2
• Bring back scheduling of follow point update
  ekrctb · 2021-06-04 18:41:02 +09:00
  d7da66d876
• Remove one TODO

  It can be removed because pooled drawables are always ready, and `FollowPointConnection` is also ready when applied.

  ekrctb · 2021-06-04 17:09:59 +09:00
  0098ac2760
• Resolve nullable inspection, enable nullable for FollowPointLifetimeEntry
  ekrctb · 2021-06-04 17:09:59 +09:00
  bc892086fe
• Use general lifetime container for follow point container
  ekrctb · 2021-06-04 16:31:50 +09:00
  b373b120ff
• Remove defunct Animate calls
  ekrctb · 2021-06-02 11:46:28 +09:00
  c06ff3c623
• Fix hit circle animation reset when skin is changed

  The transforms applied in `Animate` call was not applied because the piece is recreated.

  ekrctb · 2021-06-02 11:32:24 +09:00
  b82190e157
• Merge branch 'master' into fix-skin-sample-lookup
  Dean Herbert · 2021-05-28 14:47:35 +09:00
  6268bbea85
• Remove allowFallback parameters completely
  Dean Herbert · 2021-05-27 14:50:42 +09:00
  70a844ac10
• Make DrawableSliderTail not require ITrackSnaking
  Endrik Tombak · 2021-05-26 23:21:05 +03:00
  9ac4ef273e
• Fix sliders jumping around the screen on movement
  smoogipoo · 2021-05-24 17:15:57 +09:00
  3db995c778
• Add regression test for spinner sample actually transforming its frequency
  Dean Herbert · 2021-05-24 15:10:33 +09:00
  8336428574
• Fix follow points displaying at incorrect locations when dragging a slider out-of-bounds
  Dean Herbert · 2021-05-05 18:30:57 +09:00
  1410b8f36d
• Extract scale constant
  Dean Herbert · 2021-04-26 15:30:22 +09:00
  d10aac851d
• Expose DrawableSliderRepeat's arrow and move transforms to children
  Dean Herbert · 2021-04-26 15:22:42 +09:00
  4da964c3f3
• Expose presence of MainCirclePiece via an interface
  Dean Herbert · 2021-04-26 15:22:17 +09:00
  aa7ade8186
• Animate back slider repeat and tail circle pieces
  Salman Ahmed · 2021-04-26 02:39:49 +03:00
  0b9172a1dc
• Split out animation triggering of MainCirclePiece to be interface driven
  Dean Herbert · 2021-04-21 19:15:10 +09:00
  47a4a07024
• Keep hitcircles aligned with view in "Barrel Roll" mod
  Dean Herbert · 2021-04-20 18:36:11 +09:00
  ac0ed72d04
• Merge branch 'master' into legacy-spm-counter
  Dean Herbert · 2021-04-12 12:52:52 +09:00
  e2470d757e
• Rework slider hackery to not overwrite Samples
  smoogipoo · 2021-04-09 15:28:08 +09:00
  f2e811928b
• Actually use whistle sample for sliderwhistle
  smoogipoo · 2021-04-08 23:13:16 +09:00
  8efa381d3a
• Add support for sliderwhistle
  smoogipoo · 2021-04-08 20:20:09 +09:00
  7713c8a45f
• Reword xmldoc slightly
  smoogipoo · 2021-04-02 18:00:28 +09:00
  9c3d15171c
• Switch AlwaysPlaySample to SamplePlaysOnlyOnHit in DrawableSliderTail for conformity
  Amber · 2021-04-02 03:56:23 -05:00
  5ac36a2462
• Force hit sample to play when Classic mod is enabled
  Amber · 2021-04-02 02:54:35 -05:00
  5063cd957f
• Inline add of spm calculation (no need for it to be a separate call)
  Dean Herbert · 2021-03-30 13:43:05 +09:00
  9504fe3f3c
• Refactor spinner SPM counter for skinning purposes
  Salman Ahmed · 2021-03-30 04:19:23 +03:00
  0bf84e473d
• Merge branch 'master' into legacy-spinner-bonus
  Dean Herbert · 2021-03-25 18:09:25 +09:00
  c715b9b89e
• Always fade out approach circles at a HitObject's start time to better match stable
  Dean Herbert · 2021-03-23 19:19:07 +09:00
  64e85ba995
• Remove unnecessary null checks and debug code
  Dean Herbert · 2021-03-23 10:38:37 +09:00
  098005393e
• Fix spinners playing looping sound too long in the editor

  The `OnComplete` event was never being run due to the transform playing
  out longer than the spinner's lifetime. I've matched the durations, but
  also moved the `Stop()` call to what I deem a safer place to run it (I
  did notice that without this it would still potentially never fire).
  
  Note that this is more noticeable in the editor because of lifetime
  extension. In gameplay, the returning of a spinner to the pool will
  clean things up (but in the editor that can take longer, depending on
  timeline zoom level).
  
  Another thing worth mentioning is that the fade doesn't actually work.
  This is due to https://github.com/ppy/osu-framework/pull/4212.
  
  Closes #12119.

  Dean Herbert · 2021-03-22 16:04:51 +09:00
  c4d08463ad
• Move default spinner bonus counter to new DefaultSpinner
  Salman Ahmed · 2021-03-13 05:59:42 +03:00
  98f6e16113
• Revert legacy spinner presence changes and bonus counter component

  No longer necessary, after inlining legacy coordinates logic to `LegacySpinner` and limiting precisely-positioned legacy components there

  Salman Ahmed · 2021-03-13 05:57:47 +03:00
  8fdab5a7de
• Use sensible "score per tick" constant
  Salman Ahmed · 2021-03-13 05:56:28 +03:00
  020a03e01e
• Merge branch 'master' into legacy-spinner-bonus
  Salman Ahmed · 2021-03-13 05:54:34 +03:00
  c4048c9831