h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-28 07:23:14 +08:00
Code Issues Releases Wiki Activity

Switch AlwaysPlaySample to SamplePlaysOnlyOnHit in DrawableSliderTail for conformity

Browse Source
This commit is contained in:
Amber 2021-04-02 03:56:23 -05:00
parent 48e9985782
commit 5ac36a2462
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Osu/Mods/OsuModClassic.cs
View File

@ -84,7 +84,7 @@ namespace osu.Game.Rulesets.Osu.Mods
break;
case DrawableSliderTail tail:
tail.AlwaysPlaySample = AlwaysPlayTailSample.Value;
tail.SamplePlaysOnlyOnHit = !AlwaysPlayTailSample.Value;
break;
}
}

2
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSlider.cs
View File

@ -280,7 +280,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
{
// rather than doing it this way, we should probably attach the sample to the tail circle.
// this can only be done after we stop using LegacyLastTick.
if (TailCircle.IsHit || TailCircle.AlwaysPlaySample)
if (!TailCircle.SamplePlaysOnlyOnHit || TailCircle.IsHit)
base.PlaySamples();
}

3
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSliderTail.cs
View File

@ -29,7 +29,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
/// <summary>
/// Whether the hit sample should always be played, regardless of whether the tail was actually hit.
/// </summary>
public bool AlwaysPlaySample { get; set; }
public bool SamplePlaysOnlyOnHit { get; set; } = true;
public bool Tracking { get; set; }
@ -49,7 +49,6 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
[BackgroundDependencyLoader]
private void load()
{
AlwaysPlaySample = false;
Origin = Anchor.Centre;
Size = new Vector2(OsuHitObject.OBJECT_RADIUS * 2);