63 Commits

• Merge pull request #31645 from peppy/offset-adjust-more-lenience

  Make offset adjust more lenient

  Bartłomiej Dach · 2025-01-24 14:01:25 +01:00
  7845c5cfb7
• Fix average button not correctly becoming disabled where it previously would
  Dean Herbert · 2025-01-24 17:17:34 +09:00
  721b2dfbba
• Move line to correct location
  Dean Herbert · 2025-01-24 16:45:14 +09:00
  28a59f4e29
• Bypass offset disallowed status when handling realm callbacks

  Hopefully don't need to overthink this one.

  Dean Herbert · 2025-01-24 15:49:47 +09:00
  8f8a6455b4
• Add safeties against attempting to apply previous play while offset adjust is not allowed

  This should theoretically not be possible, but while we are sharing this
  control's implementation between gameplay and non-gameplay usages, let's
  ensure nothing weird can occur.

  Dean Herbert · 2025-01-24 15:49:47 +09:00
  ee78e1b223
• Consume GameplayStartTime for more lenient offset adjustments
  Dean Herbert · 2025-01-24 15:30:02 +09:00
  fb10996951
• Fix gameplay limitations for adjusting offset not actually being applied
  Dean Herbert · 2025-01-16 18:05:59 +09:00
  1d240eb405
• Apply beatmap offset on every beatmap set difficulty if they have the same audio
  Rudi Herouard · 2025-01-15 04:12:54 +01:00
  57a9911b22
• Add static memory of last applied offset score

  I don't really like adding this new session static, but we don't have a
  better place to put this.

  Dean Herbert · 2025-01-02 16:20:25 +09:00
  2a28c5f4de
• Do not show timing distribution graph in offset control if there's not enough timed hits

  Intended to address concerns raised in
  https://github.com/ppy/osu/pull/30620#issuecomment-2475744164.

  Bartłomiej Dach · 2024-11-14 13:17:03 +01:00
  bd1d3cad49
• Fix offset adjust control not correctly applying changes after song select quit

  This is an interesting scenario where we arrive at a fresh
  `BeatmapOffsetControl` but with a reference score (from the last play).
  
  Our best assumption here is that the beatmap's offset hasn't changed
  since the last play, so we want to use it for the `lastPlayBeatmapOffset`.
  But due to unfortunate order of execution, `Current.Value` was not yet
  initialised.

  Dean Herbert · 2024-09-05 19:04:52 +09:00
  37f61b26ea
• Inline enabled setting
  Dean Herbert · 2024-06-15 17:34:04 +08:00
  ff2d721029
• Set to enable or disable at load time
  Shiumano · 2024-06-14 21:43:17 +09:00
  6c82f1de9b
• Show tooltip on global offset adjust slider bar
  Dean Herbert · 2024-01-17 17:57:49 +09:00
  cc7be137bc
• Change display text for beatmap audio offset adjust to make more sense
  Dean Herbert · 2024-01-17 17:51:46 +09:00
  123e36a999
• Fix code quality inspection
  Bartłomiej Dach · 2023-12-28 14:12:28 +01:00
  619b0cc69b
• Expose the ability to update global offset from the player loader screen
  Dean Herbert · 2023-12-28 20:01:34 +09:00
  b7f3c83514
• Migrate BeatmapOffsetControl to use session static directly
  Bartłomiej Dach · 2023-12-27 19:19:27 +01:00
  1b7af989ec
• Add conditions to match stable offset adjust limitations
  Dean Herbert · 2023-12-24 02:36:27 +09:00
  72bec527fd
• Don't bother with alt support for now
  Dean Herbert · 2023-12-24 01:59:48 +09:00
  92b490f2e7
• Allow external use of offset text explanation
  Dean Herbert · 2023-12-23 20:46:12 +09:00
  7e9522a722
• Add basic hotkey offset adjust support (via existing offset control)
  Dean Herbert · 2023-12-23 19:55:05 +09:00
  27a9dcc5a1
• Change offset calibration control to adjust for all difficulties of the current beatmap set
  Dean Herbert · 2023-07-19 17:13:19 +09:00
  5ec9cd84b2
• Add IHasNoTimedInputs interface to scope change further
  Dean Herbert · 2023-06-06 22:22:42 +09:00
  247fa088db
• Don't show offset calibration controls when "relax" mod is active

  Closes https://github.com/ppy/osu/issues/22892.

  Dean Herbert · 2023-03-22 15:45:04 +09:00
  c65a79614d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Apply changes in line with framework NRT updates
  Dean Herbert · 2022-11-18 18:13:15 +09:00
  06ce8130c2
• Cleanup all other leftover binding instantiation
  o-dasher · 2022-09-25 16:02:40 -04:00
  feadac1f79
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use LocalisableString.Interpolate instead of invalid TranslatableStrings
  Salman Ahmed · 2022-04-28 11:38:40 +03:00
  691bec6f16
• Only null the realm write task if it actually completed
  Dean Herbert · 2022-03-09 13:52:58 +09:00
  6bf436cd62
• Ensure the value used during realm async write is the same as whe compared for equality
  Dean Herbert · 2022-03-08 19:36:23 +09:00
  960b6528ca
• Fix feedback from realm writes causing offset slider to jump around
  Dean Herbert · 2022-03-08 19:36:08 +09:00
  daa42584f4
• Merge branch 'master' into realm-property-watching
  Dean Herbert · 2022-03-07 13:53:17 +09:00
  31d6c75f40
• Merge branch 'master' into offset-ui-improvements
  Bartłomiej Dach · 2022-03-05 16:10:18 +01:00
  e4b4c3c5c4
• Revert changes to GetTooltipText and use TooltipText override directly
  Dean Herbert · 2022-03-05 22:46:13 +09:00
  ce51ce49cf
• Merge branch 'master' into add-offset-adjust-tooltip-text
  Dean Herbert · 2022-03-05 22:37:04 +09:00
  bbc2b36117
• Reorder math to be easier to pass

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  Dean Herbert · 2022-03-04 17:54:04 +09:00
  1c40fcb79e
• Fix calibrating offset from previous non-zero offset not applying adjustment correctly
  Dean Herbert · 2022-03-04 15:09:44 +09:00
  e9e92b991e
• Allow an offset to be shown on the timing distribution graph
  Dean Herbert · 2022-03-04 14:05:42 +09:00
  010fa7ed01
• Fix calibrating offset from previous non-zero offset not applying adjustment correctly
  Dean Herbert · 2022-03-04 13:25:14 +09:00
  e09dd7d8fe
• Add tooltip text for offset adjustment slider
  Dean Herbert · 2022-03-04 12:44:02 +09:00
  cc4f89eef4
• Rename lambda param to avoid name shadowing
  Bartłomiej Dach · 2022-03-03 20:28:19 +01:00
  15f65c7897
• Use property expression rather than block
  Bartłomiej Dach · 2022-03-03 20:28:00 +01:00
  2e24e7ef56
• Trim unused using directives
  Bartłomiej Dach · 2022-03-03 20:21:48 +01:00
  edd361d256
• Update existing usages to use SubscribeToPropertyChanged
  Dean Herbert · 2022-03-03 17:42:50 +09:00
  cecc746f9e
• Add tooltip text for offset adjustment slider
  Dean Herbert · 2022-03-03 17:07:46 +09:00
  3848964faa
• Use more correct mod check to encompass more than just autoplay
  Dean Herbert · 2022-03-02 14:42:10 +09:00
  763f881d4a
• Remove Precision call for database write shortcutting

  Shouldn't be required.

  Dean Herbert · 2022-03-02 14:39:29 +09:00
  e184b26cdd
• Fix incorrect precision specification for button disable check
  Dean Herbert · 2022-03-02 14:36:49 +09:00
  8bd66f1ed7