571 Commits

• Fix incremental unstable rate calculation not matching expectations

  The `EventCount` variable wasn't factoring in that some results do not
  affect unstable rate. It would therefore become more incorrect as the
  play continued.
  
  Closes https://github.com/ppy/osu/issues/31712.

  Dean Herbert · 2025-01-29 17:11:12 +09:00
  d8ec3b77e4
• Typo fix
  Shawn Presser · 2025-01-15 19:29:41 -06:00
  6008c3138e
• Add basic xmldoc to results class
  Dean Herbert · 2024-11-26 12:16:26 +09:00
  d6cf1db0f5
• Rename NextProcessableIndex to EventCount in line with actual functionality
  Dean Herbert · 2024-11-26 12:10:34 +09:00
  d903d381d5
• Only update unstable rate counter when an applicable hitobject is reached
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  bbe8f2ec44
• Use class instead of record for lower allocations
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  ea68d4b33a
• Add incremental processing
  Dean Herbert · 2024-11-25 21:13:17 +09:00
  5668258182
• Address unstable rate calculations as a list for marginal gains
  Dean Herbert · 2024-11-25 19:44:11 +09:00
  33d725e889
• Make empty hitwindows readonly static and slightly improve comparison performance
  Dean Herbert · 2024-11-25 19:17:32 +09:00
  605fe71f46
• Do not show timing distribution graph in offset control if there's not enough timed hits

  Intended to address concerns raised in
  https://github.com/ppy/osu/pull/30620#issuecomment-2475744164.

  Bartłomiej Dach · 2024-11-14 13:17:03 +01:00
  bd1d3cad49
• Simplify implementation
  Dan Balasescu · 2024-10-17 20:00:17 +09:00
  bfcf6693ca
• Add test coverage of judgements not being synced when resuming a replay
  Dean Herbert · 2024-09-18 15:28:10 +09:00
  2d993645af
• Prevent multiple invocations of failure procedure
  Dan Balasescu · 2024-06-26 13:57:18 +09:00
  0379abd714
• Fix transient rank value applied to bindable
  PercyDan54 · 2024-06-25 18:06:50 +08:00
  2de0852551
• fix accuracyProcess typo
  sometimes · 2024-06-20 22:06:00 -04:00
  89d3f67eb3
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Merge branch 'master' into pre-mod-multiplier-score
  Bartłomiej Dach · 2024-05-08 13:39:44 +02:00
  c9414da5d4
• Fix LegacyDrainingHealthProcessor drain rate computation diverging to infinity
  Bartłomiej Dach · 2024-04-23 18:57:14 +02:00
  787e60f706
• Populate TotalScoreWithoutMods on scores set locally
  Bartłomiej Dach · 2024-04-17 08:52:47 +02:00
  e0178802b8
• Add HP and AR to LegacyBeatmapConversionDifficultyInfo
  Dan Balasescu · 2024-03-28 22:30:39 +09:00
  5febd40bd9
• Fix infinite health processor loop when no top-level objects

  This is unlikely to occur in actual gameplay, but occurs in the
  follow-up test.

  Dan Balasescu · 2024-03-20 17:30:37 +09:00
  c78e203df5
• Merge branch 'master' into catch-fail-on-banana
  Dan Balasescu · 2024-03-04 13:13:26 +09:00
  5bd037fe8f
• Fix missing tiny droplet not triggering fail with perfect on

  Stable does this:
  
      https://github.com/peppy/osu-stable-reference/blob/46cd3a10af7cc6cc96f4eba92ef1812dc8c3a27e/osu!/GameplayElements/HitObjectManagerFruits.cs#L98-L102
  
  I'd rather not say what I think about it doing that, since it's likely
  to be unpublishable, but to approximate that, just make it so that
  only the "default fail condition" is beholden to the weird ebbs
  and flows of what the ruleset wants. This appears to fix the problem
  case and I'm hoping it doesn't break something else but I'm like 50/50
  on it happening anyway at this point. Just gotta add tests add nauseam.

  Bartłomiej Dach · 2024-02-14 14:21:48 +01:00
  2c0a5b7ef5
• Fix draining processor failing gameplay on bonus misses and ignore hits
  Bartłomiej Dach · 2024-02-13 13:06:19 +01:00
  16d893d40c
• Cache created judgement in HitObject
  Andrei Zavatski · 2024-02-09 23:20:31 +03:00
  c500264306
• Merge branch 'master' into ur-alloc
  Bartłomiej Dach · 2024-02-05 19:14:08 +01:00
  4b5348bbbf
• Move algorithm description to remarks section of xmldoc
  Bartłomiej Dach · 2024-02-05 18:57:57 +01:00
  7b03bebd5f
• Use better variable names

  It's not the 1970s. We can spare a few extra letters.

  Bartłomiej Dach · 2024-02-05 18:56:20 +01:00
  a5aeb2ff9e
• Improve readability
  Andrei Zavatski · 2024-02-03 00:19:04 +03:00
  57bc5ee04f
• Incorporate new unstable rate algo
  Andrei Zavatski · 2024-02-02 22:46:52 +03:00
  dde7e068a4
• Adjust default min result of SliderTailHit, remove override
  Dan Balasescu · 2024-01-31 18:01:29 +09:00
  0642a0ee11
• Revert "Merge pull request #26870 from smoogipoo/adjust-default-minresult"

  This reverts commit 1acff746ee, reversing
  changes made to 696ecda398.

  Dean Herbert · 2024-01-31 17:51:38 +09:00
  fbc923b47e
• Adjust default min result of SliderTailHit, remove override
  Dan Balasescu · 2024-01-31 16:12:05 +09:00
  9b1bbe5f48
• Merge pull request #26703 from peppy/smaller-slider-misses

  Adjust slider tick / end defaults again

  Bartłomiej Dach · 2024-01-29 13:51:07 +01:00
  2667cb8b36
• Move solution to multiplayer flow instead
  Salman Ahmed · 2024-01-28 00:42:04 +03:00
  64b61108ad
• Fix score processor no longer applying results when failing in multiplayer match
  Salman Ahmed · 2024-01-27 23:23:10 +03:00
  a25be9927d
• Update triangles skin judgment display
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  107b37494e
• Make RankFromScore()'s dictionary param readonly

  Just to make sure nobody tries any "funny" business.

  Bartłomiej Dach · 2024-01-22 19:56:30 +01:00
  cb8ec48717
• Change S rank to require no miss
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  c8521b49cd
• Merge pull request #26561 from peppy/fix-catch-banana-health-bar

  Fix argon health bar showing "miss" bar for bananas

  Bartłomiej Dach · 2024-01-16 11:04:38 +01:00
  cde0c0b2ee
• Add helper method to bypass judgement woes
  Dean Herbert · 2024-01-16 15:52:05 +09:00
  57a6025a2c
• Fix silver S/SS not being awarded correctly
  Dean Herbert · 2024-01-16 13:21:15 +09:00
  902a5436f3
• Reorder hit results so that SliderTailHit is next to SmallTickHit

  This addresses https://github.com/ppy/osu/discussions/26507.

  Bartłomiej Dach · 2024-01-14 09:33:04 +01:00
  1cd7656f33
• Merge branch 'master' into catch-scoring
  Bartłomiej Dach · 2024-01-09 15:49:37 +01:00
  00a4c055b3
• Change catch scoring to match score V2
  Bartłomiej Dach · 2024-01-05 20:46:11 +01:00
  8295ad1feb
• Avoid rank updates after failing
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  b12011d501
• Don't unset Disabled on rank (never actually disabled?)
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  a4dee1a01a
• Make ScoreProcessor.Rank read-only
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  705f25e4b9
• Add HitResult.SliderTailHit
  Dan Balasescu · 2023-12-30 10:38:47 +09:00
  807443b648