41104 Commits

This Branch

This Branch

All Branches

• Try-catch around localisation store registration

  Some platforms (android, older windows versions) will throw exceptions
  at runtime when an unsupported `CultureInfo` is attempted to be
  instantiated, leading to nasty crashes. Add a preventative try-catch
  registration to prevent the crash, and log the errors for visibility.

  Bartłomiej Dach · 2021-06-19 08:02:30 +02:00
  76db87f9cb
• Merge pull request #13517 from ekrctb/initial-entry

  Allow setting `Entry` of `PoolableDrawableWithLifetime` (including `DrawableHitObject`)

  Dean Herbert · 2021-06-19 00:03:41 +09:00
  2021.619.0 89c27dcb10
• Merge pull request #13556 from bdach/editor-hit-circle-animation-regression

  Fix editor hit circle animation toggle not working

  Dean Herbert · 2021-06-19 00:03:06 +09:00
  65014aeb7a
• Merge pull request #13528 from gagahpangeran/last-lang

  Add remaining non-rtl language

  Dean Herbert · 2021-06-19 00:00:33 +09:00
  fa838ba253
• Merge pull request #13554 from nekodex/more-ui-sfx

  Add more UI sounds

  Dean Herbert · 2021-06-19 00:00:12 +09:00
  6ac35a05ad
• Merge branch 'master' into last-lang
  smoogipoo · 2021-06-18 23:30:59 +09:00
  acb47b1606
• Merge branch 'master' into more-ui-sfx
  Dean Herbert · 2021-06-18 23:24:19 +09:00
  b1fd812805
• Merge pull request #13527 from gagahpangeran/inter-font

  Add inter font

  Dean Herbert · 2021-06-18 23:23:13 +09:00
  35f04430d0
• Use StateUpdateTime for transform clearing logic

  `MainCirclePiece` specifies a state transform starting at
  `StateUpdateTime`, which is earlier than the previously-used
  `HitStateUpdateTime`. Change the transform clearing logic to use the
  former to ensure that exactly all animation transforms are cleared.

  Bartłomiej Dach · 2021-06-18 16:04:11 +02:00
  afc89b39d9
• Ensure editor ruleset animation disable execution order
  Bartłomiej Dach · 2021-06-18 16:04:11 +02:00
  e94fbd83e2
• Also cover slider animation disable
  Bartłomiej Dach · 2021-06-18 16:04:11 +02:00
  fe48ddfee3
• Add coverage for hit circle fade-out duration
  Bartłomiej Dach · 2021-06-18 16:04:11 +02:00
  e2a370f602
• Add failing test case for hit circle animations disable
  Bartłomiej Dach · 2021-06-18 16:04:11 +02:00
  69c1cd5b34
• Merge branch 'master' into inter-font
  Dean Herbert · 2021-06-18 22:38:20 +09:00
  36f0769f83
• Update resources
  Dean Herbert · 2021-06-18 22:25:24 +09:00
  1ec03bf6fa
• Update resources
  Dean Herbert · 2021-06-18 22:16:15 +09:00
  1f6b4b10ab
• Add workaround for dropdowns playing close animation on first display
  Dean Herbert · 2021-06-18 22:08:59 +09:00
  390abccb4b
• fix ModButton duplicate click sound
  Jamie Taylor · 2021-06-18 21:41:07 +09:00
  5ce52b2669
• replace 'songselect' hover/click sounds with 'button' ones for now
  Jamie Taylor · 2021-06-18 21:03:46 +09:00
  6e4fc26e16
• fix checkbox sounds not being used for certain checkboxes
  Jamie Taylor · 2021-06-18 21:00:08 +09:00
  953683044f
• Merge pull request #13552 from peppy/fix-ruleset-dll-rename

  Fix loading a ruleset with an updated internal name causing a potential startup crash

  Dean Herbert · 2021-06-18 20:18:54 +09:00
  5897475708
• Remove unused using statement
  Dean Herbert · 2021-06-18 19:39:01 +09:00
  2dadc9d686
• Merge pull request #13549 from peppy/storyboard-outro-logic-refactor

  Separate out storyboard outro logic as much as possible from score completion flow

  Dan Balasescu · 2021-06-18 19:38:00 +09:00
  846647b5c5
• Fix renaming a ruleset DLL causing a startup crash
  Dean Herbert · 2021-06-18 19:32:40 +09:00
  78c5ccda60
• Add xmldoc remark
  smoogipoo · 2021-06-18 19:27:10 +09:00
  42c5a962fb
• Don't set entry immediately
  smoogipoo · 2021-06-18 19:23:37 +09:00
  36d51d5117
• Add exception on Apply() while loading
  smoogipoo · 2021-06-18 19:20:57 +09:00
  36d2199a02
• add sound to dropdowns
  Jamie Taylor · 2021-06-18 19:16:28 +09:00
  d462394635
• add sound to tab controls
  Jamie Taylor · 2021-06-18 19:16:00 +09:00
  4feb7c848f
• Merge pull request #13546 from peppy/mods-can-specify-self-in-incompatible-list

  Allow mods to specify incompatibility types which they implement themselves

  Dan Balasescu · 2021-06-18 19:07:38 +09:00
  e0f4c792b8
• Merge branch 'master' into storyboard-outro-logic-refactor
  Bartłomiej Dach · 2021-06-18 11:57:38 +02:00
  840d1abff0
• Merge pull request #13491 from ekrctb/catcher-trail-sprite

  Use common skinnable drawable for catcher and catcher trails

  Dean Herbert · 2021-06-18 18:33:02 +09:00
  ed9654f9c6
• Merge branch 'master' into storyboard-outro-logic-refactor
  Bartłomiej Dach · 2021-06-18 10:18:54 +02:00
  bab370c299
• Merge pull request #13551 from peppy/remove-synchronous-prepare-score-method

  Remove the synchronous version of `PrepareScoreForResults`

  Dan Balasescu · 2021-06-18 17:00:32 +09:00
  6605fa2797
• Move xmldoc to method
  Dean Herbert · 2021-06-18 16:50:31 +09:00
  0bc68a7018
• Reorder methods to make more sense
  Dean Herbert · 2021-06-18 16:46:40 +09:00
  19507e107e
• Merge branch 'remove-synchronous-prepare-score-method' into storyboard-outro-logic-refactor
  Dean Herbert · 2021-06-18 16:45:01 +09:00
  a7f40dc6d4
• Remove the synchronous version of PrepareScoreForResults

  Replaces all existing usages with the `async` version.

  Dean Herbert · 2021-06-18 16:24:08 +09:00
  45122594e5
• Add note about delay parameter
  Dean Herbert · 2021-06-18 16:18:20 +09:00
  f3426e38b4
• Remove exit override behaviour

  I don't actually know under what scenario this could have been hit, and
  actually caused expected behaviour. Consider that in the scenario I
  describe in the comment (which I added yesterday), the user is
  requesting a pause or exit which would be "cancelled showing the results
  instead". But in such a scenario, `PerformExit` would first be run,
  which cancels the `resultsDisplayDelegate` in the first place.
  
  The only special case would be pressing the close button on the window
  decoration? Which I don't think should be a special case in the first
  place, so I'm just going to remove this for the time being to keep
  things simple.

  Dean Herbert · 2021-06-18 16:12:35 +09:00
  3819a1f03b
• Default DrawableStoryboard to a completed state to avoid state change on empty storyboards
  Dean Herbert · 2021-06-18 16:08:49 +09:00
  06d1bd971c
• Remove unnecessary (and no longer correct) exception
  Dean Herbert · 2021-06-18 16:08:31 +09:00
  7ef8eac773
• add sound to scroll-to-top button
  Jamie Taylor · 2021-06-18 16:08:14 +09:00
  752d0a9f0b
• Move all storyboard outro skip logic out of updateCompletionState

  This method should only be called to trigger the score completion
  portion of player progression. The storyboard skip/end logic is now
  handled separately in `progressToResults`.

  Dean Herbert · 2021-06-18 15:50:43 +09:00
  2bf855fcca
• Adjust font namespaces
  smoogipoo · 2021-06-18 15:40:35 +09:00
  5cf2ac78fc
• Merge pull request #13499 from ekrctb/fix-mania-editor-crash

  Rewrite mania selection blueprint to use only `HitObject` (no `DrawableHitObject`) for layout

  Dan Balasescu · 2021-06-18 15:10:28 +09:00
  2cd72a92e8
• Merge pull request #13544 from smoogipoo/split-files

  Move IApplicableToDrawableHitObjects to its own file

  Dean Herbert · 2021-06-18 13:54:03 +09:00
  93eec009f8
• Merge branch 'master' into fix-mania-editor-crash
  Dan Balasescu · 2021-06-18 13:49:25 +09:00
  cdc1c60fab
• Mark all mods which adjust approach circle as incompatible with each other

  Closes https://github.com/ppy/osu/issues/13543.

  Dean Herbert · 2021-06-18 13:21:53 +09:00
  860626152a
• Change ModSelectOverlay to never deselect the user triggered selection
  Dean Herbert · 2021-06-18 13:17:55 +09:00
  4de27429bc