991 Commits

• Merge pull request #22659 from peppy/fix-taiko-drum-nested-sample-detection

  Fix `GameplaySampleTriggerSource` not considering nested objects when determining the best sample to play

  Bartłomiej Dach · 2023-02-22 18:56:59 +01:00
  d679703fa2
• Merge pull request #22635 from peppy/use-overlays-container-more

  Use `Overlays` container rather than `KeyBindingInputManager` for flashlight

  Dean Herbert · 2023-02-22 18:30:21 +09:00
  a8c692a215
• Remove contradictory remark from xmldoc
  Bartłomiej Dach · 2023-02-21 21:05:46 +01:00
  ab97b02235
• Move DrawableRuleset.Audio to a less generic level
  Dean Herbert · 2023-02-21 19:03:52 +09:00
  1acc536248
• Merge branch 'master' into fix-taiko-drum-nested-sample-detection
  Dean Herbert · 2023-02-21 13:58:15 +09:00
  5ba6059911
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-19 16:33:10 +01:00
  3183f5cee2
• Change early return to also find the earliest nested object
  Dean Herbert · 2023-02-17 18:59:31 +09:00
  19d5293ad1
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-16 21:54:29 +01:00
  3ee046000e
• Revert ResumeOverlay setter accessibility change
  Bartłomiej Dach · 2023-02-16 21:26:01 +01:00
  b8084a15eb
• Fix GameplaySampleTriggerSource not considering nested objects when determining the best sample to play
  Dean Herbert · 2023-02-16 18:21:33 +09:00
  affa9507a1
• Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not
  Dean Herbert · 2023-02-16 15:47:20 +09:00
  ce9ef3bc3c
• Merge branch 'master' into hide-resume-overlay
  Dean Herbert · 2023-02-16 15:42:14 +09:00
  7afdcb9383
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b
• Expose and consume OsuInputManager explicitly
  Dean Herbert · 2023-02-14 17:36:07 +09:00
  5ec5222d8a
• Move Overlays container to accept input and be frame-stable
  Dean Herbert · 2023-02-14 17:35:12 +09:00
  970388d4e2
• Restructure UseResumeOverlay to correctly handle a value change before BDL load
  Dean Herbert · 2023-02-14 15:11:33 +09:00
  63f3498762
• Add UseResumeOverlay and use it for hiding the ResumeOverlay
  Pasi4K5 · 2023-02-13 23:51:39 +01:00
  e4b84ebd0b
• Store RawTime in JudgementResult
  ekrctb · 2023-02-09 17:15:37 +09:00
  258de3b2d8
• Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
  ekrctb · 2023-02-09 16:47:58 +09:00
  5f0636c330
• Fix sample store creation mutating shared resource store
  Bartłomiej Dach · 2023-01-30 20:48:52 +01:00
  c5e1f54185
• Remove JudgementResultEntry

  It is not needed anymore as TimeAbsolute is stored raw.

  ekrctb · 2023-01-27 19:35:44 +09:00
  27578c48f5
• Fix inspection issue
  ekrctb · 2023-01-24 15:43:57 +09:00
  e1702a8ee9
• Store Result.TimeAbsolute separately from offset

  Calculating from TimeOffset is bad because it loses precision.
  The result time won't change anymore
  even If `HitObject.GetEndTime()` changes later.

  ekrctb · 2023-01-24 15:35:06 +09:00
  efef97d5be
• Fix OnRevertResult timing
  ekrctb · 2023-01-24 14:19:24 +09:00
  cc87923179
• Remove HidesResumeOverlay and set ResumeOverlay to null in OsuModAutopilot
  Pasi4K5 · 2023-01-24 00:49:09 +01:00
  8b47af6503
• Hide ResumeOverlay when OsuModAutopilot is enabled
  Pasi4K5 · 2023-01-22 03:44:59 +01:00
  75a1a2ec2f
• Use MaximumJudgementOffset for lifetime
  ekrctb · 2023-01-19 21:25:21 +09:00
  d8f9b7d02f
• Move judgement result revert logic to Playfield

  Previously, some judgement results were not reverted
  when the source DHO is not alive (e.g. frames skipped in editor).
  Now, all results are reverted in the exact reverse order.

  ekrctb · 2023-01-19 19:57:13 +09:00
  812a4b412a
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Merge pull request #21479 from peppy/fix-wrong-last-hit-object-time

  Fix some components not accounting for final hold notes in osu!mania beatmaps

  Dan Balasescu · 2022-12-02 18:12:00 +09:00
  850931120d
• Merge pull request #21405 from LumpBloom7/Editor-DrawableRuleset-Dependencies

  Provide DrawableRulesetDependencies from HitObjectComposer

  Dan Balasescu · 2022-12-02 17:31:31 +09:00
  a39bd634c4
• Fix two implementation oversights
  Dean Herbert · 2022-12-02 16:05:14 +09:00
  809d02cda0
• Fix test failures when no hitobjects are present in a scrolling ruleset
  Dean Herbert · 2022-12-01 21:42:03 +09:00
  d8dd7e7e0f
• Fix multiple instances of last hitobject time being calculated incorrectly
  Dean Herbert · 2022-12-01 18:04:06 +09:00
  896f2d8f74
• Annotate Playfield.Mods as maybe-null
  Bartłomiej Dach · 2022-11-30 20:00:25 +01:00
  6ebde9a747
• Hide the game mouse cursor when playing osu!catch with relax mod
  Dean Herbert · 2022-11-30 18:13:53 +09:00
  5ce2d6f54a
• Fix nullability inspection on disposal path
  Dean Herbert · 2022-11-30 17:49:08 +09:00
  bb0237d4a9
• Merge branch 'master' into Editor-DrawableRuleset-Dependencies
  Dean Herbert · 2022-11-30 17:42:46 +09:00
  4215f4f5d7
• Fix code style
  Derrick Timmermans · 2022-11-27 21:48:44 +01:00
  93ba84e5ff
• Provide ruleset dependencies only to Compose Placement Blueprints
  Derrick Timmermans · 2022-11-27 21:43:33 +01:00
  70c320b2e8
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Remove unnecessary #nullable disable
  Bartłomiej Dach · 2022-11-20 15:31:51 +01:00
  0f382590e6
• Introduce IDrawableScrollingRuleset for editor consumption
  Salman Ahmed · 2022-11-20 04:11:10 +03:00
  58296bd4f0
• Fix FallbackSampleStore.GetAsync fallback logic
  Susko3 · 2022-11-13 18:47:28 +01:00
  56fd1f95b1
• Fix incorrect fallback logic

  Regressed when attempting to share implementation of binary search.

  Dean Herbert · 2022-10-20 23:08:44 +09:00
  5c13c443ff
• Refactor implementation to support hitobjects nested multiple levels deep
  Dean Herbert · 2022-10-20 22:30:30 +09:00
  26860a903e
• Fix nested objects in overlapping scrolling hit object container ruleset not using correct reference time
  Dean Herbert · 2022-10-18 16:15:21 +09:00
  d237c818f6
• Standardise control point search logic in OverlappingScrollAlgorithm

  Was using a very local algorithm which I cannot guarantee is correct.
  I'd rather it just use the one used everywhere else.

  Dean Herbert · 2022-10-18 16:01:05 +09:00
  ec3761ced9
• Update xmlodc and add nullability attributes
  Salman Ahmed · 2022-10-13 00:16:42 +03:00
  4fb156ef4e