1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 03:43:22 +08:00
Commit Graph

15190 Commits

Author SHA1 Message Date
Dean Herbert
b5f615882f
Ensure the "Change Difficulty" menu uses up-to-date difficulty names
Closes https://github.com/ppy/osu/issues/29391.
2024-08-15 17:25:30 +09:00
Dean Herbert
9dc496d6a7
Merge pull request #29415 from Joehuu/difficulty-name-content
Implement song select v2 difficulty name content component
2024-08-15 15:20:52 +09:00
Salman Ahmed
3a4546d62d Remove x symbol from argon mania combo counter 2024-08-15 15:08:35 +09:00
Dean Herbert
28ab65243d
Remove daily challenge tooltip from main menu
Now that we have a nice intro screen for the daily challenge, it's
generally thought that we want to "spoil" the beatmap until the intro is
shown.

Also I was never a huge fan of having a tooltip on a main menu button..
just feels a bit odd.
2024-08-14 20:45:27 +09:00
Joseph Madamba
11bd0c9a61 Inline single-frame layout issue comment instead 2024-08-14 00:41:43 -07:00
Joseph Madamba
c24f1444f9 Directly resolve IBindable<WorkingBeatmap> by making a local variant of DifficultyNameContent 2024-08-13 23:26:18 -07:00
Joseph Madamba
2b41f71fd0 Workaround single-frame layout issues with {Link|Text|Fill}FlowContainers 2024-08-13 23:26:17 -07:00
Joseph Madamba
625c6fc7eb Implement song select v2 difficulty name content component 2024-08-13 23:26:17 -07:00
Dean Herbert
e465049050
Merge branch 'master' into mania-combo-counter 2024-08-14 15:12:00 +09:00
Dean Herbert
16f6e26c2e
Merge pull request #29372 from ArijanJ/song-progress-optional-time
Add option to hide song progress time/text
2024-08-13 00:57:15 +09:00
Dean Herbert
b567ab2a39
Fix context menus sometimes not being clickable at song select
Closes https://github.com/ppy/osu/issues/21602.
2024-08-12 20:31:20 +09:00
Bartłomiej Dach
92bd123ebc
Merge pull request #29363 from peppy/fix-daily-challenge-notification-spam
Fix daily challenge notification spam
2024-08-12 12:18:38 +02:00
Bartłomiej Dach
96bd374b18
Change notification interval to 30 minutes 2024-08-12 11:24:59 +02:00
Bartłomiej Dach
54a1d79136
Clean up some naming weirdness 2024-08-12 11:23:36 +02:00
Bartłomiej Dach
041c70e4eb
Fix tests 2024-08-12 11:19:02 +02:00
Bartłomiej Dach
306e84c7ac
Move disposal method to more expected location 2024-08-12 10:46:58 +02:00
ArijanJ
fed5b9d747
Fix one more inspectcode warning 2024-08-10 09:45:30 +02:00
ArijanJ
d01e76d9db
Fix double blank line 2024-08-09 23:08:22 +02:00
ArijanJ
2dee8bef7e
Add option to hide song progress time/text 2024-08-09 22:50:37 +02:00
Dean Herbert
df43263e38
Merge branch 'master' into daily-challenge-intro-sfx 2024-08-10 02:22:48 +09:00
Jamie Taylor
c6fa348d82
Add sound design for daily challenge intro animation 2024-08-09 23:05:33 +09:00
Dean Herbert
8fdd94090b
Show object inspector values during placement 2024-08-09 18:02:37 +09:00
Dean Herbert
e146c8e230
Ensure only one daily challenge notification is fired per room 2024-08-09 17:11:11 +09:00
Dean Herbert
52b2d73e04
Only show daily challenge notification if it started within the last 30 minutes 2024-08-09 17:10:18 +09:00
Dean Herbert
161734af95
Simplify argon mania combo counter implementation by sharing with base counter 2024-08-09 15:46:57 +09:00
Dean Herbert
e645651ef4
Merge branch 'master' into mania-combo-counter 2024-08-09 00:19:17 +09:00
Dean Herbert
0cb3b6a1f8
Add back TrySetDailyChallengeBeatmap call for safety 2024-08-08 22:10:26 +09:00
Dean Herbert
8eb0ef1e33
Merge branch 'master' into daily-challenge-intro-audio-auto-download 2024-08-08 22:09:21 +09:00
Dean Herbert
03d543ec99
Fix potential test failure in daily challenge tests
See https://github.com/ppy/osu/actions/runs/10296877688/job/28500580680.
2024-08-08 16:53:22 +09:00
Dean Herbert
3f3145e109
Start playing music during intro if download finishes early 2024-08-08 15:10:18 +09:00
Dean Herbert
5d66eda982
Add support for automatically downloading daily challenge during the intro display 2024-08-08 15:10:18 +09:00
Dean Herbert
e95d61d4c2
Remove accidental double handling of beatmap availability in DailyChallenge 2024-08-08 15:10:18 +09:00
Dean Herbert
f91a3e9a35
Start playing daily challenge track as part of intro sequence 2024-08-08 15:10:17 +09:00
Dean Herbert
5891780427
Show initial text a bit longer 2024-08-08 14:15:40 +09:00
Dean Herbert
7058fedf42
Merge branch 'master' into daily-challenge-intro-screen-part-2 2024-08-08 14:12:16 +09:00
Dean Herbert
1ee5522a25
Merge branch 'master' into daily-challenge-intro-screen-part-2 2024-08-08 14:08:14 +09:00
Dean Herbert
25dddb694a
And then completely change the animation to a new style 2024-08-08 14:02:43 +09:00
Dean Herbert
f72f5ee7e3
More improvements maybe 2024-08-08 13:29:10 +09:00
Dean Herbert
9bafdeeeff
Improve animation 2024-08-08 13:17:25 +09:00
Dean Herbert
8773c2f7eb
Merge pull request #29281 from kstefanowicz/multiplayer-chat-focus-hint
Add "enter" hint to in-gameplay chatbox placeholder text
2024-08-08 01:29:42 +09:00
Dan Balasescu
a06cb9a0de
Merge pull request #29322 from peppy/daily-challenge-import-improvement
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu
2024-08-08 00:42:03 +09:00
Dean Herbert
cfd7f96e76
Add missing exit line causing completely incorrect behaviour 2024-08-07 23:29:24 +09:00
kstefanowicz
775f76f472 Have placeholder text change while focused 2024-08-07 07:47:35 -04:00
Bartłomiej Dach
437812eebe
Merge pull request #29279 from normalid-awa/bugfix/editor/delete-operation-wont-close-the-menu
Close context menus when deselecting items in editor
2024-08-07 13:25:13 +02:00
Dean Herbert
e52d80a41b
Add more difficulty information and further tweaks to visuals 2024-08-07 19:08:04 +09:00
Dean Herbert
083fe32d20
Improve feel of animation 2024-08-07 19:07:45 +09:00
Salman Ahmed
a0615a8f18
Frenzi's WIP animation 2024-08-07 19:07:45 +09:00
Dean Herbert
cfccd74441
Add daily challenge intro sequence 2024-08-07 19:07:44 +09:00
Dean Herbert
6870311c1e
Remove requirement of specifying animateOnnter in BackgroundScreen ctor 2024-08-07 19:07:44 +09:00
Dean Herbert
3c05b975a0
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu 2024-08-07 19:07:43 +09:00
Dean Herbert
5a63c25f49
Fix clicking the beatmap import notification at the daily challenge screen exiting to main menu 2024-08-07 14:42:34 +09:00
Dean Herbert
8619bbb943
Fix legacy key counter's background being visible when intended to be hidden 2024-08-06 16:12:00 +09:00
Dan Balasescu
c574551ee0
Simplify caching 2024-08-06 16:02:36 +09:00
Dan Balasescu
b91461e661
Refactor + CI fixes 2024-08-06 15:17:52 +09:00
jkh675
cb877b7675 Close the menu when selecting other object 2024-08-06 13:09:48 +08:00
Dan Balasescu
d637bbf752
Merge pull request #29286 from peppy/middle-click-delete
Allow object deletion with middle mouse
2024-08-06 13:38:56 +09:00
jkh675
75c0c6a5f9 Make the OsuContextMenu nullable in SelectionHandler 2024-08-05 16:32:49 +08:00
Dean Herbert
c37f617e1d
Adjust song select info icon size slightly
Not going to PR this it's just a minor tweak.
2024-08-05 17:21:50 +09:00
Dean Herbert
0557b9ab79
Allow placement deletion with middle mouse
This is in addition to Shift + Right-click.

I thik middle mouse feels more natural and is a good permanent solution
to this issue.

Note that this also *allows triggering the context menu from placement
mode*. Until now it's done nothing. This may be annoying to users with
muscle memory but I want to make the change and harvest feedback. I
think showing the context menu is more correct behaviour (although
arguably it should return to placement mode on dismiss?).
2024-08-05 14:25:09 +09:00
Dan Balasescu
136cdcfb29
Merge pull request #29059 from frenzibyte/fix-results-fetching-twice
Fix results screen fetching scores twice when scrolled to edge
2024-08-05 14:23:47 +09:00
Dan Balasescu
f92e2094c1
Adjust localisation string name + formatting 2024-08-05 12:34:24 +09:00
AkiraTenchi
a5a392e9fc
Update FilterQueryParser.cs
Add sr as an alias for star rating in the search parameters
2024-08-04 19:48:29 +02:00
kstefanowicz
b0757a13c2 Add "enter" hint to chatbox placeholder text while in-game 2024-08-04 12:32:08 -04:00
jkh675
b32d97b4c0 Remove decreapted property 2024-08-04 21:27:25 +08:00
jkh675
2145368d17 Merge EditorContextMenuContainer into OsuContextMenuContainer 2024-08-04 21:00:43 +08:00
jkh675
7c83d6a883 Cleanup code 2024-08-04 19:56:41 +08:00
jkh675
5d31171fb0 Fix code quality 2024-08-04 19:43:43 +08:00
jkh675
3cc5466774 Refactor the code to follow IoC principle and more flexible 2024-08-04 19:39:06 +08:00
jkh675
27d6c4cecb Implement on beatmap editor 2024-08-04 19:16:14 +08:00
jkh675
5c5fcd7e7e Allow key event pass through selection handler 2024-08-04 19:11:21 +08:00
jkh675
1ff0c7cb46 Replace original menu container with custom one 2024-08-04 19:10:49 +08:00
jkh675
83aeb27c73 Replace original menu container to the custom one 2024-08-04 19:08:31 +08:00
jkh675
de6d8e7eb7 Add the custom context menu to handle the key event 2024-08-04 19:07:35 +08:00
Dan Balasescu
7bf96ce49a
Merge pull request #29231 from peppy/timeline-break-behind-objects
Show breaks behind objects in timeline
2024-08-02 21:28:11 +09:00
Dean Herbert
548fd9cbf9
Show breaks behind objects in timeline
Closes https://github.com/ppy/osu/issues/29227.
2024-08-01 19:47:44 +09:00
Layendan
19a4cef113 update var names and test logic 2024-08-01 02:52:41 -07:00
Dean Herbert
dab967e6be
Fix insane transform allocations in new leaderboard display 2024-08-01 18:36:33 +09:00
Dean Herbert
2d52bab77b
Always show timing points in timeline when at the timing screen
Supersedes https://github.com/ppy/osu/pull/29196.
2024-07-31 19:43:08 +09:00
Dean Herbert
e329427d6e
Apply nullability to Timeline 2024-07-31 19:28:32 +09:00
Layendan
36bd83bb80 Update collection state when users add/remove from collection 2024-07-30 15:22:41 -07:00
Dean Herbert
e77489f2a9
Allow notification of new strings 2024-07-31 03:10:36 +09:00
Dean Herbert
bdc465e1c6
Reword notification text slightly 2024-07-31 03:06:35 +09:00
Dean Herbert
d75c170ba1
Merge branch 'master' into daily-challenge/better-messaging 2024-07-30 19:04:48 +09:00
Dean Herbert
d5f9173288
Remove unused local variable 2024-07-30 19:04:43 +09:00
Bartłomiej Dach
1b57a2a136
Show new daily challenge notification globally 2024-07-30 10:36:26 +02:00
Salman Ahmed
621f4dfece Enforce new line between X/Y coordinate in editor position inspector 2024-07-30 02:45:21 +03:00
Dean Herbert
aa2515763c
Merge pull request #29184 from bdach/daily-challenge/wrong-mods-after-replay
Fix mods persisting after watching replay from daily challenge screen
2024-07-29 23:23:45 +09:00
Bartłomiej Dach
b46f3c97da
Add notification on daily challenge conclusion & start of new one
Because I wish to stop seeing "DAILY CHALLENGE WHERE" every day
on #general.

The notifications are constrained to the daily challenge screen only to
not spam users who may not care.
2024-07-29 14:30:10 +02:00
Dean Herbert
7afcd72872
Fix potentially too many scores displaying in breakdown while in gameplay 2024-07-29 20:58:42 +09:00
Dean Herbert
05056f0e8a
Remove no longer required AlwaysPresent definition
This also reverts commit 7fedfd368c as
no-longer-necessary.
2024-07-29 20:43:56 +09:00
Dean Herbert
5a1002c1a0
Ensure score breakdown doesn't spam scores when not visible 2024-07-29 20:43:50 +09:00
Bartłomiej Dach
f1a84a5111
Fix mods persisting after watching replay from daily challenge screen
Closes https://github.com/ppy/osu/issues/29133.

Hope I can be forgiven for no tests. I had a brief try but writing them
is going to take hours.
2024-07-29 12:52:30 +02:00
Bartłomiej Dach
cebd38c6eb
Merge pull request #29163 from Joehuu/copy-lb-mods-daily
Add ability to copy leaderboard mods in daily challenge
2024-07-29 12:09:27 +02:00
Bartłomiej Dach
2ff0a89b4f
Convert into auto-property even more 2024-07-29 10:59:21 +02:00
Bartłomiej Dach
54c904d439
Convert into auto-property 2024-07-29 10:40:29 +02:00
Bartłomiej Dach
aa7f6f81ef
Merge pull request #29127 from Joehuu/add-negative-horizontal-padding-daily
Fix daily challenge background clipping when settings/notifications is opened
2024-07-29 10:28:48 +02:00
Joseph Madamba
f6eb9037df Add ability to copy leaderboard mods in daily challenge 2024-07-27 23:55:56 -07:00
Salman Ahmed
7fedfd368c Fix score breakdown tooltips appearing in other feeds 2024-07-28 07:22:58 +03:00
Joseph Madamba
bc25e5d706 Remove unnecessary depth and padding set 2024-07-27 19:13:11 -07:00
Joseph Madamba
850bcaef7a Merge remote-tracking branch 'upstream/master' into pr/28991 2024-07-27 19:09:02 -07:00