Dean Herbert
52c2eb93de
Merge branch 'master' into taiko-beat-snap-grid
2023-10-19 23:53:01 +09:00
Dean Herbert
e8d0962197
Merge pull request #25171 from bdach/distance-snapping-composition
...
Replace `DistancedHitObjectComposer` with composition-based approach
2023-10-19 23:46:10 +09:00
Bartłomiej Dach
0c4e74c82d
Inherit ScrollingHitObjectComposer in catch
2023-10-19 11:58:25 +02:00
Bartłomiej Dach
144ef5a87c
Remove DistancedHitObjectComposer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
31849192c3
Remove DistancedHitObjectComposer inheritance from catch composer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
dcfd6a0a8a
Remove DistancedHitObjectComposer inheritance from osu! composer
2023-10-19 11:46:30 +02:00
Bartłomiej Dach
3ab083b696
Split IPositionSnapProvider from IDistanceSnapProvider
...
In preparation to remove `DistancedHitObjectComposer`, split off
`IPositionSnapProvider` from `IDistanceSnapProvider`.
`DistancedHitObjectComposer` was not touching `IPositionSnapProvider`'s
only interface member at all, it was just forwarding it for subclasses
to override to their own leisure.
2023-10-19 11:45:24 +02:00
Bartłomiej Dach
0b8b87d6bd
Merge pull request #25169 from smoogipoo/fix-diffcalc-pr-command
...
Fix invalid PR URL in diffcalc GitHub action
2023-10-19 08:29:28 +02:00
Dan Balasescu
832ba861bb
Fix incorrect PR url in diffcalc workflow
2023-10-19 15:19:51 +09:00
Dean Herbert
66421a55ab
Merge pull request #25159 from smoogipoo/improve-diffcalc-command
...
Fix + improve diffcalc command for comment-based execution
2023-10-19 12:11:16 +09:00
Dan Balasescu
14cadd1eeb
Pin third-party actions
2023-10-19 02:39:34 +09:00
Dean Herbert
42087037ae
Fix Catcher code change not accounting for double sizing requirement
2023-10-18 23:56:17 +09:00
Dean Herbert
040d0970f2
Use DifficultyRange helper method in one more place
2023-10-18 23:54:18 +09:00
Dean Herbert
78d3c3723d
Ignore instead of retry tests
2023-10-18 20:12:14 +09:00
Bartłomiej Dach
12f343f0e2
Merge pull request #24640 from Givikap120/pitch_change
...
Add an "Adjust pitch" switch to DT/HT
2023-10-18 13:07:22 +02:00
Dean Herbert
3a5490892c
Centralise and repair circle size calculations game-wide
2023-10-18 19:50:42 +09:00
Bartłomiej Dach
f1a16c50b8
Merge branch 'master' into pitch_change
2023-10-18 12:27:27 +02:00
Bartłomiej Dach
cff69d63a6
Add inline commentary in Mod{Day,Night}core about different speed adjustments
2023-10-18 12:27:16 +02:00
Dean Herbert
6ae82c5e73
Fix circle scale not matching stable due to missing multiplier
...
This multiplier has to exist.
I'm not guaranteeing that the rest is correct here. Should we be doing
proper cross-testing on this? Maybe, but it's going to be hard to get
right. We could likely check as far as "game pixels", but there's still
a chance that the osu-framework could be doing something weird in the
rest of the hierarchy where playfield scale is involved.
Closes https://github.com/ppy/osu/issues/25162 . Tested to fix the linked
replay.
2023-10-18 18:35:14 +09:00
Dean Herbert
54da6f1048
Merge pull request #25160 from bdach/repeat-arrow-hidden-fade
...
Adjust slider repeat transforms to closer match stable
2023-10-18 18:03:48 +09:00
Dean Herbert
be321e34e9
Attempt to fix flaky tests with egregious retry rule
2023-10-18 17:46:14 +09:00
Dean Herbert
92524d4299
Remove incorrect plural from variable
2023-10-18 17:44:01 +09:00
Dean Herbert
9907adc337
Take in IBindables and tidy up multiplier handling
2023-10-18 17:39:13 +09:00
Dean Herbert
161890292f
Move audio adjustment hookup to own method for clarity
2023-10-18 17:38:11 +09:00
Dean Herbert
e56ff33271
Also share ScoreMultiplier implementation
2023-10-18 17:23:50 +09:00
Dean Herbert
43238b0cee
Split common functionality from rate adjust mods into helper class
2023-10-18 17:23:50 +09:00
Dean Herbert
eabfcfbf2a
Merge branch 'master' into pitch_change
2023-10-18 16:33:03 +09:00
Dean Herbert
7479830a8e
Comment flaky tests for now
...
Same issue as other commented test (clock precision not high enough).
Will probably want a solution to this at some point.
2023-10-18 16:26:34 +09:00
Dean Herbert
bf4aa3c118
Merge pull request #25163 from Joehuu/double-click-slider-nub-default
...
Add ability to revert slider settings to default when double-clicking nub
2023-10-18 16:23:05 +09:00
Dan Balasescu
939b55020c
Merge branch 'master' into legacy-tick-test-coverage
2023-10-18 15:21:31 +09:00
Joseph Madamba
18e8ca6245
Add ability to revert slider settings to default when double-clicking nub
2023-10-17 21:41:03 -07:00
Joseph Madamba
1a3a81c33b
Add slider nub double click revert to default test
2023-10-17 21:41:03 -07:00
Bartłomiej Dach
e927267c4d
Merge pull request #25155 from peppy/fix-new-inspections
...
Fix various new rider EAP inspections
2023-10-17 17:04:39 +02:00
Bartłomiej Dach
f3cda58474
Fix legacy slider repeats becoming much too large on hit
...
They had scale transforms applied to them in two places: the actual
legacy pieces themselves (esp. `LegacyHitCirclePiece`), and on the
`DrawableSliderRepeat` level.
This change moves all of the scale transforms to the skinnable pieces.
Argon and triangles have received a copy of the previous logic each,
so behaviour on those skins should not change.
2023-10-17 14:47:44 +02:00
Bartłomiej Dach
30e5f47007
Instantly fade out slider repeats when hidden is active
2023-10-17 14:15:21 +02:00
Bartłomiej Dach
f116854c9f
Add test step for covering slider appearance with hidden active
2023-10-17 14:15:21 +02:00
Dan Balasescu
4946b437c9
Run timeout job on self-hosted runner
2023-10-17 21:01:23 +09:00
Dan Balasescu
566b09ff20
Delete comment on cancellation
...
- Add always() pre-condition to force evaluation.
- Message is set as it's required by the action for a non-error status code.
2023-10-17 20:51:28 +09:00
Dan Balasescu
08845ec1c6
Use action for GHA diffcalc workflow permissions check
2023-10-17 20:28:04 +09:00
Dean Herbert
4f0d55e1a9
Clean up code and add xmldoc and inline doc
2023-10-17 20:24:23 +09:00
Dean Herbert
80ac0c46d9
Fix final test
...
This looks to have been a WIP test, so I've brought it up to the point
of passing. I haven't given it much more attention than that, though.
2023-10-17 20:24:23 +09:00
Dean Herbert
9011170c3e
Adjust tests in line with new expectations
2023-10-17 20:24:23 +09:00
Dean Herbert
af7180a5b5
Add SpinnerSpinHistory and tests
2023-10-17 20:10:22 +09:00
Dean Herbert
d9fc532a9f
Merge pull request #25152 from bdach/key-binding-deduplication
...
Clear pre-existing bindings of same key combination to single action
2023-10-17 17:49:51 +09:00
Dean Herbert
e081fa48a2
Fix various other inspections
2023-10-17 17:48:51 +09:00
Dean Herbert
5341a335a6
Bypass Parent nullability checks for now
2023-10-17 17:48:45 +09:00
Bartłomiej Dach
2192c9f2c2
Remove unused using directive
2023-10-17 10:30:01 +02:00
Bartłomiej Dach
22c1a963e7
Remove unused field
2023-10-17 10:27:16 +02:00
Bartłomiej Dach
7abd7fe658
Remove redundant explicit array type specification
2023-10-17 10:26:02 +02:00
Bartłomiej Dach
5833c20be5
Merge pull request #25153 from peppy/store-speed-change-config
...
Persist the state of "show speed changes" between editor sessions
2023-10-17 10:23:00 +02:00
