130 Commits

• Fix test being sensitive to selected tab on new song select
  Bartłomiej Dach · 2025-05-30 10:02:40 +02:00
  9d0d3bb97a
• Add test coverage of volume changing while at song select

  This passes without changes in this pull request. But I'm just copying
  across from https://github.com/ppy/osu/pull/33225 to stay in theme?

  Dean Herbert · 2025-05-27 15:53:31 +09:00
  7d8dc1bd0a
• Fix nullability inspections
  Bartłomiej Dach · 2025-05-15 12:55:21 +02:00
  840e51e6a1
• Disallow adjusting scroll speed during gameplay

  Matches stable. Addresses https://github.com/ppy/osu/discussions/32670.

  Dean Herbert · 2025-04-04 19:46:14 +09:00
  32c60bfb36
• Minor bump some packages
  Dean Herbert · 2025-02-17 15:23:26 +09:00
  db4a4a1723
• Add failing test coverage of random rewind button not working
  Dean Herbert · 2025-01-21 17:24:41 +09:00
  c8cc36e9af
• Fix test potentially false-negative due to realm write delays
  Dean Herbert · 2025-01-17 14:16:38 +09:00
  224f39825f
• Add failing test coverage showing offset adjust is not limited correctly
  Dean Herbert · 2025-01-16 18:05:58 +09:00
  a4174a3644
• Flip navigation test expectations in line with new behaviour
  Dean Herbert · 2025-01-04 00:55:12 +09:00
  1161b7b3c0
• Add test coverage governing new behaviour
  Dean Herbert · 2024-11-28 18:03:19 +09:00
  c26c84ba45
• Also ensure filter is applied when returning to song select
  Dean Herbert · 2024-09-18 17:22:08 +09:00
  743d509241
• Add failing test showing crash at song select on selection edge case
  Dean Herbert · 2024-09-18 16:12:34 +09:00
  aae98e6906
• Fix some tests not always waiting long enough for beatmap loading

  These used to work because there was a huge blocking load operation,
  which is now more asynchronous.
  
  Note that the change made in `SongSelect` is not required, but defensive
  (feels it should have been doing this the whole time).

  Dean Herbert · 2024-08-29 18:42:43 +09:00
  def1abaeca
• Attempt file operations more than once in another test instance

  See
  https://github.com/ppy/osu/pull/29433/checks?check_run_id=28833985792.

  Dean Herbert · 2024-08-16 17:39:45 +09:00
  68bad9a277
• Fix file access test failure by forcing retries

  See https://github.com/ppy/osu/actions/runs/10369630825/job/28708248682.

  Dean Herbert · 2024-08-14 12:26:21 +09:00
  dd9705b660
• Fix TestTouchScreenDetectionAtSongSelect test failure

  https://github.com/ppy/osu/actions/runs/9985890747/job/27597501295
  
  In this case, the settings overlay is taking a very long time to load
  (on a background thread), and pops in when it finishes loading because
  it's been requested to open.
  
  The opens the settings overlay, closes it (by pressing escape, this does
  not actually close it because it's not loaded yet), and then enters song
  select by pressing 'P' 3 times. The settings overlay finishes loading at
  just the right opportune moment to eat one of the 'P' key presses.

  Dan Balasescu · 2024-07-18 16:26:16 +09:00
  1906c2f725
• Add failing test case
  Salman Ahmed · 2024-07-10 16:14:12 +03:00
  8ca8648a09
• Fix confirm exit dialog overflowing from too many ongoing operations
  Salman Ahmed · 2024-07-10 16:06:53 +03:00
  7d667ac46b
• Add medal overlay to game
  Bartłomiej Dach · 2024-02-20 16:31:31 +01:00
  8abcc70b93
• Add failing tests for beatmap inconsistencies
  Dean Herbert · 2024-02-18 19:32:21 +08:00
  415a65bf59
• Add failing test case
  Salman Ahmed · 2024-02-14 02:04:20 +03:00
  a96a66bc9e
• Add failing test coverage of skin getting nuked

  This doesn't fail in headless unfortunately.
  
  Run a few times manually to confirm.

  Dean Herbert · 2024-01-16 15:22:38 +09:00
  0e41d0c9cf
• Add test for crashing scenario
  Bartłomiej Dach · 2024-01-08 21:34:54 +01:00
  8a87301c55
• Use repeat step for more delay between the two exits
  Joseph Madamba · 2024-01-04 09:00:24 -08:00
  b190333c17
• Fix failing tests due to more textboxes being present with searchable dropdowns
  Dean Herbert · 2023-12-13 15:11:47 +09:00
  5e10f9f899
• Split test into two

  They would fail on CI when written as one, and I don't care why.

  Bartłomiej Dach · 2023-11-02 22:14:38 +01:00
  d25b54c06d
• Add failing test covering crash scenario
  Bartłomiej Dach · 2023-11-02 21:24:58 +01:00
  21a4da463b
• Add test scene for basic touchscreen detection scenarios
  Bartłomiej Dach · 2023-11-02 21:24:58 +01:00
  29d4d81eaa
• Automatically activate and deactivate touch device mod in song select
  Bartłomiej Dach · 2023-11-02 19:45:48 +01:00
  2f6ff893b5
• Add component for game-wide touch detection
  Bartłomiej Dach · 2023-11-02 19:32:56 +01:00
  980c900f43
• Fix TestSongSelectScrollHandling not waiting for VolumeOverlay to load

  See https://github.com/ppy/osu/actions/runs/6701786492/job/18210372721.

  Dean Herbert · 2023-10-31 13:49:53 +09:00
  37ec10d4f5
• Add extra test coverage for marking score as failed
  Bartłomiej Dach · 2023-10-27 12:17:03 +02:00
  3944b045ed
• Add failing test coverage for quick retry after completion not changing rank
  Bartłomiej Dach · 2023-10-27 12:17:03 +02:00
  7140eee870
• Add failing test scene for scroll handling in song select
  Bartłomiej Dach · 2023-10-26 16:24:16 +02:00
  5d6a58d443
• Add (failing) test coverage of exit/retry during progress to results
  Dean Herbert · 2023-10-12 15:42:20 +09:00
  256c95f045
• Remove unused local variable
  Bartłomiej Dach · 2023-07-16 17:10:26 +02:00
  a42992d3fd
• Add failing test covering exit dialog crash
  Bartłomiej Dach · 2023-07-16 16:55:20 +02:00
  72bf43e297
• Add test coverage of confirm-for-operations
  Dean Herbert · 2023-06-23 15:30:21 +09:00
  a76037b643
• Fix screen navigation test hijacking dummy request handler

  In an upcoming change, I stumbled upon a test failure mode wherein tests
  in `TestSceneScreenNavigation` would die on the following exception:
  
  	2023-05-07 17:58:42 [error]: System.ObjectDisposedException: Cannot access a closed Realm.
  	2023-05-07 17:58:42 [error]: Object name: 'Realms.Realm'.
  	2023-05-07 17:58:42 [error]: at Realms.Realm.ThrowIfDisposed()
  	2023-05-07 17:58:42 [error]: at Realms.Realm.All[T]()
  	2023-05-07 17:58:42 [error]: at osu.Game.Beatmaps.BeatmapManager.<>c__DisplayClass25_0.<QueryBeatmap>b__0(Realm r) in D:\a\osu\osu\osu.Game\Beatmaps\BeatmapManager.cs:line 282
  	2023-05-07 17:58:42 [error]: at osu.Game.Database.RealmAccess.Run[T](Func`2 action) in D:\a\osu\osu\osu.Game\Database\RealmAccess.cs:line 387
  	2023-05-07 17:58:42 [error]: at osu.Game.Beatmaps.BeatmapManager.QueryBeatmap(Expression`1 query) in D:\a\osu\osu\osu.Game\Beatmaps\BeatmapManager.cs:line 282
  	2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.OnlinePlay.TestRoomRequestsHandler.<HandleRequest>g__createResponseBeatmaps|6_0(Int32[] beatmapIds, <>c__DisplayClass6_0& ) in D:\a\osu\osu\osu.Game\Tests\Visual\OnlinePlay\TestRoomRequestsHandler.cs:line 174
  	2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.OnlinePlay.TestRoomRequestsHandler.HandleRequest(APIRequest request, APIUser localUser, BeatmapManager beatmapManager) in D:\a\osu\osu\osu.Game\Tests\Visual\OnlinePlay\TestRoomRequestsHandler.cs:line 140
  	2023-05-07 17:58:42 [error]: at osu.Game.Tests.Visual.TestMultiplayerComponents.<>c__DisplayClass18_0.<load>b__0(APIRequest request) in D:\a\osu\osu\osu.Game.Tests\Visual\TestMultiplayerComponents.cs:line 80
  	2023-05-07 17:58:42 [error]: at osu.Game.Online.API.DummyAPIAccess.<>c__DisplayClass32_0.<Queue>b__0() in D:\a\osu\osu\osu.Game\Online\API\DummyAPIAccess.cs:line 74
  
  Upon closer inspection, one of the tests in the scene instantiates a
  `TestMultiplayerComponents` instance. `TestMultiplayerComponents`
  registers a custom request handler onto `DummyAPIAccess`. Normally, this
  is not an issue; however, because `TestSceneScreenNavigation` is an
  `OsuGameTestScene`, and therefore has its storage recycled after every
  test, this leads to the error above in the following scenario:
  
  1. `TestPushMatchSubScreenAndPressBackButtonImmediately()` passes.
  2. The test is cleaned up, and the test case's storage is recycled,
     including the test case's realm database.
  3. In a subsequent test, a web request handled by the dummy API request
     handler is fired. The dummy API request handler subsequently attempts
     to access a realm that does not exist anymore.
  
  As the usage of `TestMultiplayerComponents` is highly unorthodox in this
  particular case, I'm opting for a localised fix which ensures that the
  request handler is cleaned up appropriately.

  Bartłomiej Dach · 2023-06-05 23:15:16 +02:00
  5c1abdc704
• Fix rapid back button test failure
  Bartłomiej Dach · 2023-05-07 21:07:38 +02:00
  8514b2758a
• Add failing beatmap listing search on initial open test
  Joseph Madamba · 2023-01-28 12:10:50 -08:00
  845bbf55fe
• Fix intermittent failure in tests with restarting player instances
  Salman Ahmed · 2023-01-15 16:06:06 +03:00
  13c1b8f5a4
• Use PerformFromScreen to exit sub screens instead
  Joseph Madamba · 2022-12-24 20:04:45 -08:00
  5232588a1f
• Merge remote-tracking branch 'upstream/master' into fix-op-non-current-onexiting
  Joseph Madamba · 2022-12-24 14:01:11 -08:00
  00ed5d6f92
• Add test coverage of featured artist filter confirmation process
  Dean Herbert · 2022-12-15 18:42:58 +09:00
  57048f0eba
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix beatmap options test failure due to no beatmap being selected
  Salman Ahmed · 2022-11-18 07:07:56 +03:00
  82829867db
• Rename test steps

  Co-authored-by: Joseph Madamba <madamba.joehu@outlook.com>

  Salman Ahmed · 2022-11-09 21:33:28 +03:00
  3909e5730e
• Add test coverage of overlay interplay
  Dean Herbert · 2022-11-08 14:58:57 +09:00
  4c15794694
• Add failing online play non-current sub screen onexiting test
  Joseph Madamba · 2022-07-31 20:13:06 -07:00
  320c4abb66